CDS: Add stress test RPC to the cars model

[controller.git] / opendaylight / netconf / netconf-impl / src / main / java / org / opendaylight / controller / netconf / impl / mapping / operations / DefaultCommit.java

diff --git a/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/mapping/operations/DefaultCommit.java b/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/mapping/operations/DefaultCommit.java
index 8b2c02bcd42cd916c2597b109762b686f68ea6c8..13e56d71e80a3f8c04e3908094216a9045c0da92 100644 (file)
--- a/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/mapping/operations/DefaultCommit.java
+++ b/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/mapping/operations/DefaultCommit.java
@@ -37,12 +37,13 @@ public class DefaultCommit extends AbstractNetconfOperation {
 
     private static final String NOTIFY_ATTR = "notify";
 
+    //TODO make commit notification optional
     private final CommitNotifier notificationProducer;
     private final NetconfMonitoringService cap;
     private final NetconfOperationRouter operationRouter;
 
-    public DefaultCommit(CommitNotifier notifier, NetconfMonitoringService cap,
-                         String netconfSessionIdForReporting, NetconfOperationRouter netconfOperationRouter) {
+    public DefaultCommit(final CommitNotifier notifier, final NetconfMonitoringService cap,
+                         final String netconfSessionIdForReporting, final NetconfOperationRouter netconfOperationRouter) {
         super(netconfSessionIdForReporting);
         this.notificationProducer = notifier;
         this.cap = cap;
@@ -68,7 +69,7 @@ public class DefaultCommit extends AbstractNetconfOperation {
     }
 
     @Override
-    public Document handle(Document requestMessage, NetconfOperationChainedExecution subsequentOperation) throws NetconfDocumentedException {
+    public Document handle(final Document requestMessage, final NetconfOperationChainedExecution subsequentOperation) throws NetconfDocumentedException {
         Preconditions.checkArgument(!subsequentOperation.isExecutionTermination(),
                 "Subsequent netconf operation expected by %s", this);
 
@@ -96,7 +97,7 @@ public class DefaultCommit extends AbstractNetconfOperation {
     }
 
     @Override
-    protected Element handle(Document document, XmlElement message, NetconfOperationChainedExecution subsequentOperation) throws NetconfDocumentedException {
+    protected Element handle(final Document document, final XmlElement message, final NetconfOperationChainedExecution subsequentOperation) throws NetconfDocumentedException {
         throw new UnsupportedOperationException("Never gets called");
     }
 
@@ -105,11 +106,11 @@ public class DefaultCommit extends AbstractNetconfOperation {
         return HandlingPriority.HANDLE_WITH_DEFAULT_PRIORITY.increasePriority(1);
     }
 
-    private void removePersisterAttributes(Document message) {
+    private static void removePersisterAttributes(final Document message) {
         message.getDocumentElement().removeAttribute(NOTIFY_ATTR);
     }
 
-    private boolean isCommitWithoutNotification(Document message) {
+    private static boolean isCommitWithoutNotification(final Document message) {
         XmlElement xmlElement = null;
         try {
             xmlElement = XmlElement.fromDomElementWithExpected(message.getDocumentElement(),
@@ -131,7 +132,7 @@ public class DefaultCommit extends AbstractNetconfOperation {
         }
     }
 
-    private Element getConfigSnapshot(NetconfOperationRouter opRouter) throws NetconfDocumentedException {
+    private Element getConfigSnapshot(final NetconfOperationRouter opRouter) throws NetconfDocumentedException {
         final Document responseDocument = opRouter.onNetconfMessage(
                 getConfigMessage, null);