summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
35235f4)
All callers are using FiniteDuration and we really do not want
to have an infinite receive timeout. Require FiniteDuration
to be specified.
Change-Id: Ia4664dd2a1fea76ee4c42641ef132d6d47c78385
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
import org.opendaylight.controller.cluster.raft.persisted.Snapshot;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.opendaylight.controller.cluster.raft.persisted.Snapshot;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import scala.concurrent.duration.Duration;
+import scala.concurrent.duration.FiniteDuration;
/**
* Temporary actor used to receive a CaptureSnapshotReply message and return a GetSnapshotReply instance.
/**
* Temporary actor used to receive a CaptureSnapshotReply message and return a GetSnapshotReply instance.
}
public static Props props(final CaptureSnapshot captureSnapshot, final ElectionTerm electionTerm,
}
public static Props props(final CaptureSnapshot captureSnapshot, final ElectionTerm electionTerm,
- final ActorRef replyToActor, final Duration receiveTimeout, final String id,
+ final ActorRef replyToActor, final FiniteDuration receiveTimeout, final String id,
final ServerConfigurationPayload updatedPeerInfo) {
return Props.create(GetSnapshotReplyActor.class, new Params(captureSnapshot, electionTerm, replyToActor,
receiveTimeout, id, updatedPeerInfo));
final ServerConfigurationPayload updatedPeerInfo) {
return Props.create(GetSnapshotReplyActor.class, new Params(captureSnapshot, electionTerm, replyToActor,
receiveTimeout, id, updatedPeerInfo));
final CaptureSnapshot captureSnapshot;
final ActorRef replyToActor;
final ElectionTerm electionTerm;
final CaptureSnapshot captureSnapshot;
final ActorRef replyToActor;
final ElectionTerm electionTerm;
- final Duration receiveTimeout;
+ final FiniteDuration receiveTimeout;
final String id;
final ServerConfigurationPayload peerInformation;
Params(final CaptureSnapshot captureSnapshot, final ElectionTerm electionTerm, final ActorRef replyToActor,
final String id;
final ServerConfigurationPayload peerInformation;
Params(final CaptureSnapshot captureSnapshot, final ElectionTerm electionTerm, final ActorRef replyToActor,
- final Duration receiveTimeout, final String id, final ServerConfigurationPayload peerInfo) {
+ final FiniteDuration receiveTimeout, final String id, final ServerConfigurationPayload peerInfo) {
this.captureSnapshot = Preconditions.checkNotNull(captureSnapshot);
this.electionTerm = Preconditions.checkNotNull(electionTerm);
this.replyToActor = Preconditions.checkNotNull(replyToActor);
this.captureSnapshot = Preconditions.checkNotNull(captureSnapshot);
this.electionTerm = Preconditions.checkNotNull(electionTerm);
this.replyToActor = Preconditions.checkNotNull(replyToActor);
import org.opendaylight.controller.cluster.raft.client.messages.GetSnapshotReply;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.opendaylight.controller.cluster.raft.client.messages.GetSnapshotReply;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import scala.concurrent.duration.Duration;
+import scala.concurrent.duration.FiniteDuration;
/**
* Temporary actor used by the ShardManager to compile GetSnapshot replies from the Shard actors and return
/**
* Temporary actor used by the ShardManager to compile GetSnapshot replies from the Shard actors and return
public static Props props(final Collection<String> shardNames, final String datastoreType,
final ShardManagerSnapshot shardManagerSnapshot, final ActorRef replyToActor, final String id,
public static Props props(final Collection<String> shardNames, final String datastoreType,
final ShardManagerSnapshot shardManagerSnapshot, final ActorRef replyToActor, final String id,
- final Duration receiveTimeout) {
+ final FiniteDuration receiveTimeout) {
return Props.create(ShardManagerGetSnapshotReplyActor.class, new Params(shardNames, datastoreType,
shardManagerSnapshot, replyToActor, id, receiveTimeout));
}
return Props.create(ShardManagerGetSnapshotReplyActor.class, new Params(shardNames, datastoreType,
shardManagerSnapshot, replyToActor, id, receiveTimeout));
}
final ShardManagerSnapshot shardManagerSnapshot;
final ActorRef replyToActor;
final String id;
final ShardManagerSnapshot shardManagerSnapshot;
final ActorRef replyToActor;
final String id;
- final Duration receiveTimeout;
+ final FiniteDuration receiveTimeout;
Params(final Collection<String> shardNames, final String datastoreType,
final ShardManagerSnapshot shardManagerSnapshot, final ActorRef replyToActor, final String id,
Params(final Collection<String> shardNames, final String datastoreType,
final ShardManagerSnapshot shardManagerSnapshot, final ActorRef replyToActor, final String id,
- final Duration receiveTimeout) {
+ final FiniteDuration receiveTimeout) {
this.shardNames = shardNames;
this.datastoreType = datastoreType;
this.shardManagerSnapshot = shardManagerSnapshot;
this.shardNames = shardNames;
this.datastoreType = datastoreType;
this.shardManagerSnapshot = shardManagerSnapshot;