This automatically-generated patch flags all appropriate parameters as
final (including caught exceptions).
Change-Id: I18d9f65ec8addc7d5ecb7d809260c2d09ee8a4df
Signed-off-by: Stephen Kitt <skitt@redhat.com>
- public String logConfiguration(Class<?> klazz) {
+ public String logConfiguration(final Class<?> klazz) {
return "log4j.logger." + klazz.getPackage().getName();
}
return "log4j.logger." + klazz.getPackage().getName();
}
try (InputStream abstractConfigTestBaseInputStream = Thread.currentThread().getContextClassLoader()
.getResourceAsStream(PROPERTIES_FILENAME)) {
abstractConfigTestBaseProps.load(abstractConfigTestBaseInputStream);
try (InputStream abstractConfigTestBaseInputStream = Thread.currentThread().getContextClassLoader()
.getResourceAsStream(PROPERTIES_FILENAME)) {
abstractConfigTestBaseProps.load(abstractConfigTestBaseInputStream);
- } catch (IOException e) {
+ } catch (final IOException e) {
LOG.error("Unable to load {} to determine the Karaf version", PROPERTIES_FILENAME, e);
}
version = abstractConfigTestBaseProps.getProperty(KARAF_DISTRO_VERSION_PROP);
LOG.error("Unable to load {} to determine the Karaf version", PROPERTIES_FILENAME, e);
}
version = abstractConfigTestBaseProps.getProperty(KARAF_DISTRO_VERSION_PROP);
LOG.info("Module: {} Instance: {} ObjectName: {}.",
moduleName,instanceName,objectName);
break;
LOG.info("Module: {} Instance: {} ObjectName: {}.",
moduleName,instanceName,objectName);
break;
- } catch (Exception e) {
+ } catch (final Exception e) {
if(i<MODULE_TIMEOUT_MILLIS) {
Thread.sleep(1);
continue;
if(i<MODULE_TIMEOUT_MILLIS) {
Thread.sleep(1);
continue;
public TestRule watcher = new TestWatcher() {
@Override
public TestRule watcher = new TestWatcher() {
@Override
- protected void starting(Description description) {
+ protected void starting(final Description description) {
LOG.info("TestWatcher: Starting test: {}", description.getDisplayName());
}
@Override
LOG.info("TestWatcher: Starting test: {}", description.getDisplayName());
}
@Override
- protected void finished(Description description) {
+ protected void finished(final Description description) {
LOG.info("TestWatcher: Finished test: {}", description.getDisplayName());
}
@Override
LOG.info("TestWatcher: Finished test: {}", description.getDisplayName());
}
@Override
- protected void succeeded(Description description) {
+ protected void succeeded(final Description description) {
LOG.info("TestWatcher: Test succeeded: {}", description.getDisplayName());
}
@Override
LOG.info("TestWatcher: Test succeeded: {}", description.getDisplayName());
}
@Override
- protected void failed(Throwable ex, Description description) {
+ protected void failed(final Throwable ex, final Description description) {
LOG.info("TestWatcher: Test failed: {}", description.getDisplayName(), ex);
}
@Override
LOG.info("TestWatcher: Test failed: {}", description.getDisplayName(), ex);
}
@Override
- protected void skipped(AssumptionViolatedException ex, Description description) {
+ protected void skipped(final AssumptionViolatedException ex, final Description description) {
LOG.info("TestWatcher: Test skipped: {} ", description.getDisplayName(), ex);
}
};
LOG.info("TestWatcher: Test skipped: {} ", description.getDisplayName(), ex);
}
};