Comment (only) in controller:checkstyle to document next steps 00/39800/2
authorMichael Vorburger <vorburger@redhat.com>
Thu, 2 Jun 2016 21:35:10 +0000 (23:35 +0200)
committerTom Pantelis <tpanteli@brocade.com>
Fri, 17 Jun 2016 00:40:07 +0000 (00:40 +0000)
Change-Id: Ia7426febf2bb7503460d40f1f4710bcaabb5a6b3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
opendaylight/commons/checkstyle/src/main/resources/controller/checkstyle.xml

index 78c38f5..0c3699d 100644 (file)
@@ -2,8 +2,28 @@
 <!DOCTYPE module PUBLIC
     "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
     "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
-
 <module name="Checker">
+
+<!--
+     ======================================================================
+        Please do not add new Checkstyle check modules here anymore:
+
+        1. https://git.opendaylight.org/gerrit/#/c/39797/ has aligned
+        odl-parent's common Checkstyle rule set to include these.
+
+        2. As a next step, perhaps you would like to accept odl-parent's
+        Checkstyle definition as errors instead of warnings for Controller?
+        This is possible via violationSeverity=error as documented on
+        https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#Checkstyle
+
+        Please contact odlparent-dev@lists.opendaylight.org if you feel
+        a Checkstyle rule is too strict in general and should be reviewed.
+
+        3. Ultimately this entire project (org.opendaylight.controller:checkstyle)
+        should then be deleted, and dependencies to it removed.
+     ======================================================================
+ -->
+
     <module name="FileTabCharacter">
         <property name="eachLine" value="true"/>
     </module>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.