Mark classes as final 08/104708/2
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 2 Mar 2023 11:16:13 +0000 (12:16 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 2 Mar 2023 11:19:57 +0000 (12:19 +0100)
Static analysis is pointing out callouts from constructor to overridable
methods. Mark classes as final to make sure nothing untowards happens.

JIRA: CONTROLLER-2071
Change-Id: I9ed90a8919f3fd72374cb5564b8e241e954bce6e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
third-party/atomix/storage/src/main/java/io/atomix/storage/journal/FileChannelJournalSegmentReader.java
third-party/atomix/storage/src/main/java/io/atomix/storage/journal/MappedJournalSegmentReader.java
third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java

index 8ce9498f6c21b185701e26b5d3d43e769b857c67..98133546cfa64805d63d3bd340e6eae9ad71a62a 100644 (file)
@@ -32,7 +32,7 @@ import java.util.zip.Checksum;
  *
  * @author <a href="http://github.com/kuujo">Jordan Halterman</a>
  */
-class FileChannelJournalSegmentReader<E> implements JournalReader<E> {
+final class FileChannelJournalSegmentReader<E> implements JournalReader<E> {
   private final FileChannel channel;
   private final int maxEntrySize;
   private final JournalIndex index;
index 03d5c7fd87e6b33f60801801403ecae7c8291984..7ad7c219bcdbc1b6b150a5663a9b73f7db274692 100644 (file)
@@ -29,7 +29,7 @@ import java.util.zip.CRC32;
  *
  * @author <a href="http://github.com/kuujo">Jordan Halterman</a>
  */
-class MappedJournalSegmentReader<E> implements JournalReader<E> {
+final class MappedJournalSegmentReader<E> implements JournalReader<E> {
   private final ByteBuffer buffer;
   private final int maxEntrySize;
   private final JournalIndex index;
index 419a67e5fba2dba00a4bd37e92b7a0ec9ac85cfb..ea5944aabd03f354389d42d7d758b95b0e935094 100644 (file)
@@ -41,7 +41,7 @@ import static java.util.Objects.requireNonNull;
 /**
  * Segmented journal.
  */
-public class SegmentedJournal<E> implements Journal<E> {
+public final class SegmentedJournal<E> implements Journal<E> {
 
   /**
    * Returns a new Raft log builder.