Remove Namespace.populate() 38/104738/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 2 Mar 2023 17:01:56 +0000 (18:01 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 2 Mar 2023 17:02:41 +0000 (18:02 +0100)
populate() is implementation specific and used only internally.
Integrate it into the constructor.

JIRA: CONTROLLER-2072
Change-Id: I6a78a506d2a7936f84dac332928848af832a21aa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
third-party/atomix/storage/src/main/java/io/atomix/utils/serializer/Namespace.java

index 2343e7afd65ef98299b29ce935e8e7e8400c6bf4..dcad23d9f0f211332f58f7a32cb6452e8ae6bb8f 100644 (file)
@@ -108,7 +108,7 @@ public final class Namespace implements KryoFactory, KryoPool {
       if (!types.isEmpty()) {
         blocks.add(new RegistrationBlock(this.blockHeadId, types));
       }
-      return new Namespace(blocks, classLoader, friendlyName).populate(1);
+      return new Namespace(blocks, classLoader, friendlyName);
     }
 
     /**
@@ -161,20 +161,9 @@ public final class Namespace implements KryoFactory, KryoPool {
     this.registeredBlocks = ImmutableList.copyOf(registeredTypes);
     this.classLoader = classLoader;
     this.friendlyName = requireNonNull(friendlyName);
-  }
-
-  /**
-   * Populates the Kryo pool.
-   *
-   * @param instances to add to the pool
-   * @return this
-   */
-  public Namespace populate(int instances) {
 
-    for (int i = 0; i < instances; ++i) {
-      release(create());
-    }
-    return this;
+    // Pre-populate with a single instance
+    release(create());
   }
 
   /**