Bug 7814: Add counter to make tx actor names unique 82/54882/1
authorTom Pantelis <tpanteli@brocade.com>
Wed, 22 Mar 2017 03:21:37 +0000 (23:21 -0400)
committerSrini Seetharaman <srini.seetharaman@gmail.com>
Wed, 12 Apr 2017 15:50:03 +0000 (08:50 -0700)
Appended an incrementing counter value to the actor name which
will guarantee uniqueness.

Change-Id: I5454968ebd549c24293203f112d4541d2aede671
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFactory.java

index d21878f95d613e724deafd6ae9af9452ccd68f57..43bf0228049c7a5cbe1b592ab661d559f6b1bd3f 100644 (file)
@@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.datastore;
 import akka.actor.ActorRef;
 import akka.actor.UntypedActorContext;
 import com.google.common.base.Preconditions;
+import java.util.concurrent.atomic.AtomicLong;
 import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
 import org.opendaylight.controller.cluster.access.concepts.FrontendIdentifier;
 import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier;
@@ -22,6 +23,7 @@ import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats
  * @author Thomas Pantelis
  */
 class ShardTransactionActorFactory {
+    private static final AtomicLong ACTOR_NAME_COUNTER = new AtomicLong();
 
     private final ShardDataTree dataTree;
     private final DatastoreContext datastoreContext;
@@ -57,7 +59,7 @@ class ShardTransactionActorFactory {
             sb.append(historyId.getHistoryId()).append('-');
         }
 
-        return sb.append(txId.getTransactionId()).toString();
+        return sb.append(txId.getTransactionId()).append('_').append(ACTOR_NAME_COUNTER.incrementAndGet()).toString();
     }
 
     ActorRef newShardTransaction(TransactionType type, TransactionIdentifier transactionID) {