yang-test POM simplification 32/58732/2
authorMichael Vorburger <vorburger@redhat.com>
Mon, 12 Jun 2017 12:45:43 +0000 (14:45 +0200)
committerRobert Varga <nite@hq.sk>
Tue, 13 Jun 2017 08:40:06 +0000 (08:40 +0000)
Motivated by review https://git.opendaylight.org/gerrit/#/c/58714/, and
realizing that the odl-license version in this POM will cause issues
everytime we'll upgrade odplarent (which may be more frequent, soon).

This is effectively a counter proposal to c/58714, as on looking at this
it seems instead of bumping that version, we can remove most of what's
causing this (without loosing anything; CS still runs, not that we
care), becaues most of this is is inherited in Maven, the point of that
configuration is just to skip the VS validation which this project for
some reason exceptionally gen. into src/main instead of into target/.

The ${lifecycle.mapping.version} is replaced by fixed 1.0.0

Change-Id: Ic78c35a940dc7ee5fe25f3527529591e5c5214f7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
opendaylight/config/yang-test/pom.xml

index ba74fa1d8aa3d3292335b0601bfcc40aa70c38c1..2cb247dc201fb5878a5a22dab1260acd78b7cfe5 100644 (file)
       <groupId>org.opendaylight.mdsal.model</groupId>
       <artifactId>ietf-inet-types-2013-07-15</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-api</artifactId>
-    </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>config-manager</artifactId>
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.opendaylight.controller</groupId>
       <artifactId>config-util</artifactId>
@@ -60,7 +51,7 @@
         <plugin>
           <groupId>org.eclipse.m2e</groupId>
           <artifactId>lifecycle-mapping</artifactId>
-          <version>${lifecycle.mapping.version}</version>
+          <version>1.0.0</version>
           <configuration>
             <lifecycleMappingMetadata>
               <pluginExecutions>
     <plugins>
       <plugin>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>${checkstyle.version}</version>
-        <dependencies>
-          <dependency>
-            <groupId>org.opendaylight.odlparent</groupId>
-            <artifactId>checkstyle</artifactId>
-            <version>${odl.checkstyle.version}</version>
-          </dependency>
-          <dependency>
-            <groupId>org.opendaylight.odlparent</groupId>
-            <artifactId>odl-license</artifactId>
-            <version>0.3.0-SNAPSHOT</version>
-          </dependency>
-        </dependencies>
         <executions>
           <execution>
             <id>check-license</id>
             </goals>
             <phase>process-sources</phase>
             <configuration>
-              <configLocation>check-license.xml</configLocation>
-              <includeResources>false</includeResources>
-              <includeTestResources>false</includeTestResources>
-              <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
               <excludes>
                 org/opendaylight/yang/gen/**,
-                **/protobuff/messages/**,
-                **/thrift/gen/*.java,
                 **/config/yang/test/**
               </excludes>
-              <failsOnError>false</failsOnError>
-              <consoleOutput>true</consoleOutput>
             </configuration>
           </execution>
         </executions>
           <execution>
             <goals>
               <goal>delete-sources</goal>
-
               <goal>process-sources</goal>
             </goals>
           </execution>