Bug 2358 - Remove tests cnsn to json and add tests nn to json 14/22614/3
authorary <jatoth@cisco.com>
Fri, 15 May 2015 13:25:08 +0000 (15:25 +0200)
committerGerrit Code Review <gerrit@opendaylight.org>
Wed, 8 Jul 2015 14:20:27 +0000 (14:20 +0000)
Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove CnSnJsonChoiceCaseTest test
* add NnJsonChoiceCaseTest to nn/to/json/test/
  * positive and negative tests for choice statement

Change-Id: I83d351bf0de9bb4a1c649c5851209ae472aaaa24
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 33657892ea175d459184732b0fbc08eb7589e787)

opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/json/test/CnSnJsonChoiceCaseTest.java [deleted file]
opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/nn/to/json/test/NnJsonChoiceCaseTest.java [new file with mode: 0644]

diff --git a/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/json/test/CnSnJsonChoiceCaseTest.java b/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/json/test/CnSnJsonChoiceCaseTest.java
deleted file mode 100644 (file)
index a98f39a..0000000
+++ /dev/null
@@ -1,20 +0,0 @@
-/*
- * Copyright (c) 2014 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.sal.restconf.impl.cnsn.to.json.test;
-
-import org.junit.BeforeClass;
-import org.opendaylight.controller.sal.restconf.impl.test.YangAndXmlAndDataSchemaLoader;
-
-public class CnSnJsonChoiceCaseTest extends YangAndXmlAndDataSchemaLoader {
-
-    @BeforeClass
-    public static void initialization() {
-        dataLoad("/cnsn-to-json/choice");
-    }
-
-}
diff --git a/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/nn/to/json/test/NnJsonChoiceCaseTest.java b/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/nn/to/json/test/NnJsonChoiceCaseTest.java
new file mode 100644 (file)
index 0000000..b2bb6a8
--- /dev/null
@@ -0,0 +1,178 @@
+package org.opendaylight.controller.sal.restconf.impl.nn.to.json.test;
+
+import static org.junit.Assert.assertTrue;
+import java.io.ByteArrayOutputStream;
+import java.io.OutputStream;
+import javax.ws.rs.core.MediaType;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.opendaylight.controller.md.sal.rest.common.TestRestconfUtils;
+import org.opendaylight.controller.sal.rest.impl.NormalizedNodeJsonBodyWriter;
+import org.opendaylight.controller.sal.rest.impl.test.providers.AbstractBodyReaderTest;
+import org.opendaylight.controller.sal.restconf.impl.NormalizedNodeContext;
+import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+
+public class NnJsonChoiceCaseTest extends AbstractBodyReaderTest {
+
+    private static SchemaContext schemaContext;
+    private final NormalizedNodeJsonBodyWriter jsonBodyWriter;
+
+    public NnJsonChoiceCaseTest() throws NoSuchFieldException,
+            SecurityException {
+        super();
+        jsonBodyWriter = new NormalizedNodeJsonBodyWriter();
+    }
+
+    @BeforeClass
+    public static void initialization() {
+        schemaContext = schemaContextLoader("/nn-to-json/choice", schemaContext);
+        controllerContext.setSchemas(schemaContext);
+    }
+
+    /**
+     * Test when some data are in one case node and other in another. This isn't
+     * correct. Next Json validator should return error because nodes has to be
+     * from one case below concrete choice.
+     */
+    @Test(expected = NullPointerException.class)
+    public void nodeSchemasOnVariousChoiceCasePathTest() throws Exception {
+        getJson("/nn-to-json/choice/xml/data_various_path_err.xml");
+    }
+
+    /**
+     * Test when some data are in one case node and other in another.
+     * Additionally data are loadef from various choices. This isn't correct.
+     * Next Json validator should return error because nodes has to be from one
+     * case below concrete choice.
+     */
+    @Test(expected = NullPointerException.class)
+    public void nodeSchemasOnVariousChoiceCasePathAndMultipleChoicesTest()
+            throws Exception {
+        getJson("/nn-to-json/choice/xml/data_more_choices_same_level_various_paths_err.xml");
+    }
+
+    /**
+     * Test when second level data are red first, then first and at the end
+     * third level. Level represents pass through couple choice-case
+     */
+
+    @Test
+    public void nodeSchemasWithRandomOrderAccordingLevel() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_random_level.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"lf1\":\"lf1 val\""));
+        assertTrue(json.contains("\"lf1aaa\":\"lf1aaa val\""));
+        assertTrue(json.contains("\"lf1aa\":\"lf1aa val\""));
+        assertTrue(json.contains("\"lf1a\":121"));
+    }
+
+    /**
+     * Test when element from no first case is used
+     */
+    @Test
+    public void nodeSchemasNotInFirstCase() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_no_first_case.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"lf1\":\"lf1 val\""));
+        assertTrue(json.contains("\"lf1ab\":\"lf1ab val\""));
+        assertTrue(json.contains("\"lf1a\":121"));
+    }
+
+    /**
+     * Test when element in case is list
+     */
+    @Test
+    public void nodeSchemaAsList() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_list.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"lst1b\":["));
+        assertTrue(json.contains("{\"lf11b\":\"lf11b_1 val\"}"));
+        assertTrue(json.contains("{\"lf11b\":\"lf11b_2 val\"}"));
+    }
+
+    /**
+     * Test when element in case is container
+     */
+    @Test
+    public void nodeSchemaAsContainer() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_container.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"cont1c\":{"));
+        assertTrue(json.contains("\"lf11c\":\"lf11c val\""));
+    }
+
+    /**
+     * Test when element in case is leaflist
+     */
+    @Test
+    public void nodeSchemaAsLeafList() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_leaflist.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"lflst1d\":["));
+        assertTrue(json.contains("\"lflst1d_1 val\""));
+        assertTrue(json.contains("\"lflst1d_2 val\""));
+    }
+
+    /**
+     *
+     */
+    @Test
+    public void nodeSchemasInMultipleChoicesTest() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_more_choices_same_level.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"lf2b\":\"lf2b value\""));
+        assertTrue(json.contains("\"cont1c\":{"));
+        assertTrue(json.contains("\"lf11c\":\"lf11c val\""));
+    }
+
+    /**
+     * Test whether is possible to find data schema for node which is specified
+     * as dirrect subnode of choice (case without CASE key word)
+     */
+    @Test
+    public void nodeSchemasInCaseNotDefinedWithCaseKeyword() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_case_defined_without_case.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("\"lf2b\":\"lf2b val\""));
+        assertTrue(json.contains("\"e1\":45"));
+    }
+
+    /**
+     * Test of multiple use of choices
+     */
+    @Test
+    public void nodeSchemasInThreeChoicesAtSameLevel() throws Exception {
+        final String json = getJson("/nn-to-json/choice/xml/data_three_choices_same_level.xml");
+
+        assertTrue(json.contains("cont"));
+        assertTrue(json.contains("lf2b\":\"lf2b value"));
+        assertTrue(json.contains("lst4a\":[{"));
+        assertTrue(json.contains("{\"lf4ab\":33}"));
+        assertTrue(json.contains("{\"lf4ab\":37}"));
+        assertTrue(json.contains("\"lf1aaa\":\"lf1aaa value\""));
+    }
+
+    private String getJson(final String xmlPath) throws Exception {
+        final String uri = "choice-case-test:cont";
+        final NormalizedNodeContext testNN = TestRestconfUtils
+                .loadNormalizedContextFromXmlFile(xmlPath, uri);
+
+        final OutputStream output = new ByteArrayOutputStream();
+        jsonBodyWriter.writeTo(testNN, null, null, null, mediaType, null,
+                output);
+
+        return output.toString();
+    }
+
+    @Override
+    protected MediaType getMediaType() {
+        return null;
+    }
+}