Using .remove() instead of .poll() makes FB shut up,
because the return value is not used for signalling
queue state.
Change-Id: I0aefc0eb7ede948b8311d12c6307137532018386
Signed-off-by: Robert Varga <rovarga@cisco.com>
- @SuppressFBWarnings(value = "RV_RETURN_VALUE_IGNORED", justification = "See inline comment below.")
void startAbort(final SimpleShardDataTreeCohort cohort) {
final Iterator<CommitEntry> it = pendingTransactions.iterator();
if (!it.hasNext()) {
void startAbort(final SimpleShardDataTreeCohort cohort) {
final Iterator<CommitEntry> it = pendingTransactions.iterator();
if (!it.hasNext()) {
LOG.debug("{}: aborted head of queue {} in state {}", logContext, cohort.getIdentifier(),
cohort.getIdentifier());
LOG.debug("{}: aborted head of queue {} in state {}", logContext, cohort.getIdentifier(),
cohort.getIdentifier());
- // The suppression of the FindBugs "RV_RETURN_VALUE_IGNORED" warning pertains to this line. In
- // this case, we've already obtained the head of the queue above via the Iterator and we just want to
- // remove it here.
- pendingTransactions.poll();
+ pendingTransactions.remove();
processNextTransaction();
} else {
LOG.warn("{}: transaction {} is committing, skipping abort", logContext, cohort.getIdentifier());
processNextTransaction();
} else {
LOG.warn("{}: transaction {} is committing, skipping abort", logContext, cohort.getIdentifier());