Stop concatination inside append of StringBuffer

Change-Id: Ic62d273a6b401fb06e0299e36dcd0b428304a799
Signed-off-by: Alissa Bonas <abonas@redhat.com>

diff --git a/opendaylight/hosttracker/implementation/src/main/java/org/opendaylight/controller/hosttracker/internal/HostTracker.java b/opendaylight/hosttracker/implementation/src/main/java/org/opendaylight/controller/hosttracker/internal/HostTracker.java
index d7941f9cce19f90e9dc4494b5c074be3b90d4a82..e98b7fc90de84eae635f8ae55e3b3a1a23c49887 100644 (file)
--- a/opendaylight/hosttracker/implementation/src/main/java/org/opendaylight/controller/hosttracker/internal/HostTracker.java
+++ b/opendaylight/hosttracker/implementation/src/main/java/org/opendaylight/controller/hosttracker/internal/HostTracker.java
@@ -696,9 +696,9 @@ public class HostTracker implements IfIptoHost, IfHostListener, ISwitchManagerAw
         int num = 1;
         for (ArrayList<String> hierarchy : hierarchies) {
             StringBuffer buf = new StringBuffer();
-            buf.append("Hierarchy#" + num + " : ");
+            buf.append("Hierarchy#").append(num).append(" : ");
             for (String switchName : hierarchy) {
-                buf.append(switchName + "/");
+                buf.append(switchName).append("/");
             }
             logger.debug("{} -> {}", getContainerName(), buf);
             num++;

diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/ComponentActivatorAbstractBase.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/ComponentActivatorAbstractBase.java
index 439e7807d4f52894244ceac0978a8972c5b6850e..b2145262d4f7228a8b6292cfd6906ac1581ec3bf 100644 (file)
--- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/ComponentActivatorAbstractBase.java
+++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/ComponentActivatorAbstractBase.java
@@ -287,7 +287,7 @@ abstract public class ComponentActivatorAbstractBase implements
         StringBuffer buffer = new StringBuffer();
 
         for (int i = 0; i < stack.length; i++) {
-            buffer.append("\n\t" + stack[i].toString());
+            buffer.append("\n\t").append(stack[i].toString());
         }
         return buffer.toString();
     }

diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Latency.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Latency.java
index 1320bbb69333b16a14f072a94be72f11e77482ba..dbe12a1e0d2fca604981f65c77b855cb40d6677c 100644 (file)
--- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Latency.java
+++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Latency.java
@@ -103,13 +103,13 @@ public class Latency extends Property {
         if (this.latencyValue == 0) {
             sb.append("UnKnown");
         } else if (this.latencyValue < LATENCY1ns) {
-            sb.append(this.latencyValue + "psec");
+            sb.append(this.latencyValue).append("psec");
         } else if (this.latencyValue < LATENCY1us) {
-            sb.append(Long.toString(this.latencyValue / LATENCY1ns) + "nsec");
+            sb.append(Long.toString(this.latencyValue / LATENCY1ns)).append("nsec");
         } else if (this.latencyValue < LATENCY1ms) {
-            sb.append(Long.toString(this.latencyValue / LATENCY1us) + "usec");
+            sb.append(Long.toString(this.latencyValue / LATENCY1us)).append("usec");
         } else if (this.latencyValue < LATENCY1s) {
-            sb.append(Long.toString(this.latencyValue / LATENCY1ms) + "msec");
+            sb.append(Long.toString(this.latencyValue / LATENCY1ms)).append("msec");
         }
 
         sb.append("]");

diff --git a/opendaylight/web/troubleshoot/src/main/java/org/opendaylight/controller/troubleshoot/web/Troubleshoot.java b/opendaylight/web/troubleshoot/src/main/java/org/opendaylight/controller/troubleshoot/web/Troubleshoot.java
index eab07418b46fa51ff9fd3524dc0160337537c70c..e46b89ac2afe3fa2f46604f5a7f3fde2298181b3 100644 (file)
--- a/opendaylight/web/troubleshoot/src/main/java/org/opendaylight/controller/troubleshoot/web/Troubleshoot.java
+++ b/opendaylight/web/troubleshoot/src/main/java/org/opendaylight/controller/troubleshoot/web/Troubleshoot.java
@@ -361,50 +361,39 @@ public class Troubleshoot implements IDaylightWeb {
                 if (outPorts.length() > 0) {
                     outPorts.append(" ");
                 }
-                actions.append(action.getType().toString() + " = "
-                        + ao.getPort().getNodeConnectorIdAsString() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(ao.getPort().getNodeConnectorIdAsString()).append("<br>");
             } else if (action instanceof SetVlanId) {
                 SetVlanId av = (SetVlanId) action;
                 String outVlanId = String.valueOf(av.getVlanId());
-                actions.append(action.getType().toString() + " = " + outVlanId
-                        + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(outVlanId).append("<br>");
             } else if (action instanceof SetDlSrc) {
                 SetDlSrc ads = (SetDlSrc) action;
-                actions.append(action.getType().toString() + " = "
-                        + HexEncode.bytesToHexStringFormat(ads.getDlAddress()) + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(HexEncode.bytesToHexStringFormat(ads.getDlAddress())).append("<br>");
             } else if (action instanceof SetDlDst) {
                 SetDlDst add = (SetDlDst) action;
-                actions.append(action.getType().toString() + " = "
-                        + HexEncode.bytesToHexStringFormat(add.getDlAddress())
-                        + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(HexEncode.bytesToHexStringFormat(add.getDlAddress())).append("<br>");
             } else if (action instanceof SetNwSrc) {
                 SetNwSrc ans = (SetNwSrc) action;
-                actions.append(action.getType().toString() + " = "
-                        + ans.getAddressAsString() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(ans.getAddressAsString()).append("<br>");
             } else if (action instanceof SetNwDst) {
                 SetNwDst and = (SetNwDst) action;
-                actions.append(action.getType().toString() + " = "
-                        + and.getAddressAsString() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(and.getAddressAsString()).append("<br>");
             } else if (action instanceof SetNwTos) {
                 SetNwTos ant = (SetNwTos) action;
-                actions.append(action.getType().toString() + " = "
-                        + ant.getNwTos() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(ant.getNwTos()).append("<br>");
             } else if (action instanceof SetTpSrc) {
                 SetTpSrc ads = (SetTpSrc) action;
-                actions.append(action.getType().toString() + " = "
-                        + ads.getPort() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(ads.getPort()).append("<br>");
             } else if (action instanceof SetTpDst) {
                 SetTpDst atd = (SetTpDst) action;
-                actions.append(action.getType().toString() + " = "
-                        + atd.getPort() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(atd.getPort()).append("<br>");
             } else if (action instanceof SetVlanPcp) {
                 SetVlanPcp avp = (SetVlanPcp) action;
-                actions.append(action.getType().toString() + " = "
-                        + avp.getPcp() + "<br>");
+                actions.append(action.getType().toString()).append(" = ").append(avp.getPcp()).append("<br>");
                 // } else if (action instanceof SetDlSrc) {
                 // SetDlSrc ads = (SetDlSrc) action;
             } else {
-                actions.append(action.getType().toString() + "<br>");
+                actions.append(action.getType().toString()).append("<br>");
             }
         }
         row.put("actions", actions.toString());