AutoCloseable.close() is recommended to be idempotent, follow that
guidance, producing a warning with a stack trace if that is not the
case.
Change-Id: I1b65466f9b84e05417d8cd24c1b7a5e89e8e836b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
import org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreThreePhaseCommitCohort;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreTransactionFactory;
import org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreThreePhaseCommitCohort;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreTransactionFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public abstract class AbstractDOMTransactionFactory<T extends DOMStoreTransactionFactory> implements AutoCloseable {
public abstract class AbstractDOMTransactionFactory<T extends DOMStoreTransactionFactory> implements AutoCloseable {
+ private static final Logger LOG = LoggerFactory.getLogger(AbstractDOMTransactionFactory.class);
@SuppressWarnings("rawtypes")
private static final AtomicIntegerFieldUpdater<AbstractDOMTransactionFactory> UPDATER =
AtomicIntegerFieldUpdater.newUpdater(AbstractDOMTransactionFactory.class, "closed");
@SuppressWarnings("rawtypes")
private static final AtomicIntegerFieldUpdater<AbstractDOMTransactionFactory> UPDATER =
AtomicIntegerFieldUpdater.newUpdater(AbstractDOMTransactionFactory.class, "closed");
private final Map<LogicalDatastoreType, T> storeTxFactories;
private final Map<LogicalDatastoreType, T> storeTxFactories;
private volatile int closed = 0;
protected AbstractDOMTransactionFactory(final Map<LogicalDatastoreType, T> txFactories) {
private volatile int closed = 0;
protected AbstractDOMTransactionFactory(final Map<LogicalDatastoreType, T> txFactories) {
@Override
public void close() {
@Override
public void close() {
- final boolean success = UPDATER.compareAndSet(this, 0, 1);
- Preconditions.checkState(success, "Transaction factory was already closed");
+ if (!UPDATER.compareAndSet(this, 0, 1)) {
+ LOG.warn("Transaction factory was already closed", new Throwable());
+ }