Remove unecessary instantiation of Integer 84/1484/3
authorAlissa Bonas <abonas@redhat.com>
Sun, 29 Sep 2013 13:52:15 +0000 (16:52 +0300)
committerGerrit Code Review <gerrit@opendaylight.org>
Mon, 30 Sep 2013 11:09:27 +0000 (11:09 +0000)
Change-Id: I057e2df2cc6bf59c8a73ecabee9235c6615f0287
Signed-off-by: Alissa Bonas <abonas@redhat.com>
opendaylight/md-sal/sal-compability/src/main/java/org/opendaylight/controller/sal/compability/FromSalConversionsUtils.java
opendaylight/samples/loadbalancer/src/main/java/org/opendaylight/controller/samples/loadbalancer/policies/RoundRobinLBPolicy.java

index 18c47246290b0207a56be128e0df02ebb87f780a..4ffa45adf34a13f27cb11e6d8e16ce48ac9336b5 100644 (file)
@@ -64,9 +64,9 @@ public class FromSalConversionsUtils {
         if (sourceFlow != null) {
             final FlowAddedBuilder targetFlow = new FlowAddedBuilder();
 
-            targetFlow.setHardTimeout(new Integer(sourceFlow.getHardTimeout()));
-            targetFlow.setIdleTimeout(new Integer(sourceFlow.getIdleTimeout()));
-            targetFlow.setPriority(new Integer(sourceFlow.getPriority()));
+            targetFlow.setHardTimeout((int) sourceFlow.getHardTimeout());
+            targetFlow.setIdleTimeout((int) sourceFlow.getIdleTimeout());
+            targetFlow.setPriority((int) sourceFlow.getPriority());
             targetFlow.setCookie(new BigInteger(String.valueOf(sourceFlow.getId())));
 
             List<org.opendaylight.controller.sal.action.Action> sourceActions = sourceFlow.getActions();
index c8687883e7e08cc0711a4d53a34762471fe06bb0..1a473a7c04ea3de5f3255c2cbfabde33748db2d1 100644 (file)
@@ -88,7 +88,7 @@ public class RoundRobinLBPolicy implements ILoadBalancingPolicy{
                 }
                 rrLogger.debug("Next pool member for new client of VIP is set to {}",pool.getAllMembers().get(memberNum));
 
-                this.nextItemFromPool.put(dest, new Integer(memberNum));
+                this.nextItemFromPool.put(dest, memberNum);
             }else{
                 rrLogger.debug("Network traffic for VIP : {} has appeared first time from client {}",dest,source);
                 pool = this.cmgr.getPool(dest.getPoolName());
@@ -96,7 +96,7 @@ public class RoundRobinLBPolicy implements ILoadBalancingPolicy{
                 this.clientMemberMap.put(source, pm);
 
                 rrLogger.info("Network traffic from client {} will be directed to pool member {}",pm);
-                this.nextItemFromPool.put(dest, new Integer(1));
+                this.nextItemFromPool.put(dest, 1);
                 rrLogger.debug("Next pool member for new client of VIP is set to {}",pool.getAllMembers().get(1));
             }
         }
@@ -145,7 +145,7 @@ public class RoundRobinLBPolicy implements ILoadBalancingPolicy{
 
         for(VIP vip:resetVIPPoolMemberCount){
             rrLogger.debug("VIP next pool member counter reset to 0");
-            this.nextItemFromPool.put(vip, new Integer(0));
+            this.nextItemFromPool.put(vip, 0);
         }
 
         rrLogger.debug("[VIP- NextMember] table after cleanup : {}",this.nextItemFromPool.toString());