This patch makes RaftState (which is a RAFT concept) independent of
behaviors (which are an implementation detail). This will allow us to
freeze RaftState and make it more widely available.
Change-Id: I70b4e7f762e3cb20a6c7b865f1a0c1f46f9a3d33
Signed-off-by: Robert Varga <rovarga@cisco.com>
import org.opendaylight.controller.cluster.raft.base.messages.Replicate;
import org.opendaylight.controller.cluster.raft.base.messages.SwitchBehavior;
import org.opendaylight.controller.cluster.raft.behaviors.AbstractLeader;
import org.opendaylight.controller.cluster.raft.base.messages.Replicate;
import org.opendaylight.controller.cluster.raft.base.messages.SwitchBehavior;
import org.opendaylight.controller.cluster.raft.behaviors.AbstractLeader;
+import org.opendaylight.controller.cluster.raft.behaviors.AbstractRaftActorBehavior;
import org.opendaylight.controller.cluster.raft.behaviors.DelegatingRaftActorBehavior;
import org.opendaylight.controller.cluster.raft.behaviors.Follower;
import org.opendaylight.controller.cluster.raft.behaviors.RaftActorBehavior;
import org.opendaylight.controller.cluster.raft.behaviors.DelegatingRaftActorBehavior;
import org.opendaylight.controller.cluster.raft.behaviors.Follower;
import org.opendaylight.controller.cluster.raft.behaviors.RaftActorBehavior;
@Override
public RaftActorBehavior get() {
if(this.message instanceof SwitchBehavior){
@Override
public RaftActorBehavior get() {
if(this.message instanceof SwitchBehavior){
- return ((SwitchBehavior) message).getNewState().createBehavior(getRaftActorContext());
+ return AbstractRaftActorBehavior.createBehavior(context, ((SwitchBehavior) message).getNewState());
}
return currentBehavior.handleMessage(sender, message);
}
}
return currentBehavior.handleMessage(sender, message);
}
package org.opendaylight.controller.cluster.raft;
package org.opendaylight.controller.cluster.raft;
-import org.opendaylight.controller.cluster.raft.behaviors.Candidate;
-import org.opendaylight.controller.cluster.raft.behaviors.Follower;
-import org.opendaylight.controller.cluster.raft.behaviors.IsolatedLeader;
-import org.opendaylight.controller.cluster.raft.behaviors.Leader;
-import org.opendaylight.controller.cluster.raft.behaviors.RaftActorBehavior;
-
- Candidate {
- @Override
- public RaftActorBehavior createBehavior(RaftActorContext context) {
- return new Candidate(context);
- }
- },
- Follower {
- @Override
- public RaftActorBehavior createBehavior(RaftActorContext context) {
- return new Follower(context);
- }
- },
- Leader {
- @Override
- public RaftActorBehavior createBehavior(RaftActorContext context) {
- return new Leader(context);
- }
- },
- IsolatedLeader {
- @Override
- public RaftActorBehavior createBehavior(RaftActorContext context) {
- return new IsolatedLeader(context);
- }
- };
-
- public abstract RaftActorBehavior createBehavior(RaftActorContext context);
+ Candidate,
+ Follower,
+ Leader,
+ IsolatedLeader;
import akka.actor.ActorRef;
import akka.actor.Cancellable;
import akka.actor.ActorRef;
import akka.actor.Cancellable;
+import com.google.common.base.Preconditions;
import java.util.Random;
import java.util.concurrent.TimeUnit;
import org.opendaylight.controller.cluster.raft.ClientRequestTracker;
import java.util.Random;
import java.util.concurrent.TimeUnit;
import org.opendaylight.controller.cluster.raft.ClientRequestTracker;
private final RaftState state;
private final RaftState state;
- protected AbstractRaftActorBehavior(RaftActorContext context, RaftState state) {
- this.context = context;
- this.state = state;
+ AbstractRaftActorBehavior(final RaftActorContext context, final RaftState state) {
+ this.context = Preconditions.checkNotNull(context);
+ this.state = Preconditions.checkNotNull(state);
this.LOG = context.getLogger();
logName = String.format("%s (%s)", context.getId(), state);
}
this.LOG = context.getLogger();
logName = String.format("%s (%s)", context.getId(), state);
}
+ public static RaftActorBehavior createBehavior(final RaftActorContext context, final RaftState state) {
+ switch (state) {
+ case Candidate:
+ return new Candidate(context);
+ case Follower:
+ return new Follower(context);
+ case IsolatedLeader:
+ return new IsolatedLeader(context);
+ case Leader:
+ return new Leader(context);
+ default:
+ throw new IllegalArgumentException("Unhandled state " + state);
+ }
+ }
+
@Override
public RaftState state() {
return state;
@Override
public RaftState state() {
return state;
protected RaftActorBehavior internalSwitchBehavior(RaftState newState) {
if(context.getRaftPolicy().automaticElectionsEnabled()){
protected RaftActorBehavior internalSwitchBehavior(RaftState newState) {
if(context.getRaftPolicy().automaticElectionsEnabled()){
- return internalSwitchBehavior(newState.createBehavior(context));
+ return internalSwitchBehavior(createBehavior(context, newState));