Use $ for list arg passed in to builtIn kw 87/79287/1
authorJamo Luhrsen <jluhrsen@redhat.com>
Mon, 7 Jan 2019 19:27:48 +0000 (11:27 -0800)
committerJamo Luhrsen <jluhrsen@redhat.com>
Mon, 7 Jan 2019 19:27:48 +0000 (11:27 -0800)
If a list is passed in with the @ syntax, it's expanded first
the first two elements are used for the BuiltIn keyword. So
the result is not what we expect. I noticed it in this false
failure:

https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netvirt-csit-1node-1cmb-0ctl-0cmp-openstack-queens-upstream-stateful-snat-conntrack-fluorine/154/robot-plugin/log_full.html.gz#s1-s11-k1-k2-k6-k5

it needs to come in with the $ syntax so the keyword can
use it internally to loop over, and compare to the 2nd
argument.

Change-Id: Iea8cda9f8f7357cac3399cf7756822cc743cc6cd
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
csit/suites/netvirt/elan/elan_service_recovery.robot

index 916a361f903bc34d6ab1d76280d15ab202186deb..1dc2892db3e737facceb5126493133b08d9882ab 100644 (file)
@@ -95,8 +95,8 @@ Create Nova VMs
     \    OpenStackOperations.Create Vm Instance With Port On Compute Node    @{PORT_LIST}[${index + 2}]    @{NET_2_VMS}[${index}]    ${OS_CMP2_HOSTNAME}    sg=${SECURITY_GROUP}
     @{NET_1_VM_IPS}    ${NET_1_DHCP_IP} =    OpenStackOperations.Get VM IPs    @{NET_1_VMS}
     @{NET_2_VM_IPS}    ${NET_2_DHCP_IP} =    OpenStackOperations.Get VM IPs    @{NET_2_VMS}
-    BuiltIn.Should Not Contain    @{NET_1_VM_IPS}    None
-    BuiltIn.Should Not Contain    @{NET_2_VM_IPS}    None
+    BuiltIn.Should Not Contain    ${NET_1_VM_IPS}    None
+    BuiltIn.Should Not Contain    ${NET_2_VM_IPS}    None
     BuiltIn.Should Not Contain    ${NET_1_DHCP_IP}    None
     BuiltIn.Should Not Contain    ${NET_2_DHCP_IP}    None