Optimize JavaIdentifierNormalizer.normalizeClassIdentifier()

Do not use toLowerCase() in order to perform a simple compare.

Change-Id: Iadb0fce7a7ec163494442396111c6f473ac649e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit bf58434226294ecaf660584d840940cedeb18010)

diff --git a/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java b/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java
index 8ff3763dd01847f15c2db5687e38b067b5ed8c6f..038d95017e6199a403d7a887d53b54e4468a85ea 100644 (file)
--- a/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java
+++ b/binding2/mdsal-binding2-generator-util/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/util/JavaIdentifierNormalizer.java
@@ -438,12 +438,12 @@ public final class JavaIdentifierNormalizer {
      */
     private static String normalizeClassIdentifier(final String packageName, final String origClassName,
             final String actualClassName, final int rank) {
+
+        // FIXME: this does not look thread-safe and seems to leak memory
         if (PACKAGES_MAP.containsKey(packageName)) {
             for (final String existingName : PACKAGES_MAP.get(packageName)) {
-                if (existingName.toLowerCase().equals(actualClassName.toLowerCase())) {
-                    final int nextRank = rank + 1;
-                    return normalizeClassIdentifier(packageName, origClassName,
-                            new StringBuilder(origClassName).append(rank).toString(), nextRank);
+                if (actualClassName.equalsIgnoreCase(existingName)) {
+                    return normalizeClassIdentifier(packageName, origClassName, origClassName + rank, rank + 1);
                 }
             }
         }