Do not instantiate iterator for debugging

Logging the entire collection is more appropriate and also
faster when logging is disabled.

Change-Id: Ib3e44851bcedad1eaabad983c1ac45de6890eec2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Perform delegate cursor enter/exit first

Delegate may fail to perform the operation, which would leave
our stack inconsistent, leading to confusion if the user ignores
exceptions. Perform enter/exit on delegate first and only if it
succeeds proceed to update our stack.

Change-Id: If6ebfd9b530e9052a5dc8cab120a5d0c8317f937
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 10787df610669aa4bb22f7f8feae1dc1455dffb8)

Move lookup check

We can use a precondition to make the code flow
more obvious.

Change-Id: Iaddfcfd4d49a91b6875a6f4803fed744ada63a85
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit bf69b6948754f6b1a7de124cc54bbe88b3532772)

Eliminate ShardedDOMDataTreeWriteTransaction.doSubmit()'s return

Returned future is not used anywhere, hence we can easily remove it.

Change-Id: I4ead4da32d1c2658d5c88f01534b5452230068e7
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit ada2c265698298bdab0201bb9a2c30af64376a9d)

Do not use entrySet() where values() or keySet() suffices

Instead of forcing instatiation of entrySet() and using only
part of the provided data, use values() and keySet() based
on what we really need.

Change-Id: I0a9333b872f9c56e1fa4eddb985309741cf77fe8
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit c935f35b6eb698878eb73ba439a57fb7f40d6539)

Do not use ExecutorService unnecessarily

Executor is the interface we need, not ExecutorService. ExecutorServices
are more complex, and we do not care about shutting them down anyway.

So require only an Executor, letting callers to deal with its lifecycle,
which allows us to use more efficient MoreExecutors.directExecutor()
instead.

Change-Id: Ide57266cc1fac395e545b466bf3b5ad86dee7b2f
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 195ee42d6fe586b331ec949a0f3579a27bb51eed)

Use ImmutableMap instead of Collections.emptyMap()

ImmutableMap behaves nicely when it meets copying and can
be checked for.

Change-Id: I2e0b52b8ea83c69e4ace3364904975b806a67aae
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 474a3348cb0a272c6c6dde7089c68497ad619198)

Speed up InmemoryDOMDataTreeShardWriteTransaction's operations

SimpleOperation's apply() method can be updated to invoke hasNext()
only once for each iteration.

Change-Id: Id94f01428dd1c8b55b883371c9830d6d7209727a
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit ab0f754780a5960525f13a06797eea0e347a4a57)

Switch to using StampedLock

Instead of using ReentrantReadWriteLock, use StampedLock,
which has better performance.

Change-Id: Ifb8c3c90fb05a37264e006acc7d94b4bde5d2893
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 24f1985c8a8f8aa4afaafc2cec7a1908890c993a)

Remove mdsal-binding-util from features because it's only a pom file

Change-Id: I2271c644416d75223858a79796343770e7ee073e
Signed-off-by: Colin Dixon <colin@colindixon.com>
(cherry picked from commit 2483a3622d0e9b395cc4c114ed56a2176b966756)

Improve ShardedDOMDataTreeProducer locking

Making 'closed' a CAS-capable field allows us to check
state and transition to closed state without holding
the object's lock.

This allows associated critical sections to be reduced
to the extent as to make the reuse fast-path completely
lock-free.

Change-Id: I29bacebf5d37a38ea6b4cc641f43dc369cd9edcf
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 6f0f4aeb4562db98368051b3ab7382ea6af8baf8)

Improve ShardedDOMDataTreeProducer locking

The path from backend was taking coarse lock even when not needed.
Explicitly annotate submitTransaction() as needing the lock being
held and push down its acquisition so we take it only after we
are certain we actually need it.

Change-Id: Icd1226796568829ea3735e6eec42677a79b9b3b5
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 2ce13c8680d68ba1e50eab9609069b6aecfa62a5)

Improve ShardedDOMDataTreeWriteTransaction performance

Make internal maps/collection immutable, as it really is
and forgo internal copying of their values in iterators.

Change-Id: Icb0e59d52464498fe87440467fec9095cc8d414e
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit edecff765d21129c17050d77400f15b670c74bdf)

Optimize InMemoryDOMDataTreeShardProducer

All state transitions in this class are based on lock-free
algorithms -- compare-and-swap and retries on conflict.

Eliminate unneeded synchronized keywords, plus inline simple
single-use methods.

Change-Id: I87e22333bb6c3c4db324c5918481fe79d5da2592
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 7d465def070bd22e0ad3836119449b3063074e13)

Fix InMemory shard transaction chaining.

In case we had multiple transactions going after each other quickly
the next transaction might not observe the state of the previous transaction yet.
Fix this by reusing the DataTreeModification of the previous transaction.
Also introduce state transitions into InMemoryDOMDataTreeProducer so it
behaves more like a transaction chain.

Change-Id: I96c746c1b91ac9f6b87152dca612094c73c23387
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit 7d8e59521efbfadd55de34f645db8a8692de6564)

Add batching of non-isolated transaction in ShardedDOMDataTreeProducer

Change-Id: If5ee94a6b2f58c6fd5a243f8784c8b56200b7343
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit 1a1d9e054b9676dfe386241bc62d02c877fcff50)

checkStyleViolationSeverity=error implemented for mdsal-dom-broker
Resolved the merge conflicts.
Implemented code review comments.
Implemented another set of code review comments.

Change-Id: I3eecb17342e4fd7f4736ca67bc57f01f91115c0f
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
(cherry picked from commit f2910f31928b7f29c7e3593065ba35460052c38f)

Use a bounded blocking queue in InmemoryDOMDataTreeShards.

Change-Id: I72b02d9f77985ec80db87792424403b6960616a2
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit f2ed6a6adc28783703c40facfcf4b5171581fbef)

checkStyleViolationSeverity=error implemented for mdsal-dom-inmemory-datastore
Changed the local variable indVal to index.
An unwanted folder was added accidentally, removed.
Code review comments are implemented.

Change-Id: Ie1736dbec9e00a49961a46c32f4433f60c211dc0
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
(cherry picked from commit 099ae98f4694007d7edf76c695a901766521f45f)

Bumping versions by 0.0.1 for next dev cycle

Change-Id: I38fe7c903e5ad5aadcabdebdf0c4fbdde89e7583
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Bug 6540 - HotFix for IsolatedLeader message handler

Change-Id: Icc495dbbbc5583ed68f162ace0e7f2ab12c498c3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Bug 1411-4: MDSAL Binding2 Generator Impl

- BindingGeneratorImpl decomposition proposal
- introduction for Twirl templates for Yang Snippets generation
- rather more templates, less logic, more content
- JUnit test - to be finished
- added several twirl templates for YANG
- review comments fixed
- apply https://git.opendaylight.org/gerrit/#/c/44939/ for spec v2

Change-Id: I79cb7e9c0d41c23408949dd5d4d40d572cc86652
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>
(cherry picked from commit a5e2366bfdf89f9b859b0a7ecfe4bdf4b4cc423e)

Bug 1411-3: MDSAL Binding2 Generator Util

- general util classes & methods
- generated type & builder classes
- Types & BindingTypes
- Annotations, Enumeration
- Method signature support
- Deviation/AnnotationType issue fixed
- Objects.hash() used in hashCode() methods
- review comments fixed

FIXME/TODO:
Binding2GeneratorUtil - implement rest of static methods, colon-dash issue
Binding2Mapping - implement rest of static methods, underscore issue

Change-Id: I9f602a893f6cbd2e9e30c6ca6dc3810e0c678d89
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit b798df97a01fdd0ac78d1d57a24ebadc7b38bed3)

Execute the ShardedDOMDataTreeTransaction.submit() async.

Change-Id: I7e8a59f03a6ed2f3e37d0aa31a2fc12b983644a8
Signed-off-by: Tomas Cere <tcere@cisco.com>

Make ShardCoordinationTasks public

These will be reused in controller so make them public.

Change-Id: I89fb776768d8e975fd744fd1daefc2d0bb3eaa3f
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit 6a8c4d89d24cb6a819949b3782965f2cde1d20fe)

Bug 6413: Fix ipv4 and ipv6 patterns used by IpAddressNoZoneBuilder

due to vague regex definition there was no way to distinguish
if shorter ip address was ipv6 or ipv4 resulting in exception
added tests

Change-Id: Id81e26f018e718675fd58469204c7ad1b647a7b1
Signed-off-by: Filip Gregor <fgregor@cisco.com>
(cherry picked from commit 25b6f8582bce7502cbfe70bbe04860d5d75ff8f8)

BUG-1411: MDSAL Binding2 Spec - comments/feedback fixed

- based on review by Martin Sunal

Change-Id: I7da6e1c35ffed18fe62c7d4092b1eb8557913762
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit a303d7a4a894d7ae9c14e0e8924388de57f08c95)

Bug 1411: MDSAL Binding2 Generator API fix

Since we narrowed down schemaPath in DocumentedNode
to List, this needs to be reflected also in
GeneratedTypeBuilderBase class.

Change-Id: Id9edb2fef730bab24415878c85ccc74c4b8a1e9d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 017c75d8779d33096b9c9a9826d3be17dad462e3)

Bug 6252

Add target/generated-sources/spi & yang/ as resource folders
Follow-up patch for Binding v2

Change-Id: I52822ca5ed5d468f8d62238133a212c9773ddffb
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 0f7a8627428f10e94d3d1ff730baea85f0f46413)

Bug 1411: MDSAL Binding2 Generator API Enumeration fix

- support for missing optional sub-statements of Enum statement added
- minor related Javadoc fixes

Change-Id: I45130065c183c4e0b6094fdb0a9d18fc9709caa7
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 0730aaec52eb3aa6bb59fd0ac78636bd5094955f)

Fix NPE when creating a producer after shard was unregistered

Change-Id: I9f6728f4c885cc18d8adf8dc9d1c14e8c99977ef
Signed-off-by: Tomas Cere <tcere@cisco.com>
(cherry picked from commit f065e5c7ac0ff2bf0227b06c1ebcdf29d30414e0)

BUG-1411 MDSAL Binding2 Generator API Enumeration fix

- missing getMappedName() method in Enumeration API

Change-Id: Ibcd79173745b14464614b494880d20b434070584
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 92f913b4049a93520db9510b8652848791f8ec08)

BUG-1411: MDSAL Binding2 Generator API small fix

- Enumeration import fix
- reflecting Yangtools API change - EnumPair.getValue() returns int now

Change-Id: I7148801e5b184e64294344f158483ca96cc58f56
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit cf079c86e7924776fb170adab48f2f67f993b6c5)

Fix AbstractDOMShardTreeChangePublisher's initial data change event

Strip shard path from listener path, when reading initial data from non
root shard. Also add requirement on DOMStoreTreeChangePublisher
interface to send initial data change event to even when data does not
exist yet.

Change-Id: I90f3aa33764a4812703c37e91378a73270fe19a3
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

BUG-6316: Fix Bit and EnumPair's position/value types

Follow-up patch for Yangtools API change:
https://git.opendaylight.org/gerrit/#/c/42855/

This solves issue with distibution-check jenkins job, where
EnumPair.getValue() returns Integer instead of correct int type.

Change-Id: I459364d17747e0adf10ec021a0bd9cc3e316726d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
(cherry picked from commit 36a598c3b773cf67d0897354c2644fcadcd11f8f)

Update .gitreview for stable/boron

Change-Id: Ice19ba299590e2b414e082ec011dc64e90b67265
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-865: remove String-based getDataChildByName()

This is follow-up patch to reflect Yangtools changes
and needs to be merged after
https://git.opendaylight.org/gerrit/#/c/42898

Note:
based on information from YT devs, relying on string-based
choice node local-name when lookup by QName failed
was useful when dealing with augmented cases.
This is supposed to be fixed now in YT and MDSAL should
rely on lookup by QName only. See patch:
https://git.opendaylight.org/gerrit/#/c/40158/

Change-Id: I1300f3ee01ad678757d564ae76e23ce2c57c76fb
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 6165: Do not omit java.lang prefix in various places

Yang expression "typedef String" leads to java class String,
creating potential naming conflict with java.lang.String.
Few places places in EnumTemplate are fixed by using «String.importedName».

Also, YangModuleInfoTemplate#getExplicitType
no longer removes java.lang unconditionally.

+ Ifs against void are re-ordered to occur sooner in getExplicitType.

Change-Id: If014aca30875589e361733317dfb47eaa07df031
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Add PMD configuration

PMD does not allow specifying wildcards, hence we have to enrich
its configuration here.

Change-Id: I45b7b8618950ec43f3c03cc9e4ee9d3b714d14ee
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make AbstractDOMShardTreeChangePublisher advertise initial data change

Change-Id: Ia9d5a7fcb8bedcb3494b4acc55c372ca5e812424
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

BUG-6316: emit value unconditionally

In the effective model of the world, value is always present.
This is a follow-up fix for the API change introduced in
yangtools.

Change-Id: I3fae5d57fce868e03fd36a7d521f87a83205bcce
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5699 - Migrate existing code to use new sharding apis

This adds adapters that translates DOMDataBroker API calls to cursor aware
API calls

Change-Id: Iab0a94af598f355768f6ef48ac8cb358960418b1
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Bug 6126: Use importedName for java.lang types in ClassTemplate

There may be a type definition in Yang, which generates class name
which are the same as a class name in java.lang.

This patch fixes the conflict at defaultInstance(),
there may be other places which need fixing.

Change-Id: I3a73b5bb284db031dbfd45468cbbb8dd2a354737
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Fix a javadoc warning about empty paragraph

Change-Id: I13eb715e2e24c51bd7df8354cc0b5338aa76763c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6238: Remove char[]-based union instantiation path

Since we are iterating over the constituent types,
there is no need to fall back to string-based instantiation.

Change-Id: Ief17f444816d78d4266e82be3e359a5918213e6d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5947: additional tests for binding-dom-adapter

Change-Id: Iae78d6b0ba6c5e163fac964db0099235801e6cee
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: added some tests for osgi in dom-broker

Change-Id: I3d404e70bd34daa47a86f072420c5d06c7674425
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: refactored common-api tests

Change-Id: I3b138c524094fcd6c63c46493c8af42c5d0c0d5a
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

InMemoryDOMStoreThreePhaseCommitCohort: wrong trace parameter

One parameter for trace is missing.
Looks like copy-n-paste bug

Change-Id: I4ca4cd8c790dfaefa7ad8b7f8e2f4f71ae85242d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 5947: added tests for mdsal-binding-api

Change-Id: Id6f0434eac4982ae91136fe5e2a04d40443df9a0
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: additional test for binding-dom-adapter

Change-Id: I4cd34de1e706eb46f2f1ddef4a89a7cc560d20d3
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Use EnumTypeBuilder

EnumPairImpl is going away, just as all public model.util
implementation classes. Use EnumPairBuilder instead.

Change-Id: Ife86e3ddf432bbd8552d95a282589b1a52645320
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 6184: Workaround for namespaces with URL with trailing slash

Change-Id: I76712209a8d42825d9e8f6d8042877cec486c53f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Bug 2332: BindingMapping to camel split also on forward slash

This is only a partial workaround, full fix for Bug 2332 needs binding v2.

Forward slash is a first character (not allowed in general yang identifiers)
that was encountered in enums from real world Yang models.

Possibly, other separators could get the same treatment,
acting the same way as dash and dot already do.

Change-Id: Ic62198a843747092113c1c7dffaff13d09e7f943
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

implemented missing equals for InstanceIdentifierBuilderImpl with tests

Change-Id: I540a3f44f964de4c3f44281fb51d9a1404313ff7
Signed-off-by: Juraj Veverka <Juraj.Veverka@pantheon.tech>

Use TypedSchemaNode

Now that the getType() method is available through a unified
interface use it to simplify type checks.

Change-Id: I9538c3677daf4ac4e3eac080220403bf2f75adb8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove an unneeded type specifier

Optional.of() can be correctly inferred with Java 8,
remove the type argument.

Change-Id: Ie0826c03c964bb1bdfd7a070fa1bf80cef2ac3f0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded cast

Since we have corrected the getSchema() method, there is no need
to perform a cast.

Change-Id: Ib3c9b2d7dc3a15f2cb9e042055178106f6b33cae
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix incorrect null check

Eliminate an Eclipse-generated warning, which actually shows a bug.

Calls to childNonNull() did not pass an actual instance, but rather
a 'obj != null' expression. That expression got evaluated to
a boolean, which got boxed. Hence childNonNull() could not observe
a null no matter what and we'd get a NPE on next use -- exactly where
Eclipse put a warning.

childNonNull() returns a correctly annotatad @Nonnull reference,
which can be used as a guard against this kind of mistake: if the
original code used that reference, compilation would fail,
as the checked object is a Boolean and does not have a get() method.

This patch eliminates the expression and uses the returned reference,
eliminating the possiblity of a NPE.

Change-Id: I706f077f90ea38d3a48125beeaf4711182c8b8d5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use direct type checks

With the removal of old parser and ExtendedType each type
definition implements proper subtype, hence we do not have
to traverse the type tree up to root.

Change-Id: Ib7a6ffa5f221278547e27e37b19c14a1a3c26d8a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Reuse model.util.EnumPairImpl

Instead of brewing our own, use a well-known implementation.

Change-Id: I22769eb63ca7d7ac7e5f9ac22b201282b0f5283b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-865: make EnumPair getQName/getSchemaPath unimplemented

A yangtools change was made to get rid of these functions using
JDK8's default statement:

https://git.opendaylight.org/gerrit/#/c/41994/

This cleans up the mdsal test implementation.

Change-Id: Ib30d15848402fbe2afe016540d39bea5d4c13112
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

import fix in binding v2

minor import fix of annotation.

Change-Id: I3043a9cbf1601516423de03be0531eff96c56bf8
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Remove mdsal-singleton-dom-api

We are using only DOM implementation so extra DOM API is not needed.

* delete mdsal-singleton-dom-api module
* clean artifacts/pom.xml
* clean features/pom.xml
* clean features.xml
* clean singleton-service/pom.xml
* clean mdsal-singleton-dom-impl/pom.xml

inpact for controller patch:
https://git.opendaylight.org/gerrit/#/c/42093/2
fix is here:
depends on - https://git.opendaylight.org/gerrit/#/c/42311/
blocks - https://git.opendaylight.org/gerrit/#/c/42317/

Change-Id: I8ece69ec65c3ed574160ef8a1c8cd27476f8d1f2
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Add better messages to getTypeWithSchema()

This will aid debugging issues.

Change-Id: Ic1562e092a073ee2066172efbebd2ca9a64fa9b4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix outstanding issuess after moving code base

Move code base from mdsal-singleton-common-spi needs
repackaging and fix some small issues.

* repackaging org.opendaylight.mdsal.singleton.common.spi
  to org.opendaylight.mdsal.singleton.dom.impl
* remove unecessary code

Change-Id: I89f45d17f198dbbc98a21464fb9c4bd3690a3255
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Fix NoSuchMethodError in Eclipse IDE by removing M2E lifecycle mapping

This is no longer required with
https://github.com/vorburger/opendaylight-eclipse-setup

This FIXES Execution check-license of goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: An
API incompatibility was encountered while executing
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check:
java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V

Change-Id: I6cbe65013a50e2178b7fda99701e02cd40880d62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add blueprint XML for the binding EntityOwnershipService

Change-Id: I4349f0f87d9fcc436ddca59e3dc111d16428a6f8
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 5947: Increasing code coverage - binding-generator

Change-Id: I7d89a0bb9950776712b57bf6aad0a3425d531c73
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Move and clean mdsal-singleton-common-spi

We don't need extra project for common-spi implemntation
for yet, because Binding implementation is not relevant
anymor. So common-spi content could be moved to dom-impl
project and mdsal-singleton-common-spi could be removed.

* move mdsal-singleton-common-spi content to mdsal-singleton-dom-impl project
* remove mdsal-singleton-common-spi
* clean feature.xml + feature/pom.xml
* clean artifacts pom.xml
* clean singleton-service/pom.xml
* clean mdsal-singleton-dom-impl/pom.xml

Change-Id: I979ecebe0bbbcd6dba5bec40aef0f287e7fe5fff
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Use lambda for Codec.loader()s

Removes a bit of boiler-plate code.

Change-Id: Id0c7c8d16d374133d9439cd72587382e31252b80
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix checkstyle errors

'if(' -> 'if ('

Change-Id: I4747befcf35724bc1f99346e0ae8ab3ee5b30254
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove ClusterSingletonBinding

We would like to use DOMClusterSingletonServiceProvider only,
so we have to remove Binding CSS instances.

* remove mdsal-singleton-binding-api project
* remove mdsal-singleton-binding-impl project
* clean features.xml + features/pom.xml
* clean artefacts pom.xml
* clean singleton-service/pom.xml

Change-Id: If4cdd968210d950dc66f4835e2ae14c25cfab7cc
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Checkstyle clean-up src/test/java

Required to be able to run (enforce) CS on src/test as well.

Change-Id: Ife78f9baf1fcb462d15ca59675e4116903048c6b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix compiler error due to removal of InMemoryDataTreeFactory.create

Change-Id: I047117f1a0c234eb6d2bc5cb9a553a8c0c2d742b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

BUG-6022: retain order of constituent types

In order to safely iterate over the types, we need
to retain their order from the SchemaNode. Use
a LinkedHashSet to achieve that.

Change-Id: I850f823a0b67dc9bc3e6b75f9a1c671e4bbf73d9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Edited the MD-SAL singleton common API adoc.

Change-Id: I9debe462a3f773fb12547357197f2c84243badbb
Signed-off-by: Jan Medved <jmedved@cisco.com>

Add blueprint XML for mdsal-singleton-dom-impl

Added a blueprint XML file to instantiate and advertise the
DOMClusterSingletonServiceProviderImpl instance.

Change-Id: I768aae041b5a33d37c21505c7debab77e7dd9c1a
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Add union deserialization debugs

We seem to be hitting the slow instantiation path for some
reason. Add more debugging in an effort to hunt them down.

Change-Id: I64c5630a819d46710f7957c3972a2ba305b21ac7
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6022: fix for yangtools api changing

Structure of deviations has changed, adjust to it.

Change-Id: Ic64e489bc6cb6c11435c5b71cf590cb8a4518f66
Signed-off-by: Robert Varga <rovarga@cisco.com>

Export impl package from mdsal-singleton-dom-impl

We need to explictly export the org.opendaylight.mdsal.singleton.dom.impl
package via maven-bundle-plugin as packages with 'impl' are
automatically excluded.

Change-Id: I6cb644eee7dc68725adc97a3ea1665c7ef5d486c
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 5421 - Single cluster-wide service instances implementation

 * add Abstract ClusterSingletonServiceProvider implementation
 * add DOM & biniding ClusterSingletonServiceProvider impl.
 * add junit test suite + import Mockito

Change-Id: If5bac3f61cc3164da1e09c2caf6713c1e3da658a
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Remove project local Xtend dependencyManagement and Maven plugin

Because we now have this available in odl-parent.  Note that the
configuration there is slightly different and uses
target/generated-source instead of src.  Therefore the clean is no
longer needed.  Also add-source does not seem to be required; I've found
that the Xtend Maven plugin and the Xtend IDE M2E support already cover
this correctly by themselves.

Change-Id: Ic878b7c3d63c06595e61c42f0b729bf3d50861cf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-6028: iterate over component types to instantiate union

This reworks union instantiation to be on par with
https://tools.ietf.org/html/rfc6020#section-9.12. We iterate
over individual members and attempt to run deserialization.

If it succeeds instantiate the union using cached constructor
specifying that member. This side-steps the need to go through
serialization.

Change-Id: Ieec37da37a05c2b2a2f432778232e136c903f654
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 5421 - Single cluster-wide service instances grouping

ClusterSingletonService grouping means to run all registred service to same
Group on same ClusterNode. So we could say, service goup will always run on
same ClusterNode.

 * implement grouping functionality for ClusterSingletonService instancies
 * implement double candidate funct. for handling ClusterSingletonService
   service group instances
 * add junit test suite + import Mockito

Change-Id: If91a6f1bf786c42c32201899bc0bb826729f0585
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Add blueprint wiring for ShardedDOMDataTree

Change-Id: I03e5d82332dd8dddf5bf782ec1f965012ba305e1
Signed-off-by: Tomas Cere <tcere@cisco.com>

Expose executor related settings for InMemoryDOMDataTreeShard

Change-Id: I4e3673ccbfc6ce14914994ca52f3a97052b8a48a
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 4202: Require that a producer has claimed a namespace on shard registration

Change-Id: Ia8f75b64e50cad876512e3818a919a6215b296b1
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 6112 - UnionTypeCodec fails to non-identityref value

When Non-identityref value is deserialized, ClassCastException exception occurs.
catch the exception and move to the next codec.

> java.lang.ClassCastException: java.lang.Short cannot be cast to org.opendaylight.yangtools.yang.common.QName
>         at org.opendaylight.yangtools.binding.data.codec.impl.IdentityCodec.deserialize(IdentityCodec.java:17)
>         at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:103)
>         at org.opendaylight.yangtools.binding.data.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:199)
>         at org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:328)
>         at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:148)
>         at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:71)
>         at com.sun.proxy.$Proxy3.getValue(Unknown Source)
>         at org.opendaylight.yangtools.binding.data.codec.test.UnionTypeWithIdentityrefTest.bug6112Test(UnionTypeWithIdentityrefTest.java:78)

Change-Id: If6d9bffbc8cecaca2894f889940c814919da6a4b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Reference BindingNormalizedNodeSerializer in BindingDOMEntityOwnershipServiceAdapter

Changed the BindingDOMEntityOwnershipServiceAdapter to reference the
BindingNormalizedNodeSerializer interface instead of the concrete
mdsal BindingToNormalizedNodeCodec class. This allows us to wire in the
controller's1 BindingToNormalizedNodeCodec instance that is currently in
use (once https://git.opendaylight.org/gerrit/#/c/41811/ and
https://git.opendaylight.org/gerrit/#/c/41815/ are merged).

Change-Id: Ia2767857c111f1ca99efd18f993762f2a48958f3
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 5947: Increasing code coverage - binding-dom-adapter

Change-Id: I9dd1322938bb528378dd224487caac2f6c21404c
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5421 - Single cluster-wide service API

ClusterSingletonServices provides a functionality which alowe to have only
one fully instantiated service instance in a cluster at one time.

* Cluster Singleton API contract definitions
* adoc for ClusterSingletonService implementation

Change-Id: I89180c0a6b6427d6cb1087457aaf2978b8544dda
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Bug 6102: Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: I696d1c394c423814dce500b3d698383c1813c06a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5947: Increasing code coverage - yang util

Change-Id: I7e2cc7590952e3de444e50f172fb4c68a84041dd
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5151 Java binding missing @return

Adds @return functionality to interface accessors.  The idea is to generate a
meaningful return label so that we don't get warnings during compilation for
missing return statements.  A test is added to verify that the return statement
is formatted appropriately.

Change-Id: I01875b788622cab002653a03ea2d844d2c954b77
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Rename Binding Eos DOM Adapter package name

* rename package in mdsal-eos-binding-adapter from
  org.opendaylight.mdsal.binding.dom.adapter.clustering to
  org.opendaylight.mdsal.eos.binding.dom.adapter

Change-Id: Ic944f3cd42110095b72cce4ed1e3f4d072a62174
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Renam Binding Eos API package name

* rename package in mdsal-eos-binding-api from
  org.opendaylight.mdsal.binding.api.clustering to
  org.opendaylight.mdsal.eos.binding.api

Change-Id: I7722187cd62b1d632cd4c07b1ac69d09ff34ad3f
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Rename DOM Eos package name

* rename package in mdsal-eos-dom-api from org.opendaylight.mdsal.dom.api.clustering
  to org.opendaylight.mdsal.eos.dom.api

Change-Id: I59a0fcfbb8b5aac0c28af596bf57e5778487b2f3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Rename EosCommonSpi package name

* rename package from org.opendaylight.mdsal.common.api.clustering
  to org.opendaylight.mdsal.eos.common.spi

Change-Id: Ic5c67f9575265a56a7a04e6787ca0ba33aa37ba3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Rename package in EosCommonApi

* rename package from org.opendaylight.mdsal.common.api.clustering
  to org.opendaylight.mdsal.eos.common.api

Change-Id: Ic97ceb1c81881dc23e29cca4c32b7c69d095b363
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>