Use javax.ws.rs.core.MediaType

sal-rest-docgen depends on JAX-RS, hence we can use its constants for
the (constant) 'produces' field.

JIRA: NETCONF-979
Change-Id: I0ed1793cedcf0653e1d5b5cf4f1f6267ce144a46
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 5.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: Ic016c2aac96bf03d06734f671769273da3abbaed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Change alignments in methods declaration

Apply commonly accepted code style to some sal-rest-docgen classes
to make further development easier.

JIRA: NETCONF-981
Change-Id: Icbd59e052bf1be767bd114425397671f0adf7865
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>

Update testtool documentation

Update URL in testtool documentation to RFC8040.
Fix the auto-connect section to use the correct parameters,
as the 'scale-util' parameters do not work in the way
described in the documentation.

JIRA: NETCONF-947
Change-Id: I6f3a97073936fa35fe667aae6ab52d1101e0a9a3
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Display default values in help section of testtool

Not all of the default values are described
in the 'Default Parameters' documentation section. Updating it
may not be maintainable. Therefore, describing the default values
in the help output could be helpful.

JIRA: NETCONF-947
Change-Id: I4333b6f66e9c9b1067cbe012d1122748c72e5261
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Remove default controller values in testtol

The default values cannot be removed from
netconf-testtool, which means that it is not possible
to turn off the auto-connect functionality.

JIRA: NETCONF-947
Change-Id: Ic8bf0730717e312ca6d7daee3a984f5b6a14419f
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Bump aaa to 0.17.7

This picks up latest updates.

Change-Id: I838f0598dc955f769fc78ba154971aeb740ab407
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix schemas not shown for created devices

Removed few lines from html template script that prevented
schemas from showing on web page.

JIRA: NETCONF-977
Change-Id: If739e6c331a45784bdd9bd00eb50b93a92a1bdb8
Signed-off-by: OleksandrZharov <Oleksandr.Zharov@pantheon.tech>

Add Change-event-notification-subscription-tutorial

Change-event-notification-subscription-tutorial was moved from
Controller dev-guide to Netconf user-guide.
Old bierman-02 paths were fixed according to RFC 8040.
SSE was mentioned as a default mechanism to get notifications.
Provided steps on how to configure to use WebSockets.

JIRA: NETCONF-962
Change-Id: I3ba50494f8f0ea60d4ab1f4ed7de746df87a5ecb
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>

Fix YangLib media types

Fix YangLib media types to return "application/yang" with default
fallback to "text/plain".

JIRA: NETCONF-972
Change-Id: Ibd7a6939342cfbe4b525442d8606e4c27d3e8b65
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Refactor YangLibProviderTest

Refactor mock usage: remove not needed doNothing constructs,
move mock setup to setUp method.

Split test cases for registering empty and non-YANG resources,
unregistering models with and without revision.

JIRA: NETCONF-968
Change-Id: I5195d794f2949c2343908281488d46d27bcf07bd
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Update NETCONF user guide

User guide still contains references to removed bierman-02 paths:
`/restconf/config`, `/restconf/operational` and `restconf/operations`.

Fix them according to RFC 8040.

Make other small changes in order to make documentation up-to-date
with current state: update RFC-7895 link, update requests, default
ports and the netopeer2 usage.

JIRA: NETCONF-946
Change-Id: I94cd1fdf53ff3038a691f43f615d96645df7f023
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump versions to 5.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I67b99862d2dfd04fc8bea573b0ae6ac366a9ede6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix YANG patch request for augmented element

When writing JSON data using yangtool's NormalizedNodeStreamWriter
we have to check if the result is instance of Augmentation.

In that case we have to use its child as data. Similar process
is applied in JsonNormalizedNodeBodyReader.

JIRA: NETCONF-747
Change-Id: I2c1d1abcd3cbb483b414408c2c768bdc5731b8ce
Signed-off-by: OleksandrZharov <Oleksandr.Zharov@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Remove WebSocketSessionHandler.getRemoteEndpointAddress()

This method is not used anywhere, remove it.

Change-Id: I19efb7e687099a3f54b2623156df77d705575676
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce verbosity of websocket timeout logging

A websocket timing out is not a big thing, do not log a complete stack
trace when it occurs.

JIRA: NETCONF-970
Change-Id: I04ec6da1957ba13a27561dfbff9c06a10f011083
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix web-socket timeout closure exceptions

As noted in WebSocketSessionHandler.onWebSocketClosed(), there is no
guarantee the session reports isOpen(). Performing the same check in
AbstractCommonSubscriber.removeSubscriber() (via isConnected()) can
therefore result in an ISE.

Fix this by removing the check.

JIRA: NETCONF-970
Change-Id: I6e437d9821e698e3faca121402a97b88ac486229
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Simplify WebSocketSessionHandler.isConnected()

Use a simple expression instead of a if/else.

Change-Id: Ie1a2e26f1731c799fa6e9e1b027563702809eb7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce idleTimeout/heartbeatInterval consistency

We should not allow a configuration where we time out before we send a
heartbeat. Enforce this invariant.

JIRA: NETCONF-970
Change-Id: Ic26319d7a3da4db9b28fa0aa2e39cdfe439fd786
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix heartbeat/idle timer confusion

The two parameters are interchanged, make sure we pass the right thing
down.

JIRA: NETCONF-970
Change-Id: Ibd2a370f6fa0864026fee450383dd752d0821669
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reuse ObjectMapper instance

It's recommended to reuse ObjectMapper instances but in current codebase
we are recreating it.
ObjectMapper field was made static to prevent multiple object creation.

JIRA: NETCONF-938
Change-Id: If6ed5b5b1959b28d2330e3dc450afb3f20c15c29
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>

Remove misleading identifier check

Check for presence of mount prefix in request for operation
is misleading. Its fully legal to ask for particular operation
on controller or device.

Remove this check which allows us to invoke requests for particular
operation on controller.

For now the request gives us all operations available on
controller/device and that will be fixed as part of NETCONF-928.

JIRA: NETCONF-929
Change-Id: Ia45ec624640b7b75416071f7675088c2bdab3091
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Fix restconf-nb websocket initialization failure on karaf

Websocket servlet is initialized using indirect dependency on
server bundle (string class name in code, dynamic-import in
manifest). This dependency require to be set explicitly. Then
required bundle will be installed with odl-restconf-nb feature
and missing artifacts will be available for restcong-nb
class loader.

JIRA: NETCONF-953
Change-Id: I82e9133af1aeb98518f97a14a3574b82573f92dc
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Bump upstreams

Adopt:
- odparent-12.0.3
- infrautils-5.0.3
- yangtools-10.0.4
- mdsal-11.0.7
- controller-7.0.4
- aaa-0.17.6

Change-Id: I85f470ac0e8c44411de28f4fde7213a68018d354
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup of AbstractCommonSubscriber class

Fix method parameter javadoc and simplify logic operations.

Change-Id: I284b9e9027cc8af75c7968d7a73273681dc4d502
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Remove Resource class

It was not used and not according to OAS v2 nor OAS v3.

JIRA: NETCONF-938
Change-Id: I315ef195749f8fc003df66778efde7747333d764
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Remove ResourceList class

Remove ResourceList class and all its usages. The methods which were
using it were never called making class itself unused.

In addition, the class was not according to OAS v2 nor OAS v3.

JIRA: NETCONF-938
Change-Id: I9fba1a8425d44c0d8f14233669c4cbbcfc56ee33
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Fix feature install inside scale-util

The feature "odl-restconf-nb-rfc8040" has been deprecated
and is no longer available. It has been replaced by
the "odl-restconf-nb" feature.

Change-Id: I5dce4d65fa241ef9453f90b13703612d8e7b5747
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Remove BaseCallHomeTopology

BaseCallHomeTopology has only one child class.
We can remove it and use CallHomeTopology directly.

When at place remove unused CallHomeTopology's constructor.

JIRA: NETCONF-969
Change-Id: Ic80140322161786a228a4735a38ee96e269a27cf
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump versions to 5.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I474a5629b2a1b9f5c3ae98b403a83359dcf28de8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add doc Entry to read Netconf device events.

This documentation suggests the procedure to use http client or browser
to read the Netconf device event notifications.

Change-Id: I6fd795f3fb8337f12620d298f0b036ba483404c9
Signed-off-by: gvrangan <gvrangan@gmail.com>

Update documentation for YangLib feature

Documentation was updated according to current model and default values.

JIRA: NETCONF-909
Change-Id: I514f3677b8ba6b02e6e146e47fdee09e5791a386
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>

Fix odl-yanglib feature usage

The problem is that Initialization stops working correctly and
expect non-empty YanglibConfig provided by blueprint.

Were set default cache-folder to cache/schema, binding-addr to
localhost and binding-port port 8181 by creating new config
file.

JIRA: NETCONF-909
Change-Id: I76455310d014a5ad87051cb0ac749f5ce9f010c1
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up mdsal-netconf-notification

Remove impl.ops package and modernize classes a bit.

Change-Id: I4a5f549c2d05cefac544ce1a426815cbc2bc17d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-notification to OSGi DS

The blueprint here is quite simple, even if a bit confusing. At the end
of the day we have only two components with services and a few plugins.

JIRA: NETCONF-963
Change-Id: I8d715d1db2ac66972c432e2b2808ad02cba7a463
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert sal-rest-docgen to OSGI DS

The generator is a few simple components. Rework their wiring to work
on top of OSGi DS.

JIRA: NETCONF-771
Change-Id: Iee36451c148c5fd414bda3c3ab43c7c8bac0b963
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate blueprint from netconf-topology-impl

The blueprint now is purely service injection, convert
NetconfTopologyImpl into a component instead.

JIRA: NETCONF-960
Change-Id: Id769b2d53cc75b0c5528aa6a0dd23d2b2a83cc85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert NetconfSalKeystoreService into a component

This is a very simple component, activate it as part of
sal-netconf-connector rather than from topology blueprints.

Also remove the initial merge transaction, as it does not (and has not
for a long time) introduce any semantic state.

JIRA: NETCONF-960
Change-Id: Ibc182675bbd31eb970be6b2df0559fe5c852090e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove org.opendaylight.netconf.topology.sb.keypair

This configuration holds the private key location and its pass phrase.
While we inject these values, they are not used anywhere.

JIRA: NETCONF-960
Change-Id: I0a5fd425a59137ac4d0dac5e2f2fd630c4f202bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert JaxRsNorthbound into a Component

We have all we need to ditch blueprint, rehost Config Admin binding and
turn JaxRsNorthbound into a proper Component.

JIRA: NETCONF-959
Change-Id: Id2af0cc4925b34de01198cfcfd98bc63351399d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump aaa to 0.17.5

Pick up wiring changes implemented upstream. This unblocks removal
pretty much all the blueprints we have.

Change-Id: I090d89b6da40ffb774f1048361eea22c5d133da6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn streams.Configuration into a record

This is a pure data holder, convert it to a record. Also rename to
StreamsConfiguration to ensure naming conflicts do not occur.

JIRA: NETCONF-958
Change-Id: I01a203aeab692911799eb24ac4bcadcb029bf1f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove WebInitializer

WebInitializer is a useless indirection, remove it and inline its logic
into JaxRsNorthbound.

JIRA: NETCONF-958
Change-Id: I8a51c128f4e17a36fb719f9c3209e0d7dde933a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor restconf-nb blueprint

Blueprint here is really a large code fragment. Move it to a new class,
RestconfNorthbound, so that we purely inject dependencies/configuration.

JIRA: NETCONF-958
Change-Id: Ic7214393a599c136aa3876c111145182cc68db0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move references to front

References should be up first, as they are declaring dependencies.

Change-Id: Ie03d7889164943fbbf17f235401002a8ce370224
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline webSocketInitializer

This bean is used only once, inline it in its sole caller.

Change-Id: I1f1ecb9c5747608c67a02b610f7f57064b76e2ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline restconfDataStreamServiceImpl

This bean is used only once, inline it in its sole user.

Change-Id: Iba47a40a7f798b5b3acd443e855b701fb543e5b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline restconfApplication

This bean is used only once, inline it in its sole user.

Change-Id: I00f886cee80d4c6e6279fe6de0f97b35067078f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline dataStreamApplication

This bean is used only once, inline it in its sole user.

Change-Id: I1540d48e3479a8bc62d0600e7845ab19772672a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline threadPoolFactory

This bean is used only once, inline it in its sole user.

Change-Id: I366274dc2b040fb666994957ad468fadd988609b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-tcp to OSGi DS

Create a disabled component instead using Declarative Services. This
enables it to be used without touching any code, just the SCR console.

JIRA: NETCONF-957
Change-Id: Id4fc561c3c8671de421b1410c3291390f87fbf56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move unit tests to netconf.ssh package

UTs should be co-located with the classes they are testing, clean that
up.

Change-Id: I59babf5ad47427a2bdb3e9145c2f0284d59a976c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-ssh to OSGi DS

This is a rather simple blueprint, just convert the single component we
have here. Since Declarative Services shutdown dependents before
deactivating the reference, we can also squash the unbind() method.

JIRA: NETCONF-956
Change-Id: If3c5af7bd212583d0f37af085a33468a8d905802
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-connector to OSGi DS

This blueprint is extremely simple wiring, migrate it to Declarative
Services and also cleanup dependencies and code a bit.

JIRA: NETCONF-955
Change-Id: I54da9529206677f9d210d2db1cb7248a0ba0259b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-monitoring to OSGi DS

These are just two simple components, convert them to Declarative
Services.

JIRA: NETCONF-954
Change-Id: I3bf22d265feb8a1db086df396fb5ebaa26bbecdd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-impl to OSGi DS

The blueprint here is just picking up config admin tuneables and wires
things together. This patch converts this wiring to OSGi DS.
Unfortunately the config admin bits are jumbled together, hence we use
factory components to split them up.

JIRA: NETCONF-951
Change-Id: Icdabc7b2e62cb77a6bf5659274955463be993f88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump json-unit-assertj to 2.36.1

Fix CVE-2022-42003 by bumping json-unit-assertj to 2.36.1
which uses fixed jackson-databind version 2.14.0.

Change-Id: I3ab3cb9e03393ea1d223616e0b013f7f10e6a74c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Remove duplicate authorization instantiation

We already have an authorization object, so it seems we should be
reusing it. This also fixes a potential leak as well.

JIRA: NETCONF-949
Change-Id: Id8c94b3f4deca9c62f3b02e1f0c9f3f36d5d23c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline serverChannelInitializer

This bean is used only as an argument, inline it to make things clearer.

JIRA: NETCONF-951
Change-Id: Ie461efe86b7b80d087ad41770e8c75275db4b170
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline netconfServerSessionNegotiatorFactory

This bean is used only as an argument, inline it to make things clearer.

JIRA: NETCONF-951
Change-Id: If0430936c0ad85346ad26ee8903d2f3bfa73b870
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split out NetconfMapperAggregator

Create a component to host the corresponding Blueprint element.
This starts the path to making the contract of
AggregatedNetconfOperationServiceFactory more explicit.

JIRA: NETCONF-951
Change-Id: Ic4f0164ac3423f39ca0d52a6200dcbbfa8f35f7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use NetconfNodeUtils.DEFAULT_TOPOLOGY_IID

We have an open-coded reference to "topology-netconf", squash it and use
the common centralized constant.

Change-Id: Id6399cd4534333b0cce16c0ebdae00c0ede2835b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify builder

We do not need the intermediate products, we can just pass them to a
fluent builder.

Change-Id: Id384d2fd54a454b89de7b43b12b23f1f135a767f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a few more instanceof patterns

We can remove duplicate getter invocations, let's do that and also
eliminate the implied casts.

Change-Id: I582d64423b968b0c9e97b541feff80cfbaca7627
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn SessionIdProvider into a component

SessionIdProvider is a service, make sure it is an interface with a
default provider, instantiated via OSGi DS. This make things a tad more
reasonable, as the provider will survive most reconfiguration.

JIRA: NETCONF-951
Change-Id: I18e95bca90ed886d13b4cc03e3a2f1b5169d7876
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert netconf-config to OSGi DS

Convert blueprint to explicit OSGi DS wiring, retaining the API and
behaviour of the wiring. This requires use of ComponentFactories to
deal with the fact the configuration is in a single configurationPid,
but really ends up being configuration of three inter-dependend classes.

JIRA: NETCONF-950
Change-Id: I19d506a336483bf0ea06a230ef5108a35d8845cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused method createDeviceCommunicator

Remove unused method AbstractNetconfTopology#createDeviceCommunicator.

Change-Id: I0042b1e3ce772dc9853f83080737e0250e50d070
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Add session-id to the operational datastore

Expose non-zero uint32 session-id provided by the device
in the HELLO-MESSAGE via operational datastore.

When device is disconnected null is used to indicate
a non-NETCONF entity session.

Session id can be used to retrieve session-specific info of the device.

JIRA: NETCONF-710
Change-Id: I1995e825cf32462232e164727a469a7b47d3acd0
Signed-off-by: Tibor Král <tibor.kral@pantheon.tech>
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Add fixme to NetconfNodeUtils

NetconfNodeUtils#extractUserCapabilities method is creating
UserPreferences from NetconfSessionPreferences.

Here the purpose is unclear because NetconfSessionPreferences
are (re)created in NetconfDeviceCommunicator#onSessionUp.

Change-Id: I78ae38ffbd327b29dd29753b8b61d1e9c07bf55b
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Clarify NetconfSessionPreferences usage

Remove the only one usage of NetconfSessionPreferences method
fromStrings(collection) from production code and mark it
as visible for testing because now it is used only in tests.

Change-Id: Ib17ddafaed113e3f18588e1870b0d53bf26e1513
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Hide CallHomeMountSessionManager

This is an implementation detail not used anywhere, hide it and document
that it is non-final (as is CallHomeMountDispatcher) for testing
purposes.

Change-Id: Ibe8c662aab5b45a4f696719928c04fe2166f5077
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline constants in CallHomeAuthProviderImpl

We are using constants only during initialization, just pass them
as arguments.

Change-Id: Id1ada2d05c41a46e9f1823b2d9a16db3df6d2689
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert TlsAllowedDevicesMonitorImpl to OSGi DS

This is a simple component, only depending on DataBroker. Use
declarative services to manage its lifecycle. Also eliminate close()
from the public contract of TlsAllowedDevicesMonitor to ensure it is
properly isolated.

JIRA: NETCONF-949
Change-Id: I4cc51ee5ea807f2b4db664b18b2f81888bb20a34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Require allowedDevicesMonitor

We cannot reasonably operate without the monitor, make sure to require
it.

JIRA: NETCONF-949
Change-Id: Ia0f8648fbcca17fbcf8143ee91085ffbb4f0579e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Return immutable set from findAllowedKeys()

We are returning a mutable HashSet, let's use a simple Set.copyOf()
instead. Also update the sole caller to perform this operation only
once, closing a TOCTOE race.

JIRA: NETCONF-949
Change-Id: If49fb938b8ac09e63bdfdef229ef22635c9bb652
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove static state from TlsAllowedDevicesMonitorImpl

Using static maps will end up retaining information even after we have
restarted this class. Make sure the information gets removed by tying
the maps to a particular instance.

JIRA: NETCONF-949
Change-Id: I941d876c8a834b2db9a257ac258685cbca29dbe8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up TlsAllowedDevicesMonitorImpl constants

We have single-use constants, let's just inline them to their use in
constructor.

JIRA: NETCONF-949
Change-Id: I12618fe42c46b0b561e85980f5cdbfce5201fad3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove NetconfConnectorFactory

This interface is not used anywhere except for instantiation. Remove it.

Change-Id: I85ff414d10d8d54790989fea22f0c728c53c2e32
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-tcp-{common,client,server} to 2022-12-12

This is just a run-of-the-mill upgrade.

Change-Id: I0233d8e59cb9d8b467c283ae4c3f10e942266b37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-keystore to 2022-12-12

This is just a run-of-the-mill upgrade.

Change-Id: I26ccadf05e7f864e5bacce989afa92fb1d12e274
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-crypto-types to 2022-12-12

This is just a run-of-the-mill upgrade.

Change-Id: If2c91e90f36c4dc34a0ee2ad1f8b3bb531768594
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-truststore to 2022-12-12

This is just a run-of-the mill upgrade.

Change-Id: I14357b9e2a770a369353eabfeb876cd2e0f17a7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix testtool parameter signature

Add one missing '-' to testtool's "ip" parameter to make it look
the same way like other parameters.

Change-Id: Ib5aa71e4424d52aa9ff6d2ca9064e5751351d51e
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.2
- intrautils-5.0.2
- yangtools-10.0.3
- mdsal-11.0.6
- controller-7.0.3
- aaa-0.17.4

Change-Id: I3e34e381b39c16a3a465fb37c5fc6584765ee4de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not pass outer model context

createDeviceNotificationListener() is not using this argument at all, do
not pass it down.

Change-Id: I177aa0dfa3fffa706f1e9194326ba261eb2f186d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add proper path validation

Rather than incurring CCEs, make sure actually validate data and report
what is wrong.

Change-Id: I70b8172732e08bc44c999bea05ff5c0ce28beff0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Point out a few more ugly casts

We are making quite a few assumptions, mark them for revision.

Change-Id: I29ae17b01f8e29d0ea67a8f8c215ebf47e9a1cbb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize notification extraction

Extract-transform-verify arguments before talking to anyone, making it
obvious the definitions do not actually leak.

Change-Id: I46c079a08d72bb9f9847a7766bc3025a932ae7b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Acquire DOMNotificationService before changing state

We have a potential source of exceptions triggering after we have
mutated state. Fix that.

Change-Id: Id178c124c37cde804b10975590a773fab0df644e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Mark a potential CCE

We have blind cast here, mark it for fixing.

Change-Id: I77812192fb772fd8f9224db75bd5adaf0db97f77
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not acquire DOMSchemaService twice

Properly sanitize input, exactly once. Prevents a 500 when there is no
DOMSchemaService exposed.

Change-Id: I304ba58efe82530186cbb5a28e0b9a79b138ff3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up DeviceNotificationListenerAdaptor

Reorg fields for clarity.

Change-Id: I088f8725f19b63c1ebebfc185598824d2a06b692
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reuse NetconfClientBuilder in NetconfCallHomeServer

To prevent issues with connecting to devices that
use old key exchange algorithms, use the default NetconfSshClient
inside the NetconfCallHomeServer.

JIRA: NETCONF-887
Change-Id: I379c26281dcec6df10dcdbe0ccbfa8c3bea7e8f0
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Bump versions to 5.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I00caf0b3e8c30bf4ed0e20a0ee04da09b87356db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove target schema node

Searching for target schema node is used only to verify that
we have "parsed" a schema node from input.

Its not needed to be processed in XMLPatchBodyReader and if
payload is invalid we get errors from other places.

Change-Id: I777999b61e3c6bd891f255d0bc301a65b1628034
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Fix XML parser condition in XmlPatchBodyReader

Remove redundant if condition which rejects to parse
LeafListSchemaNode or LeafSchemaNode value from XML.

JIRA: NETCONF-937
Change-Id: Ib001582b8476f4508bab7d746296cb7ea1b1619e
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Test Json/Xml PatchBodyReaders on mixin nodes

Created tests for both JSON and XML PatchBodyReaders with
different types of mixin nodes.

JIRA: NETCONF-943
Change-Id: Idd9bc2da6d561463bdd01b9714ea9f61a7a86e88
Signed-off-by: OleksandrZharov <Oleksandr.Zharov@pantheon.tech>

Lock datastore for call-home devices

Netconf callhome does not obey default datastore values as defined
in odl-netconf-device.yang model.

We have to set datastore lock to true manually when creating
configuration node.

This way we can prevent error when we are unable to connect callhome
device because of already closed session.

JIRA: NETCONF-942
Change-Id: I98bc0e01d8d5bd3c2fdd3f4c57546656db61569c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump upstreams

Adopt:
- mdsal-11.0.4
- controller-7.0.2
- aaa-0.17.3

Change-Id: I7c0e0b241f2ff9d4b8160e8c53c54d2f3cef841d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

NetconfMonitoringService should use Registration

We are using raw AutoCloseable here, whereas we should be using simple
registrations. It also flushes out a few places where we fail to clean
up registrations.

Change-Id: I60f956f7e7dd9b394834ae046069d0112d496975
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>