Simplified extension registration (part1)

 - introduced methods for match, action and instruction registration
 - other extension method will be added in part2

Change-Id: I928833e8df6d4a9037fea480ddef4d54d4ac46a6
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Renamed base identity for match oxm_classes

 - renamed from "Clazz" to "OxmClassBase"

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bug 1373 - Fixed NullPointerException on incorrect input

 - now throws IllegalArgumentException. This is just logged and pushed into Future, the Future delegates the information further to upper ODL layers

Change-Id: I64ac1e4904e8837ab5b26572235bdaf5fac984da
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Created special extension keys for more easier (de)serializer (un)registration

 - these keys don't need special types in their constructors, because they always use the same type (e.g. Experimenter.class)
 - also created two marker interfaces (Experimenter(De)SerializerKey) to mark appropriate extension keys

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Deleted openflow-protocol-ext bundle

 - there is another exemplary bundle - more simpler
 - removal needed by upcoming changes

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Updated extension registration keys

 - keys now properly use experimenter ID to distinguish between experimenter messages
 - also updated initialization and registry helper classes

Change-Id: I6177c72397aa7b534cffdf0a9b729fbec2effa50
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bug 1324 - Buffer released correctly (even if translated dataObject is null)

 - updated OFDecoderTest - buffer is now released even on deserialization exception

Change-Id: I1a3a6f17309f795b7db08bf3ed68ea49ab888cf0
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bug 1323 - Treated expensive logging in OFDecoder and OFFrameDecoder

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Default experimenter bundle migrated to ConfigSubsystem

 - updated copyright for ext bundle

Change-Id: I031afe7f1674d4fc44e91be64b5a1cb51bef44ac
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Default experimenters moved to separate bundle + unit tests

(ConfigSubsystem migration will be added later)

Change-Id: Ia6477919fa56347d1e28fd329949b2fb4b852b55
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Changed output directory for generated classes

 - generated classes were not cleaned when located in src -> moved to target
 - also modified .gitignore - removed unnecessary lines

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Extensibility support - added possibility to unregister registered (de)serializers

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Unified extensibility method names

 - removed ambiguity - now both registration methods use the same name pattern
 - registerSerializer() now correctly allows usage of HeaderSerializer

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Merge "Bug 1277 - Move ByteBuffUtils to separate bundle"

Merge "Bug 1277 - Move ByteBuffUtils to separate bundle"

Merge "Bug 1277 - Move ByteBuffUtils to separate bundle"

TLS support - configurable passwords

 - this change allows usage of arbitrary passwords (for keystore, certificate, truststore) instead of hardcoded "opendaylight" password

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Merge "TLS unit test resources moved from src/main/resources to test/main/resources"

Bug 1277 - Move ByteBuffUtils to separate bundle

- ByteBufUtils moved to bundle utils

Signed-off-by: Martin Bobak <mbobak@cisco.com>

Bug 1277 - Move ByteBuffUtils to separate bundle

- constants classes moved form openflow-protocol-impl to openflow-protocol-api

Signed-off-by: Martin Bobak <mbobak@cisco.com>

TLS unit test resources moved from src/main/resources to test/main/resources

 - TLS unit tests access resources via classpath (not relative path)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Updated logging on NotSslRecordException

 - stackTrace was unnecessarily disruptive

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bug 1277 - Move ByteBuffUtils to separate bundle

- bundle project directory created
- added dependency on util bundle to openflow-protocol-impl

Signed-off-by: Martin Bobak <mbobak@cisco.com>

Simple client framing fix

 - fixes problem when 2 or more messages were sent simultaneously

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bug 1248 - Pyang validation fixed

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Extensibility fix - simplified too strict key limitation

 - MessageTypeKey in SwitchConnectionProvider#registerCustomSerializer was restricted to <E extends DataObject>, which does not allow for use of other objects (such as descendants of BaseIdentity)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Merge "Fix Eclipse errors"

TLS initialization fix

 - fixed TlsConfiguration object creation - now null instead of empty object

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

TLS support

TLS is configured in 42-openflowplugin.xml (openflowplugin)
Added tests for:
 - pipeline components
 - TLS classes
 - updated integration test
Added new yang file: openflow-configuration.yang (contains generated classes for library configuration)
Logging updated

Change-Id: I5480b01760377db7de7791594a3b541338a1b43a
Signed-off-by: jameshall03885 <ghall@brocade.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Fix Eclipse errors

Copied in the m2e section from controller.

Change-Id: I19694b87833f44d39433dc05ae4e88932b56fc2e
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Eclipse Build Errors - moved generated source for build-helper

Also removed a version override on maven-bundle-plugin

Change-Id: Ia22f3d3c60cbe1ff9c8f096c52c897eb7fc5fb2b
Signed-off-by: jameshall03885 <ghall@brocade.com>

Removed unnecessary writeAndFlush() from OFEncoder

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Moved interface part of OFJava config into SPI so that OFPlugin won't need dependency on OFJava-IMPL

Change-Id: Ia1c135c1b5d026212e400fe23844c5179d0bb06d
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Use ReadTimeoutHandler for IdleHandler

This converts to using ReadTimeoutHandler, as it has no impact on the
writeout path -- which IdleStateHandler does by attaching listeners to
promises flying by -- which is omething we don't need.

Change-Id: I4e6f4ac862747116aa9f5f4fcaa9fc9d562f7de9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Started using pooled buffers

Change-Id: I1d5d583cdc0e7ff16da01f07929b8f17a63135fa
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Updated Netty to 4.0.19.Final

 - for pooled buffer performance enhancements
 - MERGE AFTER: https://git.opendaylight.org/gerrit/7727

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Checkstyle maven plugin check - openflowjava

    -violations do not fail build
    -rules defined in yangtools/common/checkstyle-logging
https://git.opendaylight.org/gerrit/#/c/7595/
https://git.opendaylight.org/gerrit/#/c/7108/

Change-Id: Ibf4e7c9dd0bbcc8a26e60a0cead7d2865c32e44d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Use 0-shifting operand

Do not use sign-dependent operator. Should not matter, as we follow up
with mask, but this makes the intent obvious.

Change-Id: Ie5c4df5373d19f6abe8b48df5b965ee43bf3e8eb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize ipv4/ipv6 formatting

IPv4/IPv6 formatting relied on multiple objects until the final string
was produced. This fixes the way the algorithm operates to make it more
obvious, but also more performant.

Change-Id: Idcfbde227e999dc78363c87952bca7dfb376c5b7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize time checking in flush()

Pre-calculate deadline and do not do timeunit conversions while checking
if we should yield.

Change-Id: Ie315a9650f6f7cdbd1bbd2ac611df2a3dfda4975
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize macAddressToBytes()

Using raw string parsing has some significant overhead. For parsing a
MAC address, we can employ hand-coded routing which has does not
allocate objects and is much more (~140x) more efficient.

Change-Id: Iad1e6bc1618dd1eedcdfbc9f1e55ac49d03ea4aa
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize mask creation utilities

This introduces a simpified fillBitMask(), which is much simpler to use
and also much faster.

Change-Id: I5519032e3a83a3ace73c1b383784b1e372870782
Signed-off-by: Robert Varga <rovarga@cisco.com>

Adding tunnel ipv4 src/dst openflow augmentations

Augments the low-level openflowjava models and
OF13 implementation to support flow based tunnels
rather then port based tunnels only which is ovsdb
specific thus making a more generic TEP implementation.

I used the v4 parent serializer
AbstractOxmIpv4AddressSerializer since its pretty
class agnostic except for the v4 OpenflowBasic
match but it that is abstracted from the DP and
I don't see any glaring issues uses it. If you
guys would prefer an NXM1Class/NXM0Class specific
ipv4 super just say the word. I have both
implementations local with the same result in the DP.

Output of tests and ovs integration is posted here:
https://gist.github.com/22f0749bba00df1a3cf6

Change-Id: I0f3ebed560bba0137553944fe342704456b4658e
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>

Optimize macAddressToString and padBuffer

Optimizes macAddressToString to prevent multiple object allocations and
do a straightforward coversion -- speedup of ~6x.

padBuffer() is deprecated in favor of writeZero(), and uses it
internally.

Change-Id: I98264fe1744b66363b8b3fcae4d54b4b78814cc8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Flush all entries on channel shutdown

This just makes sure we flush out outstanding queue quickly.

Change-Id: Ib1f7262545f012fe8c418cbe980cc63467a4f654
Signed-off-by: Robert Varga <rovarga@cisco.com>

Pre-cache key makers

These are essentially constants, so there is no need to allocate them
over and over again -- just create a single instance and reuse it. Save
CPU and GC cycles.

Change-Id: I77670f4465d8139c6f218bd6f7dab13b66a5b8fc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not instantiate Joiner/Splitter

This patch centralized Splitter and Joiner instances to ByteBufUtils,
from where they are used -- reducing object allocation and CPU usage
(due to checks).

As a bonus, this optimizes splitters on single characters to the
simplest possible form, further reducing overhead.

Change-Id: If635656af49967cd17333ebbeef3452091edd5d5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not instantiate key in fast path

This is a constant lookup for each packet -- let's just use a static
key to prevent useless allocations.

Change-Id: I4a81fc04e29607ace710c7a35671420271836066
Signed-off-by: Robert Varga <rovarga@cisco.com>

Used Splitter instead of String.split() - performance improvement

- removed ending whitespace characters from .buildBuffer method as those hexStrings should be ended with a hex character

Change-Id: If1e53d7bbcc81293aa7a231b24b1b7a7746cb5c7
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Introduce ChannelOutboundQueue

This patch introduces a tunable queue for outstanding requests. The core
idea is to maintain a limited queue between the message produces and the
IO threads. The producers place their pre-made messages to the queue,
where the IO thread picks them up and pushes them down the pipeline.
Should the queue be empty, the caller is informed of this fact and can
choose a recovery strategy -- current implementation reports
RejectedExecutionException.

The flush task is placed in the IO pool only when the channel is
writable and the queue is non-empty. A single run of the flush task is
time-limited, so a single channel which is being churned by producer
does not end up monopolizing a particular thread for extended periods of
time -- after a tunable time the flush task will re-insert itself on the
task queue and exit.

Change-Id: If6f09c60cf2cf5a69e9f051e2dfe2bae3bb90b5d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Added augmentations for TCP_Flag reads and low level models

Extensions are supered under OFPXMC_NXM_1 code point 0x0001

Once this and the high-level controller patches merge
I will commit the openflowplugin conversion patch since
openflowplugin will fail its build until the yang bindings
are generated.

Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>

Bug 1048 - Removed dependency on model-flow-service

Change-Id: Ie2065b47e02b7cd203227213b66050957f0760a9
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

DelegatingInboundHandler.consumer is mandatory

The consumer is mandatory and constant, make it final and check for
nulls.

Change-Id: I44585c03284669033639ecf5dd9bd61ab48fedf7
Signed-off-by: Robert Varga <rovarga@cisco.com>

PublishingChannelInitializer.allChannels is final

Add final keyword as appropriate.

Change-Id: Idfbadf4f1cc6f296fddcaaf49a2fb18775d63671
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Optimize checkListeners()

This changes the use of StringBuffer to StringBuilder. Also use
Preconditions.checkState().

Change-Id: I378cc84d7b70010cd9559ad6ef3a278ce5f07c90
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Share cache RemovalListener

The removal listener can be easily be shared among instances -- so
create only one shared instance for all ConnectionAdapterImpls.

Change-Id: I3d47d30eb537b86a35f42a69ff590b623a99e035
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Remove ExitingDataObject

This class is unused -- remove it.

Change-Id: Ia1587c0318f7b98638c316a61bc7a41b18a541da
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

ConnectionAdapterImpl fields should be private

This reduces visibility of protected fields to private, allowing us to
reason about their interactions.

Change-Id: Ie3954ad548c4fe20f98bda13cedf657513bd7d11
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

ConnectionAdapterImpl is always bound to a channel

ConnectionAdapterImpl needs to have a channel -- so require it in the
costructor and make it final.

Change-Id: Id170afd055460c24b851cdb3969286c62eee22d0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Improve cache interactions

Do not interact with the XID request cache until the request completes.

Change-Id: I39a8b0bac94474a5a52ef461ed596e70bddfd087
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Initial openflowjava Karaf feature file

PatchSet2: Stop using wrap when unneeded.
PatchSet3: Removed spurious config-all feature

Change-Id: Ibe67d9debb841bf93dd846e1f694019dea3c43b2
Signed-off-by: Ed Warnicke <eaw@cisco.com>

OF10ActionDeserializer and ActionDeserializer split into separate classes

 - updated deserializer initializers

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

InstructionDeserializer split into separate deserializers

 - created List deserialization classes
 - added default experimenter deserializer intialization
 - created default experimenter instruction deserializer
 - MessageDeserializerRegistryHelper renamed to SimpleDeserializerRegistryHelper
  + unified its use for simple (MessageCodeKey) deserializers
 - updated unit tests

Change-Id: I3f428fdd81f39a4cf96a826e208fee067e9c0b6f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

InstructionSerializer split into separate serializers

 - updated initialization of default Action and Instruction experimenter serializers
 - CodingUtils replaced by ListSerializer
 - added EnhancedTypeKeyMaker classes to create lookup keys
 - added InstructionConstants
 - updated unit tests

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: If27b8273aadc84ec93e90fbb08326cf7baeb3645

OF10ActionsSerializer and OF13ActionsSerializer split into separate actions (to allow easier action extensibility)
 - OF13MatchEntriesRegistryHelper renamed to EnhancedKeyRegistryHelper
   + used also in ActionsInitializer
 - added serializeActions into CodingUtils
 - created static ActionConstants class

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I61b11f3acf8d961757e3753a40d26cb77dc02615

Added default experimenter serializers
  - updated unit tests

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I5663f61d83ca40dad8a8c8dee42061175e817ec7

Extensibility refactoring
 - RegistryInjector renamed to SerializerRegistryInjector
 - EnhancedMessageTypeKey moved to api project to be visible outside library implementation
 - SerializerRegistryImpl - unified Exception message
 - MessageTypeKey - updated hashCode()
                  - also updated SerializationFactory key to .getImplementedInterface() instead of .getClass()

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Extensibility support (deserialization part)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ic73091b01614e76087b30ad79dbf9b6f8b39545c

Extensibility support (serialization part)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I51778a009f9a20d6ba1f29b74ca1e3fc1350d8bd

changes for config subsystem - BUG 754

integration - issue with initialization pending
added sal generator
changed SPI - SwitchConnectionProvider has 1:1 bound with ServerFacade
extended yang model of SwitchConnectionProvider configuration
restored exported packages for osgi
restored documentation generator
changed API in order to use ListenableFuture instead of plain Future

Change-Id: Ic21e3a0c1fd64584d98485567c26095674291548
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bumped Netty to 4.0.17.Final (to match controller's version)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

ExperimenterAction length computation added

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Added byte[] into ExperimenterAction

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Merge "Fix for Bug#239"

Merge "Bumped to SNAPSHOT dependencies  - some dependencies moved to <dependencyManagement>  - also bumped netty version to 4.0.15 Final (as there was a lot of fixes since 4.0.10 Final)"

Fix for Bug#239

Keys in models replaced by config false (as library does not use the models as configuration)
 - rebased

Change-Id: I9e6311d912ce0fc89d8d71789366752f3764e86c
Signed-off-by: SahilShah <sahil4.s@tcs.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bumped to SNAPSHOT dependencies
 - some dependencies moved to <dependencyManagement>
 - also bumped netty version to 4.0.15 Final (as there was a lot of fixes since 4.0.10 Final)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ib636921c0dd099b90f451c44d33ab1d00e4455bb

Minor model refactor
 - added "-grouping" to groupings to distinguish structures
 - moved match-grouping into openflow-extensible-match.yang
 - fixed actions structure (list action-list)
 - updated identities bases with "-base"
MERGE AFTER: https://git.opendaylight.org/gerrit/#/c/5109

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ie2bf3d446f8f5912796bd751e512189d6bf06018

Model updated with descriptions

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I32124b20c03f1b103ae7fec48437bd29ccaddeb1

Get rid of duplicate release repository

Change-Id: Ice6994f85130be3edae4d422d3c19d043ac56955
Signed-off-by: Robert Varga <rovarga@cisco.com>

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release openflow-protocol-parent-0.4

Merge "Removed explicitly defined maven-deploy-plugin"

Removed explicitly defined maven-deploy-plugin

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release openflow-protocol-parent-0.3

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release openflow-protocol-parent-0.2

Updated controller versions

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ib532bb5c9485ffcc39beb6ae4eff9becc21365ec

Yangtools version bump

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ia8c9e0deb4bdede4c59c696ba0dd1af8cbef5c96

[maven-release-plugin] prepare for next development iteration

[maven-release-plugin] prepare release openflow-protocol-parent-0.1

Temporary fix for OF10 Stats - table

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I2077e06028cf53d93a13ccc0214d9e02a0ece727

Added copyright in yang files

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Logging updated

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Added scm and maven-release-plugin to pom.xml

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Slf4j version fix (1.7.5 -> 1.7.2)

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Bump yangtools dependency to 0.6.0

Change-Id: I7f6e0b959d221114e839e0b7c3262c78f0e5eac2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Removed legacy code that wasn't being used.

Change-Id: I502025fed4b1434fb8739b31902d75b464e53340
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Merge "Updated pom.xml to build documentation only on jenkins merge-job"