fix some compilation warnings 43/74343/4
authorguillaume.lambert <guillaume.lambert@orange.com>
Mon, 23 Jul 2018 15:15:35 +0000 (17:15 +0200)
committerguillaume.lambert <guillaume.lambert@orange.com>
Mon, 30 Jul 2018 15:56:54 +0000 (17:56 +0200)
Change-Id: I73d5b4906d85cfc2ab6e2457335192e8a8d19ce7
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
24 files changed:
common/src/main/java/org/opendaylight/transportpce/common/ResponseCodes.java
common/src/main/java/org/opendaylight/transportpce/common/Timeouts.java
common/src/main/java/org/opendaylight/transportpce/common/crossconnect/CrossConnect.java
common/src/main/java/org/opendaylight/transportpce/common/openroadminterfaces/OpenRoadmInterfaces.java
inventory/src/main/java/org/opendaylight/transportpce/inventory/query/Queries.java
networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/NetConfTopologyListener.java
networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/Rdm2XpdrLink.java
olm/src/main/java/org/opendaylight/transportpce/olm/util/OlmUtils.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/DeviceRenderingResult.java
renderer/src/main/java/org/opendaylight/transportpce/renderer/provisiondevice/OLMRenderingResult.java
renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/MountPointUtils.java
renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/ServiceDataUtils.java
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/ServiceCreateValidation.java
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/CheckCoherencyHardSoft.java
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheck.java
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheck.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/PathDescriptionConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceAEndConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteInputConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceDeleteOutputConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestInputConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceImplementationRequestOutputConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/mappers/ServiceZEndConverter.java
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/utils/ServiceDataUtils.java

index 435afd3746e6c89819fe2690ba4517e895236d88..1c0965dcd94d8734d8f96e967fb22b53dbfbf654 100644 (file)
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.transportpce.common;
 
-public class ResponseCodes {
+public final class ResponseCodes {
 
     public static final String RESPONSE_FAILED = "500";
     public static final String RESPONSE_OK = "200";
@@ -17,4 +17,7 @@ public class ResponseCodes {
     public static final String SUCCESS_RESULT = "Success";
     public static final String FAILED_RESULT = "Failed";
 
+    private ResponseCodes() {
+    }
+
 }
index c8051c6f1bf6e24a7f17564f7566afef64ea9cd0..b59ab5e04b2d0ae85e38e08df391fab0492c3b8c 100644 (file)
@@ -31,4 +31,7 @@ public final class Timeouts {
     public static final TimeUnit DEVICE_WRITE_TIMEOUT_UNIT = TimeUnit.SECONDS;
 
     //TODO add timeouts for device setup (olm power setup etc.)
+
+    private Timeouts() {
+    }
 }
index 0b708c00670d55d0828597762417a873a1e9a44e..c0c6e8598ea1a989070519f15cfd1012b0c1b7cf 100644 (file)
@@ -73,10 +73,11 @@ public interface CrossConnect {
      *            Source logical connection point.
      * @param destTp
      *            Destination logical connection point.
-     * @throws OpenRoadmInterfaceException
-     *            OpenRoadm Interface Exception.
      *
      * @return list of Ports object type.
+     *
+     * @throws OpenRoadmInterfaceException
+     *            OpenRoadm Interface Exception.
      */
     List<Ports> getConnectionPortTrail(String nodeId, Long waveNumber, String srcTp, String destTp)
             throws OpenRoadmInterfaceException;
index 3cec88f635fc97faf6b75911fbe9598fbec84301..dc3821652d04c22812816a94f5fe802ea3515619 100644 (file)
@@ -44,9 +44,9 @@ public interface OpenRoadmInterfaces {
      * @param interfaceName
      *            Name of the interface
      *
-     * @throws OpenRoadmInterfaceException OpenRoadm Interface Exception
-     *
      * @return Optional of Interface from datastore
+     *
+     * @throws OpenRoadmInterfaceException OpenRoadm Interface Exception
      */
     Optional<Interface> getInterface(String nodeId, String interfaceName) throws OpenRoadmInterfaceException;
 
index d0381cec47ed03e3d9c5c792668bfd18f4694589..8438fda5f4f2927d3dd1d4bba8265ce2143a7240 100644 (file)
@@ -11,7 +11,7 @@ package org.opendaylight.transportpce.inventory.query;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
 
-public class Queries {
+public final class Queries {
 
     private static final String DEVICE_INFO_INSERT =
         "INSERT INTO %sinv_dev_info "
@@ -81,7 +81,7 @@ public class Queries {
         return new Query();
     }
 
-    public static class Query {
+    public final static class Query {
         private String sql;
         private String schema;
 
index 5f1882af87c881a5bdd3b8873659ddc25431e8a1..059479b021c7b1daf4363bd738441409e6a6cd73 100644 (file)
@@ -152,6 +152,7 @@ public class NetConfTopologyListener implements DataTreeChangeListener<Node> {
     }
 
     @Override
+    @SuppressWarnings("checkstyle:FallThrough")
     public void onDataTreeChanged(@Nonnull Collection<DataTreeModification<Node>> changes) {
         LOG.info("onDataTreeChanged");
         for (DataTreeModification<Node> change : changes) {
@@ -183,8 +184,8 @@ public class NetConfTopologyListener implements DataTreeChangeListener<Node> {
                                 netconfNode.getConnectionStatus();
                         try {
                             long count = netconfNode.getAvailableCapabilities().getAvailableCapability().stream()
-                                    .filter(cp -> cp.getCapability().contains(StringConstants.OPENROADM_DEVICE_MODEL_NAME))
-                                    .count();
+                                .filter(cp -> cp.getCapability().contains(StringConstants.OPENROADM_DEVICE_MODEL_NAME))
+                                .count();
                             if (count > 0) {
                                 LOG.info("OpenROADM node detected: {} {}", nodeId, connectionStatus.name());
                                 switch (connectionStatus) {
index 516a531e8e47464d9dd059ff554d7f37b323b606..73b765cf7bdf47c82c0053d56f7901a357959437 100644 (file)
@@ -112,5 +112,9 @@ final class Rdm2XpdrLink {
         nwBuilder.addAugmentation(Network1.class, nwBldr1.build());
         return nwBuilder;
     }
+
+    private Rdm2XpdrLink() {
+    }
+
 }
 
index cce3606541b140d433395e9a836cb5e1490a1768..41caec5b6da769400b2f8fe633bae267522b3a31 100644 (file)
@@ -54,7 +54,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class OlmUtils {
+public final class OlmUtils {
 
     private static final Logger LOG = LoggerFactory.getLogger(OlmUtils.class);
     private static long DATABROKER_READ_TIMEOUT_SECONDS = 120;
@@ -289,4 +289,7 @@ public class OlmUtils {
         return Optional.empty();
     }
 
+    private OlmUtils() {
+    }
+
 }
index 0fa7d4e72f058c812b25e36c01fda9807385f95b..565956243058021bbba7529430b9e797a6808734 100644 (file)
@@ -13,7 +13,7 @@ import org.opendaylight.transportpce.common.OperationResult;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.common.types.rev170907.node.interfaces.NodeInterface;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.common.types.rev170907.olm.renderer.input.Nodes;
 
-public class DeviceRenderingResult extends OperationResult {
+public final class DeviceRenderingResult extends OperationResult {
 
     private final List<Nodes> olmList;
     private final List<NodeInterface> renderedNodeInterfaces;
index ae8ca9ee19acc4f122c2c82fcc798dbb06dafc96..8f94dc804bca6a330f1277c0e83a7687f3307a3c 100644 (file)
@@ -9,7 +9,7 @@ package org.opendaylight.transportpce.renderer.provisiondevice;
 
 import org.opendaylight.transportpce.common.OperationResult;
 
-public class OLMRenderingResult extends OperationResult {
+public final class OLMRenderingResult extends OperationResult {
 
     private OLMRenderingResult(boolean success, String message) {
         super(success, message);
index a5d469dc9a24d1b0b15766a5e7d6223c249b5299..79690dce386dfe3814d1806bfaf49b7652252cbd 100644 (file)
@@ -42,7 +42,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
 
-public class MountPointUtils {
+public final class MountPointUtils {
 
     public static MountPointStub getMountPoint(List<Ports> ports, DataBroker dataBroker) {
         RpcConsumerRegistry rpcConsumerRegistry = Mockito.spy(RpcConsumerRegistry.class);
@@ -114,4 +114,8 @@ public class MountPointUtils {
         }
         return true;
     }
+
+    private MountPointUtils() {
+    }
+
 }
index bec9aa381ce33221085c19f1c05ad9f001b80af8..39ea8650d54d9f1f4c5bc162cb156130a69ae2f5 100644 (file)
@@ -48,7 +48,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.renderer
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.renderer.rev170228.ServicePathInputBuilder;
 
 
-public class ServiceDataUtils {
+public final class ServiceDataUtils {
 
     public static Nodes createNode(String nodeId, String srcTp, String dstTp) {
         return new NodesBuilder().setNodeId(nodeId).setKey(new NodesKey(nodeId)).setSrcTp(srcTp)
@@ -253,4 +253,7 @@ public class ServiceDataUtils {
                     .build());
     }
 
+    private ServiceDataUtils() {
+    }
+
 }
index 5b946bbdea69366cb3daa85813a117f5c3e0eb1f..68f1f2b6593b976e34dd4a72d5eb6104262e15f7 100644 (file)
@@ -21,7 +21,7 @@ import org.opendaylight.yang.gen.v1.http.org.openroadm.service.rev161014.Service
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class ServiceCreateValidation {
+public final class ServiceCreateValidation {
     private static final Logger LOG = LoggerFactory.getLogger(ServiceCreateValidation.class);
 
     public static OperationResult validateServiceCreateRequest(ServiceCreateInput input) {
@@ -89,4 +89,8 @@ public class ServiceCreateValidation {
         }
         return OperationResult.ok("Validation successful.");
     }
+
+    public ServiceCreateValidation() {
+    }
+
 }
index 426f56b3e1d4195bfa651705a4b71876683d9bdc..a9a2d80b25ff496ba3043ba902989a800e3e47cc 100644 (file)
@@ -17,7 +17,7 @@ import org.slf4j.LoggerFactory;
  * Class to check coherency between hard and soft constraints.
  *
  */
-public class CheckCoherencyHardSoft {
+public final class CheckCoherencyHardSoft {
 
     private static final Logger LOG = LoggerFactory.getLogger(CheckCoherencyHardSoft.class);
 
@@ -41,4 +41,7 @@ public class CheckCoherencyHardSoft {
         return result;
     }
 
+    public CheckCoherencyHardSoft() {
+    }
+
 }
index 70c0df79825baf04d663b7e14179c77f688c083b..72995e6ba474c716161461b19b152edc4212af08 100644 (file)
@@ -17,7 +17,7 @@ import org.slf4j.LoggerFactory;
  * Class for checking service sdnc-request-header compliancy.
  *
  */
-public class ServicehandlerCompliancyCheck {
+public final class ServicehandlerCompliancyCheck {
 
     private static final Logger LOG = LoggerFactory.getLogger(ServicehandlerCompliancyCheck.class);
 
@@ -82,4 +82,7 @@ public class ServicehandlerCompliancyCheck {
         return new ComplianceCheckResult(result, message);
     }
 
+    public ServicehandlerCompliancyCheck() {
+    }
+
 }
index 70b488eb2a043b7c7daa014e020e065b09f18b61..367e26dc113255919d830f5a6a5292ff8441effb 100644 (file)
@@ -22,7 +22,7 @@ import org.slf4j.LoggerFactory;
  * Class for checking missing info on Tx/Rx for A/Z end.
  *
  */
-public class ServicehandlerTxRxCheck {
+public final class ServicehandlerTxRxCheck {
 
     private static final Logger LOG = LoggerFactory.getLogger(ServicehandlerTxRxCheck.class);
 
@@ -168,4 +168,7 @@ public class ServicehandlerTxRxCheck {
         return new ComplianceCheckResult(result, message);
     }
 
+    public ServicehandlerTxRxCheck() {
+    }
+
 }
index 92d8f3a258fa9a7843c7bca55db80a49ad405533..c1a949f57c1db64c6e756b2dd4ef91dee2c5447c 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.PathDescription;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.PathDescriptionBuilder;
 
-public class PathDescriptionConverter {
+public final class PathDescriptionConverter {
 
     public static PathDescription getStub(org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface
             .servicepath.rev170426.service.implementation.request.input.PathDescription concrete) {
@@ -31,4 +31,7 @@ public class PathDescriptionConverter {
         concreteBuilder.setZToADirection(stub.getZToADirection());
         return concreteBuilder.build();
     }
+
+    private PathDescriptionConverter() {
+    }
 }
index 79439a7d10b4d3a25a0cc81196e1003655130b5d..471d0974f17123ad1eca97c16b89ff2dd05087a5 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceAEnd;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceAEndBuilder;
 
-public class ServiceAEndConverter {
+public final class ServiceAEndConverter {
 
     public static ServiceAEnd getStub(org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath
             .rev170426.service.implementation.request.input.ServiceAEnd concrete) {
@@ -39,4 +39,7 @@ public class ServiceAEndConverter {
         concreteBuilder.setTxDirection(stub.getTxDirection());
         return concreteBuilder.build();
     }
+
+    private ServiceAEndConverter() {
+    }
 }
index 1f4b59e6b7b9d8a418d503263dfd0c170d6f1260..412afb814d50d69f29a1d1b550b4cbc62ff350f6 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteInput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteInputBuilder;
 
-public class ServiceDeleteInputConverter {
+public final class ServiceDeleteInputConverter {
 
     public static ServiceDeleteInput getStub(org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface
             .servicepath.rev170426.ServiceDeleteInput concrete) {
@@ -31,4 +31,6 @@ public class ServiceDeleteInputConverter {
         return concreteBuilder.build();
     }
 
+    private ServiceDeleteInputConverter() {
+    }
 }
index 9de86cf780bc75d6ce5c6308d07188a100208f33..b6ea691aec69b8b955a893b702cd02d09a1c9096 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteOutput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceDeleteOutputBuilder;
 
-public class ServiceDeleteOutputConverter {
+public final class ServiceDeleteOutputConverter {
 
     public static ServiceDeleteOutput
         getStub(
@@ -34,4 +34,6 @@ public class ServiceDeleteOutputConverter {
         return concreteBuilder.build();
     }
 
+    private ServiceDeleteOutputConverter() {
+    }
 }
index cea7a31c4e05512368b318d127bd5a4a3812c773..985cb64c93c902b45cffaa52194dc33418a475ae 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestInput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestInputBuilder;
 
-public class ServiceImplementationRequestInputConverter {
+public final class ServiceImplementationRequestInputConverter {
 
     public static ServiceImplementationRequestInput getStub(org.opendaylight.yang.gen.v1.http.org.transportpce
                 .b.c._interface.servicepath.rev170426.ServiceImplementationRequestInput concrete) {
@@ -37,4 +37,7 @@ public class ServiceImplementationRequestInputConverter {
         return concreteBuilder.build();
     }
 
+    private ServiceImplementationRequestInputConverter() {
+    }
+
 }
index d44e4848ffb7ebb33ba237cb8c2e90f1c424c890..61aa49650ac75a3c7c0b35e13f49a1959bf94d5d 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestOutput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.ServiceImplementationRequestOutputBuilder;
 
-public class ServiceImplementationRequestOutputConverter {
+public final class ServiceImplementationRequestOutputConverter {
 
     public static ServiceImplementationRequestOutput getStub(org.opendaylight.yang.gen.v1.http.org.transportpce
             .b.c._interface.servicepath.rev170426.ServiceImplementationRequestOutput concrete) {
@@ -29,4 +29,7 @@ public class ServiceImplementationRequestOutputConverter {
         return concreteBuilder.build();
     }
 
+    private ServiceImplementationRequestOutputConverter() {
+    }
+
 }
index ed76c320c367ea968ebd6d6381f7937d097e456f..c830b2dda1c7fab045643fff3c0ba26975b3792d 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.transportpce.servicehandler.mappers;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceZEnd;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.stubrenderer.rev170426.service.implementation.request.input.ServiceZEndBuilder;
 
-public class ServiceZEndConverter {
+public final class ServiceZEndConverter {
     public static ServiceZEnd getStub(
         org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.servicepath.rev170426.service.implementation
         .request.input.ServiceZEnd concrete) {
@@ -40,4 +40,7 @@ public class ServiceZEndConverter {
         concreteBuilder.setTxDirection(stub.getTxDirection());
         return concreteBuilder.build();
     }
+
+    private ServiceZEndConverter(){
+    }
 }
index 8342588c22c50ce25ef9b3e45bc5e9b4eaed1d09..acdb2288502cb9470abac83689e69451e90c9473 100644 (file)
@@ -36,7 +36,7 @@ import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service
 import org.opendaylight.yang.gen.v1.http.org.transportpce.b.c._interface.service.types.rev170426.ServicePathNotificationTypes;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.DateAndTime;
 
-public class ServiceDataUtils {
+public final class ServiceDataUtils {
 
     public static ServiceCreateInput buildServiceCreateInput() {
 
@@ -255,4 +255,7 @@ public class ServiceDataUtils {
                     .build());
     }
 
+    private ServiceDataUtils() {
+    }
+
 }