Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
StringBuffer cleanup
[controller.git]
/
opendaylight
/
commons
/
liblldp
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
liblldp
/
HexEncode.java
diff --git
a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/HexEncode.java
b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/HexEncode.java
index cef174513bde59e7329ca98ffae7b304a985002d..bb181492a78d622793f5d29b97487a3b8681bdc8 100644
(file)
--- a/
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/HexEncode.java
+++ b/
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/HexEncode.java
@@
-30,12
+30,8
@@
public class HexEncode {
return "null";
}
return "null";
}
- String ret = "";
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
for (int i = 0; i < bytes.length; i++) {
for (int i = 0; i < bytes.length; i++) {
- if (i > 0) {
- ret += ":";
- }
short u8byte = (short) (bytes[i] & 0xff);
String tmp = Integer.toHexString(u8byte);
if (tmp.length() == 1) {
short u8byte = (short) (bytes[i] & 0xff);
String tmp = Integer.toHexString(u8byte);
if (tmp.length() == 1) {
@@
-43,13
+39,12
@@
public class HexEncode {
}
buf.append(tmp);
}
}
buf.append(tmp);
}
- ret = buf.toString();
- return ret;
+ return buf.toString();
}
public static String longToHexString(final long val) {
char arr[] = Long.toHexString(val).toCharArray();
}
public static String longToHexString(final long val) {
char arr[] = Long.toHexString(val).toCharArray();
- StringBu
ffer buf = new StringBuff
er();
+ StringBu
ilder buf = new StringBuild
er();
// prepend the right number of leading zeros
int i = 0;
for (; i < (16 - arr.length); i++) {
// prepend the right number of leading zeros
int i = 0;
for (; i < (16 - arr.length); i++) {
@@
-94,8
+89,7
@@
public class HexEncode {
if (bytes == null) {
return "null";
}
if (bytes == null) {
return "null";
}
- String ret = "";
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
for (int i = 0; i < bytes.length; i++) {
if (i > 0) {
buf.append(":");
for (int i = 0; i < bytes.length; i++) {
if (i > 0) {
buf.append(":");
@@
-107,7
+101,6
@@
public class HexEncode {
}
buf.append(tmp);
}
}
buf.append(tmp);
}
- ret = buf.toString();
- return ret;
+ return buf.toString();
}
}
}
}