Remove Namespace.populate()

[controller.git] / third-party / atomix / storage / src / main / java / io / atomix / utils / serializer / Namespace.java

diff --git a/third-party/atomix/storage/src/main/java/io/atomix/utils/serializer/Namespace.java b/third-party/atomix/storage/src/main/java/io/atomix/utils/serializer/Namespace.java
index a37195dadfa778cf959509e13cfbcf509e02d396..dcad23d9f0f211332f58f7a32cb6452e8ae6bb8f 100644 (file)
--- a/third-party/atomix/storage/src/main/java/io/atomix/utils/serializer/Namespace.java
+++ b/third-party/atomix/storage/src/main/java/io/atomix/utils/serializer/Namespace.java
@@ -108,7 +108,7 @@ public final class Namespace implements KryoFactory, KryoPool {
       if (!types.isEmpty()) {
         blocks.add(new RegistrationBlock(this.blockHeadId, types));
       }
-      return new Namespace(blocks, classLoader, friendlyName).populate(1);
+      return new Namespace(blocks, classLoader, friendlyName);
     }
 
     /**
@@ -161,20 +161,9 @@ public final class Namespace implements KryoFactory, KryoPool {
     this.registeredBlocks = ImmutableList.copyOf(registeredTypes);
     this.classLoader = classLoader;
     this.friendlyName = requireNonNull(friendlyName);
-  }
 
-  /**
-   * Populates the Kryo pool.
-   *
-   * @param instances to add to the pool
-   * @return this
-   */
-  public Namespace populate(int instances) {
-
-    for (int i = 0; i < instances; ++i) {
-      release(create());
-    }
-    return this;
+    // Pre-populate with a single instance
+    release(create());
   }
 
   /**
@@ -319,21 +308,6 @@ public final class Namespace implements KryoFactory, KryoPool {
     }
   }
 
-  private String friendlyName() {
-    return friendlyName;
-  }
-
-  /**
-   * Gets the number of classes registered in this Kryo namespace.
-   *
-   * @return size of namespace
-   */
-  public int size() {
-    return (int) registeredBlocks.stream()
-        .flatMap(block -> block.types().stream())
-        .count();
-  }
-
   /**
    * Creates a Kryo instance.
    *
@@ -383,7 +357,7 @@ public final class Namespace implements KryoFactory, KryoPool {
 
       if (!matches) {
         LOGGER.error("{}: Failed to register {} as {}, {} was already registered.",
-            friendlyName(), types, id, existing.getType());
+            friendlyName, types, id, existing.getType());
 
         throw new IllegalStateException(String.format(
             "Failed to register %s as %s, %s was already registered.",
@@ -406,7 +380,7 @@ public final class Namespace implements KryoFactory, KryoPool {
       if (r != null) {
         if (r.getId() != id) {
           LOGGER.debug("{}: {} already registered as {}. Skipping {}.",
-              friendlyName(), r.getType(), r.getId(), id);
+              friendlyName, r.getType(), r.getId(), id);
         }
         LOGGER.trace("{} registered as {}", r.getType(), r.getId());
       }