Code Review
/
controller.git
/ search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
first
⋅
prev
⋅
next
BUG-5280: fix a few warnings
2016-04-12
Robert Varga
BUG-5626: do not allow overriding of RaftActor.handleCommand()
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-11
Robert Varga
BUG-5626: handle ElectionTimeout message first
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-04
Robert Varga
BUG-5626: Move leaderId/leaderPayloadVersion fields
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-04
Robert Varga
Do not depend on the config generator
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-02
Robert Varga
BUG-5626: refactor BehaviorStateHolder
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-02
Robert Varga
BUG-5626: eliminate SwitchBehaviorSupplier
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-02
Robert Varga
Reduce test class visibility
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-02
Robert Varga
Remove unused TestEntityOwnershipShard
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-02
Robert Varga
Do not use Strings for internal messages
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-04-02
Robert Varga
Make MessageTracker.Context implement AutoCloseable
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-31
Robert Varga
BUG-5626: do not use needless cast
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-31
Robert Varga
Invert equals() invocation for expired TX_COMMIT_TIMEOUT_CHE...
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-31
Robert Varga
Do not allow RaftActorBehavior.close() to throw Exception
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-31
Robert Varga
Do not use Stopwatch.toString() in logging
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Use java.util.Optional in ShardLeaderStateChanged and...
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Use java.util.Objects instead of Guava
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Use java.util.function.Supplier instead of Guava
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Split out ShardInformation
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Make ShardManagerInfo a proper view of ShardManager
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Do not expose the shutdown initiator in OnComplete
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Simplify onShutdown checks
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Make RaftActor.initiateLeadershipTransfer() private
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Use inline initialization of Stopwatch
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Simplify isolated leader check
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Do not declare thrown Exception AbstractLeader
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-30
Robert Varga
Use a static YangInstanceIdentifier in AbstractEntityOwnerCh...
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Split out AbstractBuilder and rename it
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Refactor MessageTracker
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Move MessageTracker to sal-clustering-commons
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Move SwitchShardBehaviorMessage to shardmanager package
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Move ShardManagerSnapshot to new package
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Initialized visitedAddresses to a smaller list
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Use range import for odl-akka-*
Signed-off-by:
Robert Varga
<robert.varga@pantheon.sk>
commit
|
commitdiff
|
tree
2016-03-29
Robert Varga
Remove DelegatingRaftActorBehavior
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-27
Robert Varga
Enlarge critical section to cover processNextTransaction()
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-25
Robert Varga
Move ShardManager into its own package
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-22
Robert Varga
Use partial mocking for FollowerTest
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-22
Robert Varga
Make AbstractRaftActorBehavior.state() final
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-22
Robert Varga
Decouple RaftState and RaftActorBehaviors
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-22
Robert Varga
Make SwitchShardBehavior transport RaftState
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-22
Robert Varga
Fixup ShardManagerInfo constants
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-21
Robert Varga
Use instanceof instead of .class.isInstance()
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-21
Robert Varga
Handle snapshot support messages first
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-21
Robert Varga
Remove duplicate 'return true' statements
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-21
Robert Varga
Do not allow overrides of onReceive{Command,Recover}
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-11
Robert Varga
Do not guard simple logging with isXXXEnabled()
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-11
Robert Varga
Remove commented-out logging
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-07
Robert Varga
Clean up DistributedEntityOwnershipService instantiation
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-07
Robert Varga
Do not duplicate candidate list
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-07
Robert Varga
Do not use String.toString()
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-03-07
Robert Varga
BUG-4964: Bump to akka-2.4.1
Signed-off-by:
Robert Varga
<robert.varga@pantheon.sk>
commit
|
commitdiff
|
tree
2016-02-25
Robert Varga
Move JMX generator out of src/main
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-25
Robert Varga
Use {{VERSION}} for config files
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-24
Robert Varga
BUG-4329: remove references to JDT
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-24
Robert Varga
Fix broken downstream features
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-22
Robert Varga
Switch aggregator to odlparent-lite
Signed-off-by:
Robert Varga
<robert.varga@pantheon.sk>
commit
|
commitdiff
|
tree
2016-02-21
Robert Varga
BUG-4329: switch to javaparser
Signed-off-by:
Robert Varga
<robert.varga@pantheon.sk>
commit
|
commitdiff
|
tree
2016-02-21
Robert Varga
Fix missing bundle
Signed-off-by:
Robert Varga
<robert.varga@pantheon.sk>
commit
|
commitdiff
|
tree
2016-02-19
Robert Varga
Remove target-ide override
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-19
Robert Varga
Make sure yang-maven-plugin executes in eclipse
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-18
Robert Varga
Reduce reliance on NormalizedNodeInputStreamReader
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-18
Robert Varga
Hide NormalizedNodeOutputStreamWriter
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-18
Robert Varga
Remove InputStream constructors
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
NormalizedNodeDataOutput should be AutoCloseable
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
Remove implements NormalizedNodeStreamWriter declaration
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
Remove NormalizedNodeStreamReader
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
Follow-up to protobuff deprecation
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
Remove unused variant of newShardProps()
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
Add SendInstallSnapshot javadoc
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-17
Robert Varga
Clean AbstractServerChangeReply up
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Make RequestVoteReply final
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Document RaftRPC
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Turn OperationState into an abstract class
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Turn SendHeartBeat into a singleton
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Turn LeaderTransitioning into a singleton
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Hide IsolatedLeaderCheck message
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Make FollowerInitialSyncUpStatus final
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Turn ElectionTimeout into a proper singleton
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Make NOOP_CALLBACK internal constant
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
BUG-5247: notify listeners for entities which are not...
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Make GetSnapshot final and add a link
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-15
Robert Varga
Fix raw type warnings
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-13
Robert Varga
Make Shutdown message a proper singleton
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-13
Robert Varga
Cleanup and document FindLeaderReply
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-13
Robert Varga
Document FindLeader message
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-13
Robert Varga
Make methods static
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-11
Robert Varga
BUG-5247: Fix Optional.get() on absent return
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-11
Robert Varga
Make private methods static
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-11
Robert Varga
ShardTestKit.waitUntilLeader() is static
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-11
Robert Varga
Fix raw reference
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-11
Robert Varga
NodeWithValue is generic
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-10
Robert Varga
Fix raw type warnings
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-10
Robert Varga
Use a singleton instead of an ArrayList
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-10
Robert Varga
Simplify listener management
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-10
Robert Varga
Fix Eclipse errors with Java 8/Scala
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-02-05
Robert Varga
Public constants need to be final
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-01-31
Robert Varga
BUG-4869: use odl-lmax feature
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-01-28
Robert Varga
BUG-2625: fix failures with Java 8-targetted artifacts
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-01-25
Robert Varga
Remove deprecated ShardDataTree constructor
Signed-off-by:
Robert Varga
<rovarga@cisco.com>
commit
|
commitdiff
|
tree
2016-01-21
Robert Varga
Clear out router event on completion
Signed-off-by:
Robert Varga
<robert.varga@pantheon.sk>
commit
|
commitdiff
|
tree
next