Do not use RpcService in sal-cluster-admin-impl
[controller.git] / opendaylight / md-sal / sal-cluster-admin-impl / src / test / java / org / opendaylight / controller / cluster / datastore / admin / ClusterAdminRpcServiceTest.java
1 /*
2  * Copyright (c) 2015 Brocade Communications Systems, Inc. and others.  All rights reserved.
3  *
4  * This program and the accompanying materials are made available under the
5  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
6  * and is available at http://www.eclipse.org/legal/epl-v10.html
7  */
8 package org.opendaylight.controller.cluster.datastore.admin;
9
10 import static java.lang.Boolean.FALSE;
11 import static java.lang.Boolean.TRUE;
12 import static org.hamcrest.CoreMatchers.anyOf;
13 import static org.hamcrest.CoreMatchers.containsString;
14 import static org.hamcrest.MatcherAssert.assertThat;
15 import static org.junit.Assert.assertEquals;
16 import static org.junit.Assert.assertFalse;
17 import static org.junit.Assert.assertNotNull;
18 import static org.junit.Assert.assertNull;
19 import static org.junit.Assert.assertTrue;
20 import static org.junit.Assert.fail;
21 import static org.opendaylight.controller.cluster.datastore.MemberNode.verifyNoShardPresent;
22 import static org.opendaylight.controller.cluster.datastore.MemberNode.verifyRaftPeersPresent;
23 import static org.opendaylight.controller.cluster.datastore.MemberNode.verifyRaftState;
24
25 import akka.actor.ActorRef;
26 import akka.actor.PoisonPill;
27 import akka.actor.Status.Success;
28 import akka.cluster.Cluster;
29 import com.google.common.collect.ImmutableMap;
30 import com.google.common.collect.Iterables;
31 import com.google.common.collect.Lists;
32 import java.io.File;
33 import java.nio.file.Files;
34 import java.util.AbstractMap.SimpleEntry;
35 import java.util.ArrayList;
36 import java.util.HashMap;
37 import java.util.HashSet;
38 import java.util.List;
39 import java.util.Map;
40 import java.util.Map.Entry;
41 import java.util.Optional;
42 import java.util.Set;
43 import java.util.concurrent.TimeUnit;
44 import org.apache.commons.lang3.SerializationUtils;
45 import org.junit.After;
46 import org.junit.Before;
47 import org.junit.Test;
48 import org.opendaylight.controller.cluster.access.concepts.MemberName;
49 import org.opendaylight.controller.cluster.datastore.AbstractDataStore;
50 import org.opendaylight.controller.cluster.datastore.DatastoreContext;
51 import org.opendaylight.controller.cluster.datastore.MemberNode;
52 import org.opendaylight.controller.cluster.datastore.MemberNode.RaftStateVerifier;
53 import org.opendaylight.controller.cluster.datastore.Shard;
54 import org.opendaylight.controller.cluster.datastore.config.ModuleShardConfiguration;
55 import org.opendaylight.controller.cluster.datastore.identifiers.ShardIdentifier;
56 import org.opendaylight.controller.cluster.datastore.messages.CreateShard;
57 import org.opendaylight.controller.cluster.datastore.persisted.DatastoreSnapshot;
58 import org.opendaylight.controller.cluster.raft.RaftState;
59 import org.opendaylight.controller.cluster.raft.persisted.ServerConfigurationPayload;
60 import org.opendaylight.controller.cluster.raft.persisted.ServerInfo;
61 import org.opendaylight.controller.cluster.raft.persisted.SimpleReplicatedLogEntry;
62 import org.opendaylight.controller.cluster.raft.persisted.UpdateElectionTerm;
63 import org.opendaylight.controller.cluster.raft.utils.InMemoryJournal;
64 import org.opendaylight.controller.cluster.raft.utils.InMemorySnapshotStore;
65 import org.opendaylight.controller.md.cluster.datastore.model.CarsModel;
66 import org.opendaylight.mdsal.dom.spi.store.DOMStoreThreePhaseCommitCohort;
67 import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction;
68 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.AddReplicasForAllShardsInputBuilder;
69 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.AddReplicasForAllShardsOutput;
70 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.AddShardReplicaInputBuilder;
71 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.BackupDatastoreInputBuilder;
72 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ChangeMemberVotingStatesForAllShardsInputBuilder;
73 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.ChangeMemberVotingStatesForShardInputBuilder;
74 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.DataStoreType;
75 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.FlipMemberVotingStatesForAllShardsInputBuilder;
76 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.FlipMemberVotingStatesForAllShardsOutput;
77 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.MakeLeaderLocalInputBuilder;
78 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.RemoveAllShardReplicasInputBuilder;
79 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.RemoveAllShardReplicasOutput;
80 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.RemoveShardReplicaInputBuilder;
81 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.member.voting.states.input.MemberVotingStateBuilder;
82 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.shard.result.output.ShardResult;
83 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.shard.result.output.ShardResultBuilder;
84 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.cluster.admin.rev151013.shard.result.output.ShardResultKey;
85 import org.opendaylight.yangtools.yang.common.RpcError;
86 import org.opendaylight.yangtools.yang.common.RpcResult;
87 import org.opendaylight.yangtools.yang.common.XMLNamespace;
88 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
89
90 /**
91  * Unit tests for ClusterAdminRpcService.
92  *
93  * @author Thomas Pantelis
94  */
95 public class ClusterAdminRpcServiceTest {
96     private static final MemberName MEMBER_1 = MemberName.forName("member-1");
97     private static final MemberName MEMBER_2 = MemberName.forName("member-2");
98     private static final MemberName MEMBER_3 = MemberName.forName("member-3");
99     private final List<MemberNode> memberNodes = new ArrayList<>();
100
101     @Before
102     public void setUp() {
103         InMemoryJournal.clear();
104         InMemorySnapshotStore.clear();
105     }
106
107     @After
108     public void tearDown() {
109         for (MemberNode m : Lists.reverse(memberNodes)) {
110             m.cleanup();
111         }
112         memberNodes.clear();
113     }
114
115     @Test
116     public void testBackupDatastore() throws Exception {
117         MemberNode node = MemberNode.builder(memberNodes).akkaConfig("Member1")
118                 .moduleShardsConfig("module-shards-member1.conf").waitForShardLeader("cars", "people")
119                 .testName("testBackupDatastore").build();
120
121         final var fileName = "target/testBackupDatastore";
122         final var file = new File(fileName);
123         file.delete();
124
125         final var service = new ClusterAdminRpcService(node.configDataStore(), node.operDataStore(), null);
126
127         var rpcResult = service.backupDatastore(new BackupDatastoreInputBuilder().setFilePath(fileName).build())
128             .get(5, TimeUnit.SECONDS);
129         verifySuccessfulRpcResult(rpcResult);
130
131         try (var fis = Files.newInputStream(file.toPath())) {
132             List<DatastoreSnapshot> snapshots = SerializationUtils.deserialize(fis);
133             assertEquals("DatastoreSnapshot size", 2, snapshots.size());
134
135             ImmutableMap<String, DatastoreSnapshot> map = ImmutableMap.of(snapshots.get(0).getType(), snapshots.get(0),
136                     snapshots.get(1).getType(), snapshots.get(1));
137             verifyDatastoreSnapshot(node.configDataStore().getActorUtils().getDataStoreName(),
138                     map.get(node.configDataStore().getActorUtils().getDataStoreName()), "cars", "people");
139         } finally {
140             new File(fileName).delete();
141         }
142
143         // Test failure by killing a shard.
144
145         node.configDataStore().getActorUtils().getShardManager().tell(node.datastoreContextBuilder()
146                 .shardInitializationTimeout(200, TimeUnit.MILLISECONDS).build(), ActorRef.noSender());
147
148         ActorRef carsShardActor = node.configDataStore().getActorUtils().findLocalShard("cars").orElseThrow();
149         node.kit().watch(carsShardActor);
150         carsShardActor.tell(PoisonPill.getInstance(), ActorRef.noSender());
151         node.kit().expectTerminated(carsShardActor);
152
153         rpcResult = service.backupDatastore(new BackupDatastoreInputBuilder().setFilePath(fileName).build())
154                 .get(5, TimeUnit.SECONDS);
155         assertFalse("isSuccessful", rpcResult.isSuccessful());
156         assertEquals("getErrors", 1, rpcResult.getErrors().size());
157     }
158
159     private static void verifyDatastoreSnapshot(final String type, final DatastoreSnapshot datastoreSnapshot,
160             final String... expShardNames) {
161         assertNotNull("Missing DatastoreSnapshot for type " + type, datastoreSnapshot);
162         Set<String> shardNames = new HashSet<>();
163         for (DatastoreSnapshot.ShardSnapshot s: datastoreSnapshot.getShardSnapshots()) {
164             shardNames.add(s.getName());
165         }
166
167         assertEquals("DatastoreSnapshot shard names", Set.of(expShardNames), shardNames);
168     }
169
170     @Test
171     public void testGetPrefixShardRole() throws Exception {
172         String name = "testGetPrefixShardRole";
173         String moduleShardsConfig = "module-shards-default-member-1.conf";
174
175         final MemberNode member1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
176                 .moduleShardsConfig(moduleShardsConfig).build();
177
178         member1.kit().waitUntilLeader(member1.configDataStore().getActorUtils(), "default");
179     }
180
181     @Test
182     public void testModuleShardLeaderMovement() throws Exception {
183         String name = "testModuleShardLeaderMovement";
184         String moduleShardsConfig = "module-shards-member1.conf";
185
186         final MemberNode member1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
187                 .waitForShardLeader("cars").moduleShardsConfig(moduleShardsConfig).build();
188         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
189                 .moduleShardsConfig(moduleShardsConfig).build();
190         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
191                 .moduleShardsConfig(moduleShardsConfig).build();
192
193         member1.waitForMembersUp("member-2", "member-3");
194         replicaNode2.waitForMembersUp("member-1");
195         replicaNode3.waitForMembersUp("member-1", "member-2");
196
197         doAddShardReplica(replicaNode2, "cars", "member-1");
198         doAddShardReplica(replicaNode3, "cars", "member-1", "member-2");
199
200         verifyRaftPeersPresent(member1.configDataStore(), "cars", "member-2", "member-3");
201
202         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1", "member-3");
203
204         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-1", "member-2");
205
206         doMakeShardLeaderLocal(member1, "cars", "member-1");
207         verifyRaftState(replicaNode2.configDataStore(), "cars",
208             raftState -> assertThat(raftState.getLeader(),containsString("member-1")));
209         verifyRaftState(replicaNode3.configDataStore(), "cars",
210             raftState -> assertThat(raftState.getLeader(),containsString("member-1")));
211
212         doMakeShardLeaderLocal(replicaNode2, "cars", "member-2");
213         verifyRaftState(member1.configDataStore(), "cars",
214             raftState -> assertThat(raftState.getLeader(),containsString("member-2")));
215         verifyRaftState(replicaNode3.configDataStore(), "cars",
216             raftState -> assertThat(raftState.getLeader(),containsString("member-2")));
217
218         replicaNode2.waitForMembersUp("member-3");
219         doMakeShardLeaderLocal(replicaNode3, "cars", "member-3");
220     }
221
222     @Test
223     public void testAddShardReplica() throws Exception {
224         String name = "testAddShardReplica";
225         String moduleShardsConfig = "module-shards-cars-member-1.conf";
226         MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
227                 .moduleShardsConfig(moduleShardsConfig).waitForShardLeader("cars").build();
228
229         MemberNode newReplicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
230                 .moduleShardsConfig(moduleShardsConfig).build();
231
232         leaderNode1.waitForMembersUp("member-2");
233
234         doAddShardReplica(newReplicaNode2, "cars", "member-1");
235
236         MemberNode newReplicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
237                 .moduleShardsConfig(moduleShardsConfig).build();
238
239         leaderNode1.waitForMembersUp("member-3");
240         newReplicaNode2.waitForMembersUp("member-3");
241
242         doAddShardReplica(newReplicaNode3, "cars", "member-1", "member-2");
243
244         verifyRaftPeersPresent(newReplicaNode2.configDataStore(), "cars", "member-1", "member-3");
245         verifyRaftPeersPresent(newReplicaNode2.operDataStore(), "cars", "member-1", "member-3");
246
247         // Write data to member-2's config datastore and read/verify via member-3
248         final NormalizedNode configCarsNode = writeCarsNodeAndVerify(newReplicaNode2.configDataStore(),
249                 newReplicaNode3.configDataStore());
250
251         // Write data to member-3's oper datastore and read/verify via member-2
252         writeCarsNodeAndVerify(newReplicaNode3.operDataStore(), newReplicaNode2.operDataStore());
253
254         // Verify all data has been replicated. We expect 4 log entries and thus last applied index of 3 -
255         // 2 ServerConfigurationPayload entries, the transaction payload entry plus a purge payload.
256
257         RaftStateVerifier verifier = raftState -> {
258             assertEquals("Commit index", 3, raftState.getCommitIndex());
259             assertEquals("Last applied index", 3, raftState.getLastApplied());
260         };
261
262         verifyRaftState(leaderNode1.configDataStore(), "cars", verifier);
263         verifyRaftState(leaderNode1.operDataStore(), "cars", verifier);
264
265         verifyRaftState(newReplicaNode2.configDataStore(), "cars", verifier);
266         verifyRaftState(newReplicaNode2.operDataStore(), "cars", verifier);
267
268         verifyRaftState(newReplicaNode3.configDataStore(), "cars", verifier);
269         verifyRaftState(newReplicaNode3.operDataStore(), "cars", verifier);
270
271         // Restart member-3 and verify the cars config shard is re-instated.
272
273         Cluster.get(leaderNode1.kit().getSystem()).down(Cluster.get(newReplicaNode3.kit().getSystem()).selfAddress());
274         newReplicaNode3.cleanup();
275
276         newReplicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
277                 .moduleShardsConfig(moduleShardsConfig).createOperDatastore(false).build();
278
279         verifyRaftState(newReplicaNode3.configDataStore(), "cars", verifier);
280         readCarsNodeAndVerify(newReplicaNode3.configDataStore(), configCarsNode);
281     }
282
283     @Test
284     public void testAddShardReplicaFailures() throws Exception {
285         String name = "testAddShardReplicaFailures";
286         MemberNode memberNode = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
287                 .moduleShardsConfig("module-shards-cars-member-1.conf").build();
288
289         final var service = new ClusterAdminRpcService(memberNode.configDataStore(), memberNode.operDataStore(), null);
290
291         var rpcResult = service.addShardReplica(new AddShardReplicaInputBuilder()
292                 .setDataStoreType(DataStoreType.Config)
293                 .build())
294             .get(10, TimeUnit.SECONDS);
295         verifyFailedRpcResult(rpcResult);
296
297         rpcResult = service.addShardReplica(new AddShardReplicaInputBuilder().setShardName("cars").build())
298             .get(10, TimeUnit.SECONDS);
299         verifyFailedRpcResult(rpcResult);
300
301         rpcResult = service.addShardReplica(new AddShardReplicaInputBuilder().setShardName("people")
302                 .setDataStoreType(DataStoreType.Config)
303                 .build())
304             .get(10, TimeUnit.SECONDS);
305         verifyFailedRpcResult(rpcResult);
306     }
307
308     private static NormalizedNode writeCarsNodeAndVerify(final AbstractDataStore writeToStore,
309             final AbstractDataStore readFromStore) throws Exception {
310         DOMStoreWriteTransaction writeTx = writeToStore.newWriteOnlyTransaction();
311         NormalizedNode carsNode = CarsModel.create();
312         writeTx.write(CarsModel.BASE_PATH, carsNode);
313
314         DOMStoreThreePhaseCommitCohort cohort = writeTx.ready();
315         Boolean canCommit = cohort.canCommit().get(7, TimeUnit.SECONDS);
316         assertEquals("canCommit", TRUE, canCommit);
317         cohort.preCommit().get(5, TimeUnit.SECONDS);
318         cohort.commit().get(5, TimeUnit.SECONDS);
319
320         readCarsNodeAndVerify(readFromStore, carsNode);
321         return carsNode;
322     }
323
324     private static void readCarsNodeAndVerify(final AbstractDataStore readFromStore,
325             final NormalizedNode expCarsNode) throws Exception {
326         Optional<NormalizedNode> optional = readFromStore.newReadOnlyTransaction().read(CarsModel.BASE_PATH)
327                 .get(15, TimeUnit.SECONDS);
328         assertEquals("Data node", Optional.of(expCarsNode), optional);
329     }
330
331     private static void doAddShardReplica(final MemberNode memberNode, final String shardName,
332             final String... peerMemberNames) throws Exception {
333         memberNode.waitForMembersUp(peerMemberNames);
334
335         final var service = new ClusterAdminRpcService(memberNode.configDataStore(), memberNode.operDataStore(), null);
336
337         var rpcResult = service.addShardReplica(new AddShardReplicaInputBuilder()
338             .setShardName(shardName)
339             .setDataStoreType(DataStoreType.Config)
340             .build()).get(10, TimeUnit.SECONDS);
341         verifySuccessfulRpcResult(rpcResult);
342
343         verifyRaftPeersPresent(memberNode.configDataStore(), shardName, peerMemberNames);
344
345         Optional<ActorRef> optional = memberNode.operDataStore().getActorUtils().findLocalShard(shardName);
346         assertFalse("Oper shard present", optional.isPresent());
347
348         rpcResult = service.addShardReplica(new AddShardReplicaInputBuilder()
349             .setShardName(shardName)
350             .setDataStoreType(DataStoreType.Operational)
351             .build()).get(10, TimeUnit.SECONDS);
352         verifySuccessfulRpcResult(rpcResult);
353
354         verifyRaftPeersPresent(memberNode.operDataStore(), shardName, peerMemberNames);
355     }
356
357     private static void doMakeShardLeaderLocal(final MemberNode memberNode, final String shardName,
358             final String newLeader) throws Exception {
359         final var service = new ClusterAdminRpcService(memberNode.configDataStore(), memberNode.operDataStore(), null);
360
361         final var rpcResult = service.makeLeaderLocal(new MakeLeaderLocalInputBuilder()
362             .setDataStoreType(DataStoreType.Config)
363             .setShardName(shardName)
364             .build()).get(10, TimeUnit.SECONDS);
365
366         verifySuccessfulRpcResult(rpcResult);
367
368         verifyRaftState(memberNode.configDataStore(), shardName, raftState -> assertThat(raftState.getLeader(),
369                 containsString(newLeader)));
370     }
371
372     private static <T> T verifySuccessfulRpcResult(final RpcResult<T> rpcResult) {
373         if (!rpcResult.isSuccessful()) {
374             if (rpcResult.getErrors().size() > 0) {
375                 RpcError error = Iterables.getFirst(rpcResult.getErrors(), null);
376                 throw new AssertionError("Rpc failed with error: " + error, error.getCause());
377             }
378
379             fail("Rpc failed with no error");
380         }
381
382         return rpcResult.getResult();
383     }
384
385     private static void verifyFailedRpcResult(final RpcResult<?> rpcResult) {
386         assertFalse("RpcResult", rpcResult.isSuccessful());
387         assertEquals("RpcResult errors size", 1, rpcResult.getErrors().size());
388         RpcError error = Iterables.getFirst(rpcResult.getErrors(), null);
389         assertNotNull("RpcResult error message null", error.getMessage());
390     }
391
392     @Test
393     public void testRemoveShardReplica() throws Exception {
394         String name = "testRemoveShardReplica";
395         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
396         final MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
397                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
398                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
399                 .build();
400
401         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
402                 .moduleShardsConfig(moduleShardsConfig).build();
403
404         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
405                 .moduleShardsConfig(moduleShardsConfig).build();
406
407         leaderNode1.configDataStore().waitTillReady();
408         replicaNode3.configDataStore().waitTillReady();
409         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2", "member-3");
410         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1", "member-3");
411         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-1", "member-2");
412
413         // Invoke RPC service on member-3 to remove it's local shard
414
415         final var service3 = new ClusterAdminRpcService(replicaNode3.configDataStore(), replicaNode3.operDataStore(),
416             null);
417
418         var rpcResult = service3.removeShardReplica(new RemoveShardReplicaInputBuilder()
419             .setShardName("cars").setMemberName("member-3")
420             .setDataStoreType(DataStoreType.Config)
421             .build()).get(10, TimeUnit.SECONDS);
422         verifySuccessfulRpcResult(rpcResult);
423
424         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2");
425         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1");
426         verifyNoShardPresent(replicaNode3.configDataStore(), "cars");
427
428         // Restart member-2 and verify member-3 isn't present.
429
430         Cluster.get(leaderNode1.kit().getSystem()).down(Cluster.get(replicaNode2.kit().getSystem()).selfAddress());
431         replicaNode2.cleanup();
432
433         MemberNode newPeplicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
434                 .moduleShardsConfig(moduleShardsConfig).build();
435
436         newPeplicaNode2.configDataStore().waitTillReady();
437         verifyRaftPeersPresent(newPeplicaNode2.configDataStore(), "cars", "member-1");
438
439         // Invoke RPC service on member-1 to remove member-2
440
441         final var service1 = new ClusterAdminRpcService(leaderNode1.configDataStore(), leaderNode1.operDataStore(),
442             null);
443
444         rpcResult = service1.removeShardReplica(new RemoveShardReplicaInputBuilder()
445             .setShardName("cars")
446             .setMemberName("member-2")
447             .setDataStoreType(DataStoreType.Config)
448             .build()).get(10, TimeUnit.SECONDS);
449         verifySuccessfulRpcResult(rpcResult);
450
451         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars");
452         verifyNoShardPresent(newPeplicaNode2.configDataStore(), "cars");
453     }
454
455     @Test
456     public void testRemoveShardLeaderReplica() throws Exception {
457         String name = "testRemoveShardLeaderReplica";
458         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
459         final MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
460                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
461                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
462                 .build();
463
464         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
465                 .moduleShardsConfig(moduleShardsConfig).build();
466
467         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
468                 .moduleShardsConfig(moduleShardsConfig).build();
469
470         leaderNode1.configDataStore().waitTillReady();
471         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2", "member-3");
472         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1", "member-3");
473         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-1", "member-2");
474
475         replicaNode2.waitForMembersUp("member-1", "member-3");
476         replicaNode3.waitForMembersUp("member-1", "member-2");
477
478         // Invoke RPC service on leader member-1 to remove it's local shard
479
480         final var service1 = new ClusterAdminRpcService(leaderNode1.configDataStore(), leaderNode1.operDataStore(),
481             null);
482
483         final var rpcResult = service1.removeShardReplica(new RemoveShardReplicaInputBuilder()
484             .setShardName("cars")
485             .setMemberName("member-1")
486             .setDataStoreType(DataStoreType.Config)
487             .build()).get(10, TimeUnit.SECONDS);
488         verifySuccessfulRpcResult(rpcResult);
489
490         verifyRaftState(replicaNode2.configDataStore(), "cars", raftState ->
491                 assertThat("Leader Id", raftState.getLeader(), anyOf(containsString("member-2"),
492                         containsString("member-3"))));
493
494         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-3");
495         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-2");
496         verifyNoShardPresent(leaderNode1.configDataStore(), "cars");
497     }
498
499     @Test
500     public void testAddReplicasForAllShards() throws Exception {
501         String name = "testAddReplicasForAllShards";
502         String moduleShardsConfig = "module-shards-member1.conf";
503         MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
504                 .moduleShardsConfig(moduleShardsConfig).waitForShardLeader("cars", "people").build();
505
506         ModuleShardConfiguration petsModuleConfig = new ModuleShardConfiguration(
507             XMLNamespace.of("pets-ns"), "pets-module", "pets", null, List.of(MEMBER_1));
508         leaderNode1.configDataStore().getActorUtils().getShardManager().tell(
509                 new CreateShard(petsModuleConfig, Shard.builder(), null), leaderNode1.kit().getRef());
510         leaderNode1.kit().expectMsgClass(Success.class);
511         leaderNode1.kit().waitUntilLeader(leaderNode1.configDataStore().getActorUtils(), "pets");
512
513         MemberNode newReplicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
514                 .moduleShardsConfig(moduleShardsConfig).build();
515
516         leaderNode1.waitForMembersUp("member-2");
517         newReplicaNode2.waitForMembersUp("member-1");
518
519         newReplicaNode2.configDataStore().getActorUtils().getShardManager().tell(
520                 new CreateShard(petsModuleConfig, Shard.builder(), null), newReplicaNode2.kit().getRef());
521         newReplicaNode2.kit().expectMsgClass(Success.class);
522
523         newReplicaNode2.operDataStore().getActorUtils().getShardManager().tell(
524                 new CreateShard(new ModuleShardConfiguration(XMLNamespace.of("no-leader-ns"), "no-leader-module",
525                                                              "no-leader", null, List.of(MEMBER_1)),
526                                 Shard.builder(), null),
527                                 newReplicaNode2.kit().getRef());
528         newReplicaNode2.kit().expectMsgClass(Success.class);
529
530         final var service = new ClusterAdminRpcService(newReplicaNode2.configDataStore(),
531             newReplicaNode2.operDataStore(), null);
532
533         var rpcResult = service.addReplicasForAllShards(new AddReplicasForAllShardsInputBuilder().build())
534             .get(10, TimeUnit.SECONDS);
535         AddReplicasForAllShardsOutput result = verifySuccessfulRpcResult(rpcResult);
536         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
537                 successShardResult("people", DataStoreType.Config),
538                 successShardResult("pets", DataStoreType.Config),
539                 successShardResult("cars", DataStoreType.Operational),
540                 successShardResult("people", DataStoreType.Operational),
541                 failedShardResult("no-leader", DataStoreType.Operational));
542
543         verifyRaftPeersPresent(newReplicaNode2.configDataStore(), "cars", "member-1");
544         verifyRaftPeersPresent(newReplicaNode2.configDataStore(), "people", "member-1");
545         verifyRaftPeersPresent(newReplicaNode2.configDataStore(), "pets", "member-1");
546         verifyRaftPeersPresent(newReplicaNode2.operDataStore(), "cars", "member-1");
547         verifyRaftPeersPresent(newReplicaNode2.operDataStore(), "people", "member-1");
548     }
549
550     @Test
551     public void testRemoveAllShardReplicas() throws Exception {
552         String name = "testRemoveAllShardReplicas";
553         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
554         final MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
555                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
556                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
557                 .build();
558
559         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
560                 .moduleShardsConfig(moduleShardsConfig).build();
561
562         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
563                 .moduleShardsConfig(moduleShardsConfig).build();
564
565         leaderNode1.configDataStore().waitTillReady();
566         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2", "member-3");
567         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1", "member-3");
568         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-1", "member-2");
569
570         ModuleShardConfiguration petsModuleConfig = new ModuleShardConfiguration(XMLNamespace.of("pets-ns"),
571                 "pets-module", "pets", null, List.of(MEMBER_1, MEMBER_2, MEMBER_3));
572         leaderNode1.configDataStore().getActorUtils().getShardManager().tell(
573                 new CreateShard(petsModuleConfig, Shard.builder(), null), leaderNode1.kit().getRef());
574         leaderNode1.kit().expectMsgClass(Success.class);
575
576         replicaNode2.configDataStore().getActorUtils().getShardManager().tell(
577                 new CreateShard(petsModuleConfig, Shard.builder(), null), replicaNode2.kit().getRef());
578         replicaNode2.kit().expectMsgClass(Success.class);
579
580         replicaNode3.configDataStore().getActorUtils().getShardManager().tell(
581                 new CreateShard(petsModuleConfig, Shard.builder(), null), replicaNode3.kit().getRef());
582         replicaNode3.kit().expectMsgClass(Success.class);
583
584         verifyRaftPeersPresent(leaderNode1.configDataStore(), "pets", "member-2", "member-3");
585         verifyRaftPeersPresent(replicaNode2.configDataStore(), "pets", "member-1", "member-3");
586         verifyRaftPeersPresent(replicaNode3.configDataStore(), "pets", "member-1", "member-2");
587
588         final var service3 = new ClusterAdminRpcService(replicaNode3.configDataStore(), replicaNode3.operDataStore(),
589             null);
590
591         var rpcResult = service3.removeAllShardReplicas(
592                 new RemoveAllShardReplicasInputBuilder().setMemberName("member-3").build())
593             .get(10, TimeUnit.SECONDS);
594         RemoveAllShardReplicasOutput result = verifySuccessfulRpcResult(rpcResult);
595         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
596                 successShardResult("people", DataStoreType.Config),
597                 successShardResult("pets", DataStoreType.Config),
598                 successShardResult("cars", DataStoreType.Operational),
599                 successShardResult("people", DataStoreType.Operational));
600
601         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2");
602         verifyRaftPeersPresent(leaderNode1.configDataStore(), "people", "member-2");
603         verifyRaftPeersPresent(leaderNode1.configDataStore(), "pets", "member-2");
604         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1");
605         verifyRaftPeersPresent(replicaNode2.configDataStore(), "people", "member-1");
606         verifyRaftPeersPresent(replicaNode2.configDataStore(), "pets", "member-1");
607         verifyNoShardPresent(replicaNode3.configDataStore(), "cars");
608         verifyNoShardPresent(replicaNode3.configDataStore(), "people");
609         verifyNoShardPresent(replicaNode3.configDataStore(), "pets");
610     }
611
612     @Test
613     public void testChangeMemberVotingStatesForShard() throws Exception {
614         String name = "testChangeMemberVotingStatusForShard";
615         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
616         final MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
617                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
618                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
619                 .build();
620
621         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
622                 .moduleShardsConfig(moduleShardsConfig).build();
623
624         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
625                 .moduleShardsConfig(moduleShardsConfig).build();
626
627         leaderNode1.configDataStore().waitTillReady();
628         replicaNode3.configDataStore().waitTillReady();
629         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2", "member-3");
630         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1", "member-3");
631         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-1", "member-2");
632
633         // Invoke RPC service on member-3 to change voting status
634
635         final var service3 = new ClusterAdminRpcService(replicaNode3.configDataStore(), replicaNode3.operDataStore(),
636             null);
637
638         var rpcResult = service3.changeMemberVotingStatesForShard(new ChangeMemberVotingStatesForShardInputBuilder()
639             .setShardName("cars").setDataStoreType(DataStoreType.Config)
640             .setMemberVotingState(List.of(
641                 new MemberVotingStateBuilder().setMemberName("member-2").setVoting(FALSE).build(),
642                 new MemberVotingStateBuilder().setMemberName("member-3").setVoting(FALSE).build()))
643             .build())
644             .get(10, TimeUnit.SECONDS);
645         verifySuccessfulRpcResult(rpcResult);
646
647         verifyVotingStates(leaderNode1.configDataStore(), "cars", new SimpleEntry<>("member-1", TRUE),
648                 new SimpleEntry<>("member-2", FALSE), new SimpleEntry<>("member-3", FALSE));
649         verifyVotingStates(replicaNode2.configDataStore(), "cars", new SimpleEntry<>("member-1", TRUE),
650                 new SimpleEntry<>("member-2", FALSE), new SimpleEntry<>("member-3", FALSE));
651         verifyVotingStates(replicaNode3.configDataStore(), "cars", new SimpleEntry<>("member-1", TRUE),
652                 new SimpleEntry<>("member-2", FALSE), new SimpleEntry<>("member-3", FALSE));
653     }
654
655     @Test
656     public void testChangeMemberVotingStatesForSingleNodeShard() throws Exception {
657         String name = "testChangeMemberVotingStatesForSingleNodeShard";
658         String moduleShardsConfig = "module-shards-member1.conf";
659         MemberNode leaderNode = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
660                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
661                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
662                 .build();
663
664         leaderNode.configDataStore().waitTillReady();
665
666         // Invoke RPC service on member-3 to change voting status
667
668         final var service = new ClusterAdminRpcService(leaderNode.configDataStore(), leaderNode.operDataStore(), null);
669
670         final var rpcResult = service.changeMemberVotingStatesForShard(
671             new ChangeMemberVotingStatesForShardInputBuilder()
672                 .setShardName("cars").setDataStoreType(DataStoreType.Config)
673                 .setMemberVotingState(List.of(new MemberVotingStateBuilder()
674                     .setMemberName("member-1")
675                     .setVoting(FALSE)
676                     .build()))
677                 .build())
678             .get(10, TimeUnit.SECONDS);
679         verifyFailedRpcResult(rpcResult);
680
681         verifyVotingStates(leaderNode.configDataStore(), "cars", new SimpleEntry<>("member-1", TRUE));
682     }
683
684     @Test
685     public void testChangeMemberVotingStatesForAllShards() throws Exception {
686         String name = "testChangeMemberVotingStatesForAllShards";
687         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
688         final MemberNode leaderNode1 = MemberNode.builder(memberNodes)
689             .akkaConfig("Member1")
690             .testName(name)
691             .moduleShardsConfig(moduleShardsConfig)
692             .datastoreContextBuilder(DatastoreContext.newBuilder()
693                 .shardHeartbeatIntervalInMillis(300)
694                 .shardElectionTimeoutFactor(1))
695             .build();
696
697         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
698                 .moduleShardsConfig(moduleShardsConfig).build();
699
700         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
701                 .moduleShardsConfig(moduleShardsConfig).build();
702
703         leaderNode1.configDataStore().waitTillReady();
704         leaderNode1.operDataStore().waitTillReady();
705         replicaNode3.configDataStore().waitTillReady();
706         replicaNode3.operDataStore().waitTillReady();
707         verifyRaftPeersPresent(leaderNode1.configDataStore(), "cars", "member-2", "member-3");
708         verifyRaftPeersPresent(replicaNode2.configDataStore(), "cars", "member-1", "member-3");
709         verifyRaftPeersPresent(replicaNode3.configDataStore(), "cars", "member-1", "member-2");
710
711         // Invoke RPC service on member-3 to change voting status
712
713         final var service3 = new ClusterAdminRpcService(replicaNode3.configDataStore(),
714                 replicaNode3.operDataStore(), null);
715
716         final var rpcResult = service3.changeMemberVotingStatesForAllShards(
717             new ChangeMemberVotingStatesForAllShardsInputBuilder()
718                 .setMemberVotingState(List.of(
719                         new MemberVotingStateBuilder().setMemberName("member-2").setVoting(FALSE).build(),
720                         new MemberVotingStateBuilder().setMemberName("member-3").setVoting(FALSE).build()))
721                 .build())
722                 .get(10, TimeUnit.SECONDS);
723         final var result = verifySuccessfulRpcResult(rpcResult);
724         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
725                 successShardResult("people", DataStoreType.Config),
726                 successShardResult("cars", DataStoreType.Operational),
727                 successShardResult("people", DataStoreType.Operational));
728
729         verifyVotingStates(new AbstractDataStore[]{leaderNode1.configDataStore(), leaderNode1.operDataStore(),
730                 replicaNode2.configDataStore(), replicaNode2.operDataStore(),
731                 replicaNode3.configDataStore(), replicaNode3.operDataStore()},
732                 new String[]{"cars", "people"}, new SimpleEntry<>("member-1", TRUE),
733                 new SimpleEntry<>("member-2", FALSE), new SimpleEntry<>("member-3", FALSE));
734     }
735
736     @Test
737     public void testFlipMemberVotingStates() throws Exception {
738         String name = "testFlipMemberVotingStates";
739
740         ServerConfigurationPayload persistedServerConfig = new ServerConfigurationPayload(List.of(
741                 new ServerInfo("member-1", true), new ServerInfo("member-2", true),
742                 new ServerInfo("member-3", false)));
743
744         setupPersistedServerConfigPayload(persistedServerConfig, "member-1", name, "cars", "people");
745         setupPersistedServerConfigPayload(persistedServerConfig, "member-2", name, "cars", "people");
746         setupPersistedServerConfigPayload(persistedServerConfig, "member-3", name, "cars", "people");
747
748         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
749         final MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
750                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(DatastoreContext.newBuilder()
751                         .shardHeartbeatIntervalInMillis(100).shardElectionTimeoutFactor(10))
752                 .build();
753
754         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
755                 .moduleShardsConfig(moduleShardsConfig).build();
756
757         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
758                 .moduleShardsConfig(moduleShardsConfig).build();
759
760         leaderNode1.configDataStore().waitTillReady();
761         leaderNode1.operDataStore().waitTillReady();
762         replicaNode3.configDataStore().waitTillReady();
763         replicaNode3.operDataStore().waitTillReady();
764         verifyVotingStates(leaderNode1.configDataStore(), "cars", new SimpleEntry<>("member-1", TRUE),
765                 new SimpleEntry<>("member-2", TRUE), new SimpleEntry<>("member-3", FALSE));
766
767         final var service3 = new ClusterAdminRpcService(replicaNode3.configDataStore(), replicaNode3.operDataStore(),
768             null);
769
770         var rpcResult = service3.flipMemberVotingStatesForAllShards(
771             new FlipMemberVotingStatesForAllShardsInputBuilder().build())
772             .get(10, TimeUnit.SECONDS);
773         FlipMemberVotingStatesForAllShardsOutput result = verifySuccessfulRpcResult(rpcResult);
774         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
775                 successShardResult("people", DataStoreType.Config),
776                 successShardResult("cars", DataStoreType.Operational),
777                 successShardResult("people", DataStoreType.Operational));
778
779         verifyVotingStates(new AbstractDataStore[]{leaderNode1.configDataStore(), leaderNode1.operDataStore(),
780                 replicaNode2.configDataStore(), replicaNode2.operDataStore(),
781                 replicaNode3.configDataStore(), replicaNode3.operDataStore()},
782                 new String[]{"cars", "people"},
783                 new SimpleEntry<>("member-1", FALSE), new SimpleEntry<>("member-2", FALSE),
784                 new SimpleEntry<>("member-3", TRUE));
785
786         // Leadership should have transferred to member 3 since it is the only remaining voting member.
787         verifyRaftState(leaderNode1.configDataStore(), "cars", raftState -> {
788             assertNotNull("Expected non-null leader Id", raftState.getLeader());
789             assertTrue("Expected leader member-3. Actual: " + raftState.getLeader(),
790                     raftState.getLeader().contains("member-3"));
791         });
792
793         verifyRaftState(leaderNode1.operDataStore(), "cars", raftState -> {
794             assertNotNull("Expected non-null leader Id", raftState.getLeader());
795             assertTrue("Expected leader member-3. Actual: " + raftState.getLeader(),
796                     raftState.getLeader().contains("member-3"));
797         });
798
799         // Flip the voting states back to the original states.
800
801         rpcResult = service3.flipMemberVotingStatesForAllShards(
802             new FlipMemberVotingStatesForAllShardsInputBuilder().build())
803             .get(10, TimeUnit.SECONDS);
804         result = verifySuccessfulRpcResult(rpcResult);
805         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
806                 successShardResult("people", DataStoreType.Config),
807                 successShardResult("cars", DataStoreType.Operational),
808                 successShardResult("people", DataStoreType.Operational));
809
810         verifyVotingStates(new AbstractDataStore[]{leaderNode1.configDataStore(), leaderNode1.operDataStore(),
811                 replicaNode2.configDataStore(), replicaNode2.operDataStore(),
812                 replicaNode3.configDataStore(), replicaNode3.operDataStore()},
813                 new String[]{"cars", "people"},
814                 new SimpleEntry<>("member-1", TRUE), new SimpleEntry<>("member-2", TRUE),
815                 new SimpleEntry<>("member-3", FALSE));
816
817         // Leadership should have transferred to member 1 or 2.
818         verifyRaftState(leaderNode1.configDataStore(), "cars", raftState -> {
819             assertNotNull("Expected non-null leader Id", raftState.getLeader());
820             assertTrue("Expected leader member-1 or member-2. Actual: " + raftState.getLeader(),
821                     raftState.getLeader().contains("member-1") || raftState.getLeader().contains("member-2"));
822         });
823     }
824
825     @Test
826     public void testFlipMemberVotingStatesWithNoInitialLeader() throws Exception {
827         String name = "testFlipMemberVotingStatesWithNoInitialLeader";
828
829         // Members 1, 2, and 3 are initially started up as non-voting. Members 4, 5, and 6 are initially
830         // non-voting and simulated as down by not starting them up.
831         ServerConfigurationPayload persistedServerConfig = new ServerConfigurationPayload(List.of(
832                 new ServerInfo("member-1", false), new ServerInfo("member-2", false),
833                 new ServerInfo("member-3", false), new ServerInfo("member-4", true),
834                 new ServerInfo("member-5", true), new ServerInfo("member-6", true)));
835
836         setupPersistedServerConfigPayload(persistedServerConfig, "member-1", name, "cars", "people");
837         setupPersistedServerConfigPayload(persistedServerConfig, "member-2", name, "cars", "people");
838         setupPersistedServerConfigPayload(persistedServerConfig, "member-3", name, "cars", "people");
839
840         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
841         final MemberNode replicaNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
842                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
843                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
844                 .build();
845
846         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
847                 .moduleShardsConfig(moduleShardsConfig).build();
848
849         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
850                 .moduleShardsConfig(moduleShardsConfig).build();
851
852         // Initially there won't be a leader b/c all the up nodes are non-voting.
853
854         replicaNode1.waitForMembersUp("member-2", "member-3");
855
856         verifyVotingStates(replicaNode1.configDataStore(), "cars", new SimpleEntry<>("member-1", FALSE),
857                 new SimpleEntry<>("member-2", FALSE), new SimpleEntry<>("member-3", FALSE),
858                 new SimpleEntry<>("member-4", TRUE), new SimpleEntry<>("member-5", TRUE),
859                 new SimpleEntry<>("member-6", TRUE));
860
861         verifyRaftState(replicaNode1.configDataStore(), "cars", raftState ->
862             assertEquals("Expected raft state", RaftState.Follower.toString(), raftState.getRaftState()));
863
864         final var service1 = new ClusterAdminRpcService(replicaNode1.configDataStore(), replicaNode1.operDataStore(),
865             null);
866
867         var rpcResult = service1.flipMemberVotingStatesForAllShards(
868             new FlipMemberVotingStatesForAllShardsInputBuilder().build())
869             .get(10, TimeUnit.SECONDS);
870         FlipMemberVotingStatesForAllShardsOutput result = verifySuccessfulRpcResult(rpcResult);
871         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
872                 successShardResult("people", DataStoreType.Config),
873                 successShardResult("cars", DataStoreType.Operational),
874                 successShardResult("people", DataStoreType.Operational));
875
876         verifyVotingStates(new AbstractDataStore[]{replicaNode1.configDataStore(), replicaNode1.operDataStore(),
877                 replicaNode2.configDataStore(), replicaNode2.operDataStore(),
878                 replicaNode3.configDataStore(), replicaNode3.operDataStore()},
879                 new String[]{"cars", "people"},
880                 new SimpleEntry<>("member-1", TRUE), new SimpleEntry<>("member-2", TRUE),
881                 new SimpleEntry<>("member-3", TRUE), new SimpleEntry<>("member-4", FALSE),
882                 new SimpleEntry<>("member-5", FALSE), new SimpleEntry<>("member-6", FALSE));
883
884         // Since member 1 was changed to voting and there was no leader, it should've started and election
885         // and become leader
886         verifyRaftState(replicaNode1.configDataStore(), "cars", raftState -> {
887             assertNotNull("Expected non-null leader Id", raftState.getLeader());
888             assertTrue("Expected leader member-1. Actual: " + raftState.getLeader(),
889                     raftState.getLeader().contains("member-1"));
890         });
891
892         verifyRaftState(replicaNode1.operDataStore(), "cars", raftState -> {
893             assertNotNull("Expected non-null leader Id", raftState.getLeader());
894             assertTrue("Expected leader member-1. Actual: " + raftState.getLeader(),
895                     raftState.getLeader().contains("member-1"));
896         });
897     }
898
899     @Test
900     public void testFlipMemberVotingStatesWithVotingMembersDown() throws Exception {
901         String name = "testFlipMemberVotingStatesWithVotingMembersDown";
902
903         // Members 4, 5, and 6 are initially non-voting and simulated as down by not starting them up.
904         ServerConfigurationPayload persistedServerConfig = new ServerConfigurationPayload(List.of(
905                 new ServerInfo("member-1", true), new ServerInfo("member-2", true),
906                 new ServerInfo("member-3", true), new ServerInfo("member-4", false),
907                 new ServerInfo("member-5", false), new ServerInfo("member-6", false)));
908
909         setupPersistedServerConfigPayload(persistedServerConfig, "member-1", name, "cars", "people");
910         setupPersistedServerConfigPayload(persistedServerConfig, "member-2", name, "cars", "people");
911         setupPersistedServerConfigPayload(persistedServerConfig, "member-3", name, "cars", "people");
912
913         String moduleShardsConfig = "module-shards-member1-and-2-and-3.conf";
914         final MemberNode leaderNode1 = MemberNode.builder(memberNodes).akkaConfig("Member1").testName(name)
915                 .moduleShardsConfig(moduleShardsConfig).datastoreContextBuilder(
916                         DatastoreContext.newBuilder().shardHeartbeatIntervalInMillis(300).shardElectionTimeoutFactor(1))
917                 .build();
918
919         final MemberNode replicaNode2 = MemberNode.builder(memberNodes).akkaConfig("Member2").testName(name)
920                 .moduleShardsConfig(moduleShardsConfig).build();
921
922         final MemberNode replicaNode3 = MemberNode.builder(memberNodes).akkaConfig("Member3").testName(name)
923                 .moduleShardsConfig(moduleShardsConfig).build();
924
925         leaderNode1.configDataStore().waitTillReady();
926         leaderNode1.operDataStore().waitTillReady();
927         verifyVotingStates(leaderNode1.configDataStore(), "cars", new SimpleEntry<>("member-1", TRUE),
928                 new SimpleEntry<>("member-2", TRUE), new SimpleEntry<>("member-3", TRUE),
929                 new SimpleEntry<>("member-4", FALSE), new SimpleEntry<>("member-5", FALSE),
930                 new SimpleEntry<>("member-6", FALSE));
931
932         final var service1 = new ClusterAdminRpcService(leaderNode1.configDataStore(), leaderNode1.operDataStore(),
933             null);
934
935         final var rpcResult = service1.flipMemberVotingStatesForAllShards(
936             new FlipMemberVotingStatesForAllShardsInputBuilder().build())
937             .get(10, TimeUnit.SECONDS);
938         FlipMemberVotingStatesForAllShardsOutput result = verifySuccessfulRpcResult(rpcResult);
939         verifyShardResults(result.getShardResult(), successShardResult("cars", DataStoreType.Config),
940                 successShardResult("people", DataStoreType.Config),
941                 successShardResult("cars", DataStoreType.Operational),
942                 successShardResult("people", DataStoreType.Operational));
943
944         // Members 2 and 3 are now non-voting but should get replicated with the new new server config.
945         verifyVotingStates(new AbstractDataStore[]{leaderNode1.configDataStore(), leaderNode1.operDataStore(),
946                 replicaNode2.configDataStore(), replicaNode2.operDataStore(),
947                 replicaNode3.configDataStore(), replicaNode3.operDataStore()},
948                 new String[]{"cars", "people"},
949                 new SimpleEntry<>("member-1", FALSE), new SimpleEntry<>("member-2", FALSE),
950                 new SimpleEntry<>("member-3", FALSE), new SimpleEntry<>("member-4", TRUE),
951                 new SimpleEntry<>("member-5", TRUE), new SimpleEntry<>("member-6", TRUE));
952
953         // The leader (member 1) was changed to non-voting but it shouldn't be able to step down as leader yet
954         // b/c it can't get a majority consensus with all voting members down. So verify it remains the leader.
955         verifyRaftState(leaderNode1.configDataStore(), "cars", raftState -> {
956             assertNotNull("Expected non-null leader Id", raftState.getLeader());
957             assertTrue("Expected leader member-1", raftState.getLeader().contains("member-1"));
958         });
959     }
960
961     private static void setupPersistedServerConfigPayload(final ServerConfigurationPayload serverConfig,
962             final String member, final String datastoreTypeSuffix, final String... shards) {
963         String[] datastoreTypes = {"config_", "oper_"};
964         for (String type : datastoreTypes) {
965             for (String shard : shards) {
966                 List<ServerInfo> newServerInfo = new ArrayList<>(serverConfig.getServerConfig().size());
967                 for (ServerInfo info : serverConfig.getServerConfig()) {
968                     newServerInfo.add(new ServerInfo(ShardIdentifier.create(shard, MemberName.forName(info.peerId()),
969                             type + datastoreTypeSuffix).toString(), info.isVoting()));
970                 }
971
972                 final String shardID = ShardIdentifier.create(shard, MemberName.forName(member),
973                         type + datastoreTypeSuffix).toString();
974                 InMemoryJournal.addEntry(shardID, 1, new UpdateElectionTerm(1, null));
975                 InMemoryJournal.addEntry(shardID, 2, new SimpleReplicatedLogEntry(0, 1,
976                         new ServerConfigurationPayload(newServerInfo)));
977             }
978         }
979     }
980
981     @SafeVarargs
982     private static void verifyVotingStates(final AbstractDataStore[] datastores, final String[] shards,
983             final SimpleEntry<String, Boolean>... expStates) throws Exception {
984         for (AbstractDataStore datastore: datastores) {
985             for (String shard: shards) {
986                 verifyVotingStates(datastore, shard, expStates);
987             }
988         }
989     }
990
991     @SafeVarargs
992     private static void verifyVotingStates(final AbstractDataStore datastore, final String shardName,
993             final SimpleEntry<String, Boolean>... expStates) throws Exception {
994         String localMemberName = datastore.getActorUtils().getCurrentMemberName().getName();
995         Map<String, Boolean> expStateMap = new HashMap<>();
996         for (Entry<String, Boolean> e: expStates) {
997             expStateMap.put(ShardIdentifier.create(shardName, MemberName.forName(e.getKey()),
998                     datastore.getActorUtils().getDataStoreName()).toString(), e.getValue());
999         }
1000
1001         verifyRaftState(datastore, shardName, raftState -> {
1002             String localPeerId = ShardIdentifier.create(shardName, MemberName.forName(localMemberName),
1003                     datastore.getActorUtils().getDataStoreName()).toString();
1004             assertEquals("Voting state for " + localPeerId, expStateMap.get(localPeerId), raftState.isVoting());
1005             for (Entry<String, Boolean> e: raftState.getPeerVotingStates().entrySet()) {
1006                 assertEquals("Voting state for " + e.getKey(), expStateMap.get(e.getKey()), e.getValue());
1007             }
1008         });
1009     }
1010
1011     private static void verifyShardResults(final Map<ShardResultKey, ShardResult> shardResults,
1012             final ShardResult... expShardResults) {
1013         Map<String, ShardResult> expResultsMap = new HashMap<>();
1014         for (ShardResult r: expShardResults) {
1015             expResultsMap.put(r.getShardName() + "-" + r.getDataStoreType(), r);
1016         }
1017
1018         for (ShardResult result: shardResults.values()) {
1019             ShardResult exp = expResultsMap.remove(result.getShardName() + "-" + result.getDataStoreType());
1020             assertNotNull(String.format("Unexpected result for shard %s, type %s", result.getShardName(),
1021                     result.getDataStoreType()), exp);
1022             assertEquals("isSucceeded", exp.getSucceeded(), result.getSucceeded());
1023             if (exp.getSucceeded()) {
1024                 assertNull("Expected null error message", result.getErrorMessage());
1025             } else {
1026                 assertNotNull("Expected error message", result.getErrorMessage());
1027             }
1028         }
1029
1030         if (!expResultsMap.isEmpty()) {
1031             fail("Missing shard results for " + expResultsMap.keySet());
1032         }
1033     }
1034
1035     private static ShardResult successShardResult(final String shardName, final DataStoreType type) {
1036         return new ShardResultBuilder().setDataStoreType(type).setShardName(shardName).setSucceeded(TRUE).build();
1037     }
1038
1039     private static ShardResult failedShardResult(final String shardName, final DataStoreType type) {
1040         return new ShardResultBuilder().setDataStoreType(type).setShardName(shardName).setSucceeded(FALSE).build();
1041     }
1042 }