import akka.actor.ActorRef;
import akka.actor.ActorSelection;
-import akka.actor.Cancellable;
import org.opendaylight.controller.cluster.raft.RaftActorContext;
import org.opendaylight.controller.cluster.raft.RaftState;
import org.opendaylight.controller.cluster.raft.internal.messages.ElectionTimeout;
import org.opendaylight.controller.cluster.raft.messages.AppendEntries;
import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply;
+import org.opendaylight.controller.cluster.raft.messages.RaftRPC;
import org.opendaylight.controller.cluster.raft.messages.RequestVote;
import org.opendaylight.controller.cluster.raft.messages.RequestVoteReply;
-import scala.concurrent.duration.FiniteDuration;
+import java.util.Collection;
import java.util.HashMap;
-import java.util.List;
import java.util.Map;
-import java.util.Random;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicLong;
/**
* The behavior of a RaftActor when it is in the CandidateState
- * <p>
+ * <p/>
* Candidates (§5.2):
* <ul>
* <li> On conversion to candidate, start election:
*/
public class Candidate extends AbstractRaftActorBehavior {
- /**
- * The maximum election time variance
- */
- private static final int ELECTION_TIME_MAX_VARIANCE = 100;
-
- /**
- * The interval in which a new election would get triggered if no leader is found
- */
- private static final long ELECTION_TIME_INTERVAL = Leader.HEART_BEAT_INTERVAL.toMillis() * 2;
-
- /**
- *
- */
private final Map<String, ActorSelection> peerToActor = new HashMap<>();
- private Cancellable electionCancel = null;
-
private int voteCount;
private final int votesRequired;
- public Candidate(RaftActorContext context, List<String> peerPaths) {
+ public Candidate(RaftActorContext context) {
super(context);
+ Collection<String> peerPaths = context.getPeerAddresses().values();
+
for (String peerPath : peerPaths) {
peerToActor.put(peerPath,
context.actorSelection(peerPath));
}
+ context.getLogger().debug("Election:Candidate has following peers:"+peerToActor.keySet());
if(peerPaths.size() > 0) {
// Votes are required from a majority of the peers including self.
// The votesRequired field therefore stores a calculated value
votesRequired = 0;
}
- scheduleElection(randomizedDuration());
+ startNewTerm();
+ scheduleElection(electionDuration());
}
@Override protected RaftState handleAppendEntries(ActorRef sender,
- AppendEntries appendEntries, RaftState suggestedState) {
-
- // There is some peer who thinks it's a leader but is not
- // I will not accept this append entries
- sender.tell(new AppendEntriesReply(
- context.getTermInformation().getCurrentTerm().get(), false),
- context.getActor());
+ AppendEntries appendEntries) {
- return suggestedState;
+ return state();
}
@Override protected RaftState handleAppendEntriesReply(ActorRef sender,
- AppendEntriesReply appendEntriesReply, RaftState suggestedState) {
-
- // Some peer thinks I was a leader and sent me a reply
-
- return suggestedState;
- }
-
- @Override protected RaftState handleRequestVote(ActorRef sender,
- RequestVote requestVote, RaftState suggestedState) {
-
- // We got this RequestVote because the term in there is less than
- // or equal to our current term, so do not grant the vote
- sender.tell(new RequestVoteReply(
- context.getTermInformation().getCurrentTerm().get(), false),
- context.getActor());
+ AppendEntriesReply appendEntriesReply) {
- return suggestedState;
+ return state();
}
@Override protected RaftState handleRequestVoteReply(ActorRef sender,
- RequestVoteReply requestVoteReply, RaftState suggestedState) {
- if(suggestedState == RaftState.Follower) {
- // If base class thinks I should be follower then I am
- return suggestedState;
- }
+ RequestVoteReply requestVoteReply) {
- if(requestVoteReply.isVoteGranted()){
+ if (requestVoteReply.isVoteGranted()) {
voteCount++;
}
- if(voteCount >= votesRequired){
+ if (voteCount >= votesRequired) {
return RaftState.Leader;
}
return state();
}
- @Override protected RaftState state() {
+ @Override public RaftState state() {
return RaftState.Candidate;
}
@Override
public RaftState handleMessage(ActorRef sender, Object message) {
- if(message instanceof ElectionTimeout){
- if(votesRequired == 0){
+
+ if (message instanceof RaftRPC) {
+ RaftRPC rpc = (RaftRPC) message;
+ // If RPC request or response contains term T > currentTerm:
+ // set currentTerm = T, convert to follower (§5.1)
+ // This applies to all RPC messages and responses
+ if (rpc.getTerm() > context.getTermInformation().getCurrentTerm()) {
+ context.getTermInformation().updateAndPersist(rpc.getTerm(), null);
+ return RaftState.Follower;
+ }
+ }
+
+ if (message instanceof ElectionTimeout) {
+ if (votesRequired == 0) {
// If there are no peers then we should be a Leader
// We wait for the election timeout to occur before declare
// ourselves the leader. This gives enough time for a leader
// to send a message to the candidate
return RaftState.Leader;
}
- scheduleElection(randomizedDuration());
+ startNewTerm();
+ scheduleElection(electionDuration());
return state();
}
return super.handleMessage(sender, message);
}
- private FiniteDuration randomizedDuration(){
- long variance = new Random().nextInt(ELECTION_TIME_MAX_VARIANCE);
- return new FiniteDuration(ELECTION_TIME_INTERVAL + variance, TimeUnit.MILLISECONDS);
- }
- private void scheduleElection(FiniteDuration interval) {
+ private void startNewTerm() {
+
// set voteCount back to 1 (that is voting for self)
voteCount = 1;
// Increment the election term and vote for self
- AtomicLong currentTerm = context.getTermInformation().getCurrentTerm();
- context.getTermInformation().update(currentTerm.incrementAndGet(), context.getId());
+ long currentTerm = context.getTermInformation().getCurrentTerm();
+ context.getTermInformation().updateAndPersist(currentTerm + 1, context.getId());
+
+ context.getLogger().debug("Starting new term " + (currentTerm+1));
// Request for a vote
- for(ActorSelection peerActor : peerToActor.values()){
+ // TODO: Retry request for vote if replies do not arrive in a reasonable
+ // amount of time TBD
+ for (ActorSelection peerActor : peerToActor.values()) {
peerActor.tell(new RequestVote(
- context.getTermInformation().getCurrentTerm().get(),
- context.getId(), context.getReplicatedLog().last().getIndex(),
- context.getReplicatedLog().last().getTerm()),
- context.getActor());
+ context.getTermInformation().getCurrentTerm(),
+ context.getId(),
+ context.getReplicatedLog().lastIndex(),
+ context.getReplicatedLog().lastTerm()),
+ context.getActor()
+ );
}
- if (electionCancel != null && !electionCancel.isCancelled()) {
- electionCancel.cancel();
- }
- // Schedule an election. When the scheduler triggers an ElectionTimeout
- // message is sent to itself
- electionCancel =
- context.getActorSystem().scheduler().scheduleOnce(interval,
- context.getActor(), new ElectionTimeout(),
- context.getActorSystem().dispatcher(), context.getActor());
}
+ @Override public void close() throws Exception {
+ stopElection();
+ }
}
Code Review / controller.git / blobdiff