netty-event-executor-config: final parameters 71/56971/2
authorStephen Kitt <skitt@redhat.com>
Fri, 12 May 2017 15:33:21 +0000 (17:33 +0200)
committerTom Pantelis <tompantelis@gmail.com>
Mon, 15 May 2017 11:49:46 +0000 (11:49 +0000)
This automatically-generated patch flags all appropriate parameters as
final (including caught exceptions).

Change-Id: I53e5803a91a723714f4c9b5a2299c869d81b5a9a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/AutoCloseableEventExecutor.java
opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModule.java
opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleFactory.java
opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModule.java
opendaylight/config/netty-event-executor-config/src/main/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleFactory.java
opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java
opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/ImmediateEventExecutorModuleTest.java

index b77126b..d4e58db 100644 (file)
@@ -22,7 +22,7 @@ public interface AutoCloseableEventExecutor extends EventExecutor, AutoCloseable
         public static final int DEFAULT_SHUTDOWN_SECONDS = 1;
         private final EventExecutor eventExecutor;
 
-        public CloseableEventExecutorMixin(EventExecutor eventExecutor) {
+        public CloseableEventExecutorMixin(final EventExecutor eventExecutor) {
             this.eventExecutor = eventExecutor;
         }
 
@@ -36,7 +36,7 @@ public interface AutoCloseableEventExecutor extends EventExecutor, AutoCloseable
                 final CloseableEventExecutorMixin closeableEventExecutorMixin) {
             return Reflection.newProxy(AutoCloseableEventExecutor.class, new AbstractInvocationHandler() {
                 @Override
-                protected Object handleInvocation(Object proxy, Method method, Object[] args) throws Throwable {
+                protected Object handleInvocation(final Object proxy, final Method method, final Object[] args) throws Throwable {
                     if (method.getName().equals("close")) {
                         closeableEventExecutorMixin.close();
                         return null;
index 476b202..427cad5 100644 (file)
@@ -30,14 +30,14 @@ public final class GlobalEventExecutorModule extends
         org.opendaylight.controller.config.yang.netty.eventexecutor.AbstractGlobalEventExecutorModule {
     private BundleContext bundleContext;
 
-    public GlobalEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier,
-            org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) {
+    public GlobalEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier,
+            final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) {
         super(identifier, dependencyResolver);
     }
 
-    public GlobalEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier,
-            org.opendaylight.controller.config.api.DependencyResolver dependencyResolver,
-            GlobalEventExecutorModule oldModule, java.lang.AutoCloseable oldInstance) {
+    public GlobalEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier,
+            final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver,
+            final GlobalEventExecutorModule oldModule, final java.lang.AutoCloseable oldInstance) {
         super(identifier, dependencyResolver, oldModule, oldInstance);
     }
 
index c15d80b..d4597d4 100644 (file)
@@ -30,7 +30,7 @@ public class GlobalEventExecutorModuleFactory extends org.opendaylight.controlle
 
 
     @Override
-    public GlobalEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, GlobalEventExecutorModule oldModule, AutoCloseable oldInstance, BundleContext bundleContext) {
+    public GlobalEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final GlobalEventExecutorModule oldModule, final AutoCloseable oldInstance, final BundleContext bundleContext) {
         checkArgument(SINGLETON_NAME.equals(instanceName),"Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME);
         GlobalEventExecutorModule module = super.instantiateModule(instanceName, dependencyResolver, oldModule,
                 oldInstance, bundleContext);
@@ -39,7 +39,7 @@ public class GlobalEventExecutorModuleFactory extends org.opendaylight.controlle
     }
 
     @Override
-    public GlobalEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) {
+    public GlobalEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final BundleContext bundleContext) {
         checkArgument(SINGLETON_NAME.equals(instanceName),"Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME);
         GlobalEventExecutorModule module = super.instantiateModule(instanceName, dependencyResolver, bundleContext);
         module.setBundleContext(bundleContext);
index 6163ce0..6bdef5c 100644 (file)
@@ -15,12 +15,12 @@ import org.opendaylight.controller.config.yang.netty.eventexecutor.AutoCloseable
 @Deprecated
 public final class ImmediateEventExecutorModule extends org.opendaylight.controller.config.yang.netty.eventexecutor.AbstractImmediateEventExecutorModule {
 
-    public ImmediateEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) {
+    public ImmediateEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) {
         super(identifier, dependencyResolver);
     }
 
-    public ImmediateEventExecutorModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver,
-                                        ImmediateEventExecutorModule oldModule, java.lang.AutoCloseable oldInstance) {
+    public ImmediateEventExecutorModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver,
+                                        final ImmediateEventExecutorModule oldModule, final java.lang.AutoCloseable oldInstance) {
 
         super(identifier, dependencyResolver, oldModule, oldInstance);
     }
index f9d6417..814ca21 100644 (file)
@@ -19,13 +19,13 @@ public class ImmediateEventExecutorModuleFactory extends org.opendaylight.contro
     public static final String SINGLETON_NAME = "singleton";
 
     @Override
-    public ImmediateEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, ImmediateEventExecutorModule oldModule, AutoCloseable oldInstance, BundleContext bundleContext) {
+    public ImmediateEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final ImmediateEventExecutorModule oldModule, final AutoCloseable oldInstance, final BundleContext bundleContext) {
         checkArgument(SINGLETON_NAME.equals(instanceName), "Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME);
         return super.instantiateModule(instanceName, dependencyResolver, oldModule, oldInstance, bundleContext);
     }
 
     @Override
-    public ImmediateEventExecutorModule instantiateModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) {
+    public ImmediateEventExecutorModule instantiateModule(final String instanceName, final DependencyResolver dependencyResolver, final BundleContext bundleContext) {
         checkArgument(SINGLETON_NAME.equals(instanceName), "Illegal instance name '" + instanceName + "', only allowed name is " + SINGLETON_NAME);
         return super.instantiateModule(instanceName, dependencyResolver, bundleContext);
     }
index 7d76369..2bf7149 100644 (file)
@@ -71,7 +71,7 @@ public class GlobalEventExecutorModuleTest extends AbstractConfigTest {
         try {
             createInstance(transaction, instanceName + "x");
             fail();
-        }catch(IllegalArgumentException e){
+        }catch(final IllegalArgumentException e){
             assertTrue(e.getMessage() + " failure", e.getMessage().contains("only allowed name is singleton"));
         }
     }
@@ -93,7 +93,7 @@ public class GlobalEventExecutorModuleTest extends AbstractConfigTest {
         assertStatus(status, 0, 0, 1);
     }
 
-    private ObjectName createInstance(ConfigTransactionJMXClient transaction, String instanceName)
+    private ObjectName createInstance(final ConfigTransactionJMXClient transaction, final String instanceName)
             throws InstanceAlreadyExistsException {
         ObjectName nameCreated = transaction.createModule(factory.getImplementationName(), instanceName);
         transaction.newMXBeanProxy(nameCreated, GlobalEventExecutorModuleMXBean.class);
index d280bca..8ab1570 100644 (file)
@@ -61,7 +61,7 @@ public class ImmediateEventExecutorModuleTest extends AbstractConfigTest {
         assertStatus(status, 0, 0, 1);
     }
 
-    private ObjectName createInstance(ConfigTransactionJMXClient transaction, String instanceName)
+    private ObjectName createInstance(final ConfigTransactionJMXClient transaction, final String instanceName)
             throws InstanceAlreadyExistsException {
         ObjectName nameCreated = transaction.createModule(factory.getImplementationName(), instanceName);
         transaction.newMXBeanProxy(nameCreated, ImmediateEventExecutorModuleMXBean.class);

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.