Fix checkstyle warnings in config-util

Change-Id: I5a8caa79f38081b65f2e25f9aaecc403584fa394
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Merge changes If7159c39,I6c84b2fe

* changes:
  Deprecate ForwardedBackwardsCompatibleDataBroker
  Migrate from using the deprecated SchemaContextProvider

Merge "Migrate FRM/SM to use model API SchemaContextProvider"

Deprecate ForwardedBackwardsCompatibleDataBroker

It implements a deprecated API only, so rather than suppressing the
deprecation warnings, deprecate the entire class.

Change-Id: If7159c3960b3ca2707bb4b9c716e95ed38ddb394
Signed-off-by: Robert Varga <rovarga@cisco.com>

Migrate from using the deprecated SchemaContextProvider

org.opendaylight.controller.sal.dom.broker.SchemaContextProvider has
been deprecated, the services away so it is no longer used.

Change-Id: I6c84b2fe6ce02dce71aed4e4c24f8bc84ba078d8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Migrate FRM/SM to use model API SchemaContextProvider

Simple migration, eliminates the need for deprecation suppression.

Change-Id: Ic6d14c15dd1909d89c9b76bef20c36cdbde23187
Signed-off-by: Robert Varga <rovarga@cisco.com>

Rename 01-mdsal.xml to 01-md-sal.xml

This renames the feature definition to ensure that the file distributed
in karaf matches the name that is stored in the SCM.

Change-Id: Ic885e1714f1754d9e57b513e3ad9e24395c6d11f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Remove raw references to Map in XSQL"

Merge "BUG-8: mark deprecated classes as such"

Bug 865: Changed Config subsystem module for ForwardedBindingDataBroker.

Implementation of new Bidning Data Broker was wired to deprecated APIs
and used broker to discover dependencies which did not allowed for
full-fledged customized wiring. Reworked configuration to explicitly
allow injection of each required depenency and to not use
deprecated APIs for dependency injection.

Change-Id: Iccbb20ee4bb1df380f5fc4a3a1bbc5748dcc5a38
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "BUG-650: Split out CommitCoordinationTask"

Merge changes Ia7cd7eda,If961a029,I9f6a57a2,Id8551489

* changes:
  Fix checkstyle warnings in config-persister-file-xml-adapter.
  Fix checkstyle warnings in config-persister-feature-adapter
  Fix checkstyle warnings in config-persister-directory-xml-adapter
  Fix checkstyle warnings in config-manager

Merge "Fix checkstyle warnings in config-api"

Fix checkstyle warnings in netconf-client

Change-Id: I94d8c31a16f0755451a3bebad5a8792a97d426d2
Signed-off-by: Marian Dubai <mdubai@cisco.com>

BUG-650: Split out CommitCoordinationTask

The coordination task takes most of the coordinator implementation. We
do not want to expose it, but at the same time we want to evolve task.
Split it out and eliminate the unneeded atomic state updates, as it is
only ever touched by a single thread.

Change-Id: I49b494d23a8b8f9cdf6cb3dc33e08d22c5bf325e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-650: remove executor abstraction"

Bug-2277: fix the Leader test failing in jenkins

Change-Id: I149d643b517df5010595962cbdf616c2b2fb9945
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

BUG-8: mark deprecated classes as such

These classes refer to various deprecated interfaces of MD-SAL,
triggering a lot of warnings about deprecated constructs. Since these
classes themselves have been superseded, mark them as Deprecated,
lowering the amount of warnings we get.

Change-Id: I19753166fa1fd617ad7085b71a1218f6bc4a3f53
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove raw references to Map in XSQL

This adds the proper types to map, removing some casts and improving
efficiency slightly. Fixes quite a few of eclipse warnings.

Change-Id: Ia8cc61961a1898dd17e4e5d0e6e7a247475a007a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix checkstyle warnings in config-persister-file-xml-adapter.

Change-Id: Ia7cd7eda114225cfc35ec301535d5aaec0fa8794
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings in config-api

Change-Id: I56eedb15f3c5892731a757bdb06c34d9d15efab7
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings in config-persister-feature-adapter

Change-Id: If961a029b48d85b58ca10b9b71f5fc29d41dbe9c
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings in config-persister-directory-xml-adapter

Change-Id: I9f6a57a22b470359c7eb038e77736376cd2ac3ee
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings in config-manager

Change-Id: Id8551489d678ebb35908f052a571303fc6c68999
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Merge "Remove unused warnings suppressions"

Merge "BUG-868: do not use YangInstanceIdentifier.getPath()"

Merge "Do not retain module through NotificationListener"

BUG-650: remove executor abstraction

This patch removes sameThreadExecutor from the commit path, eliminating
associated overhead. Relevant benchmarks show improvement pretty much
across the board:

BEFORE                                                            millis        error
write100KSingleNodeWithOneInnerItemInCommitPerWriteBenchmark    2213.735       77.597
write100KSingleNodeWithOneInnerItemInOneCommitBenchmark          171.524        2.289
write10KSingleNodeWithTenInnerItemsInCommitPerWriteBenchmark     164.282        1.391
write10KSingleNodeWithTenInnerItemsInOneCommitBenchmark           14.161        0.196
write50KSingleNodeWithTwoInnerItemsInCommitPerWriteBenchmark     982.697       29.397
write50KSingleNodeWithTwoInnerItemsInOneCommitBenchmark           93.233        2.174

AFTER                                                             millis        error   delta
write100KSingleNodeWithOneInnerItemInCommitPerWriteBenchmark    2138.900       75.844   -3.4%
write100KSingleNodeWithOneInnerItemInOneCommitBenchmark          177.839        3.997   +3.5%
write10KSingleNodeWithTenInnerItemsInCommitPerWriteBenchmark     158.666        1.090   -3.5%
write10KSingleNodeWithTenInnerItemsInOneCommitBenchmark           13.022        0.105   -8.0%
write50KSingleNodeWithTwoInnerItemsInCommitPerWriteBenchmark     935.490       30.395   -4.8%
write50KSingleNodeWithTwoInnerItemsInOneCommitBenchmark           89.907        1.204   -3.6%

Furthermore it cleans up and marks FIXMEs for defunct statistics. These
will need to be replaced with implementation which does not assume
underlying implementation.

Change-Id: I01c51462a8529a2f874ecd2f9af05faba503bc58
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-868: do not use YangInstanceIdentifier.getPath()

This method has been deprecated, so stop using it.

Change-Id: Ibfaf7e40a3d119ed05ff5743c4869e345d18e298
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Fix typos and missing space"

Merge "BUG-2381: do not retain references to DependencyResolverManager"

Make NetconfMessageTransformUtil constants final

All of these constants were missing 'final' keyword, making them not
really constant.

Change-Id: I192df7dc9d063442f99256e874d467ed800f3717
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix typos and missing space

Change-Id: Iaf581baea36091724eebbc5de33dda34605e1912
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2381: do not retain references to DependencyResolverManager

Instead of creating an anonymous subclass, define a proper class and
pass it the three required fields.

Change-Id: I5c9eea66284b60597ac77b336ef3afa652633479
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unused warnings suppressions

Remove suppressions which do not do anything -- thus fixing eclipse
warnings.

Change-Id: I846133477235152504bb159b6bf58e58c0455521
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not retain module through NotificationListener

Analysis shows we are retaining Module instances via
NotificationListener instances. This turns out to be caused by anonymous
class retaining a reference to AbstractDynamicWrapper, which holds the
module for hashCode/equals purposes.

Change-Id: Iab3c30eb3d03a1387fa1f4b0f3cf16eb348f1117
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Set auth timeout along with idle in SshProxyServer"

Merge changes Ic434bf4a,I05a3fb18,I47a3783d,I8234bbfd

* changes:
  Fix checkstyle warnings in netconf-cli
  Fix checkstyle warnings ietf-netconf-monitoring
  Fix checkstyle warnings for netconf-testtool
  Fix checkstyle warnings for config-netconf-connector

Merge "BUG-2243 Fixing invalid hello message handling"

Merge "BUG-2218: Keep existing link augmentations during discovery process"

Merge "Bug 2273: Removed unbuilt third-party code."

Merge "Remove unneeded embedded dependency"

Merge "Do not retain NetconfConnectModule reference"

Merge "Use ImmutableSet/Map in ServiceReferenceRegistry"

Merge "Fix raw references to Iterator"

Merge "Fix raw ServiceReferences and ServiceRegistrations"

Merge changes Ife66b5fe,I174ea168

* changes:
  Fix checkstyle warnings for config-persister-impl
  Fix checkstyle warnings in netconf-api

Merge "Bug-2277 : Isolated Leader Implementation"

Merge "BUG-2304 Fix leafref/instanceIdentifier processing in restconf -> netconf pipeline"

BUG-2243 Fixing invalid hello message handling

When invalid message before hello message, session dropped after hello message

Change-Id: I2c92012d3ba25069693a35b76d105407d200a833
Signed-off-by: Marian Dubai <mdubai@cisco.com>

BUG-2304 Fix leafref/instanceIdentifier processing in restconf -> netconf pipeline

Resolve the leafref type based on type being referenced by the xpath.
Fix tests testing wrong instance identifier behavior
Fix subtree filtering in netconf northbound when identityrefs are involved

Change-Id: I561e0c92550dd6639a9f9fbd1909695041c378e4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Fix checkstyle warnings in netconf-cli

Change-Id: Ic434bf4aac666c312e41781588aa9fca94acca4e
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings ietf-netconf-monitoring

Change-Id: I05a3fb185ae53128c31f8565a9489f7d0399febe
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings for netconf-testtool

Change-Id: I47a3783d9b89cadc6549d6f4784508cefb149059
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings for config-netconf-connector

Change-Id: I8234bbfdb7092f6423cedc7f95de07995871756d
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Fix checkstyle warnings for config-persister-impl

Change-Id: Ife66b5fea7bb6d1fe293d6181d6da7221e296731
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Use ImmutableSet/Map in ServiceReferenceRegistry

Rather than wrapping collections in unmodifiable references, perform a
copy to obtain a properly-constant collection. These references are
usually retained for longer time, so opting for memory efficiency is
better than using sparse collections.

Change-Id: I708beaaa9abb13560297a7eb1369322220e87d5a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded embedded dependency

yangtools:util already embeds the dependency with a different version,
causing a potential clash. Since sal-dom-broker is not a direct user,
this will work just fine.

Change-Id: If92555d6feb15c6ee9495fb789244750a48e9129
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not retain NetconfConnectModule reference

Anononymous classes retain a reference to the module, which means we
leak quite a bit of memory if the client is not shut down.

Change-Id: Ifeaeb383afe8ff5c899cee66ea861e30bdf2ae41
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix raw ServiceReferences and ServiceRegistrations

Adding a windcard is enough to reduce the number of eclipse warnings.

Change-Id: I060ce96e2eb4cc6c6ed0e2bf87daabacc33b2d3f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix raw references to Iterator

Adds type declarations to fix eclipse warnings.

Change-Id: I33c9303bda2d5dd42632de2ec191e294d496e09b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Set auth timeout along with idle in SshProxyServer

Change-Id: I4d7de2ca3f5e2025856646b825040b79ca344f34
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Bug-2277 : Isolated Leader Implementation

A new RaftState has been added and on a scheduler, we check if the leader is isolated, looking at the majority peer statuses.
If Yes, then it switches the behavior to IsolatedLeader.

On the receipt of each AppendEntriesReply, the IsolatedLeader checks for isolation.
And if no, then switches back to either Leader or Follower.

These changes have been tested with TestDriver  and 3 node cluster and the switching of Leader to IsolatedLeader and back,
on the stopping and reinstating of followers, was successful.

The Isolated Leader check interval can be configured via the config subsystem

Change-Id: I42b9165cc477d812c7e0e02339537c0f1fe74934
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

Remove legacy distribution.

Change-Id: I0652f606efb99a4c8bcb06df8418413c3cc68d8c
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Fix checkstyle warnings in netconf-api

Change-Id: I174ea168e5b264cd99c2faa9ab182859806ef12f
Signed-off-by: Marian Dubai <mdubai@cisco.com>

Merge "Updating features archetype to talk about user-facing features."

Merge "Netconf testtool fix multiple feature file modification"

Merge "BUG-2345 Move bouncycastle bundles from netconf-connector to netconf feature"

Bug 2368: MD-SAL FRM may update/remove unexpected flow entries.

FRM should always set strict flag into update-flow/remove-flow
RPC input.

Change-Id: I6027442b56f4cd93cfc3f954dc8501bb57e2d64a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug-2136 - fix for is-local-path

Change-Id: I38a58683c94c54e9f399df56aa586e3916f75e41
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

Merge "Bug 2347: Minor fixes to correct log output"

Merge "Bug 2021 - Continuous WARN log nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx"

Merge "BUG 2353 : Handle binary, bits and instanceidentifier types in NodeIdentifiers"

BUG-2345 Move bouncycastle bundles from netconf-connector to netconf feature

Apache mina sshd bundle is located in features-netconf and bouncycastle in features-netconf-connector.
This is wrong because mina sshd depends directly on bouncycastle but marks the dependency as optional which is probably not correct because this can result in runtime errors instead of resolution problems.

Change-Id: Ic9ef61294069859788fd10366e50b71f5bac9a43
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

BUG-2370 Reset schema context on disconnect in nc

Change-Id: I64197fc4ec375a07b2f0ea1dfb1215c4e31e206c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Netconf testtool fix multiple feature file modification

Change-Id: I141c5298cecdbd6607789bd1688ffb8792acdad7
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Bug 2347: Minor fixes to correct log output

DOMConcurrentDataCommitCoordinator#handleException hard-codes the error
mapper to CAN_COMMIT_ERROR_MAPPER however this should be passed
in corresponding to the phase.

In TransactionCommitFailedExceptionMapper, the opNames for
PRE_COMMIT_MAPPER and CAN_COMMIT_ERROR_MAPPER are reversed, should be
"preCommit", "canCommit" respectively.

Change-Id: I6c0513f0f6265ec19de39476c95efefee53d2ee1
Signed-off-by: tpantelis <tpanteli@brocade.com>

Bug 2273: Removed unbuilt third-party code.

Change-Id: I0158a970b3ae65e6a0c49c93d96ab71928b25dd0
Signed-off-by: Ed Warnicke <eaw@cisco.com>

BUG 2353 : Handle binary, bits and instanceidentifier types in NodeIdentifiers

This fix properly serializes and deserializes NodeIdentifier attributes of the types
  - binary (byte[])
  - yanginstanceidentifier
  - bits (set)

Change-Id: I612d40f9730c939be0594496c26370db96ea6449
Signed-off-by: Moiz Raja <moraja@cisco.com>

Merge "Bug 2347: DOMConcurrentDataCommitCoordinator uses wrong phase name"

Bug 2347: DOMConcurrentDataCommitCoordinator uses wrong phase name

Change-Id: I8b9083a428553525861137fc8630635f6508c2dc
Signed-off-by: tpantelis <tpanteli@brocade.com>

Merge "Bug 1029: Remove dead code: samples/clustersession"

Merge "Bug 1029: Remove dead code: p2site"

Bug 2021 - Continuous WARN log nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx

This fixes the bug in ToSalConversionsUtils.actionFrom() that mistakenly
passed an AD-SAL-style NodeID to a conversion utility (fromNodeConnectorRef)
that was expecting a MD-SAL-style NodeID.

Patch 8: Add unit test to exercise code path that exposes the issue

Change-Id: Icc107bd785d6558a3351f139c1b13b8737b56ae7
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Signed-off-by: Colin Dixon <colin@colindixon.com>

Merge "Move adsal into its own subdirectory."

BUG 2302 : odl-clustering-test-app should not be part of the odl-restconf-all feature set

This patch does the following,

1. It removes odl-clustering-test-app from the restconf features
2. Move odl-clustering-test-app to the md-sal feature (just like odl-toaster)
3. Removes all unneccessary dependencies from odl-clustering-test-app
4. Removes all the clustering configuration files from the odl-clustering-test-app feature

This now allows the odl-clustering-test-app to be used with/without clustering. It also
eliminates the problem is inadvertently installing the odl-clustering-test-app when installing
odl-restconf-all.

Change-Id: I8021f88c967576aa8cf8da54dbfa8f4464233bc3
Signed-off-by: Moiz Raja <moraja@cisco.com>

Move adsal into its own subdirectory.

Moved various adsal components into an opendaylight/adsal subdir,
gave it a parent pom, and changed the root parent pom to have the
opendaylight/adsal as a module.

Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Merge "BUG-2329 Add test for anyxmls inside rpc resonse for netcfon-connector"

Merge "BUG-2254 Enable schema-less rpcs invocation in netconf-connector"

Merge "Make idle timeout configurable in ssh proxy server"

BUG-2254 Enable schema-less rpcs invocation in netconf-connector

Change-Id: Id84a2be3db050a546380186c79deadf5c9f7fd28
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Fix raw references to SimpleNode"

Merge "Fix raw reference to SessionNegotiatior"

Merge "Fix raw use of Gauge"

Merge "Add serialVersionUID to Serializable classes"

Merge changes Ic7e83322,I2482a37c

* changes:
  Fix a non-generic reference to Comparable
  Fix non-generic references to ArrayList

Merge changes I525c2070,Ib920ff67

* changes:
  Fix neutron pagination
  Reuse NeutronObject comparator

Merge "Use generic-aware empty collections"

Make idle timeout configurable in ssh proxy server

Change-Id: Ia17b79331159dc04c2a837eacc33f3b7ac8033bc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

BUG-2329 Add test for anyxmls inside rpc resonse for netcfon-connector

Change-Id: If58216b8174c7cdbf248e6472ae1c5ba3a405a5b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>