Remove explicit default super-constructor calls 20/63620/1
authorDavid Suarez <david.suarez.fuentes@gmail.com>
Wed, 27 Sep 2017 13:23:16 +0000 (15:23 +0200)
committerDavid Suarez <david.suarez.fuentes@gmail.com>
Wed, 27 Sep 2017 13:23:16 +0000 (15:23 +0200)
The default constructor is called by default (hence its name), no need
to call it explicitly.

Change-Id: I0f4ac3bf4a1d582b7a9d50beeaa1de6d2f107499
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
27 files changed:
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConflictingVersionException.java
opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/rpc/Rpcs.java
opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java
opendaylight/config/netty-threadgroup-config/src/main/java/org/opendaylight/controller/config/yang/netty/threadgroup/NioEventLoopGroupCloseable.java
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Constructor.java
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Header.java
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java
opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/AbstractEntry.java
opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedRegistryReportEntry.java
opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java
opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadOnlyTransaction.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadWriteTransaction.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingWriteTransaction.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/rpc/RpcContextIdentifier.java
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMAdapterLoader.java
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMRpcServiceAdapter.java
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/LazySerializedDOMNotification.java
opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/ConstantSchemaAbstractDataBrokerTest.java
opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/util/compat/DataNormalizationOperation.java
opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerStats.java
opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/RpcErrors.java
opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java
opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/RpcRoutingContext.java
opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaContextProviders.java

index 2cdf9a5..a78ff6a 100644 (file)
@@ -44,7 +44,6 @@ public class Ethernet extends Packet {
      * Default constructor that creates and sets the HashMap
      */
     public Ethernet() {
-        super();
         fieldValues = new HashMap<>();
         hdrFieldCoordMap = fieldCoordinates;
         hdrFieldsMap = fieldValues;
index dfd8ca4..7ed1ede 100644 (file)
@@ -34,7 +34,6 @@ public class LLDP extends Packet {
      * Default constructor that creates the tlvList LinkedHashMap
      */
     public LLDP() {
-        super();
         init();
     }
 
index bb02561..9e3c501 100644 (file)
@@ -18,7 +18,6 @@ public class ConflictingVersionException extends Exception {
     private static final long serialVersionUID = 1L;
 
     public ConflictingVersionException() {
-        super();
     }
 
     public ConflictingVersionException(final String message, final Throwable cause) {
index 8abb635..8b66ad7 100644 (file)
@@ -17,7 +17,6 @@ public interface ReadOnlyAtomicBoolean {
         private final AtomicBoolean atomicBoolean;
 
         public ReadOnlyAtomicBooleanImpl(final AtomicBoolean atomicBoolean) {
-            super();
             this.atomicBoolean = atomicBoolean;
         }
 
index b9a6284..f8f58d0 100644 (file)
@@ -11,7 +11,6 @@ public class Header {
     private final String yangModuleName, yangModuleLocalName;
 
     public Header(String yangModuleName, String yangModuleLocalName) {
-        super();
         this.yangModuleName = yangModuleName;
         this.yangModuleLocalName = yangModuleLocalName;
     }
index 1c44040..be917df 100644 (file)
@@ -17,7 +17,6 @@ public class TypeDeclaration {
 
     public TypeDeclaration(String type, String name, List<String> extended,
             List<String> implemented, boolean isAbstract, boolean isFinal) {
-        super();
         this.type = type;
         this.name = name;
         this.extended = extended;
index 1681eb8..2dd161a 100644 (file)
@@ -24,7 +24,6 @@ public class CloseTrackedRegistryReportEntry<T extends CloseTracked<T>> {
 
     public CloseTrackedRegistryReportEntry(CloseTracked<T> exampleCloseTracked, long numberAddedNotRemoved,
             List<StackTraceElement> stackTraceElements) {
-        super();
         this.exampleCloseTracked = requireNonNull(exampleCloseTracked, "closeTracked");
         this.numberAddedNotRemoved = requireNonNull(numberAddedNotRemoved, "numberAddedNotRemoved");
         this.stackTraceElements = requireNonNull(stackTraceElements, "stackTraceElements");
index 3336ad9..6e89ca7 100644 (file)
@@ -45,7 +45,6 @@ public class ExampleRoleChangeListener extends AbstractUntypedActor implements A
     private static final String[] shardsToMonitor = new String[] {"example"};
 
     public ExampleRoleChangeListener(String memberName) {
-        super();
         scheduleRegistrationListener(schedulerDuration);
         this.memberName = memberName;
         populateRegistry(memberName);
index 00a2fcd..7ad5812 100644 (file)
@@ -2389,7 +2389,6 @@ public class LeaderTest extends AbstractLeaderTest<Leader> {
         private final int snapshotChunkSize;
 
         MockConfigParamsImpl(final long electionTimeOutIntervalMillis, final int snapshotChunkSize) {
-            super();
             this.electionTimeOutIntervalMillis = electionTimeOutIntervalMillis;
             this.snapshotChunkSize = snapshotChunkSize;
         }
index bc7d18c..a8fad51 100644 (file)
@@ -25,7 +25,6 @@ public class ForwardingReadOnlyTransaction extends ForwardingObject implements R
     private final ReadOnlyTransaction delegate;
 
     protected ForwardingReadOnlyTransaction(ReadOnlyTransaction delegate) {
-        super();
         this.delegate = delegate;
     }
 
index ae7446b..97a6db6 100644 (file)
@@ -29,7 +29,6 @@ public class ForwardingReadWriteTransaction extends ForwardingObject implements
     private final ReadWriteTransaction delegate;
 
     protected ForwardingReadWriteTransaction(ReadWriteTransaction delegate) {
-        super();
         this.delegate = delegate;
     }
 
index 81193af..e602743 100644 (file)
@@ -28,7 +28,6 @@ public class ForwardingWriteTransaction extends ForwardingObject implements Writ
     private final WriteTransaction delegate;
 
     protected ForwardingWriteTransaction(WriteTransaction delegate) {
-        super();
         this.delegate = delegate;
     }
 
index e3bedd3..b4bd6eb 100644 (file)
@@ -17,7 +17,6 @@ public final  class RpcContextIdentifier implements Immutable{
     public final Class<? extends BaseIdentity> routingContext;
 
     private RpcContextIdentifier(Class<? extends RpcService> rpcService, Class<? extends BaseIdentity> routingContext) {
-        super();
         this.rpcService = rpcService;
         this.routingContext = routingContext;
     }
index 96108ee..d8afdeb 100644 (file)
@@ -33,7 +33,6 @@ public abstract class BindingDOMAdapterLoader extends AdapterLoader<BindingServi
     private final BindingToNormalizedNodeCodec codec;
 
     public BindingDOMAdapterLoader(final BindingToNormalizedNodeCodec codec) {
-        super();
         this.codec = codec;
     }
 
index 26e696d..6504341 100644 (file)
@@ -40,7 +40,6 @@ public class BindingDOMRpcServiceAdapter implements RpcConsumerRegistry {
     private final BindingToNormalizedNodeCodec codec;
 
     public BindingDOMRpcServiceAdapter(final DOMRpcService domService, final BindingToNormalizedNodeCodec codec) {
-        super();
         this.domService = domService;
         this.codec = codec;
     }
index 8eba75a..ffab566 100644 (file)
@@ -30,7 +30,6 @@ public final class LazySerializedDOMNotification implements DOMNotification {
     private ContainerNode domBody;
 
     private LazySerializedDOMNotification(final BindingNormalizedNodeSerializer codec, final Notification data, final SchemaPath type) {
-        super();
         this.codec = codec;
         this.data = data;
         this.type = type;
index ba646c4..7e245a3 100644 (file)
@@ -19,7 +19,6 @@ import org.opendaylight.yangtools.yang.model.api.SchemaContext;
 public class ConstantSchemaAbstractDataBrokerTest extends AbstractConcurrentDataBrokerTest {
 
     public ConstantSchemaAbstractDataBrokerTest() {
-        super();
     }
 
     public ConstantSchemaAbstractDataBrokerTest(final boolean useMTDataTreeChangeListenerExecutor) {
index bbe3660..ca344aa 100644 (file)
@@ -56,7 +56,6 @@ public abstract class DataNormalizationOperation<T extends PathArgument> impleme
     }
 
     protected DataNormalizationOperation(final T identifier, final SchemaNode schema) {
-        super();
         this.identifier = identifier;
         if(schema instanceof DataSchemaNode) {
             this.dataSchemaNode = Optional.of((DataSchemaNode) schema);
@@ -328,7 +327,6 @@ public abstract class DataNormalizationOperation<T extends PathArgument> impleme
     private static final class AugmentationNormalization extends DataContainerNormalizationOperation<AugmentationIdentifier> {
 
         public AugmentationNormalization(final AugmentationSchema augmentation, final DataNodeContainer schema) {
-            //super();
             super(augmentationIdentifierFrom(augmentation), augmentationProxy(augmentation,schema),null);
         }
 
index c6e5006..1cc62f4 100644 (file)
@@ -31,9 +31,8 @@ public class QueuedNotificationManagerStats {
     private final List<ListenerNotificationQueueStats> currentListenerQueueStats;
 
     @ConstructorProperties({"maxListenerQueueSize","currentListenerQueueStats"})
-    public QueuedNotificationManagerStats( int maxListenerQueueSize,
-            List<ListenerNotificationQueueStats> currentListenerQueueStats ) {
-        super();
+    public QueuedNotificationManagerStats(int maxListenerQueueSize,
+            List<ListenerNotificationQueueStats> currentListenerQueueStats) {
         this.maxListenerQueueSize = maxListenerQueueSize;
         this.currentListenerQueueStats = currentListenerQueueStats;
     }
index cacb167..28133c5 100644 (file)
@@ -55,7 +55,6 @@ public class RpcErrors {
          */
         protected RpcErrorTO(String applicationTag, String tag, String info,
                 ErrorSeverity severity, String message, ErrorType errorType, Throwable cause) {
-            super();
             this.applicationTag = applicationTag;
             this.tag = tag;
             this.info = info;
index c242e0c..17221bc 100644 (file)
@@ -23,7 +23,6 @@ public interface BindingAwareRpcRouter extends RpcRouter<String, String, String,
         private final byte[] payload;
 
         public BindingAwareRequest(BindingAwareRouteIdentifier routingInformation, byte[] payload) {
-            super();
             this.routingInformation = routingInformation;
             this.payload = payload;
         }
@@ -45,7 +44,6 @@ public interface BindingAwareRpcRouter extends RpcRouter<String, String, String,
         private final String content;
 
         public BindingAwareRouteIdentifier(String type, String route, String content) {
-            super();
             this.type = type;
             this.route = route;
             this.content = content;
index 66d290f..ff3bb89 100644 (file)
@@ -24,7 +24,6 @@ public class RpcRoutingContext implements Immutable, Serializable {
 
 
     private RpcRoutingContext(QName context, QName rpc) {
-        super();
         this.context = context;
         this.rpc = rpc;
     }
index 6806c5d..e312e3d 100644 (file)
@@ -30,7 +30,6 @@ public class SchemaContextProviders {
         private final SchemaService service;
 
         public SchemaServiceAdapter(final SchemaService service) {
-            super();
             this.service = service;
         }
 

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.