controller.git
7 years agoBug 2103: Make sure InventoryManager survives Transaction failure. 28/11628/1
Tony Tkacik [Sat, 27 Sep 2014 16:13:21 +0000 (18:13 +0200)]
Bug 2103: Make sure InventoryManager survives Transaction failure.

Change-Id: I5896a0b7c3e63d2828361dc93d3582843a35b35d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoBug 2101: Do not block processing on transaction submit. 27/11627/3
Tony Tkacik [Sat, 27 Sep 2014 15:25:23 +0000 (17:25 +0200)]
Bug 2101: Do not block processing on transaction submit.

Change-Id: Ibdc75aa670254f84aa70647d655e4e1438edd9e9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoBUG 2049 DataStore failure in StatisticsManager 98/11598/13
Vaclav Demcak [Thu, 25 Sep 2014 21:03:30 +0000 (23:03 +0200)]
BUG 2049  DataStore failure in StatisticsManager
BUG 2101  When L2 switch installed, its flows are interpreted as new flows with each stats request

* hashCode is not safe in general so we'd like to prevent Collisions how we can
* we change HashBuilding to KeyBuilding from toString method
* toString is generated in CompileTime
* it can not be change during JVM run
* every one use same YANG model version and jar files
* and the same aproach could by use across claster
* add cleaning disconnected Node from StatListeningCommiter implementers

Change-Id: I645e9f07382af0b293bc43698446b7b84b95bbde
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoBUG-2049: DataStore failure in StatisticsManager 39/11539/2
Michal Rehak [Wed, 24 Sep 2014 16:21:38 +0000 (18:21 +0200)]
BUG-2049: DataStore failure in StatisticsManager

!WORKAROUND ONLY

- during node reconciliation statsManager could join together 2 similar
  sets of statistics notifications and hit duplicate values during
  processing - here we just skip those duplicates in order not to loose
  stats working thread and finish actual multipart

Change-Id: I526ab5439055ac565bfaa08e84e5043e8764846a
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agoMerge "Bug 1948: Finish separating out restconf features"
Moiz Raja [Wed, 24 Sep 2014 05:20:26 +0000 (05:20 +0000)]
Merge "Bug 1948: Finish separating out restconf features"

7 years agoMerge "Bug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid...
Ed Warnicke [Wed, 24 Sep 2014 03:39:14 +0000 (03:39 +0000)]
Merge "Bug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid cross origin error"

7 years agoBug 1948: Finish separating out restconf features 74/11474/3
Ed Warnicke [Tue, 23 Sep 2014 02:24:47 +0000 (21:24 -0500)]
Bug 1948: Finish separating out restconf features

In order to avoid a maven project cycle in solving
Bug 1948, we needed to separate restconf features.
Note, this is the second step, removing the suffix
 -new.

Change-Id: I3cad2e72141bd78a212dda71b4ef81ba6ab6555a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "Pulled the RPC query out of the data schema loop, so that modules that only...
Ed Warnicke [Wed, 24 Sep 2014 03:04:12 +0000 (03:04 +0000)]
Merge "Pulled the RPC query out of the data schema loop, so that modules that only contain RPCs will also be picked up."

7 years agoBug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid cross... 04/11504/3
Harman Singh [Tue, 23 Sep 2014 23:26:58 +0000 (16:26 -0700)]
Bug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid cross origin error

Change-Id: I47b860b5c092d54e0ae106b2b832c021502ad52f
Signed-off-by: Harman Singh <harmasin@cisco.com>
7 years agoMerge "Bug 2019: Have FeatureConfigPusher retry installedFeature check until it succe...
Moiz Raja [Tue, 23 Sep 2014 20:06:31 +0000 (20:06 +0000)]
Merge "Bug 2019: Have FeatureConfigPusher retry installedFeature check until it succeeds (or 100ms pass)."

7 years agoBug#2056 odl:xsql karaf command is throwing NPE when empty args 98/11498/1
Sharon Aicler [Tue, 23 Sep 2014 18:40:46 +0000 (11:40 -0700)]
Bug#2056 odl:xsql karaf command is throwing NPE when empty args

Change-Id: I60b6321aea4e02e4a7b409645bc8ebcec9a39112
Signed-off-by: Sharon Aicler <saichler@cisco.com>
7 years agoBug 2019: Have FeatureConfigPusher retry installedFeature check 96/11496/1
Ed Warnicke [Tue, 23 Sep 2014 17:08:42 +0000 (12:08 -0500)]
Bug 2019: Have FeatureConfigPusher retry installedFeature check
until it succeeds (or 100ms pass).

Karaf reports FeatureEvents before it marks the features
installed.  It also only guarantees complete info about
the features when you read the installed ones.  This
is causing a race condition that is at the root of 2019.

So this patch retries at 1ms intervals until we see

Change-Id: I67080475fc4b2dc2f053a286424f676f89164b6e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "Bug 1948: Separate out restconf features."
Devin Avery [Tue, 23 Sep 2014 16:44:11 +0000 (16:44 +0000)]
Merge "Bug 1948: Separate out restconf features."

7 years agoPulled the RPC query out of the data schema loop, so that 75/11475/1
David K. Bainbridge [Tue, 23 Sep 2014 03:35:45 +0000 (20:35 -0700)]
Pulled the RPC query out of the data schema loop, so that
modules that only contain RPCs will also be picked up.

Signed-off-by: David K. Bainbridge <dbainbri@ciena.com>
Change-Id: I63981d2126209263a762acbc190f4ad15f4dd725

7 years agoMerge "Bug 2026: Fix for Neutron REST API NullPointer exception on POST Port when...
Ed Warnicke [Tue, 23 Sep 2014 02:35:06 +0000 (02:35 +0000)]
Merge "Bug 2026: Fix for Neutron REST API NullPointer exception on POST Port when no fisxed-ips are present"

7 years agoBug 2026: Fix for Neutron REST API NullPointer exception on POST Port when no fisxed... 61/11461/1
Vina Ermagan [Mon, 22 Sep 2014 22:28:00 +0000 (15:28 -0700)]
Bug 2026: Fix for Neutron REST API NullPointer exception on POST Port when no fisxed-ips are present

Change-Id: I80e6435add3e0a07f28dbdf37911cd2bc8b263d0
Signed-off-by: Vina Ermagan <vermagan@cisco.com>
7 years agoBug 963 - OSGi error in Topology manager component - After exiting 50/11450/2
Jan Hajnar [Tue, 16 Sep 2014 13:07:17 +0000 (15:07 +0200)]
Bug 963 - OSGi error in Topology manager component - After exiting
mininet of13 simulation

* added check in onLinkRemoved() to check if link exists before
atempting to delete it (without check, lots of datastore transaction
errors were displayed on mininet shutdown because links were already
removed with nodes)
* added checks to check if node, connector or link exists before trying
to remove it (reads are cheap and delete exception can break the
transaction chain)
* made reads synchronous
* added illegalState exception handling to operation processor
* made affected links removal to be in the same transaction as
Node/NodeConnector removal(creating and applying snapshot for each link
is expensive)
* updated tests

Change-Id: I83b5f91569e64082ce13a4f379cd6261e63fbde6
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
7 years agoBug 1484 - StatisticManager performance improvement refactoring 05/10605/23
Vaclav Demcak [Wed, 17 Sep 2014 00:53:03 +0000 (02:53 +0200)]
Bug 1484 - StatisticManager performance improvement refactoring

* migration to new MD-SAL API (DataBroker DataChangeListener)
* splitting project api/impl + (javaDoc for api)
* clean pom.xml (xtend dependency and private-package, add sal-binding-broker-impl for test)
* chaining req/resp StatisticNotification per FlowNode per statistic for prevent DS and RPC queue overload
* add multipart msg joiner (StatManager wait for all relevant multipart msg for notification before write relevant
Oper/DS action) - possibility to remove all not used subtrees (target -> reflect actual device contain asap for
all alien node's data).
* add FlowNode registratration - registration needs all SwitchFuture information for make a correct Stat target list (flows,
groups, meters, queues, tables, nrOfTables, ports) - fix for sending not supported notifications to device
* add logic for unique identification FlowId - DeviceFlow (create unique tweens FlowId and flowHash from responded device
flow fields like match, priority, flowCookie, flowCookieMask)
* change FlowCookieMap to FlowHashMap -> List<FlowHash, FlowId>
* implement parallel statistics collecting for FlowCapableNode Sets
* add MockTestSuite for a StatManager workflow interaction testing (neet to be fixed for newest changes)

PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-base-of13
PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-karaf-l2switch-only/
PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-karaf-compatible-min/

Change-Id: I265b57378fc19573d6f18036825cb57f4131ca80
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
7 years agoMerge "Bug 1025: Fixed incorrect revision in sal-remote-augment, which caused log...
Ed Warnicke [Mon, 22 Sep 2014 18:31:51 +0000 (18:31 +0000)]
Merge "Bug 1025: Fixed incorrect revision in sal-remote-augment, which caused log polution."

7 years agoMerge "Bug 1309 - Cannot publish LinkDiscovered event"
Tony Tkacik [Mon, 22 Sep 2014 18:29:28 +0000 (18:29 +0000)]
Merge "Bug 1309 - Cannot publish LinkDiscovered event"

7 years agoMerge "Bug 963 - OSGi error in Topology manager component - After exiting mininet...
Tony Tkacik [Mon, 22 Sep 2014 18:28:40 +0000 (18:28 +0000)]
Merge "Bug 963 - OSGi error in Topology manager component - After exiting mininet of13 simulation"

7 years agoBug 1860: increase max permgen in karaf for windows 37/11337/3
Ryan Moats [Thu, 18 Sep 2014 20:52:03 +0000 (15:52 -0500)]
Bug 1860: increase max permgen in karaf for windows

Move file to proper place

Change-Id: Ib9da0ac05b8747ae59aa989c131b9f45d82b2495
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoBug 1025: Fixed incorrect revision in sal-remote-augment, which caused log polution. 47/11447/1
Tony Tkacik [Mon, 22 Sep 2014 15:12:13 +0000 (17:12 +0200)]
Bug 1025: Fixed incorrect revision in sal-remote-augment, which caused log polution.

Change-Id: I5db5bfb43217d21bad58c913de8dedac5d7cdf23
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoMerge "BUG-1845: implement proper shutdown sequence"
Tony Tkacik [Mon, 22 Sep 2014 14:13:03 +0000 (14:13 +0000)]
Merge "BUG-1845: implement proper shutdown sequence"

7 years agoMerge "Bug 1915: Configuration knob for enabling L3 forwarding in OVSDB"
Ed Warnicke [Mon, 22 Sep 2014 14:00:28 +0000 (14:00 +0000)]
Merge "Bug 1915: Configuration knob for enabling L3 forwarding in OVSDB"

7 years agoMerge "Bug 2014: Workaround for karaf listFeatures bug"
Tony Tkacik [Mon, 22 Sep 2014 12:36:53 +0000 (12:36 +0000)]
Merge "Bug 2014: Workaround for karaf listFeatures bug"

7 years agoBug 1915: Configuration knob for enabling L3 forwarding in OVSDB 33/11333/3
Flavio Fernandes [Thu, 18 Sep 2014 19:38:29 +0000 (15:38 -0400)]
Bug 1915: Configuration knob for enabling L3 forwarding in OVSDB

Change-Id: Ic71708b0f4e2dccdfc789d392b8722b68b5ace1f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoBug 2014: Workaround for karaf listFeatures bug 31/11431/2
Ed Warnicke [Mon, 22 Sep 2014 03:01:42 +0000 (22:01 -0500)]
Bug 2014: Workaround for karaf listFeatures bug

karaf FeatureService.listInstalledFeatures() sometimes
throws a ConcurrentModificationException, this workaround
retries to make sure we succeed.

Change-Id: I4e307d5daba683dfc1b44b6524ce40b3b0e59d1b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug 1309 - Cannot publish LinkDiscovered event 37/11437/1
Jan Hajnar [Thu, 11 Sep 2014 13:50:10 +0000 (15:50 +0200)]
Bug 1309 - Cannot publish LinkDiscovered event

* added back MD_SAL_TYPE for nodeConnectorId and nodeId for case when
nodeId and NodeConnectorId are not in openflow format (NodeId and
NodeConnector Ids are strings)
* added test that shows

Change-Id: I73438a14b0b32a9fd3b0bc311663ad29b7bd7dd1
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
7 years agoMerge "Bug 1850 - The earlier patch missed out on removing the unnecessary call to...
Madhu Venugopal [Mon, 22 Sep 2014 06:27:54 +0000 (06:27 +0000)]
Merge "Bug 1850 - The earlier patch missed out on removing the unnecessary call to INeutronLoadBalancerPoolMemberCRUD. This cleans that up."

7 years agoMerge "Bug 2002 Importing javax.ws.rs.ext explicitly which helps in some cases."
Ed Warnicke [Mon, 22 Sep 2014 03:10:53 +0000 (03:10 +0000)]
Merge "Bug 2002 Importing javax.ws.rs.ext explicitly which helps in some cases."

7 years agoBug 963 - OSGi error in Topology manager component - After exiting 33/11233/6
Jan Hajnar [Tue, 16 Sep 2014 13:07:17 +0000 (15:07 +0200)]
Bug 963 - OSGi error in Topology manager component - After exiting
mininet of13 simulation

* added check in onLinkRemoved() to check if link exists before
atempting to delete it (without check, lots of datastore transaction
errors were displayed on mininet shutdown because links were already
removed with nodes)
* added checks to check if node, connector or link exists before trying
to remove it (reads are cheap and delete exception can break the
transaction chain)
* made reads synchronous
* added illegalState exception handling to operation processor
* made affected links removal to be in the same transaction as
Node/NodeConnector removal(creating and applying snapshot for each link
is expensive)
* updated tests

Change-Id: Icef03a02bbfb88a7cebd0fe35e4b713dcfeb317c
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
7 years agoMerge "Bug-1978:Leader initializes commit index to last index"
Moiz Raja [Sun, 21 Sep 2014 23:05:46 +0000 (23:05 +0000)]
Merge "Bug-1978:Leader initializes commit index to last index"

7 years agoBug#1961 - Missing recource in the XSQL Karaf Command 41/11341/3
Sharon Aicler [Thu, 18 Sep 2014 21:44:50 +0000 (14:44 -0700)]
Bug#1961 - Missing recource in the XSQL Karaf Command

Change-Id: I718dbd67e6478deea4c42b434bbaa74821bdbbac
Signed-off-by: Sharon Aicler <saichler@cisco.com>
7 years agoBug 1948: Separate out restconf features. 23/11423/1
Ed Warnicke [Thu, 18 Sep 2014 11:59:43 +0000 (06:59 -0500)]
Bug 1948: Separate out restconf features.

In order to avoid a maven project cycle in solving
Bug 1948, we need to separate restconf features.

Note, this is a first step, suffixing everything
with -new.  Subsquently, after everywhere using
odl-restconf has been fixed to use this new repo,
we will deprecate the ones in the mdsal features.xml
and rename these to not have the -new.

Change-Id: I80451e055c071b30a1d0a83ec5a5c14c41afb586
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug-1978:Leader initializes commit index to last index 91/11391/4
Kamal Rameshan [Sat, 20 Sep 2014 00:43:32 +0000 (17:43 -0700)]
Bug-1978:Leader initializes commit index to last index

Change-Id: Ic42a14911e8ff4db40fde2a917c8cb2edf412c76
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoMerge "BUG-1866: sal-compatibility does not register some services"
Ed Warnicke [Sun, 21 Sep 2014 14:32:49 +0000 (14:32 +0000)]
Merge "BUG-1866: sal-compatibility does not register some services"

7 years agoBug 2002 Importing javax.ws.rs.ext explicitly which helps in some cases. 07/11407/2
Madhu Venugopal [Sat, 20 Sep 2014 23:49:54 +0000 (16:49 -0700)]
Bug 2002 Importing javax.ws.rs.ext explicitly which helps in some cases.

We still are trying to figure out the root-cause & this failure has been very random in different setups.

Change-Id: I38da0e23885c2fc4a39d69048c69459f8ac8fc84
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
7 years agoBUG-1866: sal-compatibility does not register some services 00/11400/2
Michal Rehak [Sat, 20 Sep 2014 12:11:11 +0000 (14:11 +0200)]
BUG-1866: sal-compatibility does not register some services

- fixed service wiring
- involved statistics collected by statisticsManager (instead fresh request)

Change-Id: I9914dd7e9b20c87d77f7b5350abb9f5c8ba02c0f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agoBug 1971 : Removing the bounded queue while actor creation to avoid issues in recovery 90/11390/3
Harman Singh [Sat, 20 Sep 2014 00:28:58 +0000 (17:28 -0700)]
Bug 1971 : Removing the bounded queue while actor creation to avoid issues in recovery

Change-Id: I1c423ee0edf2a9b5bc9354f7ddc07150c700d4d3
Signed-off-by: Harman Singh <harmasin@cisco.com>
7 years agoMerge "BUG-1953: fix bad values in netconf monitoring test"
Tony Tkacik [Sat, 20 Sep 2014 14:46:54 +0000 (14:46 +0000)]
Merge "BUG-1953: fix bad values in netconf monitoring test"

7 years agoBUG-1953: fix bad values in netconf monitoring test 83/11383/1
Robert Varga [Fri, 19 Sep 2014 19:40:36 +0000 (21:40 +0200)]
BUG-1953: fix bad values in netconf monitoring test

Uses string values which do not match the format prescribed by the
model. Fix them.

Change-Id: I55efcdd87aea24bcfd805a865319fe324e663768
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "bug 1888 - FRM Flow Listener registration fail"
Tony Tkacik [Fri, 19 Sep 2014 11:12:32 +0000 (11:12 +0000)]
Merge "bug 1888 - FRM Flow Listener registration fail"

7 years agoMerge "Bug 1963: Fix missing bundle in xsql feature"
Moiz Raja [Fri, 19 Sep 2014 05:35:30 +0000 (05:35 +0000)]
Merge "Bug 1963: Fix missing bundle in xsql feature"

7 years agoBug#1955 - Avoid the bug condition in XSQL 45/11345/2
Sharon Aicler [Thu, 18 Sep 2014 22:58:22 +0000 (15:58 -0700)]
Bug#1955 - Avoid the bug condition in XSQL

Change-Id: I15c8c409ca6bc9aa7c147cdaaa7deca6e640bdcc
Signed-off-by: Sharon Aicler <saichler@cisco.com>
7 years agoBug 1970: Disabling NetconfITSecureTest test 51/11351/1
Ed Warnicke [Fri, 19 Sep 2014 02:38:22 +0000 (21:38 -0500)]
Bug 1970: Disabling NetconfITSecureTest test

Change-Id: Id937c37cd237ee4340a0e8e5bd63561d1e1afe21
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug 1963: Fix missing bundle in xsql feature 28/11328/4
Ed Warnicke [Thu, 18 Sep 2014 15:37:24 +0000 (10:37 -0500)]
Bug 1963: Fix missing bundle in xsql feature

Change-Id: Ieedf3f07bc85110c8c0e4be2d73612311ed5074c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBUG-1845: implement proper shutdown sequence 31/11331/1
Robert Varga [Thu, 18 Sep 2014 17:35:52 +0000 (19:35 +0200)]
BUG-1845: implement proper shutdown sequence

The notification chain should only invoke the successful callback once
all transactions have been committed successfully. This patch does
precisely that by tracking the number of outstanding transactions. Since
this requires notification about successful transactions, too, we get
rid of the unneeded DOMDataCommitErrorInvoker/Listener abstraction.

Change-Id: I38534a3fb79a8a461059504de7b0cdd48348afef
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Bug-1903:On recovery all replicated log entries should not be applied to state"
Moiz Raja [Thu, 18 Sep 2014 16:30:45 +0000 (16:30 +0000)]
Merge "Bug-1903:On recovery all replicated log entries should not be applied to state"

7 years agoMerge "Bug 1763: Fixed illegal state in Binding Transaction Chain."
Ed Warnicke [Thu, 18 Sep 2014 16:02:48 +0000 (16:02 +0000)]
Merge "Bug 1763: Fixed illegal state in Binding Transaction Chain."

7 years agoBug 1831 Batch messages on journal recovery 36/11136/11
tpantelis [Sun, 31 Aug 2014 15:15:18 +0000 (11:15 -0400)]
Bug 1831 Batch messages on journal recovery

Added journal log recovery batching support in RaftActor along with
additonal abstract methods for granular recovery control.

It turns out that batching helps a little but the real performance hog
was deserialization. There was a couple inefficient PreConditions in the
NormalizedNodeSerializer (unwanted String concats in the fast path) that
accounted for significant performance degradation. I also made a few
other minor performance enhancements.

Although deserialization is much better with the fixes, I also
implemented some parallelization during shard recovery. I added a
ShardRecoveryCoordinator class that parallelizes deserialization
of journal log enry batches and snapshots for faster recovery time.
The resulting transactions are still committed to the data store in the
order the corresponding snapshot or log batch are received to preserve
data store integrity.

The journal recovery log batch size is configurable vai the config XML.
I also made the shard heartbeat interval and shard snapshot batch count
configurable.
`
Change-Id: I52ef1690bfb6cc486c329ee60f77c52720c24469
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoBUG 1815 - Do not allow Shards to be created till an appropriate schema context is... 46/11346/4
Moiz Raja [Thu, 18 Sep 2014 17:54:47 +0000 (10:54 -0700)]
BUG 1815 - Do not allow Shards to be created till an appropriate schema context is available

The fix works like so,
- ShardManager maintains a list of all the modules that it ever knew about
- ShardManager persists the known modules to disk using persistence
- When ShardManager recovers it reads back the knownModules from persistence
- As ShardManager gets new SchemaContext's it checks whether the modules in
  the new SchemaContext are a superset of the knownModules. If they are then
  ShardManager persists it and let's the Shards know about the new SchemaContext
  otherwise the new SchemaContext is rejected and a message is logged

Also reduced the log level of some log messages in RaftActor from info to debug
it was too verbose

Change-Id: If388f690114c58e6a8df30f34ddac32a99f255e5
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoMerge "Bug 1876 - Added missing parent tag to pom files"
Ed Warnicke [Fri, 19 Sep 2014 19:44:20 +0000 (19:44 +0000)]
Merge "Bug 1876 - Added missing parent tag to pom files"

7 years agoBug 1963 - Fix bad dependency in sal-karaf-xsql 75/11375/1
Devin Avery [Fri, 19 Sep 2014 17:16:14 +0000 (13:16 -0400)]
Bug 1963 - Fix bad dependency in sal-karaf-xsql

Change-Id: I2b9b1d2764f7c65cc2990c715928b05875b12c3c
Signed-off-by: Devin Avery <devin.avery@brocade.com>
7 years agoBUG-1949 Fix race condition in AsyncSshHandler 29/11329/3
Maros Marsalek [Thu, 18 Sep 2014 15:58:48 +0000 (17:58 +0200)]
BUG-1949 Fix race condition in AsyncSshHandler

Remove pending limit due to unexpected behaviour with chunked messages.
Extract Reader/Writer into separate classes.

Also lower the amount of requests sent in SSH Stress integration test.

Change-Id: Idff719ac3a6bed9e8939efa01b8306f2884848fe
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-509: remove HashMapDataStore 33/7433/9
Robert Varga [Sun, 14 Sep 2014 22:21:12 +0000 (00:21 +0200)]
BUG-509: remove HashMapDataStore

The HashMapDataStore is not something we want to ship in Helium -- it
is utterly obsolete and defunct. So just remove it.

Change-Id: I62977f0f897752a388673f977222c79ff55062f0
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "BUG-692 Fix major issues reported by sonar for netconf subsystem"
Tony Tkacik [Thu, 18 Sep 2014 12:56:57 +0000 (12:56 +0000)]
Merge "BUG-692 Fix major issues reported by sonar for netconf subsystem"

7 years agoBUG-1521 netconf-util line coverage 79/11279/5
Filip Tehlar [Wed, 17 Sep 2014 10:39:29 +0000 (12:39 +0200)]
BUG-1521 netconf-util line coverage

Change-Id: I90fc67622d95fa1b1e06fcf3c10a4d0ea40000c4
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoBUG-692 Fix major issues reported by sonar for netconf subsystem 90/11290/2
Maros Marsalek [Wed, 17 Sep 2014 14:11:14 +0000 (16:11 +0200)]
BUG-692 Fix major issues reported by sonar for netconf subsystem

Change-Id: I2f7cd479a773b7c3edc111c45add8ab5510fb47f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "BUG - 1756 - changed tableId's comparison"
Ed Warnicke [Thu, 18 Sep 2014 02:45:26 +0000 (02:45 +0000)]
Merge "BUG - 1756  - changed tableId's comparison"

7 years agoMerge "Bug 1817 - Have the md-sal-broker feature reference the yangmodels feature...
Ed Warnicke [Wed, 17 Sep 2014 20:59:53 +0000 (20:59 +0000)]
Merge "Bug 1817 - Have the md-sal-broker feature reference the yangmodels feature (which are core yangs)"

7 years agoMerge "BUG-1542 Remove netconf-ssh|tcp features from netconf-all feature"
Ed Warnicke [Wed, 17 Sep 2014 20:48:32 +0000 (20:48 +0000)]
Merge "BUG-1542 Remove netconf-ssh|tcp features from netconf-all feature"

7 years agoMerge "Bug-1928:TestDriver, fix stop and reinstateNode"
Moiz Raja [Wed, 17 Sep 2014 18:26:49 +0000 (18:26 +0000)]
Merge "Bug-1928:TestDriver, fix stop and reinstateNode"

7 years agoBug-1903:On recovery all replicated log entries should not be applied to state 69/11269/4
Kamal Rameshan [Wed, 17 Sep 2014 06:15:32 +0000 (23:15 -0700)]
Bug-1903:On recovery all replicated log entries should not be applied to state

Change-Id: I8b246a813d0e2afb723510cfd187b2d411caab6b
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
7 years agoMerge "BUG-650: fix benchmark compilation"
Tony Tkacik [Wed, 17 Sep 2014 14:09:09 +0000 (14:09 +0000)]
Merge "BUG-650: fix benchmark compilation"

7 years agoMerge "BUG-1933: consult state in subtree modified path"
Tony Tkacik [Wed, 17 Sep 2014 14:08:58 +0000 (14:08 +0000)]
Merge "BUG-1933: consult state in subtree modified path"

7 years agoBUG - 1756 88/11288/1
Timotej Kubas [Wed, 17 Sep 2014 12:42:17 +0000 (14:42 +0200)]
BUG - 1756
 - changed tableId's comparison

Change-Id: I81caa80c680052faffc54e34cbc33022ee32adf8
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
7 years agoBUG-650: fix benchmark compilation 80/11280/1
Robert Varga [Wed, 17 Sep 2014 09:49:27 +0000 (11:49 +0200)]
BUG-650: fix benchmark compilation

The datastore needs a ListeningExecutorService, so wrap the one we have
instantiating here.

Change-Id: I25c0af24839510265b9d5c4d3386a199af287838
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "BUG 1659 - non unified returning data default format"
Tony Tkacik [Wed, 17 Sep 2014 11:21:52 +0000 (11:21 +0000)]
Merge "BUG 1659 - non unified returning data default format"

7 years agoMerge "Bug 1926: fixed features/mdsal/pom.xml dependencies"
Tony Tkacik [Wed, 17 Sep 2014 11:21:14 +0000 (11:21 +0000)]
Merge "Bug 1926: fixed features/mdsal/pom.xml dependencies"

7 years agoMerge "BUG-1842 Fix byte buffer handling for pending messages"
Tony Tkacik [Wed, 17 Sep 2014 10:45:28 +0000 (10:45 +0000)]
Merge "BUG-1842 Fix byte buffer handling for pending messages"

7 years agoMerge "BUG-1393 Fix ignoring module based capabilities in sal-netconf-connector"
Tony Tkacik [Wed, 17 Sep 2014 10:45:18 +0000 (10:45 +0000)]
Merge "BUG-1393 Fix ignoring module based capabilities in sal-netconf-connector"

7 years agoMerge "Bug 1726 : Adding test-case to check Install Snapshot functionality is handled...
Moiz Raja [Wed, 17 Sep 2014 10:13:07 +0000 (10:13 +0000)]
Merge "Bug 1726 : Adding test-case to check Install Snapshot functionality is handled correctly"

7 years agoBUG-1933: consult state in subtree modified path 81/11281/1
Robert Varga [Wed, 17 Sep 2014 09:34:57 +0000 (11:34 +0200)]
BUG-1933: consult state in subtree modified path

resolveSubtreeChangeEvent() was missing a state.needsProcessing() check,
which means change resolution continued down that path eventhough no
listeners were subscribed to it. Add the check and return with a true if
we terminate early.

Change-Id: I7d386f3abd67c1a241ad88b5809236598dc967dd
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG 1659 - non unified returning data default format 34/11234/2
Jozef Gloncak [Tue, 16 Sep 2014 12:59:34 +0000 (14:59 +0200)]
BUG 1659 - non unified returning data default format

Returning value (errors and data) will be by default in JSON format

Change-Id: I65368da31b1364c3e8153d39ab66e1fd8ecc49d3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoBug-1928:TestDriver, fix stop and reinstateNode 70/11270/1
Kamal Rameshan [Wed, 17 Sep 2014 06:35:58 +0000 (23:35 -0700)]
Bug-1928:TestDriver, fix stop and reinstateNode

Change-Id: I115da9b5b32b3e1a71f04bc2185df1d15e1ac205
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
7 years agoMerge "Bug 1808: Don't deserialize IPv4 payload in non-first fragments."
Alessandro Boch [Wed, 17 Sep 2014 05:42:42 +0000 (05:42 +0000)]
Merge "Bug 1808: Don't deserialize IPv4 payload in non-first fragments."

7 years agoMerge "Bug 1805: Fixed 2 bugs in ICMP.computeChecksum()."
Alessandro Boch [Wed, 17 Sep 2014 05:39:50 +0000 (05:39 +0000)]
Merge "Bug 1805: Fixed 2 bugs in ICMP.computeChecksum()."

7 years agoBug 1726 : Adding test-case to check Install Snapshot functionality is handled correctly 72/10872/8
Debolina Bandyopadhyay [Sat, 6 Sep 2014 00:52:49 +0000 (17:52 -0700)]
Bug 1726 : Adding test-case to check Install Snapshot functionality is handled correctly

Change-Id: Ia130d690f5009a8252e8e78a76e60479ea4fcc1f
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
7 years agoBug 1926: fixed features/mdsal/pom.xml dependencies 65/11265/1
Ed Warnicke [Wed, 17 Sep 2014 04:15:58 +0000 (23:15 -0500)]
Bug 1926: fixed features/mdsal/pom.xml dependencies

Change-Id: I40fad4d7140d9c6ebaf60c23bbdb4ac8f7767a40
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "BUG-1759: SET_NW_TOS action values"
Ed Warnicke [Tue, 16 Sep 2014 18:57:27 +0000 (18:57 +0000)]
Merge "BUG-1759: SET_NW_TOS action values"

7 years agoMerge "Bug 1894: Add LISP configuration options to etc/custom.properties in Karaf"
Madhu Venugopal [Tue, 16 Sep 2014 17:49:02 +0000 (17:49 +0000)]
Merge "Bug 1894: Add LISP configuration options to etc/custom.properties in Karaf"

7 years agoBUG-1759: SET_NW_TOS action values 32/11132/2
Michal Rehak [Sat, 13 Sep 2014 10:08:20 +0000 (12:08 +0200)]
BUG-1759: SET_NW_TOS action values

- changed adapters in sal-compatibility to switch:
  - AD-SAL to MD-SAL = DSCP to TOS (no ENC present)
  - MD-SAL to AD-SAL = TOS to DSCP (ENC destroyed)

Change-Id: Ie4954f4c76fc19e70f27a41df0a1a65907acade4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agoMerge "Bug 1904: Handle null ThreadExecutorStatsMXBeanImpl in ShardStats"
Moiz Raja [Tue, 16 Sep 2014 15:29:29 +0000 (15:29 +0000)]
Merge "Bug 1904: Handle null ThreadExecutorStatsMXBeanImpl in ShardStats"

7 years agobug 1888 - FRM Flow Listener registration fail 02/11202/2
Jan Hajnar [Tue, 16 Sep 2014 14:01:02 +0000 (16:01 +0200)]
bug 1888 - FRM Flow Listener registration fail

* sometimes BindingAware doesn't load codec, so FRM try to register listener 5x and after rise IllegalStateException
system needs to start again.

Change-Id: I47def2f4ebd6605eb00942ed56f762cb7465592e
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
7 years agoMerge "Bug 1892 - Karaf setenv should use '=' instead of '=='"
Tony Tkacik [Tue, 16 Sep 2014 12:45:12 +0000 (12:45 +0000)]
Merge "Bug 1892 - Karaf setenv should use '=' instead of '=='"

7 years agoBUG-1393 Fix ignoring module based capabilities in sal-netconf-connector 35/9135/5
Maros Marsalek [Tue, 16 Sep 2014 12:11:06 +0000 (14:11 +0200)]
BUG-1393 Fix ignoring module based capabilities in sal-netconf-connector

If a capability for yang module was advertised without revision, it was ignored.

Change-Id: I7b6db7efdbec02c2bea3771f39e1d0e81cf9783d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-1842 Fix byte buffer handling for pending messages 28/11228/1
Maros Marsalek [Tue, 16 Sep 2014 11:22:57 +0000 (13:22 +0200)]
BUG-1842 Fix byte buffer handling for pending messages

Change-Id: I54cd873e12d73779e20be280226480d090d9e8c5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "Bug-1829:Commit index of follower not changed after Snapshot applied on recovery."
Moiz Raja [Tue, 16 Sep 2014 11:30:15 +0000 (11:30 +0000)]
Merge "Bug-1829:Commit index of follower not changed after Snapshot applied on recovery."

7 years agoBug 1876 - Added missing parent tag to pom files 62/10462/5
Devin Avery [Thu, 28 Aug 2014 18:59:05 +0000 (14:59 -0400)]
Bug 1876 - Added missing parent tag to pom files

    Some pom files were missing the parent tag even
    though they were still referenced from a parent
    pom file in terms of building.

    By adding a logical parent pom reference in
    we are able to inherit properties, specifically
    the distributionManagement tag (which should
    not be defined in every tag pom).

Change-Id: I812bb3377bdb3a74ccded4d73639b465ffcc688c
Signed-off-by: Devin Avery <devin.avery@brocade.com>
7 years agoMerge "Bug 1875 - Used variables for nexusproxy host, externalized versions"
Tony Tkacik [Tue, 16 Sep 2014 11:17:39 +0000 (11:17 +0000)]
Merge "Bug 1875 - Used variables for nexusproxy host, externalized versions"

7 years agoBug 1817 - Have the md-sal-broker feature reference the yangmodels feature (which... 65/11065/5
Devin Avery [Thu, 11 Sep 2014 18:00:16 +0000 (14:00 -0400)]
Bug 1817 - Have the md-sal-broker feature reference the yangmodels feature (which are core yangs)

Change-Id: I771d78b7d03d2b8c45fcf2c00c9701bed7e034e4
Signed-off-by: Devin Avery <devin.avery@brocade.com>
7 years agoMerge "Bug 1819 - Moved bundle up in features.xml to avoid exception in log Change...
Tony Tkacik [Tue, 16 Sep 2014 10:32:53 +0000 (10:32 +0000)]
Merge "Bug 1819 - Moved bundle up in features.xml to avoid exception in log   Change-Id: Icbd3d8957d38ca74797c11f2c60683fa017c3246 Signed-off-by: Devin Avery <devin.avery@brocade.com>"

7 years agoBug-1829:Commit index of follower not changed after Snapshot applied on recovery. 82/11182/3
Kamal Rameshan [Mon, 15 Sep 2014 05:48:31 +0000 (22:48 -0700)]
Bug-1829:Commit index of follower not changed after Snapshot applied on recovery.

Change-Id: Id2e30f6756e5d71886ddb8ab3f3b095f03352b0a
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
7 years agoMerge "BUG 1883 - Ensure that all debug logging is done conditionally"
Moiz Raja [Tue, 16 Sep 2014 10:22:28 +0000 (10:22 +0000)]
Merge "BUG 1883 - Ensure that all debug logging is done conditionally"

7 years agoMerge "Bug 1688: Fix IllegalStateEx from FlowCapableTopologyExporter"
Moiz Raja [Tue, 16 Sep 2014 09:59:09 +0000 (09:59 +0000)]
Merge "Bug 1688: Fix IllegalStateEx from FlowCapableTopologyExporter"

7 years agoBUG 1883 - Ensure that all debug logging is done conditionally 18/11218/4
Harman Singh [Tue, 16 Sep 2014 00:14:17 +0000 (17:14 -0700)]
BUG 1883 - Ensure that all debug logging is done conditionally

This commit is mostly about conditional logging.

It also sneaks in a couple of other things,
1. Cleanup of ClientRequestTracker
2. Removal of some dead code

Change-Id: I0862f1273e94856e19107d3a4beec4d66452787d
Signed-off-by: Moiz Raja <moraja@cisco.com>
Signed-off-by: Harman Singh <harmasin@cisco.com>
7 years agoMerge "Bug 1804: the condition was not working correctly to report leader"
Moiz Raja [Tue, 16 Sep 2014 00:26:17 +0000 (00:26 +0000)]
Merge "Bug 1804: the condition was not working correctly to report leader"

7 years agoBug 1850 - The earlier patch missed out on removing the unnecessary 17/11217/1
Srini Seetharaman [Tue, 16 Sep 2014 00:09:38 +0000 (17:09 -0700)]
Bug 1850 - The earlier patch missed out on removing the unnecessary
call to INeutronLoadBalancerPoolMemberCRUD. This cleans that up.

Change-Id: I3aeb163e334a527a66d7752b53f4e6837e1ef56a
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
7 years agoMerge "Bug#1854 - Exit command in console causing OOM."
Moiz Raja [Mon, 15 Sep 2014 23:25:21 +0000 (23:25 +0000)]
Merge "Bug#1854 - Exit command in console causing OOM."