controller.git
7 years agoMerge "Fix a few eclipse-reported warnings"
Ed Warnicke [Mon, 10 Feb 2014 23:36:04 +0000 (23:36 +0000)]
Merge "Fix a few eclipse-reported warnings"

7 years agoMerge "Get rid of NetconfMessageFactory"
Ed Warnicke [Mon, 10 Feb 2014 19:44:20 +0000 (19:44 +0000)]
Merge "Get rid of NetconfMessageFactory"

7 years agoMerge "Get rid of DeserializerException"
Ed Warnicke [Mon, 10 Feb 2014 19:44:01 +0000 (19:44 +0000)]
Merge "Get rid of DeserializerException"

7 years agoMerge "Get rid of using ProtocolHandlerFactory, part 2"
Ed Warnicke [Mon, 10 Feb 2014 19:43:32 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 2"

7 years agoMerge "Get rid of using ProtocolHandlerFactory, part 1"
Ed Warnicke [Mon, 10 Feb 2014 19:43:22 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 1"

7 years agoMerge "Cleanup dependencyManagement section"
Ed Warnicke [Mon, 10 Feb 2014 19:42:50 +0000 (19:42 +0000)]
Merge "Cleanup dependencyManagement section"

7 years agoMerge "Remove repositories/pluginRepositories/distributionManagement"
Ed Warnicke [Mon, 10 Feb 2014 19:41:45 +0000 (19:41 +0000)]
Merge "Remove repositories/pluginRepositories/distributionManagement"

7 years agoMerge "Remove duplicate properties"
Ed Warnicke [Mon, 10 Feb 2014 19:41:24 +0000 (19:41 +0000)]
Merge "Remove duplicate properties"

7 years agoMerge "SwitchMgrNB: URL does not allow nodeconnectorId with forward slash"
Alessandro Boch [Mon, 10 Feb 2014 19:33:00 +0000 (19:33 +0000)]
Merge "SwitchMgrNB: URL does not allow nodeconnectorId with forward slash"

7 years agoFix for BUG 410 32/5232/3
Ryan Moats [Mon, 10 Feb 2014 18:02:16 +0000 (12:02 -0600)]
Fix for BUG 410

Ensure lower case alpha hex representation is included in MAC
regex match in all cases.

Change-Id: Ic2da17146cf8f9325cc5d951f70d614ec61762a0
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoSwitchMgrNB: URL does not allow nodeconnectorId with forward slash 06/5206/2
Pramila Singh [Sun, 9 Feb 2014 00:15:10 +0000 (16:15 -0800)]
SwitchMgrNB: URL does not allow nodeconnectorId with forward slash

Change-Id: I489d5ae559b8c1e35a3c7b9749f7476618b2765b
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoMerge "Fixed bugs in getUnsigned methods of NetUtils class."
Alessandro Boch [Mon, 10 Feb 2014 16:49:34 +0000 (16:49 +0000)]
Merge "Fixed bugs in getUnsigned methods of NetUtils class."

7 years agoCleanup dependencyManagement section 44/4744/4
Robert Varga [Fri, 24 Jan 2014 22:37:13 +0000 (23:37 +0100)]
Cleanup dependencyManagement section

Change-Id: I48ab30fc7f96ab0a30e1094f8f9ca5097be0975b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove repositories/pluginRepositories/distributionManagement 43/4743/4
Robert Varga [Fri, 24 Jan 2014 22:30:03 +0000 (23:30 +0100)]
Remove repositories/pluginRepositories/distributionManagement

Change-Id: I1d005ee4ea4881d79c368a009ae2dfa1d643746a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of NetconfMessageFactory 88/5188/2
Robert Varga [Fri, 7 Feb 2014 22:15:56 +0000 (23:15 +0100)]
Get rid of NetconfMessageFactory

This removes the use of deprecated ProtocolMessageFactory and
ProtocolHandlerFactory. Just instantiate appropriate Netty handlers
instead.

Change-Id: I98b6424af0256483be21c92dfdbe4c0ddbac7a9d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of DeserializerException 87/5187/2
Robert Varga [Fri, 7 Feb 2014 21:19:43 +0000 (22:19 +0100)]
Get rid of DeserializerException

We can throw anything, so use NetconfDeserializerException instead.

Change-Id: Ibf2b7f2778217b19e7b4aaf22571f19fdf3f610f
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of using ProtocolHandlerFactory, part 2 86/5186/2
Robert Varga [Fri, 7 Feb 2014 21:08:39 +0000 (22:08 +0100)]
Get rid of using ProtocolHandlerFactory, part 2

Now that we do not rely on passing it around, we can safely keep
NetconfHandlerFactory wired directly to the
ProtocolMessageEncoder/Decoder.

Change-Id: I47a9b76f8d9bbb98304e06960e5a85d2730994f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of using ProtocolHandlerFactory, part 1 85/5185/3
Robert Varga [Fri, 7 Feb 2014 20:57:07 +0000 (21:57 +0100)]
Get rid of using ProtocolHandlerFactory, part 1

This gets rid of completely dead code in NetconfSshClientDispatcher. It
already talks directly to the initializer.

Change-Id: Ieaac37a3335e87032730cfa65e94bb59f26dd3c1
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove duplicate properties 42/4742/4
Robert Varga [Fri, 24 Jan 2014 22:28:48 +0000 (23:28 +0100)]
Remove duplicate properties

Change-Id: If079f0051241989a4f71e0ac8fa42f3a80e27182
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Cleanup imports/whitespace in MD-SAL"
Ed Warnicke [Mon, 10 Feb 2014 12:20:21 +0000 (12:20 +0000)]
Merge "Cleanup imports/whitespace in MD-SAL"

7 years agoMerge "Adding FlowRef,GroupRef and MeterRef for the ErrorNotification Message"
Ed Warnicke [Mon, 10 Feb 2014 11:56:41 +0000 (11:56 +0000)]
Merge "Adding FlowRef,GroupRef and MeterRef for the ErrorNotification Message"

7 years agoMerge "BUG-362: add some diagnostic information Changed Remote RPC Server Implementat...
Ed Warnicke [Mon, 10 Feb 2014 11:55:41 +0000 (11:55 +0000)]
Merge "BUG-362: add some diagnostic information Changed Remote RPC Server Implementation to log an error when host IP address is not found and stop itself. Earlier it would raise exception that the configuration subsystem could not handle."

7 years agoCleanup imports/whitespace in MD-SAL 83/5183/3
Robert Varga [Fri, 7 Feb 2014 20:01:21 +0000 (21:01 +0100)]
Cleanup imports/whitespace in MD-SAL

Change-Id: I0f18ffe229ed213308a0cd5cf343fd64ff79a17c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "BUG 408"
Ed Warnicke [Mon, 10 Feb 2014 11:53:48 +0000 (11:53 +0000)]
Merge "BUG 408"

7 years agoFixed bugs in getUnsigned methods of NetUtils class. 21/5021/2
Hideyuki Tai [Thu, 30 Jan 2014 10:17:25 +0000 (02:17 -0800)]
Fixed bugs in getUnsigned methods of NetUtils class.

 * Fixed bugs that getUnsignedByte(byte) and getUnsignedShort(short)
   handled 0 incorrectly.
 * Added tests for getUnsignedByte(byte) and getUnsignedShort(short).

Change-Id: Ie67fb5c07bed31d16d4a52068dda7735fb7cd5e2
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
7 years agoMerge "Fix incorrect validation in SwitchConfig"
Andrew Kim [Sat, 8 Feb 2014 01:11:35 +0000 (01:11 +0000)]
Merge "Fix incorrect validation in SwitchConfig"

7 years agoFix incorrect validation in SwitchConfig 72/5172/2
Alessandro Boch [Fri, 7 Feb 2014 14:20:03 +0000 (06:20 -0800)]
Fix incorrect validation in SwitchConfig

Change-Id: Ie9267b97b8742f9bd5ebbd85a4f0dc05bf1cebd9
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix a few eclipse-reported warnings 92/5192/2
Robert Varga [Fri, 7 Feb 2014 23:01:27 +0000 (00:01 +0100)]
Fix a few eclipse-reported warnings

- unused suppresswarnings
- missing serialVersionUuid
- missing generic arguments

Change-Id: Ie741e88bfe161a9e4613b4076892cbcabdd0375c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Lower logger level in OF1.0 Discovery Service"
Andrew Kim [Fri, 7 Feb 2014 17:12:01 +0000 (17:12 +0000)]
Merge "Lower logger level in OF1.0 Discovery Service"

7 years agoBUG 408 74/5174/1
Michal Rehak [Fri, 7 Feb 2014 15:37:35 +0000 (16:37 +0100)]
BUG 408

- added null safe comparison
- added unit test
- added SLF4j
- added log message in method StrIpToIntIp in case of exception

Change-Id: Id15dc4f80d419df5e73ab79fea4e8ab25ec82968
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agooperation, store, path and data properties added to Data change event model 18/5118/5
Martin Bobak [Tue, 4 Feb 2014 13:27:57 +0000 (14:27 +0100)]
operation, store, path and data properties added to Data change event model

Change-Id: I0b1c39e23506988528614b33c4a49cf8e00802ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Fixed publishDataChangeEvent in 2phase commit"
Ed Warnicke [Fri, 7 Feb 2014 06:36:35 +0000 (06:36 +0000)]
Merge "Fixed publishDataChangeEvent in 2phase commit"

7 years agoMerge "Increase timeout for waiting for broker service in sal-binding-it."
Ed Warnicke [Fri, 7 Feb 2014 06:35:34 +0000 (06:35 +0000)]
Merge "Increase timeout for waiting for broker service in sal-binding-it."

7 years agoMerge "Remove unnecessary warn log from config subsystem"
Ed Warnicke [Fri, 7 Feb 2014 06:34:42 +0000 (06:34 +0000)]
Merge "Remove unnecessary warn log from config subsystem"

7 years agoMerge "Fix for bug #236 and bug #240 Have made changes in opendaylight-table-types...
Ed Warnicke [Fri, 7 Feb 2014 06:14:47 +0000 (06:14 +0000)]
Merge "Fix for bug #236 and bug #240 Have made changes in opendaylight-table-types.yang"

7 years agoMerge "Improve netconf negotiator messages"
Ed Warnicke [Fri, 7 Feb 2014 06:14:16 +0000 (06:14 +0000)]
Merge "Improve netconf negotiator messages"

7 years agoMerge "Improve logging in NetconfClient, logging-bridge. Increase connection timeout...
Ed Warnicke [Fri, 7 Feb 2014 06:13:46 +0000 (06:13 +0000)]
Merge "Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector."

7 years agoMerge "Maven archetype for config subsystem aware bundles"
Ed Warnicke [Fri, 7 Feb 2014 06:12:23 +0000 (06:12 +0000)]
Merge "Maven archetype for config subsystem aware bundles"

7 years agoMerge "Fix of bug in Notificator class"
Ed Warnicke [Fri, 7 Feb 2014 06:11:23 +0000 (06:11 +0000)]
Merge "Fix of bug in Notificator class"

7 years agoMerge "Fix Plugin execution not covered in Eclipse for config subsystem"
Ed Warnicke [Fri, 7 Feb 2014 06:10:44 +0000 (06:10 +0000)]
Merge "Fix Plugin execution not covered in Eclipse for config subsystem"

7 years agoLower logger level in OF1.0 Discovery Service 60/5160/1
Alessandro Boch [Fri, 7 Feb 2014 00:40:09 +0000 (16:40 -0800)]
Lower logger level in OF1.0 Discovery Service

- Discovery Service has a function to attempt to snoop
  non controller generated or malformed LLDP frames.
  The whole function block is in a try catch block,
  as exceptions are well expected.
  In case an exception is hit though, the function logs
  it as a warn.
- Change the log level to debug, do not print a stack trace,
  print the source MAC and the port on which it was received.

Change-Id: I82b459b16356b0a57934b3c26c993d20a2b53dc2
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoImprove netconf negotiator messages 24/5124/6
Robert Varga [Wed, 5 Feb 2014 07:36:23 +0000 (08:36 +0100)]
Improve netconf negotiator messages

Change-Id: I8b36f2fa6173055e5fc34783873a55cdf240589d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Requestor FRM to update the sw views on remote execution"
Giovanni Meo [Fri, 7 Feb 2014 00:02:44 +0000 (00:02 +0000)]
Merge "Requestor FRM to update the sw views on remote execution"

7 years agoMerge "Minor change to resource name regex"
Andrew Kim [Thu, 6 Feb 2014 20:33:01 +0000 (20:33 +0000)]
Merge "Minor change to resource name regex"

7 years agoMerge "Fix for BUG 402: Subnet creation with NeutronAPIService sometimes fails with...
Giovanni Meo [Thu, 6 Feb 2014 20:23:00 +0000 (20:23 +0000)]
Merge "Fix for BUG 402: Subnet creation with NeutronAPIService sometimes fails with a 409 error"

7 years agoMinor change to resource name regex 55/5155/2
Alessandro Boch [Thu, 6 Feb 2014 18:32:14 +0000 (10:32 -0800)]
Minor change to resource name regex

Change-Id: Ia087f56b7fd51406e1e81a4b1e7aaf3996f0250d
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMerge "The Switch Event thread is the thread that processes events coming from all...
Jason Ye [Thu, 6 Feb 2014 20:01:43 +0000 (20:01 +0000)]
Merge "The Switch Event thread is the thread that processes events coming from all switches. Right now its very fragile as an unhandled exception can cause the thread to die causing the controller to be unusable. Making the thread more tolerant of exceptions and making the shutdown of the thread more deterministic."

7 years agoFix Plugin execution not covered in Eclipse for config subsystem 52/5152/1
Maros Marsalek [Thu, 6 Feb 2014 15:52:04 +0000 (16:52 +0100)]
Fix Plugin execution not covered in Eclipse for config subsystem

yang-test, yang-test-plugin

Change-Id: I9be015e1221ad9ff143370bb68837e0c55558a3e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoFix of bug in Notificator class 03/5103/4
Jozef Gloncak [Mon, 3 Feb 2014 14:58:26 +0000 (15:58 +0100)]
Fix of bug in Notificator class

Deleting of listner from listenersByStreamName map was corrected
try, finally block was added for locking, unlocking of access to map

Change-Id: I60ecb9c247af18436f348d4f4827c7f75fdfaeaa
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoThe Switch Event thread is the thread that processes events coming from all switches. 42/5142/1
Asad Ahmed [Wed, 5 Feb 2014 23:44:31 +0000 (15:44 -0800)]
The Switch Event thread is the thread that processes events coming from all switches.
Right now its very fragile as an unhandled exception can cause the thread to die causing
the controller to be unusable. Making the thread more tolerant of exceptions and making
the shutdown of the thread more deterministic.

Change-Id: I31c31f012229de8e124c0c13fa651513daaf6776
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
7 years agoMerge changes I8290457c,If84199a1
Jason Ye [Wed, 5 Feb 2014 20:11:38 +0000 (20:11 +0000)]
Merge changes I8290457c,If84199a1

* changes:
  Stats Mgr to skip equality check on flow stats
  Apply configs' name convention to authorization roles and resource groups

7 years agoFix for BUG 402: Subnet creation with NeutronAPIService sometimes fails 34/5134/2
Ryan Moats [Wed, 5 Feb 2014 17:07:35 +0000 (11:07 -0600)]
Fix for BUG 402: Subnet creation with NeutronAPIService sometimes fails
with a 409 error

Correct typo and bring hostRoutes out as own init block

Change-Id: I7f6f83cb6a63aa81a057b40c377ac49132a9fcb9
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoRequestor FRM to update the sw views on remote execution 50/5050/8
Alessandro Boch [Wed, 5 Feb 2014 07:20:09 +0000 (23:20 -0800)]
Requestor FRM to update the sw views on remote execution

- When FRM relay the flow add/remove/modify action to an executor
  FRM on another cluster node, it should be in charge of updating
  the sw view caches. As this happens inside the caller application's transaction.
  Currently the executor updates the cache, update which is not
  reflected in the requestor until the caller application commits the transaction.

Change-Id: I36f3efa2770e71c24e0d059d6bf08eee2c1684f5
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoImprove logging in NetconfClient, logging-bridge. Increase connection timeout in... 26/5126/4
Tomas Olvecky [Wed, 5 Feb 2014 10:55:39 +0000 (11:55 +0100)]
Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector.

Stop polluting log file with unnecessary 'Exception' messages by logging-bridge, print stack trace with exceptions using slf4j.
Increase connection timeout in sal-netconf-client from 5s to 20s.
Include label in NetconfClient exceptions.

Change-Id: If6819029fb79ea6ebead6b6745adf2c439d107da
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoFix unintentional breakage 30/5130/3
Robert Varga [Wed, 5 Feb 2014 13:06:39 +0000 (14:06 +0100)]
Fix unintentional breakage

Yangtools commit 6e7a42bd344f5928343ad67328bc8a8a734bea2e introduced a
new method which broke the controller-side proxy. Fix it up by simply
forwarning it through the delegate.

Change-Id: I4582acb3a6987d9d87d422a86283984a38cd31ba
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Added resource /streams/stream/<streamName>"
Ed Warnicke [Wed, 5 Feb 2014 06:37:28 +0000 (06:37 +0000)]
Merge "Added resource /streams/stream/<streamName>"

7 years agoMerge "Added support for /modules, /modules/module, /operations resources"
Ed Warnicke [Wed, 5 Feb 2014 06:36:47 +0000 (06:36 +0000)]
Merge "Added support for /modules, /modules/module, /operations resources"

7 years agoMerge "Handle uncaught exceptions from Clustering Services in HostTracker"
Chi-Vien Ly [Wed, 5 Feb 2014 02:43:13 +0000 (02:43 +0000)]
Merge "Handle uncaught exceptions from Clustering Services in HostTracker"

7 years agoHandle uncaught exceptions from Clustering Services in HostTracker 81/5081/5
Maurice Qureshi [Fri, 31 Jan 2014 23:18:44 +0000 (15:18 -0800)]
Handle uncaught exceptions from Clustering Services in HostTracker

There are couple of timer tasks in host tracker which use caches
provided by clustening services. If a container is deleted, then
the cache allocated to that container is also removed. Although
TimerTasks do get cancelled when container is deleted, but if it
happens during the execution of timer thread, then the task will
run to completion (even though it was cancelled) and may try to
access a cache which has already been deallocated.

The accessing of this deallocated cache will result in clustering
service exception which needs to be handled by timer tasks

Also adding toString methods to IPHostId and IPMacHostId for more
readable output when diplaying hosttracker data structures

Change-Id: Id1c481360a4ff71b6eb0afab3c030ef011ca7dcd
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
7 years agoAdded resource /streams/stream/<streamName> 94/5094/9
Martin Sunal [Sun, 2 Feb 2014 23:26:58 +0000 (00:26 +0100)]
Added resource /streams/stream/<streamName>

- added netty web socket server - port 8181

Subscriber can be registered for notifications in this flow:
1. Subscriber invokes RPC create-data-change-event-subscription with input element regarding to module sal-remote revision "2014-01-14"
2. Subscriber gets sream name as a response from server
3. Subscriber calls GET operation on /streams/stream/<streamName>
4. Subscriber gets response with status code 200 OK and header field Location contains URI of web socket server
5. Subscriber creates web socket http connection to obtained URI in step 4.
6. Subscriber can be unregistered from receiving notifications by sending CloseWebSocketFrame with reasonText containing stream name

Change-Id: I92925f5a50b2ceadf2cc8f0eaee2c99dd6a63d8d
Signed-off-by: Martin Sunal <msunal@cisco.com>
7 years agoAdded support for /modules, /modules/module, /operations resources 47/4847/6
Jozef Gloncak [Mon, 3 Feb 2014 12:56:13 +0000 (13:56 +0100)]
Added support for /modules, /modules/module, /operations resources

support for:
/restconf/modules
/restconf/modules/pathToMountPoint/yang-ext:mount
/restconf/modules/module/moduleName/revision
/restconf/modules/module/pathToMountPoint/yang-ext:mount/moduleName/revision
/restconf/operations
/restconf/operations/pathToMountPoint/yang-ext:mount

revision must be in format "yyyy-MM-dd"

test for URIs:
- /modules
- /modules/module/<module_name>/<module_revision>
- /operations
- /modules/......./yang-ext:mount
- /modules/module/........../yang-ext:mount/<module_name>/<module_revision>
- /operations/........../yang-ext:mount

Change-Id: I7169a25024598dd3b49d7960d1ef90bc40c5d1d5
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoStats Mgr to skip equality check on flow stats 21/5121/2
Alessandro Boch [Tue, 4 Feb 2014 17:20:32 +0000 (09:20 -0800)]
Stats Mgr to skip equality check on flow stats

- Statistics Manager runs an equality check on the list of flow statistics
  received from the protocol plugin with its cached ones to decide whether
  to update or not, in order to avoid a cluster cache update.
  In presence of flows on the switch, the flow updated statistics are always
  different becasue of the milli and nano secs duration fields they contain

Change-Id: I8290457c1d0a43294e2449cb16c14d6c1e36481e
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMaven archetype for config subsystem aware bundles 64/5064/3
Maros Marsalek [Fri, 31 Jan 2014 13:35:27 +0000 (14:35 +0100)]
Maven archetype for config subsystem aware bundles

Change-Id: I0b109770f03917b923de3d4fd78d91f43eded4e2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoApply configs' name convention to authorization roles and resource groups 11/5011/5
Alessandro Boch [Wed, 29 Jan 2014 19:14:32 +0000 (11:14 -0800)]
Apply configs' name convention to authorization roles and resource groups

- Also include Switch config

Change-Id: If84199a1db6e1fc35c02c4b92493f99aeb8d8af8
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMerge "Fix end of TLV in LLDP packet"
Alessandro Boch [Tue, 4 Feb 2014 02:56:44 +0000 (02:56 +0000)]
Merge "Fix end of TLV in LLDP packet"

7 years agoMerge "MD-SAL transaction chaining API"
Ed Warnicke [Mon, 3 Feb 2014 22:51:26 +0000 (22:51 +0000)]
Merge "MD-SAL transaction chaining API"

7 years agoMerge "Removed unused code from md-sal."
Ed Warnicke [Mon, 3 Feb 2014 22:49:16 +0000 (22:49 +0000)]
Merge "Removed unused code from md-sal."

7 years agoMerge "Restrict MD-SAL data operations to a single thread"
Ed Warnicke [Mon, 3 Feb 2014 22:45:17 +0000 (22:45 +0000)]
Merge "Restrict MD-SAL data operations to a single thread"

7 years agoMerge "Clarify the semantics of put{Configuration,Operational}Data()"
Ed Warnicke [Mon, 3 Feb 2014 22:42:40 +0000 (22:42 +0000)]
Merge "Clarify the semantics of put{Configuration,Operational}Data()"

7 years agoClarify the semantics of put{Configuration,Operational}Data() 07/5107/1
Robert Varga [Mon, 3 Feb 2014 18:40:03 +0000 (19:40 +0100)]
Clarify the semantics of put{Configuration,Operational}Data()

This just adds documentation to how the put operations interact with
pre-existing data.

Change-Id: I01979df6a22f1a6d16c04c2cb0b97d7472d62040
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMake sure transaction applies whole removal list 06/5106/1
Tony Tkacik [Mon, 3 Feb 2014 18:33:52 +0000 (19:33 +0100)]
Make sure transaction applies whole removal list

Change-Id: I53d1cf10bce6e444f80b13d9ce57e5f1ef2eb5c9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFixed bug when new childs were ommited during data store merge. 05/5105/1
Tony Tkacik [Mon, 3 Feb 2014 18:20:36 +0000 (19:20 +0100)]
Fixed bug when new childs were ommited during data store merge.

Change-Id: I0680d1354614d7597b0079445951d4a6f33d8d5c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoMerge "Yang Changes to include list<actions> to PacketOut - Added list<actions> and...
Ed Warnicke [Mon, 3 Feb 2014 16:34:53 +0000 (16:34 +0000)]
Merge "Yang Changes to include list<actions> to PacketOut - Added list<actions> and buffer_id to PacketOut Message to handle group processing and Packet Modification through different actions"

7 years agoMD-SAL transaction chaining API 54/5054/4
Robert Varga [Fri, 31 Jan 2014 09:31:46 +0000 (10:31 +0100)]
MD-SAL transaction chaining API

This API complements the normal MD-SAL transaction API. Applications can
use this API to maintain inter-transaction ordering and data
consistency.

Change-Id: Ia603f7dacf081fb1528d149f4635c2f22101a7a0
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRestrict MD-SAL data operations to a single thread 70/5070/3
Robert Varga [Fri, 31 Jan 2014 15:31:05 +0000 (16:31 +0100)]
Restrict MD-SAL data operations to a single thread

MD-SAL does not give us transaction ordering guarantees, which mean that
data may hit the data store than what the application intended. Change
the model to single-threaded until proper transaction ordering APIs are
defined.

Change-Id: I6c6375480082b94c614ab2602a2857e0f4779ee8
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge changes I805ec065,Idc9995b1
Ed Warnicke [Sat, 1 Feb 2014 16:09:03 +0000 (16:09 +0000)]
Merge changes I805ec065,Idc9995b1

* changes:
  Change unprotected netconf address from 0.0.0.0 to 127.0.0.1 .
  Refactor config-persister: clean up exception handling and netconf client.

7 years agoMerge "Fix typo and add more descriptive error"
Ed Warnicke [Sat, 1 Feb 2014 16:08:26 +0000 (16:08 +0000)]
Merge "Fix typo and add more descriptive error"

7 years agoMerge changes Iae4ee2f2,I148c22c4,I1dab84ae
Ed Warnicke [Sat, 1 Feb 2014 16:07:41 +0000 (16:07 +0000)]
Merge changes Iae4ee2f2,I148c22c4,I1dab84ae

* changes:
  Additional test for instance-identifier
  BUG 388: corrected media type in /operations resource
  BUG 312: Removed legacy RESTCONF draft 01 syntax

7 years agoMerge "updated test coverage for AutodetectDirectoryPersister test coverage raised...
Ed Warnicke [Sat, 1 Feb 2014 16:02:09 +0000 (16:02 +0000)]
Merge "updated test coverage for AutodetectDirectoryPersister test coverage raised on config-persister-file-xml-adapter"

7 years agoMerge "minor test fix"
Ed Warnicke [Sat, 1 Feb 2014 16:00:23 +0000 (16:00 +0000)]
Merge "minor test fix"

7 years agoMerge "Add configurable connection timeout to netconf client."
Ed Warnicke [Sat, 1 Feb 2014 15:59:14 +0000 (15:59 +0000)]
Merge "Add configurable connection timeout to netconf client."

7 years agoMerge "Added description to meter types yang model."
Ed Warnicke [Sat, 1 Feb 2014 15:57:56 +0000 (15:57 +0000)]
Merge "Added description to meter types yang model."

7 years agoFix typo and add more descriptive error 38/5038/3
Robert Varga [Thu, 30 Jan 2014 18:07:22 +0000 (19:07 +0100)]
Fix typo and add more descriptive error

When comparing keys, also provide a hint to the node which violated the
key constraint.

Change-Id: I02a9ba3c887bcbc3af34fe770f662e627c3a4414
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBump yangtools to 0.6.2-SNAPSHOT 23/5023/5
Robert Varga [Thu, 30 Jan 2014 10:28:15 +0000 (11:28 +0100)]
Bump yangtools to 0.6.2-SNAPSHOT

This will pick up upcoming yangtools release.

Change-Id: I3c6f8faf8888eaa3a71a9f0e16cc242b6f958832
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoYang Changes to include list<actions> to PacketOut 71/5071/2
Gaurav Bhagwani [Fri, 31 Jan 2014 16:11:36 +0000 (21:41 +0530)]
Yang Changes to include list<actions> to PacketOut
- Added list<actions> and buffer_id to PacketOut Message to handle group processing and Packet Modification through different actions

Signed-off-by: Gaurav Bhagwani <gaurav.bhagwani@ericsson.com>
Change-Id: I5875f9792f6a036bf2b4060ba377f1565e66d2fd

7 years agoAdditional test for instance-identifier 22/5022/4
Jozef Gloncak [Mon, 27 Jan 2014 14:19:35 +0000 (15:19 +0100)]
Additional test for instance-identifier

- test for instance identifier
- correction of ignored test (adding revisions to wrong tests)
- instance identifier with leaflist predicate:
-- serialize codec
-- XML output
-- JSON output

Change-Id: Iae4ee2f2ff3c1b3445958f1d69673df9f56b0e2a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoBUG 388: corrected media type in /operations resource 35/5035/3
Martin Sunal [Thu, 30 Jan 2014 15:50:05 +0000 (16:50 +0100)]
BUG 388: corrected media type in /operations resource

There were added these media types for /operations resource:
application/yang.operation+json
application/yang.operation+xml
Corrected handling of requests which have empty body and Content-Type has some value or is missing

Change-Id: I148c22c4c6c28d0d13f2b717fe629b42d5c73f70
Signed-off-by: Martin Sunal <msunal@cisco.com>
7 years agoChange unprotected netconf address from 0.0.0.0 to 127.0.0.1 . 66/5066/1
Tomas Olvecky [Fri, 31 Jan 2014 14:13:40 +0000 (15:13 +0100)]
Change unprotected netconf address from 0.0.0.0 to 127.0.0.1 .

Plaintext netconf server was bound to any local interface. This is a security risk
because there is no authentication. The ssh server should be used as public endpoint instead.

Change-Id: I805ec065548e017dd2244d37e3275d379761e490
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoupdated test coverage for AutodetectDirectoryPersister 16/5016/8
Martin Bobak [Thu, 30 Jan 2014 09:19:00 +0000 (10:19 +0100)]
updated test coverage for AutodetectDirectoryPersister
test coverage raised on config-persister-file-xml-adapter

Change-Id: I027fd57baeb233271c88499c29e4708a735bb10d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoRefactor config-persister: clean up exception handling and netconf client. 65/5065/1
Tomas Olvecky [Fri, 31 Jan 2014 13:51:08 +0000 (14:51 +0100)]
Refactor config-persister: clean up exception handling and netconf client.

Split ConfigPersisterNotificationHandler into registrator and listener, remove unnecessary
reference to NetconfClient.
Refactor ConfigPusher: each method now returns computational results instead of void. Avoid
unnecessary NetconfClient reference leak - close it after every use. Rename generic 'timeout'
to 'maxWaitForCapabilitiesMillis'. Avoid throwing and catching SAXException and IOException
as there is no recovery from them; keep only ConflictingVersionException.
ConfigPersisterActivator now actually uses the configurable timeout, the property is renamed
from 'pushTimeout' to 'maxWaitForCapabilitiesMillis'.

Change-Id: Idc9995b11dd2f19a90598c88eb7337d39d63fc27
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agominor test fix 55/5055/2
Martin Bobak [Fri, 31 Jan 2014 09:26:36 +0000 (10:26 +0100)]
minor test fix

Change-Id: I3dce2b98d5d7452a9363150b91827eb3dcc03e60
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoFix Helper sorting issue 58/5058/1
Sapan Shah [Fri, 31 Jan 2014 10:57:03 +0000 (02:57 -0800)]
Fix Helper sorting issue

Fix sorting in tables, for undefined values

Change-Id: Id9c09aa9b9de93f07c4063e21e6dac578d13913f
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoRemoved unused code from md-sal. 32/5032/3
Martin Vitez [Thu, 30 Jan 2014 14:15:45 +0000 (15:15 +0100)]
Removed unused code from md-sal.

Change-Id: Ia64a118ec7c75d0abf5800f7eee98ae708b8e50a
Signed-off-by: Martin Vitez <mvitez@cisco.com>
7 years agoDisplay Vlan Priority in Flow Stats in TS GUI 46/5046/3
Sapan Shah [Thu, 30 Jan 2014 22:09:42 +0000 (14:09 -0800)]
Display Vlan Priority in Flow Stats in TS GUI

also display Priority values, greater than 32767

Change-Id: Idc067ffe3b9e859c1f2ce2eeec7d5e569f318db6
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoFix end of TLV in LLDP packet 42/5042/1
Diti Bhatia [Thu, 30 Jan 2014 20:46:22 +0000 (12:46 -0800)]
Fix end of TLV in LLDP packet

Change-Id: Id4bc88bcf792758ff73f9d143481aca2a6ef3c95
Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
7 years agoMerge "Handling the case where vlan priority is set to 0."
Alessandro Boch [Thu, 30 Jan 2014 18:16:37 +0000 (18:16 +0000)]
Merge "Handling the case where vlan priority is set to 0."

7 years agoMerge "Double the SSL input packet buffer size"
Alessandro Boch [Thu, 30 Jan 2014 17:02:02 +0000 (17:02 +0000)]
Merge "Double the SSL input packet buffer size"

7 years agoHandling the case where vlan priority is set to 0. 10/5010/3
Asad Ahmed [Wed, 29 Jan 2014 22:36:16 +0000 (14:36 -0800)]
Handling the case where vlan priority is set to 0.

Change-Id: I0d9735343633c2efc1f6a3a5c768aad3f7c88c90
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
7 years agoAdd configurable connection timeout to netconf client. 36/5036/1
Tomas Olvecky [Thu, 23 Jan 2014 16:03:17 +0000 (17:03 +0100)]
Add configurable connection timeout to netconf client.

Make connection timeout configurable. Previous behavior was having hardcoded connection timeout set to 1 minute.
Make NetconfConnectorModule more configurable, allow (and this is new default) to retry on connection failures forever.

Change-Id: Ia9280cff1b751a4e7318e1e0331175c960823dad
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoBUG 312: Removed legacy RESTCONF draft 01 syntax 29/5029/1
Martin Sunal [Thu, 30 Jan 2014 14:26:54 +0000 (15:26 +0100)]
BUG 312: Removed legacy RESTCONF draft 01 syntax

Change-Id: I1dab84ae70ef39964ead1b14efd58ae2e3eee087
Signed-off-by: Martin Sunal <msunal@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.