controller.git
5 years agoBug 2517: Catch RuntimeExceptions thrown from the DCL in DataChangeListener 68/13668/2
tpantelis [Mon, 8 Dec 2014 14:25:16 +0000 (09:25 -0500)]
Bug 2517: Catch RuntimeExceptions thrown from the DCL in DataChangeListener

This prevents akka from suppressing/dropping subsequent data change
events if a RuntimeException is propagated to akka.

Change-Id: Ibc90e00c56a3e3b6f0039ff609d639fe8201adf0
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Remove throws declaration of a runtime exception"
Tony Tkacik [Mon, 15 Dec 2014 15:07:09 +0000 (15:07 +0000)]
Merge "Remove throws declaration of a runtime exception"

5 years agoMerge "BUG-2511 Fix possible XXE vulnerability in restconf"
Tony Tkacik [Mon, 15 Dec 2014 14:57:59 +0000 (14:57 +0000)]
Merge "BUG-2511 Fix possible XXE vulnerability in restconf"

5 years agoMerge "Allow rpc definition for RuntimeMXBeans to come from groupings"
Tony Tkacik [Mon, 15 Dec 2014 14:57:22 +0000 (14:57 +0000)]
Merge "Allow rpc definition for RuntimeMXBeans to come from groupings"

5 years agoMerge "BUG-2511 Fix XXE vulnerability in Netconf"
Tony Tkacik [Mon, 15 Dec 2014 13:20:47 +0000 (13:20 +0000)]
Merge "BUG-2511 Fix XXE vulnerability in Netconf"

5 years agoAllow rpc definition for RuntimeMXBeans to come from groupings 29/13129/4
Maros Marsalek [Tue, 25 Nov 2014 17:02:02 +0000 (18:02 +0100)]
Allow rpc definition for RuntimeMXBeans to come from groupings

Change-Id: I796b43e8a4b01277bcb0c73f5ac86bc710839061
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2511 Fix possible XXE vulnerability in restconf 49/13649/2
Maros Marsalek [Mon, 15 Dec 2014 11:19:11 +0000 (12:19 +0100)]
BUG-2511 Fix possible XXE vulnerability in restconf

Change-Id: I16eaf8a743b94ec26e3ac427fb777d0c769ec3c2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge topic 'checkstyle'
Tony Tkacik [Mon, 15 Dec 2014 11:43:59 +0000 (11:43 +0000)]
Merge topic 'checkstyle'

* changes:
  Fix checkstyle if-statements must use braces northbound/commons
  Fix checkstyle if-statements must use braces hosttracker_new
  Fix checkstyle simplify boolean expression config-api

5 years agoMerge "Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration"
Tony Tkacik [Mon, 15 Dec 2014 11:42:32 +0000 (11:42 +0000)]
Merge "Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration"

5 years agoMerge "Registry instance cannot be null in RpcProxyRegistration"
Tony Tkacik [Mon, 15 Dec 2014 11:37:34 +0000 (11:37 +0000)]
Merge "Registry instance cannot be null in RpcProxyRegistration"

5 years agoMerge "Do not instantiate FluentIterable"
Tony Tkacik [Mon, 15 Dec 2014 11:37:25 +0000 (11:37 +0000)]
Merge "Do not instantiate FluentIterable"

5 years agoBUG-2511 Fix XXE vulnerability in Netconf 47/13647/1
Maros Marsalek [Mon, 15 Dec 2014 10:03:56 +0000 (11:03 +0100)]
BUG-2511 Fix XXE vulnerability in Netconf

Change-Id: Ifc1d63fc632e7395a46d85fc2ccb9095e7008430
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Fix warnings in config-manager"
Tony Tkacik [Mon, 15 Dec 2014 09:51:11 +0000 (09:51 +0000)]
Merge "Fix warnings in config-manager"

5 years agoRemove throws declaration of a runtime exception 33/13633/2
Robert Varga [Sun, 14 Dec 2014 18:18:40 +0000 (19:18 +0100)]
Remove throws declaration of a runtime exception

IllegalStateException is a RuntimeException -- hence we do not need to
declare it.

Change-Id: I681eff319b299beecf7710c44f154c1bb1b5174a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoShorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration 32/13632/2
Robert Varga [Sun, 14 Dec 2014 17:38:56 +0000 (18:38 +0100)]
Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration

We can safely import the class, shortening references to it.

Change-Id: I41d5ca29f1dd4daff726d3598c1bf14732318752
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRegistry instance cannot be null in RpcProxyRegistration 31/13631/2
Robert Varga [Sun, 14 Dec 2014 17:21:25 +0000 (18:21 +0100)]
Registry instance cannot be null in RpcProxyRegistration

removeRegistration() is guaranteed to be invoked at most once, and
registry cannot be null. Make it final and remove the safety check.

Change-Id: Ie8f2da7430c076d0bec71eb8b58a4adc2af25adf
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoDo not instantiate FluentIterable 30/13630/2
Robert Varga [Sun, 14 Dec 2014 17:16:50 +0000 (18:16 +0100)]
Do not instantiate FluentIterable

We are performing an immediate transformation of the iterrable.
Instead of that we can immediately use Collections2.transform(), saving
an object.

Change-Id: Ie943a0a79e04713427bf6470e06d921412ebb179
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Fixed compilation error in Eclipse."
Tony Tkacik [Mon, 15 Dec 2014 08:49:25 +0000 (08:49 +0000)]
Merge "Fixed compilation error in Eclipse."

5 years agoFix checkstyle if-statements must use braces northbound/commons 20/13620/2
Thanh Ha [Sun, 14 Dec 2014 16:29:16 +0000 (11:29 -0500)]
Fix checkstyle if-statements must use braces northbound/commons

Change-Id: Iadad636ebf07e8c31a8c85540f10180b825c8a4a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces hosttracker_new 19/13619/2
Thanh Ha [Sun, 14 Dec 2014 16:21:37 +0000 (11:21 -0500)]
Fix checkstyle if-statements must use braces hosttracker_new

Change-Id: I8261723a288103deb227b99e72d558f6303a37d8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle simplify boolean expression config-api 86/13586/3
Thanh Ha [Fri, 12 Dec 2014 03:03:26 +0000 (22:03 -0500)]
Fix checkstyle simplify boolean expression config-api

Change-Id: I4e47824cfd73bc798a06fc1dac299d94cebed7b3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix warnings in config-manager 73/13073/4
Robert Varga [Fri, 21 Nov 2014 19:31:19 +0000 (20:31 +0100)]
Fix warnings in config-manager

Unused import and an unused PMD warning suppression.

Change-Id: I84073e732a1ea40f07b20e5ebd0101ae4249906e
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Reuse PEM provider in netconf-testtool."
Tony Tkacik [Mon, 15 Dec 2014 08:06:17 +0000 (08:06 +0000)]
Merge "Reuse PEM provider in netconf-testtool."

5 years agoMerge topic 'stable/helium'
Tony Tkacik [Mon, 15 Dec 2014 07:57:53 +0000 (07:57 +0000)]
Merge topic 'stable/helium'

* changes:
  Shorten YangInstanceIdentifier references
  BUG-2510: handle RPC route removal

5 years agoMerge "BUG-2510: Remove all registrations when a routed rpc is closed"
Tony Tkacik [Mon, 15 Dec 2014 07:56:57 +0000 (07:56 +0000)]
Merge "BUG-2510: Remove all registrations when a routed rpc is closed"

5 years agoMerge "BUG-2459: use thread-local cache of transformers"
Tony Tkacik [Mon, 15 Dec 2014 07:51:47 +0000 (07:51 +0000)]
Merge "BUG-2459: use thread-local cache of transformers"

5 years agoMerge "Mark DomBrokerImplModule.createLegacyDataService() as deprecated"
Tony Tkacik [Mon, 15 Dec 2014 07:51:25 +0000 (07:51 +0000)]
Merge "Mark DomBrokerImplModule.createLegacyDataService() as deprecated"

5 years agoMerge "BUG-2500: add current tree state to traces"
Tony Tkacik [Mon, 15 Dec 2014 07:51:15 +0000 (07:51 +0000)]
Merge "BUG-2500: add current tree state to traces"

5 years agoMerge "Cache TransformerFactory"
Tony Tkacik [Mon, 15 Dec 2014 07:50:52 +0000 (07:50 +0000)]
Merge "Cache TransformerFactory"

5 years agoShorten YangInstanceIdentifier references 29/13629/1
Robert Varga [Sun, 14 Dec 2014 17:13:10 +0000 (18:13 +0100)]
Shorten YangInstanceIdentifier references

We no longer have InstanceIdentifier name clash, so we can safely import
YangInstanceIdentifier and use it that way.

Change-Id: I48d13f9e6ecd17c1de40b5a017962cfc792810ad
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2510: handle RPC route removal 28/13628/1
Robert Varga [Sun, 14 Dec 2014 18:32:13 +0000 (19:32 +0100)]
BUG-2510: handle RPC route removal

DOM to Binding forwarding ignored removals of RPC implementations. Add
that case back.

Change-Id: I7af1d8b43b9b229cc9a696cfdfc61146f960b374
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2510: Remove all registrations when a routed rpc is closed 27/13627/1
Robert Varga [Sun, 14 Dec 2014 18:20:00 +0000 (19:20 +0100)]
BUG-2510: Remove all registrations when a routed rpc is closed

The API contract specifies that the effects of a Registration are
removed on close(). Unfortunately the routed RPC case is more funny, as
it has sub-registrations, for each added path -- and we have no mention
of the fact that the user should be removing them.

Hence we need to handle the user expecting us to remove any and all
paths which have been registered.

Change-Id: Iedf451c2a481d648173819f895cccb9e63c54d99
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFixed compilation error in Eclipse. 51/13551/2
Gary Wu [Wed, 10 Dec 2014 22:56:39 +0000 (14:56 -0800)]
Fixed compilation error in Eclipse.

Change-Id: Id6004fbbc1c409f111b9ca57419d36b8686b1f89
Signed-off-by: Gary Wu <gary.wu@gmail.com>
5 years agoMark DomBrokerImplModule.createLegacyDataService() as deprecated 77/13077/2
Robert Varga [Mon, 24 Nov 2014 16:40:49 +0000 (17:40 +0100)]
Mark DomBrokerImplModule.createLegacyDataService() as deprecated

This marks the method deprecated, as we want to get rid of it. Fixes a
few warnings.

Change-Id: If4e613c07e9cd2b9b737fd697cbcd5709499c4d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: use thread-local cache of transformers 17/13317/13
Robert Varga [Tue, 2 Dec 2014 19:01:53 +0000 (20:01 +0100)]
BUG-2459: use thread-local cache of transformers

As it turns out, we can reuse transformers in the encode path. Do
precisely that, keeping them in thread-local variables. This is safe in
context of Netty, as we are invoked only from the netty threadpool. This
has the benefit of reusing the transformers across all sessions
associated with the threadpool.

Change-Id: If57933f68a9c9196b649baea17353fd2bd472e09
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2500: add current tree state to traces 63/13563/3
Robert Varga [Thu, 11 Dec 2014 12:10:10 +0000 (13:10 +0100)]
BUG-2500: add current tree state to traces

When a data validation exception occurs, also add the current tree state
to trace output.

Change-Id: I637973458519d4ed25fa3203fa79b72faf9a9e8b
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoCache TransformerFactory 62/13562/2
Robert Varga [Thu, 11 Dec 2014 10:11:59 +0000 (11:11 +0100)]
Cache TransformerFactory

Instantiating a transformerfactory is costly, so cache and reuse it.

Change-Id: I43561ef36cdd10ef077b77c71673840d4dc83fbd
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: do not instantiate factories in fastpath 60/13560/2
Robert Varga [Thu, 11 Dec 2014 10:08:26 +0000 (11:08 +0100)]
BUG-2459: do not instantiate factories in fastpath

This caches the factories in static fields rather than instantiating
them on each call.

Change-Id: I4dfee7724320914f2c7c9724192e4653deea3cde
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2506: split out maven binding 90/13590/2
Robert Varga [Fri, 12 Dec 2014 11:07:45 +0000 (12:07 +0100)]
BUG-2506: split out maven binding

Maven integration needs to be split out of the runtime implementation,
simply because we do not want to pull the requisite runtime into our
containers. It would never be used there anyway.

Change-Id: Ided36e3b06316739a3829d758889ba523e7e19ad
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "BUG-2470: add trace of failed modification"
Tony Tkacik [Wed, 10 Dec 2014 15:35:38 +0000 (15:35 +0000)]
Merge "BUG-2470: add trace of failed modification"

5 years agoMerge "BUG-2475: Do not issue garbage collection on when pushing configurations"
Tony Tkacik [Wed, 10 Dec 2014 15:34:14 +0000 (15:34 +0000)]
Merge "BUG-2475: Do not issue garbage collection on when pushing configurations"

5 years agoMerge topic 'checkstyle'
Tony Tkacik [Wed, 10 Dec 2014 09:11:31 +0000 (09:11 +0000)]
Merge topic 'checkstyle'

* changes:
  Fix checkstyle if-statements must use braces liblldp
  Fix checkstyle if-statements must use braces hosttracker
  Fix checkstyle if-statements must use braces bundlescanner
  Fix checkstyle if-statements must use braces ClusterManager
  Fix checkstyle if-statements must use braces HostTrackerCallable
  Fix checkstyle if-statements must use braces ConnectionManagerNorthbound
  Fix checkstyle if-statements must use braces HostTrackerNorthbound
  Fix checkstyle if-statements must use braces BridgeDomainNorthbound
  Fix checkstyle if-statements must use braces adsal/northbound/staticrouting
  Fix checkstyle if-statements must use braces adsal/northbound/statistics
  Fix checkstyle if-statements must use braces adsal/protocol_plugins
  Fix checkstyle if-statements must use braces adsal/sal/connection
  Fix checkstyle if-statements must use braces adsal/samples/loadbalancer
  Fix checkstyle if-statements must use braces adsal/usermanager
  Fix checkstyle if-statements must use braces config-persister-file-xml-adapter
  Fix checkstyle if-statements must use braces logback-config
  Fix checkstyle if-statements must use braces yang-jmx-generator-plugin
  Fix checkstyle if-statements must use braces yang-jmx-generator
  Fix checkstyle if-statements must use braces sal-common-impl
  Fix checkstyle if-statements must use braces sal-common-util
  Fix checkstyle if-statements must use braces sal-dom-xsql
  Fix checkstyle if-statements must use braces sal-netconf-connector
  Fix checkstyle if-statements must use braces sal-rest-docgen
  Fix checkstyle if-statements must use braces md/statistics
  Fix checkstyle if-statements must use braces netconf

5 years agoMerge "Fix duplicate dependency warnings"
Tony Tkacik [Wed, 10 Dec 2014 09:07:23 +0000 (09:07 +0000)]
Merge "Fix duplicate dependency warnings"

5 years agoMerge "Fix Sonar Bad practice - Method may fail to close stream"
Tony Tkacik [Wed, 10 Dec 2014 09:07:01 +0000 (09:07 +0000)]
Merge "Fix Sonar Bad practice - Method may fail to close stream"

5 years agoFix checkstyle if-statements must use braces liblldp 24/13524/1
Thanh Ha [Wed, 10 Dec 2014 00:19:16 +0000 (19:19 -0500)]
Fix checkstyle if-statements must use braces liblldp

Change-Id: I2e36139dbeea5890a7eec7003da186af162e8998
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces hosttracker 23/13523/1
Thanh Ha [Wed, 10 Dec 2014 00:16:11 +0000 (19:16 -0500)]
Fix checkstyle if-statements must use braces hosttracker

Change-Id: I4ecd87422d228da396bfd3027aae3a365206fe2a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces bundlescanner 22/13522/1
Thanh Ha [Wed, 10 Dec 2014 00:13:17 +0000 (19:13 -0500)]
Fix checkstyle if-statements must use braces bundlescanner

Change-Id: I54dcb1e13e913f3dcfcb1b2801b78aa62919a6bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces ClusterManager 21/13521/1
Thanh Ha [Tue, 9 Dec 2014 23:03:30 +0000 (18:03 -0500)]
Fix checkstyle if-statements must use braces ClusterManager

Change-Id: Ie8f6ec2ad3ea1e4131218b599fa4f1c5a9eb5cc4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces HostTrackerCallable 20/13520/1
Thanh Ha [Tue, 9 Dec 2014 23:02:46 +0000 (18:02 -0500)]
Fix checkstyle if-statements must use braces HostTrackerCallable

Change-Id: I199f7b95f8e2740a4f5375f2ecd9a6ce4e39a2f6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces ConnectionManagerNorthbound 19/13519/1
Thanh Ha [Tue, 9 Dec 2014 23:01:44 +0000 (18:01 -0500)]
Fix checkstyle if-statements must use braces ConnectionManagerNorthbound

Change-Id: If429fd24b5b346a350bc1cf488c800d445d4bbc1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces HostTrackerNorthbound 18/13518/1
Thanh Ha [Tue, 9 Dec 2014 23:01:12 +0000 (18:01 -0500)]
Fix checkstyle if-statements must use braces HostTrackerNorthbound

Change-Id: Iaf3b56c7d66bd1609599e05833788c80bddf8924
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces BridgeDomainNorthbound 17/13517/1
Thanh Ha [Tue, 9 Dec 2014 22:59:45 +0000 (17:59 -0500)]
Fix checkstyle if-statements must use braces BridgeDomainNorthbound

Change-Id: If3656f11133856b14340ef03939e53ebd46874a3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/northbound/staticrouting 16/13516/1
Thanh Ha [Tue, 9 Dec 2014 22:58:29 +0000 (17:58 -0500)]
Fix checkstyle if-statements must use braces adsal/northbound/staticrouting

Change-Id: I1a12ee8523e948af752c5fb2627a8567c99ed9e5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/northbound/statistics 15/13515/1
Thanh Ha [Tue, 9 Dec 2014 22:57:09 +0000 (17:57 -0500)]
Fix checkstyle if-statements must use braces adsal/northbound/statistics

Change-Id: I2ef8d4fc3977eb8db6e369d9bb2fb2c6b5ad70db
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/protocol_plugins 14/13514/1
Thanh Ha [Tue, 9 Dec 2014 22:55:35 +0000 (17:55 -0500)]
Fix checkstyle if-statements must use braces adsal/protocol_plugins

Change-Id: I2110c4623f141e738b368d0bce0695ebc98809ff
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/sal/connection 13/13513/1
Thanh Ha [Tue, 9 Dec 2014 22:54:26 +0000 (17:54 -0500)]
Fix checkstyle if-statements must use braces adsal/sal/connection

Change-Id: Ib08edee1ed589b1bcbbaa9b38054ed5c301bb49c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/samples/loadbalancer 12/13512/1
Thanh Ha [Tue, 9 Dec 2014 22:53:03 +0000 (17:53 -0500)]
Fix checkstyle if-statements must use braces adsal/samples/loadbalancer

Change-Id: I57535ed22a2ad4947dfb768b399c69d15444b39e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/usermanager 11/13511/1
Thanh Ha [Tue, 9 Dec 2014 22:51:06 +0000 (17:51 -0500)]
Fix checkstyle if-statements must use braces adsal/usermanager

Change-Id: Idfb6cc67ab679c6b126724d25fefecc3e4cf45c2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces config-persister-file-xml-adapter 10/13510/1
Thanh Ha [Tue, 9 Dec 2014 22:50:14 +0000 (17:50 -0500)]
Fix checkstyle if-statements must use braces config-persister-file-xml-adapter

Change-Id: I8c3d8a5e7ada9bb39822d364e765be253c6a9691
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces logback-config 09/13509/1
Thanh Ha [Tue, 9 Dec 2014 22:49:34 +0000 (17:49 -0500)]
Fix checkstyle if-statements must use braces logback-config

Change-Id: Ie857c55d72e6ab582a9abde8bf7e649e23f8323a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces yang-jmx-generator-plugin 08/13508/1
Thanh Ha [Tue, 9 Dec 2014 22:48:37 +0000 (17:48 -0500)]
Fix checkstyle if-statements must use braces yang-jmx-generator-plugin

Change-Id: Ic3411f453bea29817e0c637423059efa6d398e93
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces yang-jmx-generator 07/13507/1
Thanh Ha [Tue, 9 Dec 2014 22:45:50 +0000 (17:45 -0500)]
Fix checkstyle if-statements must use braces yang-jmx-generator

Change-Id: I2d57b840a80d48d5227651582436b6c78ddf1ad5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-common-impl 06/13506/1
Thanh Ha [Tue, 9 Dec 2014 22:42:25 +0000 (17:42 -0500)]
Fix checkstyle if-statements must use braces sal-common-impl

Change-Id: Ib2d0a8bcf4cef4a589a8c23181433dd14ea84657
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-common-util 05/13505/1
Thanh Ha [Tue, 9 Dec 2014 22:41:24 +0000 (17:41 -0500)]
Fix checkstyle if-statements must use braces sal-common-util

Change-Id: I518b9fa156af55c080d7e6a55067deab2c789a42
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-dom-xsql 04/13504/1
Thanh Ha [Tue, 9 Dec 2014 22:40:23 +0000 (17:40 -0500)]
Fix checkstyle if-statements must use braces sal-dom-xsql

Change-Id: I68b6f356b30e56247dec7c96aa43e345e6d972f8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-netconf-connector 03/13503/1
Thanh Ha [Tue, 9 Dec 2014 22:35:29 +0000 (17:35 -0500)]
Fix checkstyle if-statements must use braces sal-netconf-connector

Change-Id: I2b4587534eb54833a012e01179d24e526d70d208
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-rest-docgen 02/13502/1
Thanh Ha [Tue, 9 Dec 2014 22:32:21 +0000 (17:32 -0500)]
Fix checkstyle if-statements must use braces sal-rest-docgen

Change-Id: Id08ad375b27838637497dd507df0c076bf2b63df
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces md/statistics 01/13501/1
Thanh Ha [Tue, 9 Dec 2014 22:30:56 +0000 (17:30 -0500)]
Fix checkstyle if-statements must use braces md/statistics

Change-Id: I3e1ba6fdbed82a4f724585d5a420299698e851c9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces netconf 00/13500/1
Thanh Ha [Tue, 9 Dec 2014 22:28:38 +0000 (17:28 -0500)]
Fix checkstyle if-statements must use braces netconf

Change-Id: I2e5b8cc264acee74530ccbb990014b54649764b1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBUG-2470: add trace of failed modification 82/13482/1
Robert Varga [Tue, 9 Dec 2014 17:01:10 +0000 (18:01 +0100)]
BUG-2470: add trace of failed modification

With this change, the InMemoryDOMDataStore trace logs should contain the
dump of failed modifications.

Change-Id: Iea3038169090a574030c5e03cf155089faa6e985
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2475: Do not issue garbage collection on when pushing configurations 79/13479/3
Robert Varga [Tue, 9 Dec 2014 15:11:48 +0000 (16:11 +0100)]
BUG-2475: Do not issue garbage collection on when pushing configurations

This gc() call used to make sense when we were running this code as a
one-shot initialization (e.g. Hydrogen container). With the Karaf
changes, this was moved into a persistent codepath -- which does not
make sense at all.

Change-Id: I0e3d4a2b674241c80d682630b031fb3517621251
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Fix checkstyle warnings in yang-test."
Tony Tkacik [Tue, 9 Dec 2014 15:46:37 +0000 (15:46 +0000)]
Merge "Fix checkstyle warnings in yang-test."

5 years agoMerge "Fix checkstyle warnings in yang-test-plugin."
Tony Tkacik [Tue, 9 Dec 2014 15:46:30 +0000 (15:46 +0000)]
Merge "Fix checkstyle warnings in yang-test-plugin."

5 years agoMerge "Fix checkstyle warnings in yang-jmx-generator."
Tony Tkacik [Tue, 9 Dec 2014 15:46:22 +0000 (15:46 +0000)]
Merge "Fix checkstyle warnings in yang-jmx-generator."

5 years agoMerge "Fix checkstyle warnings in yang-jmx-generator-plugin"
Tony Tkacik [Tue, 9 Dec 2014 15:46:13 +0000 (15:46 +0000)]
Merge "Fix checkstyle warnings in yang-jmx-generator-plugin"

5 years agoMerge "Fix checkstyle warnings in yang-jmx-generator-it."
Tony Tkacik [Tue, 9 Dec 2014 15:46:05 +0000 (15:46 +0000)]
Merge "Fix checkstyle warnings in yang-jmx-generator-it."

5 years agoMerge "Fix checkstyle warnings in threadpool-config-impl"
Tony Tkacik [Tue, 9 Dec 2014 15:45:58 +0000 (15:45 +0000)]
Merge "Fix checkstyle warnings in threadpool-config-impl"

5 years agoMerge "Fix checkstyle warnings in netty-timer-config"
Tony Tkacik [Tue, 9 Dec 2014 15:45:51 +0000 (15:45 +0000)]
Merge "Fix checkstyle warnings in netty-timer-config"

5 years agoFix checkstyle warnings in yang-test. 07/13007/8
Marian Dubai [Thu, 20 Nov 2014 12:13:13 +0000 (13:13 +0100)]
Fix checkstyle warnings in yang-test.

Change-Id: I82e31fbcb5a375d009556f2163829f1beff7cc5b
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in yang-test-plugin. 06/13006/9
Marian Dubai [Thu, 20 Nov 2014 12:12:21 +0000 (13:12 +0100)]
Fix checkstyle warnings in yang-test-plugin.

Change-Id: Ic89f1d2c4006181d8cfdcf0a4c1f71a468e977b7
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in yang-jmx-generator. 05/13005/9
Marian Dubai [Thu, 20 Nov 2014 12:11:16 +0000 (13:11 +0100)]
Fix checkstyle warnings in yang-jmx-generator.

Change-Id: I0bb7cb63e6e75f24d293e6ceaad0ab6ec4e8d458
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in yang-jmx-generator-plugin 04/13004/10
Marian Dubai [Thu, 20 Nov 2014 12:10:18 +0000 (13:10 +0100)]
Fix checkstyle warnings in yang-jmx-generator-plugin

Change-Id: I2c1d564b8ddbc04beaa0f2a1914fb6c64bfc2dfb
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in yang-jmx-generator-it. 03/13003/10
Marian Dubai [Thu, 20 Nov 2014 12:09:18 +0000 (13:09 +0100)]
Fix checkstyle warnings in yang-jmx-generator-it.

Change-Id: I448d07b553bdf432e2fe709947cb45d96af4426b
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in threadpool-config-impl 02/13002/10
Marian Dubai [Thu, 20 Nov 2014 12:08:15 +0000 (13:08 +0100)]
Fix checkstyle warnings in threadpool-config-impl

Change-Id: If16877977975fa07190ea8c245be3a80264a29ec
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netty-timer-config 01/13001/11
Marian Dubai [Thu, 20 Nov 2014 10:17:30 +0000 (11:17 +0100)]
Fix checkstyle warnings in netty-timer-config

Change-Id: I8c2127cfd7cf00edc8ffcc90882ec2965f4bb775
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoAdditional checkstyle fixes. Checkstyle validation fail enabled 11/12911/7
Marian Dubai [Tue, 18 Nov 2014 11:53:01 +0000 (12:53 +0100)]
Additional checkstyle fixes. Checkstyle validation fail enabled

Change-Id: Ie6052a2ed10e2964f3da56f1832a797e700dc2f6
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix duplicate dependency warnings 50/13150/6
Thanh Ha [Wed, 26 Nov 2014 19:18:56 +0000 (14:18 -0500)]
Fix duplicate dependency warnings

Reorganizes dependencies to be neater as well as resolve duplicate
dependencies that were causing Maven to throw warnings.

Change-Id: Id3bfa285df3beabb95a813509294fd288ee90e6e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix Sonar Bad practice - Method may fail to close stream 60/13060/6
Thanh Ha [Sat, 22 Nov 2014 23:30:30 +0000 (18:30 -0500)]
Fix Sonar Bad practice - Method may fail to close stream

Change-Id: I8360fce5e14a0b90134004e3255ee979fc73dfa3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoMerge changes I26ca5aba,Ia615dbd4
Tony Tkacik [Mon, 8 Dec 2014 14:58:28 +0000 (14:58 +0000)]
Merge changes I26ca5aba,Ia615dbd4

* changes:
  BUG-2459: optimize NetconfOperationRouterImpl operations
  BUG-2459: Reuse SAXTransformerFactory in EXI decoder

5 years agoMerge "BUG-2459: do not convert NetconfMessage"
Tony Tkacik [Mon, 8 Dec 2014 09:57:43 +0000 (09:57 +0000)]
Merge "BUG-2459: do not convert NetconfMessage"

5 years agoBUG-2459: optimize NetconfOperationRouterImpl operations 06/13406/4
Robert Varga [Fri, 5 Dec 2014 09:38:26 +0000 (10:38 +0100)]
BUG-2459: optimize NetconfOperationRouterImpl operations

Ensure operations are created immutable at initialization, thus removing
the need for synchronization and speeding up lookups.

Change-Id: I26ca5aba435d989689994364c53b4d27c7eccd84
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Fix improper cleanup of operational data in sal-netconf-connector's disconnect"
Tony Tkacik [Mon, 8 Dec 2014 09:08:11 +0000 (09:08 +0000)]
Merge "Fix improper cleanup of operational data in sal-netconf-connector's disconnect"

5 years agoMerge "Fix channelInactive event handling in the netty pipeline for netconf."
Tony Tkacik [Mon, 8 Dec 2014 09:07:36 +0000 (09:07 +0000)]
Merge "Fix channelInactive event handling in the netty pipeline for netconf."

5 years agoMerge "Remove logged unstubbed exception in test for netconf-monitoring"
Tony Tkacik [Mon, 8 Dec 2014 09:07:27 +0000 (09:07 +0000)]
Merge "Remove logged unstubbed exception in test for netconf-monitoring"

5 years agoBUG-2459: Reuse SAXTransformerFactory in EXI decoder 06/13306/13
Robert Varga [Tue, 2 Dec 2014 13:19:49 +0000 (14:19 +0100)]
BUG-2459: Reuse SAXTransformerFactory in EXI decoder

Rather than allocating the same factory over and over, create a single
instance for reuse.

Change-Id: Ia615dbd462527addadb03a5f2e54618438fb1612
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: do not convert NetconfMessage 84/13384/5
Robert Varga [Thu, 4 Dec 2014 22:55:47 +0000 (23:55 +0100)]
BUG-2459: do not convert NetconfMessage

Router's onNetconfMessage shows up as a hotspot in performance traces,
which turns out to be another case of coversion of XML document to a
string just for debugging/error handling purposes.

In case of a debug + error we are taking the hit of one toString()
operation, but that should be fine. We make that up by being smarter
about creating maps in the error path.

Change-Id: I78ec6ad44c4689b67bbc51184465c5092b0d8657
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Speed up chunked framing"
Tony Tkacik [Mon, 8 Dec 2014 09:02:25 +0000 (09:02 +0000)]
Merge "Speed up chunked framing"

5 years agoMerge "Remove duplicate dependency declaration"
Tony Tkacik [Mon, 8 Dec 2014 09:01:42 +0000 (09:01 +0000)]
Merge "Remove duplicate dependency declaration"

5 years agoReuse PEM provider in netconf-testtool. 18/13418/2
Maros Marsalek [Fri, 5 Dec 2014 13:31:09 +0000 (14:31 +0100)]
Reuse PEM provider in netconf-testtool.

Change-Id: Iedc005d2e2c717dc75320234a4605791e5307e53
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoSpeed up chunked framing 13/13413/3
Robert Varga [Fri, 5 Dec 2014 12:37:41 +0000 (13:37 +0100)]
Speed up chunked framing

Instead of allocating temporary byte arrays and ByteBufs, insert chunk
headers explicitly and transfer bytes directly from input message to
output.

Change-Id: Id300cbb9bc39b36e9a07def3d50c948edda7f570
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.