Bump to yangtools 2.0.20 and odlparent 3.1.7

to comply with new Fluorine SR3 dependencies

yangtools.yang.data.codec.gson.JSONNormalizedNodeStreamWriter
createExclusiveWriter has now 2 prototypes
JSONDataObjectConverter.java has to be adapted to avoid ambiguity

Change-Id: Ie04fada57672c4ff75eb45c942cc620308f4ff0e
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Fix some bugs in topology tests

Remove in some tests the manual node deletions in openroadm-network.
This action is already performed by TransportPCE when disconnecting the
topology-netconf device. Related tests should no longer report an error.

JIRA: TRNSPRTPCE-86
Change-Id: Icf0eb7b38a2bd6f82b24a64ed32c44238fdb9087
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

clean api pom

Change-Id: I57fc668daf8acbda5df718d1afab433663c46ab8
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Bump to Fluorine SR3 dev dependencies

Change-Id: I758d352facd8fe1913ec5b88be0a5f796f7628a0
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

bump project version

Change-Id: I7cbcbfc9d26043737b8a19008bfebd4b2d4475cf
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

deactivate faulty UT

OlmPowerServiceImplTest is still OK locally
but it now fails on releng after odlparent ang yangtools bump

Change-Id: If9ed48f36d21bc47bf4e69f25a1ee438f37066ff
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Bump to odlparent 3.1.6 and yangtools 2.0.16

Change-Id: I992abf5412b128723a4ce764398e813072e2354a
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

PCE unit testing update

Change-Id: I5e3e60917f855b4dbf854a158c4d6c4d2f31b78d

OLM unit testing update

Change-Id: I1ae94c6cd0daf6fed6dac0e1e7f74653bd218a5a

pce module unit testing init

JIRA: TRNSPRTPCE-61
Change-Id: Icb55e6e906f09320bc2460690e4fc6e843fbdadc

Bump TPCE dependencies after Fluorine SR1 release

Change-Id: I245f7915ce1f691359a273a5b7582b45d6814f5a
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Bump project version to x.y.(z+1)

Change-Id: I67d5d1e722eb61fe4c7c5900f4dd2894923a1212
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Bump to yangtools 2.0.13

Change-Id: I11b821a1b8182f5b6495048278f67b23813f6066
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

OLM unit testing update

Change-Id: Ic513dd8d5e36fd35b436cd4d397d7f2eb80c8572

Merge "test topology adapted to Honeynode" into stable/fluorine

test topology adapted to Honeynode

From last commit : old test with testtool is not called in tox anymore.
Tests 9 and 17 in test-topology are now completed to check termination
points (related to  PS 77801).
A config file was created to emulate node ROADMB with honeynode.
Corresponding test script was adapted. Tox was modified accordingly.

JIRA: TRNSPRTPCE-68
Change-Id: I5f1dd82be95f523d0942a582c0f156c09920e99a

initial olm unit testing commit

JIRA: TRNSPRTPCE-59
Change-Id: I0bd11fa7df291891acab856e5e4b666b9b23caa9

Bump to yangtools 2.0.12

Change-Id: I0214031cc909541f35b08d8453fd02c44a564bf6
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Bug correction in ServiceDatastore Operations

* modify mappingServices from ModelMappingUtils to not add container
topology in service datastore because RPC serviceImplementation not
returned this information. Otherwise Renderer module add this Topology
information in datastore.
* remove some bug in renderer ModelMappingUtils

Change-Id: I0280aabd5c9943030a27ec4cd27698413efc3d0d
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Bump oldparent to 3.1.4

Change-Id: I17497a22493ef1e2fee8735ad33927d1d06bc76e
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Update OLM function tests

- tests calculate-spanloss-base rpc with all links
- tests calculate-spanloss-current rpc

Change-Id: I0cf3cba86d92b478b9bf644a0ac222faf12253c9
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

OLM bug correction in rpc span-loss-current

- remove internal class which defined ROADM links
- bug correction in calculateSpanlossBase and calculateSpanlossCurrent
methods of OlmPowerServiceImpl class
- adapt olm yang model to return the list of roadm links with their
associated spanloss

Change-Id: I4c9477d873aad17791347a803b0d7f67f202ca0e
JIRA: TRNSPRTPCE-47
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

OLM functional Tests init

- complement functional test suite with additional checks
  - 'power' value of a roadm-connection
  - different cases according to presence or not of 'power-capabilities'
    in configuration node
- update initializing config files of nodes according to these tests

Change-Id: Ib3dd25ba3d9309023da2b91f76c719b35daa34ae
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

Enhance the createOtsOms RPC with a timer

Modify the createOtsOms RPC to be able to wait 1min until the operation
'updatePortmapping' refreshes the supportedOts information in the
portmapping datastore.

Change-Id: I8ebdb52f528a65d8abd1843ead54959f9d65ca79
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Honeynode Enhancements

- remove warnings in the fluorine controller logs
- make Honeynode use only one configuration file with all container :
  * netconf streams
  * org-openroadm-device
  * currentPmlist

JIRA:TRNSPRTPCE-38
Change-Id: I167be28214058d4d55d0bf7b49b220edcda8e402
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Bug correction in topoPortMapping tests

Change-Id: I7942014db5149258a7718c653a4e80db2b132f49
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Update testtool version to release/fluorine

Change-Id: Iad8ba2987c224bac0da0688c3b5a1aea4a0ae602
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Correct tp creation of Xponders in topo layer.

JIRA: TRNSPRTPCE-12
Change-Id: I27e891752709eda1e4606feaabba5db1c2eaecf4
Signed-off-by: Dhruv Bhardwaj <db929a@att.com>

remove stubs bundles from build process

move stubrenderer implementation to servicehandler test folder.

Change-Id: I8a284ea6445421aecbcd99a804274c5f20017e7d
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

remove impl and it useless folders

Change-Id: I55618d4d1da2651661c0222f7e2610e8597914a1
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Bump TPCE dependencies after Fluorine release

Change-Id: I9f63c1cf066e33fe6e4be10560c1db91f8a33a51
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Migrate transportpce docs to project repo

Issue: DOCS-69
Change-Id: I035abf694de6e5fb23ef3457d6584402c11cafb9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bootstrap transportpce documentation

Issue: DOCS-69
Change-Id: Ic3dd2d82ee6af8cdb50a971d1012646dc54f89d1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump project version to x.y.(z+1)

Change-Id: I6132cd73bf3dbeb2590063020c98d28db4026dd7
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Merge "Revert "Bump to upstreams to released Fluorine artifacts"" into stable/fluorine

Revert "Bump to upstreams to released Fluorine artifacts"

This reverts commit 15338daf66c2a2fd7cdae199c4acb9c5311c177d.

Change-Id: Iced6a77cde14e9793ffedf440b368f61c2166d41

Add archives/ to .gitignore

The maven-release job seems to pick up the archives/ directory during
the build and fails. Ignore that directory as we should not be
git tracking it.

Change-Id: I36951cf345131e10e1a464856c3971ed5ef3bc97
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump to upstreams to released Fluorine artifacts

This bumps version to depend on released artifacts.
Also change project version to 0.2.0 and remove useless folders.

Change-Id: I3c914627b1225d5cdd395d2a334cfa4effa14442
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

fix more javadocs warnings

Change-Id: Ic03ee472e01b7d229759fb2c5fca93c44b7332b2
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

fix javadocs errors and warnings

Change-Id: Ifc315c5787bca120d6e177ba3576024058052d05
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

clean some compilation warnings

- remove HiddenField warnings
- remove HideUtilityClassConstructor warnings
- remove Servicehandler private constructors call from Junit tests

Change-Id: I48af49e124dee63793fb4193aa7d79bb6d808a49
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

fix functests failures

Change-Id: Id27d7f8de35b5e5b8b357c761a93ccd095de6073
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

clean some compilation warnings

remove WhitespaceAround and LineLength warnings

Change-Id: Idbf503cae338870786e0fc7960ea1b2d8353db80
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

fix Honeynode issues with fluorine

- solve the OpenEXI compability with honeynode with a patch to
netconf-netty-util module
- solve the rpc 'get-schema' error by putting a netconfState info in the
OPERATIONAL datastore and copying in a dedicated folder all the yang
schemas needed at honeynode start-up (similarly to testtool)
- move device datastore config listener from core module
'minimal-distribution-core' to 'honeynode-plugin-impl' module.

JIRA: TRNSPRTPCE-32
Change-Id: I9af0ec2e098271a18993433cf99db9b3b5f73b20
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Merge "fix netconf testtool portmapping" into stable/fluorine

Merge "Update unit testing - Renderer" into stable/fluorine

Update unit testing - Renderer

JIRA: TRNSPRTPCE-11
Change-Id: I721603b6733accca1fa1fdaf2c3eb8f3cf0d77f2
Signed-off-by: doha.khaled <dkhaled.ext@orange.com>

fix netconf testtool portmapping

Change-Id: I0a1aa88e3488fd585ea85616210761799ba046ad
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Update .gitreview to stable/fluorine

Change-Id: I3e323255c374bea36962302074f0fe93d526f48e
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Add check in cp state to avoid npe

Change-Id: I27469f5e95e7a20a5110628515ce099e760d1a51

Removed debug statement

Change-Id: Iabb51395f3ef8256da307d63b996d4c4612eead7

Update xponder portmapping

Change-Id: Ib740319fc4b5ee9e6cd3a9b6e275f1321b465ec5

Merge "Fix Issues coming up during end to end testing"

Fix Issues coming up during end to end testing

1. Correct NodeId read offset in ModelMapping Utils
2. Correct Portmapping creation for XPDR
3. Remove notification subscription feature
4. Deleted unit test file :
    RendererServiceOperationsImplTest,
    RendererServiceOperationsImplDeleteTest.

Change-Id: Id29187c59dac9b9afa7479e057a60448d3c42bca

Remove the inventory feature

The inventory feature needs to be rethought and also requires an
external DB that will not be shipped in the formal release.

Change-Id: I1eae9a429592151bc1faedb3473f9029b9dfc800
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

fix functional tests

Change-Id: Iad15d5af4b9376bcb734412109a0b0a755d4ecd5
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Update unit testing - Renderer

JIRA: TRNSPRTPCE-11
Change-Id: I42f760cdd39ed0a7585965a506ba05070b370529
Signed-off-by: doha.khaled <dkhaled.ext@orange.com>

Fix circuit-pack equipment state on XPDR

Change the equipment state of circuit-packs supporting ETH and OCH
interfaces of XPDR node to "not-reserved-inuse" after creation and to
"not-reserved-available" after deletion.

JIRA: TRNSPRTPCE-28
Change-Id: Id662d1ef664f8283ca4ae7cd25a7f874351fdd7a
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

Creation of OTS-OMS interfaces

- add new rpc in renderer@2017-02-28.yang
- add 2 methods in OpenRoadmInterfaceFactory.java to create ots and oms
interfaces on ROADM configuration datastore
- add method in PortMappingImpl.java to update the associated mapping
with new interfaces just created
- modify DeviceRendererServiceImplTest.java and
RendererServiceOperationsImplTest.java to take into account blueprint
modification..

Change-Id: I4eb21aed513a5378d23559827bc581dad60412a3
JIIRA: TRNSPRTPCE-8
JIIRA: TRNSPRTPCE-33
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

fix unit test Renderer

JIRA: TRNSPRTPCE-11
Change-Id: Ibf13f1af6ba04755c624ee58e6a5520e14c44adc
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

clean some compilation warnings

mostly remove LineLength warnings introduced in Fluorine bump changes

Change-Id: I1ab4cd671ad7a453abd2c5a158a7590bda7ca1ce
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

update netconf testtool version

- switches testtool mock version from 1.3.1 to 1.5.0-SNAPSHOT
  (netconf dir git submodule switched to branch 'origin/master'):
  testtool 1.3.1 caused some errors with the fluorine controller for
  several reasons including EXI messages generation.
- updates patches, nose tests files and scripts consequently

JIRA: TRNSPRTPCE-32
Change-Id: I27476ea83edefbffff986ddc856078219f925fc6
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

remove rfc8345 dependencies

- remove direct dependencies in ordmodels
- remove indirect dependencies inherited from mdsal models in others pom
- repackage correctly ietf-network-* models revision 2015-06-08

JIRA: TRNSPRTPCE-29

Change-Id: Icbf5f9cef59fed6f04c741f2cfb0875f63a82026
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

package ietf-network 2015-06-08 yang models

JIRA: NETCONF-550
JIRA: TSC-124
JIRA: TRNSPRTPCE-29

Change-Id: I416422e94a8f684b1246efa21cddb424d2136c11
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Upgrade to Fluorine dependencies

This switches all the ODL dependencies to the appropriate versions for
Fluorine.

Note that due to the rfc8345 ietf-network migration, openroadm imports
of 2015-06-08 ietf-network-* models are no more available so this fails
to build until those obsolete draft models are repackaged inside tpce.
https://git.opendaylight.org/gerrit/#/c/73591/

JIRA: NETCONF-550
JIRA: TSC-124
JIRA: TRNSPRTPCE-29

Change-Id: I288e560cc9eb376facc61c34a098b3fba5f524d8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove Karaf4 useless features

Change-Id: I02496ac1574d2094eb937fa995cad251ec94cafc
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

fix some compilation warnings

Change-Id: I73d5b4906d85cfc2ab6e2457335192e8a8d19ce7
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Initial unit testing commit - Renderer

JIRA: TRNSPRTPCE-11
Change-Id: Iae7f1d5d4e4b8d9ba3227b5debcc30437220d460

fix functional tests suite

- fix ServiceHandler Stub patch file
- fix the tox.ini configuration file so that the complete test suite can
  be performed
- comment out the portmapping and servicehandler tests 01 since there is
  no more netconf node "controller-config" automatically connected

Change-Id: I044063b6adc06a42d58101d66cc8712b44ec55b4
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

RPC to delete link

Implemented RPC to delete link with a given link-id

JIRA: TRNSPRTPCE-16

Change-Id: I722002997250d4dd07a2f9195f4828eecc7dcfee

Manage service deletion on XPDR node

-Manage the case where XPDR ports (client, line) are unidirectionals.
-Test if an OCH interface is not used by another cross-connection
(in the reverse side) before deleting it (new isUsedByXc() method).

Change-Id: Icceef760c21626c96ea1c48b417fd2332372da47
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>

ServiceHandler unit testing update

The Complete unit testing for the ServiceHandler module

Change-Id: Ica4bbba4e94bd46c8c44d965071fe0409abd4637

Service Handler unit test update

-serviceReroute
-PCEServiceWrapper

Change-Id: I0f77e47d1b246c9349c15c50b9a0187d099053dd

Test alignment between topology and portmapping

- connect one ROADM and one XPDR
- check the alignment of the TPs naming between both the topology
and what appears in the port mapping
- test 5 fails because naming of TP  are not aligned for the XPDR

JIIRA: TRNSPRTPCE-5
Change-Id: I514f2cae964c8cb12e2bb8700a19d946f4059b72
Signed-off-by: Ahmed Triki <ahmed.triki@orange.com>

Topology functional tests bugs correction

- modify the code to ignore the order of appearance of nodes or links
in the REST query responses
- tests 24, 25, 33 and 37 have been commented out. They fail because of
  current mocks limitations.
- add the karaf launch option "server"

JIRA: TRNSPRTPCE-4
JIRA: TRNSPRTPCE-13
Change-Id: I7662255acbfd1a2fe075a7397f23e606a4252d92
Signed-off-by: Ahmed Triki <ahmed.triki@orange.com>

Functional tests for the topology init

- connects successively ROADMA, XPDRA ROADMB and ROADMC and then
disconnect them
- checks that the clli-network, the openroadm-network and the
openroadm-topology are well updated and the appropriate links/nodes
are well created/deleted after each creation/deletion operation
- checks that a degree is not used by more than one link at the same
time
- tests 9 and 17 currently fail beause 4 TPs appear (XPDR1-CLIENT1,
XPDR1-NETWORK1, XPDR1-CLIENT2 and XPDR1-NETWORK2) while only 2 TPs are
defined in the sample-config-XPDRA.xml
- tests 24, 33 and 37 currently fail because the link ROADM-to-ROADM
is not automatically deleted.
A new version of the code will be proposed by ATT where these links will
be marked as up or down:
    Up to indicate the pce that the path is available for service
    Down to indicate that the path is not available

JIRA: TRNSPRTPCE-4
Change-Id: Iba78869ad884fadd766f11c4c321ae1b4bdfcd64
Signed-off-by: Ahmed Triki <ahmed.triki@orange.com>

fix karaf launch error from tox

Add a karaf launch option 'server' in python nose files.
This option disables the karaf local console.
(OPTS="-Dkaraf.startLocalConsole=false -Dkaraf.startRemoteShell=true")

Change-Id: Iac160454fa6a74aa31813dacbb74a94dce417592
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

fix some karaf runtime errors

remove the following errors :
- netconf-monitoring already start error
- netconf-impl completion error cause by netconf-console
the netconf CLI is still broken at startup but works again after one
Netconf device has been connected (through the REST API)

JIRA: NETCONF-534
JIRA: TRNSPRTPCE-6
Change-Id: Idec350c7679891098bd8b94448292468a787fa1c
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Increase OLM timer to turn-up xc power in RDM node

Increase a timer from 20s to 60s when the RDM node is in a "power" state
to let it configure the optical power level of a cross-connection before
moving to "gainLoss" state.
NB: The value recommended in the openroadm whitepaper is normally 20s.

Change-Id: Ife8153f11977844f2b074d118e1dcfe93858eb79
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

Bug corrections in ServiceHandler

- Change CONFIGURATION datastore to OPERATIONAL which is the right
LogicalDatastoreType to look into to get services already created.
- Fix the bug mappingServices method in ModelMappingUtils class.

Change-Id: I23a0871e0f1d50180c3b09f185693888e2a83840
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Co-authored-by: Doha Khaled <dkhaled.ext@orange.com>

Functional Tests for servicehandler

These tests verify the servicehandler RPCs service-create and
service-delete.
Some tests have been (temporarily) disabled because a few RPCs are no
more available following the ServicePath downgrade from 1.6 to 1.5 :
cf change 72037 'ServiceHandler update for new PCE compatibility'

Change-Id: Ib57a35aef9cd89fc7b3e26bbd43d6a5195e5d533
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

ServiceHandler unit tests init

Change-Id: I4cd1989fea6971e7d06874978fe05d33407c0f78
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Signed-off-by: doha.khaled <dkhaled.ext@orange.com>

ServiceHandler update for new PCE compatibility

- Updates to have org-openroadm-service.yang
- Creates new mapping utils
- Implements service-create, service-reroute and service-delete RPCs
- Integrates the Service handler with PCE, Renderer, OLM and network
topology manager
This commit downgrades the Service Handler functions to the servicepath
1.5 YANG specifications so that they match with the PCE current RPCs.
This implies that some RPCs already implemented in servicepath 1.6
(service-reconfigure,service-restoration) will no more be available,
at least until the PCE is upgraded.

Change-Id: I94f2edbcfbde22747871e7eec55ed01e198e40af
Signed-off-by: Shweta <sv111y@att.com>
Co-Authored-By: Dhruv Bhardwaj <db929a@att.com>
Co-Authored-By: Shweta Vachhani <sv111y@att.com>
Co-Authored-By: Masha Dorfman <>
Co-Authored-By: Archana Soundararajan <as7463@att.com>
Co-Authored-By: Juraj Veverka <Juraj.Veverka@pantheon.tech>
Co-Authored-By: Samuel Kontri <samuel.kontris@pantheon.sk>
Co-Authored-By: Andrej Zan <andrej.zan@pantheon.sk>
Co-Authored-By: Milan Fratrik <>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

fix karaf runtime log console

JIRA: TRNSPRTPCE-6
Change-Id: I6f7b46c77f54742a02de2b8200d04e3592f34bea
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

fix some compilation warnings

Change-Id: I007c87de212afbc58ad91965eeefa3649066c375
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

PCE module init

- Minimim hop based path calculation using network model
- Weighted path calculation based on propagation delay
- Checks available wavelength
- Supports hard constraints based routing with latency
- Provides JUnit tests
- Adds a pce functionnal test  (python script 'tests_pce.py')
- Creates for it a specific profile called 'pce' in the tox.ini file.
  PCE functionnal tests can be launched from the tests folder with
  the command 'tox -e pce'

Co-Authored-By: Dhruv Bhardwaj <db929a@att.com>
Co-Authored-By: Shweta Vachhani <sv111y@att.com>
Co-Authored-By: Masha Dorfman <>
Co-Authored-By: Archana Soundararajan <as7463@att.com>
Co-Authored-By: Juraj Veverka <Juraj.Veverka@pantheon.tech>
Co-Authored-By: Samuel Kontri <samuel.kontris@pantheon.sk>
Co-Authored-By: Andrej Zan <andrej.zan@pantheon.sk>
Co-Authored-By: Milan Fratrik <>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Change-Id: I7be504ec423e240baaeaa731d50424be46df82ea
Signed-off-by: Shweta <sv111y@att.com>
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

fix build configuration and dependencies

repair project build by correcting dependencies import

Change-Id: Id4c6beb550d81a6f00dd76315801b411b4c1bd23
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

creates common test functions

adds a test-common folder at project root that contains several
functions to convert XML to DataObjectConverter and vice versa

Co-Authored-By: Dhruv Bhardwaj <db929a@att.com>
Co-Authored-By: Shweta Vachhani <sv111y@att.com>
Co-Authored-By: Masha Dorfman <>
Co-Authored-By: Archana Soundararajan <as7463@att.com>
Co-Authored-By: Juraj Veverka <Juraj.Veverka@pantheon.tech>
Co-Authored-By: Samuel Kontri <samuel.kontris@pantheon.sk>
Co-Authored-By: Andrej Zan <andrej.zan@pantheon.sk>
Co-Authored-By: Milan Fratrik <>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Change-Id: Ie7fbe4db4678843bc89e67a2269a5587e722ef75
Signed-off-by: Shweta <sv111y@att.com>
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

clean some XML files

removes tabs and trailing blanks from various XML files and configs

Change-Id: I903f94d66b639514947cac671628f0a54a42db47
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

Bug corrections in topo and portmapping modules

- insert if not found, the SRG number into the logical connection
point name during the portmapping creation.
- add the CP as one of the  termination points of the SRG
- put the right node type value of the XPONDER
- take into account the ROADMs found by the lldp even if the previous
declared ones are missing

Change-Id: I9da179dada5a23c764da3fdb3f74ccd493e9dc4e
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Relicensing a few files from EPL to Apache License

Honeynode resused some files under EPL that come from a previous
testtool development. This commit relicenses those files.
FD.io honeycomb project uses the Apache License contrary to ODL.
EPL headers in honeynode generated checkstyle errors during build phase.

Change-Id: I76b02475146866e3c44802274069bdcc680c931f
Signed-off-by: Dhruv Bhardwaj <db929a@att.com>
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Honeynode test tool

- Add honeynode folder in tests module.
- Add some operational config files.
- Add README file.

Honeynode is base on FD.io project https://fd.io/.
Due to checkstyle warnings cause by FD.io licence
you have to compile this projects with:
mvn clean install -DskipTests=true -Dcheckstyle.skip

Change-Id: I43b94db04f27c2e93b096aa4c7488dc51ca104a2
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Bugs correction in NetworkModelService

Modify NetworkModelService class to add deleteOpenROADMnode function
to be able to :
- delete OpenROADM node portmapping
- delete OpenROADM node topologies (clli-network, openroadm-network,
openroadm-topology) created in datastores.
Modify NetConfTopologyListener OnDataTreeChanged to allow Portmapping
working in Oxygen. This issue is similar to the previous commit
"Bug correction in RendererNotificationImpl"

JIRA: TRNSPRTPCE-18
Change-Id: Ib529aff433c14c1c103f39be158b2a7746cb0cef
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Network topology and inventory init

- Includes network topology creation when NE gets mounted including
CLLI, Openroadm-Network and Openroadm-Topology
- Abstracts network model for Roadm and Xponder nodes
- Derives Roadm-to-Roadm links from LLDP config and notifications
- Provides RPC to create Xponder-input and Xponder-output links
- Includes functionality to update available and used pool based
on service-create and service-delete request
- Remove log error for LLDP subtree
Differences with initial change from ATT-Sandbox branch
- Fix code design issues pointed by Juraj (Patch Set 5)
https://git.opendaylight.org/gerrit/#/c/68859/5
- fix inventory feature building

Co-Authored-By: Dhruv Bhardwaj <db929a@att.com>
Co-Authored-By: Shweta Vachhani <sv111y@att.com>
Co-Authored-By: Masha Dorfman <>
Co-Authored-By: Archana Soundararajan <as7463@att.com>
Co-Authored-By: Juraj Veverka <Juraj.Veverka@pantheon.tech>
Co-Authored-By: Samuel Kontri <samuel.kontris@pantheon.sk>
Co-Authored-By: Andrej Zan <andrej.zan@pantheon.sk>
Co-Authored-By: Milan Fratrik <>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Change-Id: I440caf77157d2fa5a5b17ab048252c96833e7561
Signed-off-by: Shweta <sv111y@att.com>
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Minor checkstyle corrections

Change-Id: Ie9f5ba977615211e5813cc47d39fb7f363d961e1
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

activate deleteMapping function in Renderer

the deleteMapping data function was added in a previous commit
dcc4c10093436dbb7692c50c210daf86fd5b124a

more details in Gerrit change 74091
https://git.opendaylight.org/gerrit/#/c/74091/

Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I5392512a0b3323178aef6275de0d938cdb74a7e3
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Renderer and OLM update

- Supports multiple threads configuring devices simulatneously rather
than sequentially earlier.
- It is now updating service-list topology with port-trail details.
- Performs service activation test by checking pre-FEC BER values at
a-end and z-end transponders and compares it to a threshold.
- Rollback:
    - Rollback based on device provision failure
    - Rollback based on powerset failure
    - Rollback based on ber test failure
- Alarm management:
    - Alarm parsing and logging for fault detection
    - Alarm suppression at the time of service-request
    - Alarm inventory
- Simultaneous power control on A-Z and Z-A direction
- New RPC for calculating span loss base and current based on
network model.

Co-Authored-By: Dhruv Bhardwaj <db929a@att.com>
Co-Authored-By: Shweta Vachhani <sv111y@att.com>
Co-Authored-By: Masha Dorfman <>
Co-Authored-By: Archana Soundararajan <as7463@att.com>
Co-Authored-By: Juraj Veverka <Juraj.Veverka@pantheon.tech>
Co-Authored-By: Samuel Kontri <samuel.kontris@pantheon.sk>
Co-Authored-By: Andrej Zan <andrej.zan@pantheon.sk>
Co-Authored-By: Milan Fratrik <>
Co-authored-by: Martial COULIBALY <martial.coulibaly@gfi.fr>
Change-Id: I7292e82bfecb5fe9c025f9fde8bcd5ebc3be90ba
Signed-off-by: Shweta <sv111y@att.com>
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

Update testtool version in tests folder

- testtool 1.3.1-SNAPSHOT is no more available in netconf nexus repo.
  Switched netconf submodule to branch 'release/nitrogen-sr1' (=1.3.1).
- updated portmapping tests and start.sh with testtool new version.
- changed portmapping tests restconf address 172.0.0.1 into localhost
  because of some tox issues.

Change-Id: Ie885f71c8103800a7888bd456170ceb98e2424df
Signed-off-by: Martial COULIBALY <martial.coulibaly@gfi.fr>

rewrite portmapping functional test

- add support for xpdr devices
- add some tests to check the devices are correctly (dis)connected
- remove useless tests
- add a folder and a subfolder for ordm 1.2.1 sample configuration files
- update the sample ROADM configuration file for tests purpose
  Add new data to create a SRG3 but no SRG2. This is to ensure that
  portmapping parses correctly config with unordered SRGs.
  The related test is "test_07_rdm_portmapping_SRG3_PP1_TXRX".
- add a specific tox profile to allow running portmapping tests only
- add a folder with ordm 1.2.1 models needed by testtool
- update schemas location in build.sh
  New 2.x schemas previously pushed in ordmodels generate errors in
  testool with current ordm 1.2.1 sample configs.
  Although, tests must show that an ODL instance compiled with 2.x
  models can manage ordm 1.2.1 devices.

Change-Id: I67ed29d00cf5cd75e7a9ff854ab598522fc1b83f
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>

Bug correction in LogicalConnectionPoint naming

insert if not found, the SRG number into the logical connection point
name during the portmapping creation.

Change-Id: I979dac8100a17c122cf73f2e77403a4df19a03db
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>