controller.git
6 years agoMerge changes I9865d0cd,Ic71d525f,Ib8faba91,Ia10e5ec9,I35591747,If456a131,I9f8709cc
Tony Tkacik [Sat, 8 Nov 2014 16:08:44 +0000 (16:08 +0000)]
Merge changes I9865d0cd,Ic71d525f,Ib8faba91,Ia10e5ec9,I35591747,If456a131,I9f8709cc

* changes:
  Fix non-generic references to List
  Hide XSQLBluePrintRelation.addToResult()
  Fix non-generic references to Set
  Fix HashMap references
  Fix raw references to java.lang.Class
  Fix raw references to NotificationListener
  Fix non-generic references to HashSet

6 years agoMerge changes I52c2aaab,I2509ed5e,Ic1d8a4e5,I73730f79,Ica1959e5,I0ce61b07
Tony Tkacik [Sat, 8 Nov 2014 16:06:15 +0000 (16:06 +0000)]
Merge changes I52c2aaab,I2509ed5e,Ic1d8a4e5,I73730f79,Ica1959e5,I0ce61b07

* changes:
  Fix a raw Dictionary reference
  Fix a raw Enumeration reference
  Fix a non-generic CheckedFuture
  Access static methods via class
  Remove unused local variable
  Fix non-generic references to Optional

6 years agoMerge "Do not create Map subclasses"
Tony Tkacik [Sat, 8 Nov 2014 15:59:58 +0000 (15:59 +0000)]
Merge "Do not create Map subclasses"

6 years agoFix a raw Dictionary reference 17/12617/2
Robert Varga [Fri, 7 Nov 2014 17:41:47 +0000 (18:41 +0100)]
Fix a raw Dictionary reference

Fix the cast to match the variable declaration.

Change-Id: I52c2aaab4f9df9699672042b23272a7b8cc54e98
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix a raw Enumeration reference 16/12616/2
Robert Varga [Fri, 7 Nov 2014 17:40:39 +0000 (18:40 +0100)]
Fix a raw Enumeration reference

Adds the proper type argument.

Change-Id: I2509ed5efc784ab5bef8a34aed66223c69cc41ab
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix a non-generic CheckedFuture 25/12625/2
Robert Varga [Fri, 7 Nov 2014 17:22:13 +0000 (18:22 +0100)]
Fix a non-generic CheckedFuture

This adds proper type, and actually amkes the code cleaner.

Change-Id: Ic1d8a4e526830dd9ce48e0677b97842def537cf4
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAccess static methods via class 15/12615/2
Robert Varga [Fri, 7 Nov 2014 18:16:12 +0000 (19:16 +0100)]
Access static methods via class

Invocation is slightly faster and fixes eclipse warnings.

Change-Id: I73730f7903aa8f25786625aa4903dc66d4f61e09
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove unused local variable 22/12622/2
Robert Varga [Fri, 7 Nov 2014 17:11:55 +0000 (18:11 +0100)]
Remove unused local variable

It does not use generic arguments, it's unused, and has overall no
impact (aside from eclipse warnings).

Change-Id: Ica1959e50f6e60a9431893e2ebee31a5595fc6db
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix non-generic references to Optional 21/12621/2
Robert Varga [Fri, 7 Nov 2014 17:09:24 +0000 (18:09 +0100)]
Fix non-generic references to Optional

Just adds arguments as needed.

Change-Id: I0ce61b07e3286a2d3415c92bbbe5e5bc28b5baef
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix non-generic references to List 24/12624/2
Robert Varga [Fri, 7 Nov 2014 17:18:22 +0000 (18:18 +0100)]
Fix non-generic references to List

Adds arguments as appropriate.

Change-Id: I9865d0cd56b9432be8cc079e32f5c6c513ba51e0
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoHide XSQLBluePrintRelation.addToResult() 23/12623/2
Robert Varga [Fri, 7 Nov 2014 17:17:32 +0000 (18:17 +0100)]
Hide XSQLBluePrintRelation.addToResult()

Also fixes non-generic references to List.

Change-Id: Ic71d525fde6b0c52a2aa181e0da4e6c50f140721
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix non-generic references to Set 20/12620/2
Robert Varga [Fri, 7 Nov 2014 17:07:21 +0000 (18:07 +0100)]
Fix non-generic references to Set

Adds arguments as appropriate.

Change-Id: Ib8faba91bd9fc8751014ea00f1859636e0fcda6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix HashMap references 18/12618/2
Robert Varga [Fri, 7 Nov 2014 16:56:34 +0000 (17:56 +0100)]
Fix HashMap references

This patch fixes missing generic arguments not being added to HashMap
references.

Change-Id: Ia10e5ec9dc3ac1f95fc08dcd11c6a963cec5da02
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix raw references to java.lang.Class 36/12636/2
Robert Varga [Fri, 7 Nov 2014 18:13:29 +0000 (19:13 +0100)]
Fix raw references to java.lang.Class

Fixes eclipse warnings just by adding either a wildcard, or the proper
type.

Change-Id: I35591747ae585f5af262f98c7592430d6a9268e2
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix raw references to NotificationListener 35/12635/2
Robert Varga [Fri, 7 Nov 2014 17:54:15 +0000 (18:54 +0100)]
Fix raw references to NotificationListener

The restconf broker has raw references, so modify the type definition to
allow passing the type down.

Change-Id: If456a1312d1ccce67987d0b4db1ba613b48d91db
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix non-generic references to HashSet 19/12619/2
Robert Varga [Fri, 7 Nov 2014 17:00:58 +0000 (18:00 +0100)]
Fix non-generic references to HashSet

Adds arguments and changes to use ImmutableSet.of() where that
is more straighforward.

Change-Id: I9f8709cc320ee9804eb2d83e552ec69cc99ee05a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDo not create Map subclasses 48/12648/3
Robert Varga [Fri, 7 Nov 2014 19:34:56 +0000 (20:34 +0100)]
Do not create Map subclasses

Rather than using subclasses for initialization, which require a serial
version, populate them normally -- thus fixing warnings.

Change-Id: Ia204b3ed6a58acaee1de2f1d780a9421cd0eea8f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG 2339 : TransactionChain id created by the Clustered Data Store are not unique 58/12658/1
Moiz Raja [Sat, 8 Nov 2014 02:12:45 +0000 (18:12 -0800)]
BUG 2339 : TransactionChain id created by the Clustered Data Store are not unique

The fix is to use a simple atomically incrementing integer to form the transaction chain
identifier instead of using the system time.

I also added a few log statements in there which were helpful in debugging the issue.

Change-Id: Ie1465f1640d6be0ff9da0f66477ebafc7ebff137
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Bug 2318: Follow-up changes for previous patch 12535"
Moiz Raja [Fri, 7 Nov 2014 20:41:48 +0000 (20:41 +0000)]
Merge "Bug 2318: Follow-up changes for previous patch 12535"

6 years agoMerge "BUG 2317 : StatisticsManager does not unregister from yang notifications on...
Tom Pantelis [Fri, 7 Nov 2014 18:42:12 +0000 (18:42 +0000)]
Merge "BUG 2317 : StatisticsManager does not unregister from yang notifications on close"

6 years agoBUG 2303 : Remove the implementation of AddRaftPeer/RemoveRaftPeer 07/12607/2
Moiz Raja [Tue, 4 Nov 2014 01:10:59 +0000 (17:10 -0800)]
BUG 2303 : Remove the implementation of AddRaftPeer/RemoveRaftPeer

It is both unused and incorrect

Change-Id: Ie0a9844ccf4de7dae68586954031599b55646c47
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Bug-2301 - Clustering:Snapshots need not be stored in in-mem ReplicatedLog...
Moiz Raja [Fri, 7 Nov 2014 17:03:06 +0000 (17:03 +0000)]
Merge "Bug-2301 - Clustering:Snapshots need not be stored in in-mem ReplicatedLog for Installing snapshots"

6 years agoMerge "Update junit Assert imports"
Tony Tkacik [Fri, 7 Nov 2014 14:30:42 +0000 (14:30 +0000)]
Merge "Update junit Assert imports"

6 years agoMerge "Migrade JUnitMatchers references"
Tony Tkacik [Fri, 7 Nov 2014 14:30:28 +0000 (14:30 +0000)]
Merge "Migrade JUnitMatchers references"

6 years agoMerge "Remove unused imports"
Tony Tkacik [Fri, 7 Nov 2014 14:30:18 +0000 (14:30 +0000)]
Merge "Remove unused imports"

6 years agoMerge "Fix checkstyle warnings in opendaylight/netconf"
Tony Tkacik [Fri, 7 Nov 2014 14:30:01 +0000 (14:30 +0000)]
Merge "Fix checkstyle warnings in opendaylight/netconf"

6 years agoMerge "Fix checkstyle warnings in opendaylight/config"
Tony Tkacik [Fri, 7 Nov 2014 14:29:51 +0000 (14:29 +0000)]
Merge "Fix checkstyle warnings in opendaylight/config"

6 years agoMerge "Create config-artifacts"
Tony Tkacik [Fri, 7 Nov 2014 14:08:15 +0000 (14:08 +0000)]
Merge "Create config-artifacts"

6 years agoUpdate junit Assert imports 03/12603/1
Robert Varga [Fri, 7 Nov 2014 12:42:30 +0000 (13:42 +0100)]
Update junit Assert imports

JUnit 4.11 has moved Assert to org.junit, and deprecated
junit.framework.Assert. This adjust the imports to fix the warnings.

Change-Id: Iecbf2a1b4ae097989e840ad6f6d5bf759c521639
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMigrade JUnitMatchers references 02/12602/1
Robert Varga [Fri, 7 Nov 2014 13:05:56 +0000 (14:05 +0100)]
Migrade JUnitMatchers references

With JUnit 4.11 JUnitMatchers.containsString() has been deprecated in
favor of org.hamcrest.CoreMatchers.containsString(). Same goes for
hasItem().

Change-Id: Ie11616588b126110579e92bfb4b72de022bf211c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove unused imports 01/12601/1
Robert Varga [Fri, 7 Nov 2014 12:49:49 +0000 (13:49 +0100)]
Remove unused imports

This fixes warnings stemming from unused imports.

Change-Id: I7e91ca9fdde55f19d0463c9f662ca96f8270c87d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix checkstyle warnings in opendaylight/netconf 97/12597/2
Robert Varga [Fri, 7 Nov 2014 10:42:22 +0000 (11:42 +0100)]
Fix checkstyle warnings in opendaylight/netconf

Change-Id: I4f3da06f1166a924a4a7623047251167df84a389
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix checkstyle warnings in opendaylight/config 96/12596/2
Robert Varga [Fri, 7 Nov 2014 10:34:06 +0000 (11:34 +0100)]
Fix checkstyle warnings in opendaylight/config

Change-Id: Ie82918d2888b6271850e371340b46825079ad485
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in sal-akka-raft 72/12572/2
Robert Varga [Thu, 6 Nov 2014 12:42:52 +0000 (13:42 +0100)]
Fix warnings in sal-akka-raft

Make sure to add generic arguments to instantiation and do not use
deprecated junit classes.

Change-Id: I0a84c3c20125a00bb262bf4dfce30c77fcaa765d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd generic arguments to Answer 71/12571/2
Robert Varga [Thu, 6 Nov 2014 12:42:11 +0000 (13:42 +0100)]
Add generic arguments to Answer

Just use Object as the argument to get rid of the warnings.

Change-Id: I17d2ee9c518ed53c27bd5e1c330e7c161a388194
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Introduce forwarding DOMData classes"
Tony Tkacik [Fri, 7 Nov 2014 10:30:22 +0000 (10:30 +0000)]
Merge "Introduce forwarding DOMData classes"

6 years agoMerge "Fix a typo in javadoc"
Tony Tkacik [Fri, 7 Nov 2014 10:29:10 +0000 (10:29 +0000)]
Merge "Fix a typo in javadoc"

6 years agoCreate config-artifacts 39/12439/2
Robert Varga [Tue, 21 Oct 2014 12:55:34 +0000 (14:55 +0200)]
Create config-artifacts

This creates a dedicated artifact for hoilding the config subsystem
artifacts, which then can be reused by downstream projects.

Change-Id: I94637d6b9266e845f7d53eae058b847a24795d0e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Bug 2233 - RPC register exception when rpc has no input"
Tony Tkacik [Fri, 7 Nov 2014 10:18:49 +0000 (10:18 +0000)]
Merge "Bug 2233 - RPC register exception when rpc has no input"

6 years agoMerge "BUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance...
Tony Tkacik [Fri, 7 Nov 2014 10:12:42 +0000 (10:12 +0000)]
Merge "BUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance attribute with namespaces"

6 years agoMerge "Fix logback-config warnings"
Tony Tkacik [Fri, 7 Nov 2014 10:06:13 +0000 (10:06 +0000)]
Merge "Fix logback-config warnings"

6 years agoMerge "Remove duplicate groupId"
Tony Tkacik [Fri, 7 Nov 2014 10:06:00 +0000 (10:06 +0000)]
Merge "Remove duplicate groupId"

6 years agoMerge "Fix warnings in netconfig-netty-util"
Tony Tkacik [Fri, 7 Nov 2014 10:05:48 +0000 (10:05 +0000)]
Merge "Fix warnings in netconfig-netty-util"

6 years agoMerge "Fix warnings in netconfig-monitoring"
Tony Tkacik [Fri, 7 Nov 2014 10:05:34 +0000 (10:05 +0000)]
Merge "Fix warnings in netconfig-monitoring"

6 years agoMerge "Fix cluster test warnings"
Tony Tkacik [Fri, 7 Nov 2014 10:05:22 +0000 (10:05 +0000)]
Merge "Fix cluster test warnings"

6 years agoMerge "Add serialversionUUID to cluster/datastore/modification"
Tony Tkacik [Fri, 7 Nov 2014 10:05:04 +0000 (10:05 +0000)]
Merge "Add serialversionUUID to cluster/datastore/modification"

6 years agoMerge "Fix raw Class in sal-distributed-datastore messages"
Tony Tkacik [Fri, 7 Nov 2014 10:04:46 +0000 (10:04 +0000)]
Merge "Fix raw Class in sal-distributed-datastore messages"

6 years agoMerge "Fix warnings in clustering"
Tony Tkacik [Fri, 7 Nov 2014 10:03:58 +0000 (10:03 +0000)]
Merge "Fix warnings in clustering"

6 years agoMerge "Fix warnings in config-manager"
Tony Tkacik [Fri, 7 Nov 2014 10:03:30 +0000 (10:03 +0000)]
Merge "Fix warnings in config-manager"

6 years agoMerge "Fix warnings in config-util"
Tony Tkacik [Fri, 7 Nov 2014 10:01:01 +0000 (10:01 +0000)]
Merge "Fix warnings in config-util"

6 years agoMerge "Fix warnings in neconf-util"
Tony Tkacik [Fri, 7 Nov 2014 10:00:48 +0000 (10:00 +0000)]
Merge "Fix warnings in neconf-util"

6 years agoMerge "Fix warnings in config-api tests"
Tony Tkacik [Fri, 7 Nov 2014 10:00:01 +0000 (10:00 +0000)]
Merge "Fix warnings in config-api tests"

6 years agoMerge "Do not override managed versions"
Tony Tkacik [Fri, 7 Nov 2014 09:59:34 +0000 (09:59 +0000)]
Merge "Do not override managed versions"

6 years agoBug-2301 - Clustering:Snapshots need not be stored in in-mem ReplicatedLog for Instal... 15/12515/5
Kamal Rameshan [Wed, 5 Nov 2014 00:50:26 +0000 (16:50 -0800)]
Bug-2301 - Clustering:Snapshots need not be stored in in-mem ReplicatedLog for Installing snapshots

1. Snapshots, once persisted to disk, would not be stored as part of ReplicatedLog in memory
2. An Install snapshot would initiate a snapshot capture and be sent to the follower
3. FollowerLogInformation in Leader has a stopwatch which helps to find if a given follower is active/up.

Rebased

Change-Id: If7aac2518a0f624a0cc121112ce165456d002a18
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
6 years agoBUG 2317 : StatisticsManager does not unregister from yang notifications on close 86/12586/1
Moiz Raja [Thu, 6 Nov 2014 22:44:40 +0000 (14:44 -0800)]
BUG 2317 : StatisticsManager does not unregister from yang notifications on close

Change-Id: I9506fda6f3068d1ed047177009542a240f7c0bb4
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Bug 2318: Ensure previous Tx in chain is readied before creating the next"
Moiz Raja [Thu, 6 Nov 2014 23:17:04 +0000 (23:17 +0000)]
Merge "Bug 2318: Ensure previous Tx in chain is readied before creating the next"

6 years agoBUG 2325 : Value type of byte[] not recognized by the NormalizedNodeSerializer 40/12540/2
Moiz Raja [Wed, 5 Nov 2014 19:09:06 +0000 (11:09 -0800)]
BUG 2325 : Value type of byte[] not recognized by the NormalizedNodeSerializer

Change-Id: I16eab6cdbf7712624f2c1fafb5bf41107b6ae379
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 819b04091a3d4d96612a1036228638a3b4e85d09)

6 years agoIntroduce forwarding DOMData classes 80/12580/2
Robert Varga [Thu, 6 Nov 2014 14:31:36 +0000 (15:31 +0100)]
Introduce forwarding DOMData classes

These classes are useful for implementing various decorator. Their sole
functionality is to forward calls to a backing instance.

Change-Id: I8a65283ab6e3f9787dc59f43d7b7e8eb37459538
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix a typo in javadoc 79/12579/1
Robert Varga [Thu, 6 Nov 2014 14:30:54 +0000 (15:30 +0100)]
Fix a typo in javadoc

Simple typo.

Change-Id: I9934e8674b0bb9c2dc8a28dcb189c213e7709cb9
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix logback-config warnings 70/12570/1
Robert Varga [Thu, 6 Nov 2014 12:40:50 +0000 (13:40 +0100)]
Fix logback-config warnings

We do not need to use raw types, so use proper generic arguments.

Change-Id: Ifcbce1eb924067db8077f43246f33e3f2ae746bb
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove duplicate groupId 69/12569/1
Robert Varga [Thu, 6 Nov 2014 12:39:52 +0000 (13:39 +0100)]
Remove duplicate groupId

Specified groupId is the same as parent's -- so we do not need to
re-declare it.

Change-Id: I7610f6f4bbc4b303b0f3b6971822f8e715bf1a2e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in netconfig-netty-util 57/12557/2
Robert Varga [Thu, 6 Nov 2014 10:48:33 +0000 (11:48 +0100)]
Fix warnings in netconfig-netty-util

Removes the use of deprecated junit classes and raw types.

Change-Id: Ibde538ae563a82a89b865d1ef9303a6e24a026f5
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in netconfig-monitoring 56/12556/2
Robert Varga [Thu, 6 Nov 2014 10:48:03 +0000 (11:48 +0100)]
Fix warnings in netconfig-monitoring

Removes the use of deprecated junit classes and raw types.

Change-Id: I594f2cc10771d8a5291cbab3f651a6fb01ac7a4c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix cluster test warnings 55/12555/3
Robert Varga [Thu, 6 Nov 2014 10:11:36 +0000 (11:11 +0100)]
Fix cluster test warnings

Remove use of raw types, suppress serialVersionUUID warnings and the use
of deprecated junit classes.

Change-Id: I14f8e28b4bd27944b7001cbc1018479ae7b24f12
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd serialversionUUID to cluster/datastore/modification 54/12554/3
Robert Varga [Thu, 6 Nov 2014 10:16:41 +0000 (11:16 +0100)]
Add serialversionUUID to cluster/datastore/modification

Serializable classes need to define this field. Also fixes the use of
raw NormalizedNode type.

Change-Id: I674b57d0eea60c1e015cd35eba6c407d29826216
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix raw Class in sal-distributed-datastore messages 53/12553/3
Robert Varga [Thu, 6 Nov 2014 10:06:51 +0000 (11:06 +0100)]
Fix raw Class in sal-distributed-datastore messages

Fixes the use of Class in the messages. Also makes sure exported
constants are really constant.

Change-Id: Ibc0f688e95e8a2c26d30407897aaf7c51323032e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in clustering 52/12552/2
Robert Varga [Thu, 6 Nov 2014 10:03:05 +0000 (11:03 +0100)]
Fix warnings in clustering

Fixes the use of raw types.

Change-Id: I06d7935e6686bfceb3c574c9465a76adff2c825c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in config-manager 51/12551/2
Robert Varga [Thu, 6 Nov 2014 10:01:16 +0000 (11:01 +0100)]
Fix warnings in config-manager

Fix the use of raw types, unnecessary casts and use of deprecated junit
classes.

Change-Id: I137793ccf28f62b0e477f6042293b8c3a50e98fe
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in config-util 50/12550/2
Robert Varga [Thu, 6 Nov 2014 09:59:52 +0000 (10:59 +0100)]
Fix warnings in config-util

Fix use of deprecated junit classes and unused imports.

Change-Id: I5262ac6e870edbd83d86cd56ecfc08c17eee1490
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in neconf-util 49/12549/2
Robert Varga [Thu, 6 Nov 2014 09:56:53 +0000 (10:56 +0100)]
Fix warnings in neconf-util

Remove use of raw types, unnecessary casts and use of deprecated junit
classes.

Change-Id: If7fb8b107a5b3086dc5f37d495def7db17363ced
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in config-api tests 48/12548/2
Robert Varga [Thu, 6 Nov 2014 09:55:01 +0000 (10:55 +0100)]
Fix warnings in config-api tests

Move to non-deprecated classes and fix the use of raw types.

Change-Id: I9ef7d36d1f294b634787738292deedc2546d4097
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDo not override managed versions 47/12547/2
Robert Varga [Thu, 6 Nov 2014 09:52:49 +0000 (10:52 +0100)]
Do not override managed versions

Versions managed by parent, no need to specify them.

Change-Id: I70718711d3894c5edc6fd9ac66c453165124cac6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoQuickfix: Changed used feature to odl-aaa-netconf-plugin 59/12559/3
Tony Tkacik [Thu, 6 Nov 2014 11:41:44 +0000 (12:41 +0100)]
Quickfix: Changed used feature to odl-aaa-netconf-plugin

AAA project renamed their netconf related feature without
introducing proper patchset into controller. This fixes
features.xml to reference properly new feature.

Change-Id: Ic0d512804a87f20f058462541cd061f83a8f52e7
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Remove l2switch sample"
Tony Tkacik [Thu, 6 Nov 2014 08:20:06 +0000 (08:20 +0000)]
Merge "Remove l2switch sample"

6 years agoBUG 2090 : Clustering : Bring akka-raft unit test coverage upto 80% 22/12522/1
Moiz Raja [Thu, 16 Oct 2014 23:51:46 +0000 (16:51 -0700)]
BUG 2090 : Clustering : Bring akka-raft unit test coverage upto 80%

Change-Id: I7b2b16aa42b655e924942f356602c64ccf6d86b7
Signed-off-by: Moiz Raja <moizr@dhcp-10-154-140-127.cisco.com>
6 years agoBUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance attrib... 86/12286/3
Maros Marsalek [Wed, 5 Nov 2014 13:29:55 +0000 (14:29 +0100)]
BUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance attribute with namespaces

Change-Id: I9ca4accdb10ba5a6b52ce9b8f7ad02a8cbe8743d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Fix for Bug 2290."
Devin Avery [Tue, 4 Nov 2014 20:07:31 +0000 (20:07 +0000)]
Merge "Fix for Bug 2290."

6 years agoMerge "Introduce a benchmark for databroker"
Tony Tkacik [Tue, 4 Nov 2014 12:11:52 +0000 (12:11 +0000)]
Merge "Introduce a benchmark for databroker"

6 years agoBug 2340: Fixed chained Tx not ready prior next create 59/12659/1
tpantelis [Sun, 2 Nov 2014 21:44:34 +0000 (16:44 -0500)]
Bug 2340: Fixed chained Tx not ready prior next create

On new*Transaction, utilized the new State classes to obtain
the previous Tx's ready Futures and pass then to the new
ChainedTransactionProxy. This makes it deterministic so that
a Tx will always get ready Futures from the previous Tx.

Change-Id: Icc017285bd5ceb118e98d3e38ec9a10a9144155e
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoBug 2318: Follow-up changes for previous patch 12535 82/12582/4
tpantelis [Sat, 1 Nov 2014 22:17:33 +0000 (18:17 -0400)]
Bug 2318: Follow-up changes for previous patch 12535

Addressed some comments and other minor changes as a follow-up to patch 12535.

Enhanced the comments in TransactionChainProxy.

Modified Shard to send a failure reply if an runtime exception occurs in
createTransaction. This allows the error to be propagated to the caller
instead of being thrown back to akka.

Modified TransactionChainProxy to throw an IllegalStateException if the
next chain Tx is created before the previous one is readied. Prior, the
Shard would throw an IllegalStateException but from the Future returned
from submit and not on new*Transaction as the API docs state. So this make
it consistent with API contract. This was implemented by introducing a
volatile State field with implemnetations, Idle, Allocated and Closed.

Also, modified TransactionChainProxy to throw TransactionChainClosedException
if the chain is already closed when on Tx create. Again. this makes it
consistent with the API docs.

Added unit tests in DistributedDataStoreIntegrationTest to verify failure
in both cases.

Change-Id: I1b1ed06ceb1d4599f3f6c5443ca24ac1441ac38f
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoBug 2337: Fix Tx already sealed failure on Tx commit 81/12581/2
tpantelis [Sat, 1 Nov 2014 21:55:34 +0000 (17:55 -0400)]
Bug 2337: Fix Tx already sealed failure on Tx commit

Details outlined in bug 2337.

Moved the publishing of the TransactonContext instance in
TransactionFutureCallback#onComplete after the cached operations are
executed.

Also fixed a timing issue in
DistributedDataStoreIntegrationTest#testChangeListenerRegistration that
caused intermittent failures. This was an issue with the test. The
listener registration is done async in the shard so the notification for
the first write commit could occur in the initial notification on
registration which screwed up the test. So I moved the first write
commit before the registration so we expect an initial notification.

Change-Id: Ied2af93be8165208b853c48e57312c3a5acbdaea
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoBug 2318: Ensure previous Tx in chain is readied before creating the next 35/12535/2
tpantelis [Sat, 1 Nov 2014 08:10:20 +0000 (04:10 -0400)]
Bug 2318: Ensure previous Tx in chain is readied before creating the next

In TransactionChainProxy, subclassed TransactionProxy (ChainedTransactionProxy)
to hook into the TransactionProxy to capture the cohort Futures on ready
and to customize the returned create shard Tx Future.

The previous Tx's ready Futures are captured and cached in the enclosing
TransactionChainProxy instance. When the client creates the next Tx in
the chain, the Future from the shard Tx create message is wrapped by a
sequence Future that combines all the previous ready Futures. Thus, when
the previous ready Futures complete, the shard Tx create is sent and
that Future is used to complete the returned Promise.

Change-Id: If002e4d705510aee3f560c506318d25f386768e5
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoIntroduce a benchmark for databroker 08/12408/3
Robert Varga [Tue, 7 Oct 2014 18:08:12 +0000 (20:08 +0200)]
Introduce a benchmark for databroker

Change-Id: Ica44433b1dd1c863e1c255cc5ec297c56e705fd8
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix for Bug 2290. 30/12430/1
Ryan Moats [Fri, 31 Oct 2014 22:14:01 +0000 (17:14 -0500)]
Fix for Bug 2290.

Wrap existing IPv4 code with version test.
Add new IPv6 code with version test.

Change-Id: I30ed4c510dbc79f3e40cdafea4dd46cf37a20f39
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
6 years agoRemove l2switch sample 98/12398/2
Robert Varga [Fri, 31 Oct 2014 11:14:36 +0000 (12:14 +0100)]
Remove l2switch sample

This sample is openflow-specific and creates confusion with the l2switch
project. Remove it.

Change-Id: I03b08bbe08c98c0bd712470c4fb2c29ba65467a3
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 2233 - RPC register exception when rpc has no input 01/12401/1
Jan Hajnar [Fri, 31 Oct 2014 12:59:08 +0000 (13:59 +0100)]
Bug 2233 - RPC register exception when rpc has no input

* added check that should prevent non routed Rpcs being treated as
routed and and failing at context resolution.

Change-Id: I281152879429f2020f48894753f1d57aea85bde6
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
6 years agoMerge "BUG-1953: fix SAL compatility layer"
Tony Tkacik [Fri, 31 Oct 2014 12:57:24 +0000 (12:57 +0000)]
Merge "BUG-1953: fix SAL compatility layer"

6 years agoMerge "Bug 2065 - fixed typo in leaf name"
Tony Tkacik [Fri, 31 Oct 2014 10:19:45 +0000 (10:19 +0000)]
Merge "Bug 2065 - fixed typo in leaf name"

6 years agoFix intermittent failure in DataChangeListenerTest 60/12460/1
tpantelis [Fri, 31 Oct 2014 06:12:10 +0000 (02:12 -0400)]
Fix intermittent failure in DataChangeListenerTest

Fixed an intermittent failure in testDataChangedWithNoSender due to timing if a
DeadLetter is received due to the Monitor message being dropped as the
unit tests don't set up the termination monitor actor. The test expects
no DeadLetter for DataChangedReply so added chanhes to ignore
DeadLetters for other messages.

Change-Id: I39ddc888de7fbff9201ac9f785baa6fec7cb8f2c
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoBUG 2296 : TransactionProxy should support the ability to accept a local TPC actor... 51/12451/1
Moiz Raja [Sun, 2 Nov 2014 16:14:03 +0000 (08:14 -0800)]
BUG 2296 : TransactionProxy should support the ability to accept a local TPC actor path

In Helium when the ShardTransaction processes a Ready message it sends back a the path of a ThreePhaseCommitCohort actor in the ReadyReply. This path is actually a local actor path, this local actor path is then converted into a remote path by the TransactionProxy.

The fix for Bug 1607 breaks this capability which is required to support forward compatibility in a cluster where a transaction request originates in a node that has been upgraded to Helium-1 and the actual transaction is happening on a node which has not yet been upgraded to Helium-1.

Change-Id: I857384bdd61b3492ea270dcf04d14883811c37c2
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Bug 2294: Handle Shard backwards compatibility"
Moiz Raja [Sun, 2 Nov 2014 21:48:34 +0000 (21:48 +0000)]
Merge "Bug 2294: Handle Shard backwards compatibility"

6 years agoMerge "Bug 2134: Fix intermittent RaftActorTest failure"
Moiz Raja [Sat, 1 Nov 2014 20:33:07 +0000 (20:33 +0000)]
Merge "Bug 2134: Fix intermittent RaftActorTest failure"

6 years agoBUG 2134 : Make persistence configurable at the datastore level 52/12352/5
Moiz Raja [Fri, 17 Oct 2014 23:42:41 +0000 (16:42 -0700)]
BUG 2134 : Make persistence configurable at the datastore level

- Added a peristent flag in the config sub-system
- If persistent in not true then we ignore recovery messages and not use the
  akka persistence apis for persisting anything
- The unit tests
    - assume that persistence is on by default (which it is)
    - test that if recovery is applicable only then the ShardManager and RaftActor process the recovoery messages.
    - test that when persisting the data-persistence API is used in the appropriate places (see RaftActorTest/ShardManagerTest)

Change-Id: I19913bcd32e609ccde6ad8e35209788315504426
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoBug 2065 - fixed typo in leaf name 81/12381/1
Martin Bobak [Thu, 30 Oct 2014 13:54:14 +0000 (14:54 +0100)]
Bug 2065 - fixed typo in leaf name

Change-Id: I9f0f201078ffc3d7c08f57108b4d113f87df9ac4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
6 years agoBug 2294: Handle Shard backwards compatibility 44/12444/2
tpantelis [Thu, 30 Oct 2014 11:30:32 +0000 (07:30 -0400)]
Bug 2294: Handle Shard backwards compatibility

Implemented as outlined in Bug 2294.

Change-Id: I14aa8ef5f320f9d165492396ece4ea63cce9b0c3
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoMerge "Bug 2055: Handle Tx create in TransactionProxy resiliently"
Moiz Raja [Thu, 30 Oct 2014 01:59:53 +0000 (01:59 +0000)]
Merge "Bug 2055: Handle Tx create in TransactionProxy resiliently"

6 years agoBug 2134: Fix intermittent RaftActorTest failure 29/12429/1
tpantelis [Wed, 29 Oct 2014 16:05:05 +0000 (12:05 -0400)]
Bug 2134: Fix intermittent RaftActorTest failure

We need to wait for akka's recovery to complete before we perform our
tests as akka's recovery runs async and may interfere with our tests and
cause them to fail if the timing is right. This was seen once on
jenkins.

Change-Id: Ia748d17f662d64235881005e6522441b384c78ea
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoMerge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"
Devin Avery [Wed, 29 Oct 2014 14:17:58 +0000 (14:17 +0000)]
Merge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"

6 years agoCosmetics: check in pom.xml files as _sort_pom_ wants them to be 12/12312/1
Flavio Fernandes [Wed, 29 Oct 2014 10:07:12 +0000 (06:07 -0400)]
Cosmetics: check in pom.xml files as _sort_pom_ wants them to be

Change-Id: I08fc2c0284e0396605cec7d218ea4470a312bfc8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
6 years agoMerge "Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools...
Moiz Raja [Wed, 29 Oct 2014 09:00:27 +0000 (09:00 +0000)]
Merge "Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.