controller.git
9 years agoBug 967: Fixed incorrect delete was addressing augmentation 46/7046/2
Tony Tkacik [Wed, 7 May 2014 11:10:40 +0000 (13:10 +0200)]
Bug 967: Fixed incorrect delete was addressing  augmentation

of augmentation

DataNormalizationOperation was constructed incorrectly, if augmentation
was already augmented, which leaded to incorrect construction of instance
identifier for delete.

Patchset 2: Fixed normalization in cases of mixin inside mixin
e.g. augmentation containing choice with cases.

Change-Id: I580e5dfe41ce504775ac454b66368037f4d707bb
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG 1001 Failing test - RestGetOperationTest.getStreamsTest 45/7045/2
Jozef Gloncak [Wed, 14 May 2014 08:23:24 +0000 (10:23 +0200)]
BUG 1001 Failing test - RestGetOperationTest.getStreamsTest

responseBody variable now contained some data and therefore it wasn't xml
tag <streams/> but <streams></streams>

Change-Id: I73004f848f0dfc5f2929f8f8ea2dbd6afc25d35a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBUG-372 Add reconnecting to netconf-connector for unexpected 44/7044/2
Maros Marsalek [Tue, 13 May 2014 14:10:59 +0000 (16:10 +0200)]
BUG-372 Add reconnecting to netconf-connector for unexpected

session drop

Netconf connector will reattempt connection if the session to remote device is dropped.
Increase sleep factor in netconf connector from 1.0 to 1.5.
This prevents connection attempt every second in case remote device is not comming back for longer time.
Connection attempts span increases gradually.

Change-Id: Icc4b993942e9cc6897c0da858eb867afa4c8aa87
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-981: Fixed incorrect condition in 43/7043/2
Robert Varga [Tue, 13 May 2014 11:52:10 +0000 (13:52 +0200)]
BUG-981: Fixed incorrect condition in
ResolveDataChangeEventsTask

When we insert a new subtree, we need to make sure to call serialization
on the entire, such that any new elements which appear have their
classed attached to paths.

This reuses a previous code path, which pruned the walk tree as soon as
it encountered a node which did not have any listeners attached (thus
improving performance when we're gathering listeners).

In this specific case, though, this check is not correct: we need to
walk the path because it may be placing new data in the subtree.

At the same time add debug statements which made pinpointing this
problem possible.

Change-Id: I1687ba45817a84ea4a888496a90defc5896216c9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-574 Added a 4th RPC Invocation strategy for the case where 42/7042/2
Mayank Agarwal [Mon, 14 Apr 2014 21:58:31 +0000 (14:58 -0700)]
Bug-574 Added a 4th RPC Invocation strategy for the case where

 the RPC has an output, but no input

Change-Id: I7d1a596f3bb1362044cc240a15bdb9bb7d094c55
Signed-off-by: Mayank Agarwal <mayagarw@cisco.com>
9 years agoBug 508: Improved error reporting for failed canCommit phase. 41/7041/2
Tony Tkacik [Mon, 12 May 2014 10:33:58 +0000 (12:33 +0200)]
Bug 508: Improved error reporting for failed canCommit phase.

Original implementation did not provide enough information
when transaction precondition failed.

Introduced new Exception DataPreconditionFailedException
which captures fail reason and path to subtree
for which precondition failed.

This helps debug accidental overwrites / conflicting
writes between transactions.

Change-Id: I0133fd3fdb8e6492bf457dab7b20efa67fd6e2af
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBug 981: Fixed accidental shaddowing of data in Data Change Event. 40/7040/2
Tony Tkacik [Sun, 11 May 2014 20:46:24 +0000 (22:46 +0200)]
Bug 981: Fixed accidental shaddowing of data in Data Change Event.

Not all Normalized DOM InstanceIdentifier has their counterpart
in Binding-Aware representation. Added explicit check to
detect mixin instance-identifiers which could lead to
incorrect deserialization into maps and shadowing parent data.

Change-Id: I66166f50c636ce0dfcd962efac7fc488da622336
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG-648: Improve performance by reusing old data nodes 39/7039/2
Robert Varga [Thu, 8 May 2014 16:29:30 +0000 (18:29 +0200)]
BUG-648: Improve performance by reusing old data nodes

This patchset gives yang-data-api the chance to optimize copy
operations we execute when creating a new generation.

Change-Id: Ib23a87e116a0a04f7fd4f2b709d7239e213ea744
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-868: stop using InstanceIdentifier.builder() 38/7038/2
Robert Varga [Sun, 11 May 2014 06:41:18 +0000 (08:41 +0200)]
BUG-868: stop using InstanceIdentifier.builder()

The static helper method has been deprecated. Use either the non-static
one, or child()/augmentation() helpers.

Change-Id: Ic69057d2db669153dde60ba1797e8139623a755c
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-981: remove deprecated use of constructors 37/7037/2
Robert Varga [Sun, 11 May 2014 05:35:34 +0000 (07:35 +0200)]
BUG-981: remove deprecated use of constructors

This removes the use of all constructors, such that we initialize in one
go.

Change-Id: Iff461a878fb7061b0ea1c8efea6a34b833645784
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-893: do not store classPool 36/7036/2
Robert Varga [Sat, 10 May 2014 13:43:45 +0000 (15:43 +0200)]
BUG-893: do not store classPool

This prevents storing a reference to the classPool. It is not necessary
and it makes thinking about accesses much easier.

Change-Id: Iebbdac46c3ca445bbe36ba6efd19d3150d728f7f
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-642: get rid of sneakyThrow 35/7035/2
Robert Varga [Sat, 10 May 2014 11:25:21 +0000 (13:25 +0200)]
BUG-642: get rid of sneakyThrow

This patch rids us of unneeded usage of Exceptions.sneakyThrow. It
generally hides problems and is only useful for generated (or sloppy)
code.

Change-Id: Ibb73f4546b1785c4bcb3e6c033249f58efd1d2d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-980: stop emiting copyright 34/7034/2
Robert Varga [Fri, 9 May 2014 07:33:44 +0000 (09:33 +0200)]
BUG-980: stop emiting copyright

This is a stop-gap quickfix to stop doing the wrong thing.

Change-Id: I51a2ca012ea605632a737788005cf4143d9c1f44
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-891: do not drop events silently 33/7033/2
Robert Varga [Fri, 9 May 2014 15:22:19 +0000 (17:22 +0200)]
BUG-891: do not drop events silently

As it turns out, infrastructure silently drops things on the floor if
exceptions happen. When these exceptions occur, they hint at major
problems. Promote tham to warnings.

Change-Id: Ib4afdc7ff1a17e562211b3cfbb30735a592d0a2d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-969 Move fake read on nodes/node to separate thread. 32/7032/2
Maros Marsalek [Fri, 9 May 2014 07:27:55 +0000 (09:27 +0200)]
BUG-969 Move fake read on nodes/node to separate thread.

This will prevent blocking of config thread.

Change-Id: Ieb2e1c192ef91775153837956e6e6a428985c2d1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBug 809: Enhancements to the toaster example 31/7031/2
tpantelis [Fri, 18 Apr 2014 19:10:47 +0000 (15:10 -0400)]
Bug 809: Enhancements to the toaster example

See https://bugs.opendaylight.org/show_bug.cgi?id=809 for details.

Need someone to commit this!

Change-Id: Icb9697de77d844d816ec61a0e7a6ac2100d185ae
Signed-off-by: tpantelis <tpanteli@brocade.com>
9 years agoBUG-972: correct Precondition 30/7030/2
Robert Varga [Thu, 8 May 2014 15:30:25 +0000 (17:30 +0200)]
BUG-972: correct Precondition

This is just a tiny adjustment of a Precondition, which should have been
triggered before this access. isPresent() returns true/false, which will
be autoboxed, so will always pass checkNotNull. use checkArgument()
instead, which will ensure that isPresent() == true.

Change-Id: I53fe6913c7a0f8073a193bc76c0792059c26fe2a
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug 617: Remove extend files from sal-rest-connector 29/7029/2
tpantelis [Sun, 4 May 2014 17:29:22 +0000 (13:29 -0400)]
Bug 617: Remove extend files from sal-rest-connector

Converted ControllerContext and BrokerFacade xtend code to java.

Addressed review comments:
  - Removed SupressWarnings "all"
  - Converted use of xext classes to guava
  - Removed sneakyThrow

Patch set 4: mistake - no changes

Patch set 5: Converted RestconfImpl

Patch set 6: removed xtend plugin anf dependencies from pom file

Change-Id: I45c22b22fee07a178faba9fcb9e52d3ff12a6697
Signed-off-by: tpantelis <tpanteli@brocade.com>
9 years agoBug 849: Fixed NPE in Translated Data Change Events. 28/7028/1
Tony Tkacik [Tue, 6 May 2014 11:31:05 +0000 (13:31 +0200)]
Bug 849: Fixed NPE in Translated Data Change Events.

Change-Id: I7f79b9a713414192f14d934fbc3b9eabb3a2a051
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMaking it easier for cygwin users to run OpenDaylight using run.sh. 27/7027/1
Srini Seetharaman [Wed, 30 Apr 2014 23:47:37 +0000 (16:47 -0700)]
Making it easier for cygwin users to run OpenDaylight using run.sh.

With this change, the users will only have to add the following line
to their .bashrc to make it run: export CLASSPATH=".;lib/*;"

Change-Id: Icc1576ea1c46568d43f11d90eebecb06c74db184
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
9 years agoRevert "Enabling Remote RPC Router module in ODL distribution." 77/6977/3
Ed Warnicke [Tue, 13 May 2014 22:16:48 +0000 (17:16 -0500)]
Revert "Enabling Remote RPC Router module in ODL distribution."

This reverts commit c29d8b2e81598d2710c5aa3735110fd7388a6059.
This commit roughly also reverts the commits after this line by
isolating them:

This reverts commit 1f2754487ab1e3a37c830909806f90cd54180c7b.
This reverts commit da73a89f4cfc3a9f73304df8ef23e50d1053e6d3.
This reverts commit cd206a46a93f519f133db968d2235271c28228ef.
This reverts commit 8ec80cfe8201adca88813d83a007417133da162e.

Change-Id: Ibe0198bfb93cf20d331015236ba336e06f22c466
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Add reverse() method in Edge and Path classes" 76/6976/3
Ed Warnicke [Tue, 13 May 2014 21:06:31 +0000 (16:06 -0500)]
Revert "Add reverse() method in Edge and Path classes"

This reverts commit 142c513a58c066cc9fbe4b256320f809034ba365.

Change-Id: Ieeba0e0d6ab47ab49288969a57446da044adcd8c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Apply configs' name convention to authorization roles 75/6975/3
Ed Warnicke [Tue, 13 May 2014 20:50:23 +0000 (15:50 -0500)]
Revert "Apply configs' name convention to authorization roles

and resource groups"

This reverts commit 14ebd2da24a8122c1059e73d80aa1c50afb553dd.

Change-Id: I6ba6c11cf62fb3fa92dcaa52b5ada0223b977997
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Bug 639, Bug 641, Bug 642: This is MD-SAL based sample 74/6974/3
Ed Warnicke [Tue, 13 May 2014 19:00:47 +0000 (14:00 -0500)]
Revert "Bug 639, Bug 641, Bug 642: This is MD-SAL based sample

implementation of a learning switch with optimizations in how
packet is forwarded."

This reverts commit 273b2a25453e9fe24f973fd6f7bc8c65bcf372d3.

Change-Id: I1e7df9bff60aa790cc267e438572e54378eb94b3
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Upgrading clustermanager to use infinispan 6.0.2Final." 73/6973/2
Ed Warnicke [Tue, 13 May 2014 18:51:48 +0000 (13:51 -0500)]
Revert "Upgrading clustermanager to use infinispan 6.0.2Final."

This reverts commit eed877b90a0f8ed70150d710a9479e5a11409259.

Change-Id: I6671fe7e00f18a596a9fcf21904eff426bdd657c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Add async addStaticFlow api to FRM" 72/6972/2
Ed Warnicke [Tue, 13 May 2014 17:37:55 +0000 (12:37 -0500)]
Revert "Add async addStaticFlow api to FRM"

This reverts commit 198d5e3309648814c6d5ef849d86d15dfc8e886f.

Change-Id: I2a4483ecd310e8ab6f683c65726c8c5d1d21aaf3
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Sorting of numeric fields in Troubleshooting module" 71/6971/2
Ed Warnicke [Tue, 13 May 2014 16:29:20 +0000 (11:29 -0500)]
Revert "Sorting of numeric fields in Troubleshooting module"

This reverts commit 2d1d1993628ba741a52251dd0bd648a965a7e901.

Change-Id: Ie34d15c79cb0aa7883232ffcd8bb0e7d0a5b2dc1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "TS GUI does not show ToS field in flow stats" 70/6970/2
Ed Warnicke [Tue, 13 May 2014 16:29:07 +0000 (11:29 -0500)]
Revert "TS GUI does not show ToS field in flow stats"

This reverts commit 7d7f86f108c85b5325f8bea5d3dbf60efca776ce.

Change-Id: I662df9f1548697ff27ba5d9093da98efccef5df1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Display Vlan Priority in Flow Stats in TS GUI" 69/6969/2
Ed Warnicke [Tue, 13 May 2014 16:28:48 +0000 (11:28 -0500)]
Revert "Display Vlan Priority in Flow Stats in TS GUI"

This reverts commit 7c5788de6364886747dc616940d5eddbbd615034.

Change-Id: Ia5cbc3de23c559548568ae3c5ef975d7fe53e26b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Lower logger level in OF1.0 Discovery Service" 67/6967/2
Ed Warnicke [Tue, 13 May 2014 16:27:24 +0000 (11:27 -0500)]
Revert "Lower logger level in OF1.0 Discovery Service"

This reverts commit f6fa5e9c1c613feafdc654de23915432b3f1ddbc.

Change-Id: I89b091022abf889b1b77539b5bf8e0ab92a04657
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Provide Switch Information in Troubleshooting Tab" 66/6966/2
Ed Warnicke [Tue, 13 May 2014 16:27:09 +0000 (11:27 -0500)]
Revert "Provide Switch Information in Troubleshooting Tab"

This reverts commit ac381f143afaf7c508a576889c82075842347499.

Change-Id: I1be6661131fd7087373a2af9f9563ca5da9833ae
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "AuthenticatedUser not to expose internal 65/6965/2
Ed Warnicke [Tue, 13 May 2014 16:26:54 +0000 (11:26 -0500)]
Revert "AuthenticatedUser not to expose internal
implementation"

This reverts commit 37e5de08510c2d8c0bc5942aea527105f6795ef1.

Change-Id: I059f7b3f01732e55ae943303e7855c2a2c222706
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Add northbound archetype" 64/6964/2
Ed Warnicke [Tue, 13 May 2014 16:23:03 +0000 (11:23 -0500)]
Revert "Add northbound archetype"

This reverts commit 41fa12f651c2520cbf617cb5c4b14f500ee53358.

Change-Id: I5fe187bd5fabbec953b445159a06e40f392057a1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Add FLOOD_ALL action to FlowConfig" 63/6963/2
Ed Warnicke [Tue, 13 May 2014 16:22:12 +0000 (11:22 -0500)]
Revert "Add FLOOD_ALL action to FlowConfig"

This reverts commit 021ac5b7e2cfaa1f2cb027e9d9c27ff90cad56d9.

Change-Id: I3ca4ae856f7f6c3456bc922fd69a0d95d41a9287
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Initial commit for new Match classes" 62/6962/2
Ed Warnicke [Tue, 13 May 2014 16:21:51 +0000 (11:21 -0500)]
Revert "Initial commit for new Match classes"

This reverts commit 2c4b7c792b049ece3177b8b6fc6b6331038c5f5b.

Change-Id: I4974096c9215e8437f76c620ebba514684b49ce4
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Added a comment that briefly describes the ArpHander 61/6961/2
Ed Warnicke [Tue, 13 May 2014 16:21:35 +0000 (11:21 -0500)]
Revert "Added a comment that briefly describes the ArpHander

service and explains some design decisions."

This reverts commit ce8b227502448c0a18e3dc22362e4b42e589ef35.

Change-Id: Iefddf5e9788a54d7691cf0f7d868d01d45a7fb5c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Add Flood and FloodAll supported actions" 60/6960/2
Ed Warnicke [Tue, 13 May 2014 16:21:17 +0000 (11:21 -0500)]
Revert "Add Flood and FloodAll supported actions"

This reverts commit 9f8e45dc9cc77739c690f5d463854aae678efb7f.

Change-Id: Ic13148679ae96ff6f0210745a6588d9443a21a58
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Remove unused code" 59/6959/2
Ed Warnicke [Tue, 13 May 2014 16:20:02 +0000 (11:20 -0500)]
Revert "Remove unused code"

This reverts commit 6990871b68adfd57b4cdd218ba797b641f6f9562.

Change-Id: I8d7b98e2edc701d08d3ad0433cbc80d56850d302
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Allow abilitiy to boot controller with non-default 58/6958/2
Ed Warnicke [Tue, 13 May 2014 16:18:16 +0000 (11:18 -0500)]
Revert "Allow abilitiy to boot controller with non-default

admin credentials"

This reverts commit c198e5355b6702b6d96f1174bc4d1477143397cc.

Change-Id: I5638245c7ae767c237c6ec8b92076c711191c8fc
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Enhance the LLDPTLV.java to handle the LLDP port ID" 57/6957/2
Ed Warnicke [Tue, 13 May 2014 16:17:42 +0000 (11:17 -0500)]
Revert "Enhance the LLDPTLV.java to handle the LLDP port ID"

This reverts commit 66ca7f84baed5633cd135c5037a8aa847d2b9621.

Change-Id: I7c5ed9181d52eabe2be0747fb6320796cf7a9f0e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Update to new version of the artifacts proposed by 55/6955/2
Ed Warnicke [Tue, 13 May 2014 15:57:45 +0000 (10:57 -0500)]
Revert "Update to new version of the artifacts proposed by

jenkins-controller-version-changes-30"

This reverts commit 481b16a129f4fd2c2a8c783f934cf3056ca64d12.

Change-Id: I8754bcc73c7e95112d047ff92d25705fc594beba
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Cleaned Commons POM prerequisites for Karaf 54/6954/2
Ed Warnicke [Tue, 13 May 2014 15:56:04 +0000 (10:56 -0500)]
Revert "Cleaned Commons POM prerequisites for Karaf
distribution"

This reverts commit 5bd02c519c018adc898678203f79f05bb667addc.

Change-Id: I439a7e26b6ab9f0ed1ee4ca2ce3f12673ca37495
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Allow to disable default gw feature" 53/6953/2
Ed Warnicke [Tue, 13 May 2014 15:55:50 +0000 (10:55 -0500)]
Revert "Allow to disable default gw feature"

This reverts commit b10374443562bed1960c06bb85767d8c270436dd.

Change-Id: Ib3f84575277e57e4d1afe4226fc1898fece9e9e8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Bug: 627" 52/6952/2
Ed Warnicke [Tue, 13 May 2014 15:55:30 +0000 (10:55 -0500)]
Revert "Bug: 627"

This reverts commit 2e8e671a52614978de6940919fc677625dc25def.

Change-Id: Id9d0e784597085561ca7a257e7456c4abc1fec20
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Breaking up 6360: common pom file" 51/6951/2
Ed Warnicke [Tue, 13 May 2014 15:54:49 +0000 (10:54 -0500)]
Revert "Breaking up 6360: common pom file"

This reverts commit cd5eabba225cd4305295f61a071a21f0253d18d4.

Change-Id: Id84a59bafc921d25581cac9fefb8df1d016906a2
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Breaking up 6360: Simple karaf distro" 50/6950/2
Ed Warnicke [Tue, 13 May 2014 15:54:32 +0000 (10:54 -0500)]
Revert "Breaking up 6360: Simple karaf distro"

This reverts commit 845caac725424c84bf32b4e36c7b25490b4ab538.

Change-Id: I3c769ed0577751cd8a724e8ad6c39803924815a3
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Breaking up 6360: dummy console" 49/6949/2
Ed Warnicke [Tue, 13 May 2014 15:53:01 +0000 (10:53 -0500)]
Revert "Breaking up 6360: dummy console"

This reverts commit 59fa31193e7e8b7bb807024ee65ac724434006b6.

Change-Id: I94c1348feaae8ba2da454692f8f581b7857f3bec
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Fixed opendaylight-karaf to have resources in 48/6948/2
Ed Warnicke [Tue, 13 May 2014 15:52:47 +0000 (10:52 -0500)]
Revert "Fixed opendaylight-karaf to have resources in

target/assembly"

This reverts commit 7ba2ba55116b0f4ebe6a13232e13ce9e821c4210.

Change-Id: Ib71d2c8eadfdc44ce9201ed118a1af206b83ac7e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Initial mdsal and config karaf features" 44/6944/2
Ed Warnicke [Tue, 13 May 2014 15:52:24 +0000 (10:52 -0500)]
Revert "Initial mdsal and config karaf features"

This reverts commit d3ee1db2786e3d239c32d2bc983b5d926939e8b9.

Change-Id: Ie85f9465b53627c734c10276d4baeab9e259ff46
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Felix Web Console authenticates using 43/6943/2
Ed Warnicke [Tue, 13 May 2014 15:51:51 +0000 (10:51 -0500)]
Revert "Felix Web Console authenticates using

HTTP-Bridge, which is similar to web-gui"

This reverts commit 5bb121603f96d59785101efecf0da6dab9bca5f4.

Change-Id: I7b663d77d1d8ab9931cca42bbc8594064389400c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRevert "Upgrade enunciate version to 1.28" 42/6942/1
Ed Warnicke [Tue, 13 May 2014 15:51:37 +0000 (10:51 -0500)]
Revert "Upgrade enunciate version to 1.28"

This reverts commit b99cd6b7820481c843d74e221253284a1db830be.

Change-Id: Ief25a1c2eb018a12a2f58151932152f6e9a79b40
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Wed, 7 May 2014 23:21:44 +0000 (23:21 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

10 years agoMerge "Upgrade enunciate version to 1.28 -Convert XmlElementRef to XmlElement to...
Alessandro Boch [Wed, 7 May 2014 23:20:15 +0000 (23:20 +0000)]
Merge "Upgrade enunciate version to 1.28   -Convert XmlElementRef to XmlElement to allow doc generation to work properly   -Add swagger module dependency to enunciate"

10 years agoUpgrade enunciate version to 1.28 33/6733/4
mrajvaid [Mon, 5 May 2014 23:10:56 +0000 (16:10 -0700)]
Upgrade enunciate version to 1.28
  -Convert XmlElementRef to XmlElement to allow doc generation to work properly
  -Add swagger module dependency to enunciate

Change-Id: Ia41e7733bd44965951ca83aaa7738e2df74151da
Signed-off-by: mrajvaid <mrajvaid@cisco.com>
10 years agoFelix Web Console authenticates using HTTP-Bridge, which is similar to web-gui 58/6558/3
mrajvaid [Mon, 28 Apr 2014 19:34:25 +0000 (12:34 -0700)]
Felix Web Console authenticates using HTTP-Bridge, which is similar to web-gui

By default web console perform its own authentication using default user and passowrd
If user password is modified via web, felix console can not authenticate

Change-Id: I38a277ffabdfac652325b83fe80facffc043c669
Signed-off-by: mrajvaid <mrajvaid@cisco.com>
10 years agoBug-590: Packet loss on first time ping test 98/6798/2
Flavio Fernandes [Wed, 7 May 2014 18:00:51 +0000 (14:00 -0400)]
Bug-590: Packet loss on first time ping test

Bump severity of log in exception code path.
Undo copy and paste mistake, which caused unwanted line left behind.

Change-Id: If73e516635172e31e794cd1524611c1cdb15f89f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
10 years agoBug:969 - Add fake read to block thread to sync with BI broker. 97/6797/1
Tomas Olvecky [Wed, 7 May 2014 17:54:42 +0000 (19:54 +0200)]
Bug:969 - Add fake read to block thread to sync with BI broker.

Block netconf client until Binding Independent broker loads inventory
models.

Change-Id: I8b2bcb82bcdf97598665b0b45f8fdfed19072e3c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoMerge "Fix netconf-connector filter construction"
Tony Tkacik [Wed, 7 May 2014 16:46:15 +0000 (16:46 +0000)]
Merge "Fix netconf-connector filter construction"

10 years agoMerge "Add missing exception to log message in SchemaAwareRpcBroker"
Tony Tkacik [Wed, 7 May 2014 16:46:08 +0000 (16:46 +0000)]
Merge "Add missing exception to log message in SchemaAwareRpcBroker"

10 years agoFix netconf-connector filter construction 96/6796/2
Maros Marsalek [Wed, 7 May 2014 15:32:30 +0000 (17:32 +0200)]
Fix netconf-connector filter construction

Change-Id: I9b36458d0e3bb2a14b303e14ddcd8dcab4e7b33d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoMerge "Initial mdsal and config karaf features"
Tony Tkacik [Wed, 7 May 2014 15:43:12 +0000 (15:43 +0000)]
Merge "Initial mdsal and config karaf features"

10 years agoMerge "Increase mdsal's notification queue size, make it configurable."
Tony Tkacik [Wed, 7 May 2014 15:42:46 +0000 (15:42 +0000)]
Merge "Increase mdsal's notification queue size, make it configurable."

10 years agoInitial mdsal and config karaf features 53/6753/3
Ed Warnicke [Tue, 6 May 2014 14:57:45 +0000 (09:57 -0500)]
Initial mdsal and config karaf features

This loads cleanly into karaf :)

Instructions for checking:

cd controller/

mvn clean install

cd opendaylight/distributions/opendaylight-karaf/target/assembly/bin
sh karaf

at the karaf prompt

feature:install odl-mdsal-restconf
feature:list -i

(odl-mdsal-restconf will pull everything else through).

PatchSet2:  Fixed failure to use odl- prefix in features for -all

Change-Id: Ib85347eaab7729d1b2723eb7ce59a3c18f2eef0e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoAdd missing exception to log message in SchemaAwareRpcBroker 94/6794/1
Maros Marsalek [Wed, 7 May 2014 15:13:00 +0000 (17:13 +0200)]
Add missing exception to log message in SchemaAwareRpcBroker

Change-Id: I1e8196babd9f5486fbe1edadba5f610f00d1ac37
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoMerge "FRM should use async function on southbound event"
Giovanni Meo [Wed, 7 May 2014 15:08:07 +0000 (15:08 +0000)]
Merge "FRM should use async function on southbound event"

10 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Wed, 7 May 2014 15:06:38 +0000 (15:06 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

10 years agoMerge "Bug 933: Fixed incorrect update type when Link was deleted."
Ed Warnicke [Wed, 7 May 2014 14:38:53 +0000 (14:38 +0000)]
Merge "Bug 933: Fixed incorrect update type when Link was deleted."

10 years agoFRM should use async function on southbound event 54/6754/2
Alessandro Boch [Tue, 6 May 2014 17:39:18 +0000 (10:39 -0700)]
FRM should use async function on southbound event

- On reacting to southbound events (switch up/down, ports added/removed, ...)
  FRM is supposed to use asynchronous calls for flows installation/removal.
  This is needed because these events may affect a large number of flows,
  for which we do not want to slow down the processing via sync calls.
  Also, logic has been we never do process synchronously a southbound event.
- In case of port up, FRM was still using a synchronous call.
  This patch is for taking care of that.

Change-Id: I4b6dae0df75ad778ea2f1d555a258a48ea66c57b
Signed-off-by: Alessandro Boch <aboch@cisco.com>
10 years agoBug 967: Statistics Manager should delete flow, not augmentation only. 83/6783/3
Tony Tkacik [Wed, 7 May 2014 11:15:26 +0000 (13:15 +0200)]
Bug 967: Statistics Manager should delete flow, not augmentation only.

Change-Id: I0c74e3e55f61078851e28b27847945c0ea8a9c51
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agoIncrease mdsal's notification queue size, make it configurable. 87/6787/1
Tomas Olvecky [Wed, 7 May 2014 12:56:56 +0000 (14:56 +0200)]
Increase mdsal's notification queue size, make it configurable.

Add System property mdsal.notificationqueue.size to allow tweaking
of queue size.
Increase default queue size from 10 to 1000.

Change-Id: I91e8ac3939092af2b26a7a4d952fe561557b7a46
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoBug 933: Fixed incorrect update type when Link was deleted. 85/6785/1
Tony Tkacik [Wed, 7 May 2014 11:51:45 +0000 (13:51 +0200)]
Bug 933: Fixed incorrect update type when Link was deleted.

Change-Id: I660fc6006785bcf7560a0479ca29f38ceaa208b6
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agoMerge "Bug 946: Fixed eclipse errors with nagasena projects"
Tony Tkacik [Wed, 7 May 2014 11:14:22 +0000 (11:14 +0000)]
Merge "Bug 946: Fixed eclipse errors with nagasena projects"

10 years agoMerge "Fixed typo in SnapshotBackedWriteTransaction class"
Tony Tkacik [Wed, 7 May 2014 11:14:00 +0000 (11:14 +0000)]
Merge "Fixed typo in SnapshotBackedWriteTransaction class"

10 years agoMerge "Breaking up 6360: dummy console"
Giovanni Meo [Tue, 6 May 2014 19:12:42 +0000 (19:12 +0000)]
Merge "Breaking up 6360: dummy console"

10 years agoMerge "Fixed opendaylight-karaf to have resources in target/assembly"
Giovanni Meo [Tue, 6 May 2014 17:12:05 +0000 (17:12 +0000)]
Merge "Fixed opendaylight-karaf to have resources in target/assembly"

10 years agoFixed opendaylight-karaf to have resources in target/assembly 50/6750/1
Ed Warnicke [Tue, 6 May 2014 16:03:03 +0000 (11:03 -0500)]
Fixed opendaylight-karaf to have resources in target/assembly

Change-Id: I1a5ad76bb2c6e6a49cad347df14a1f6630e64475
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoBug-590: Packet loss on first time ping test 74/6674/2
Flavio Fernandes [Sun, 4 May 2014 01:44:34 +0000 (21:44 -0400)]
Bug-590: Packet loss on first time ping test

In this commit, we are addressing a race that could cause the exception (ie first ip packet) to
be lost. What is observed with this bug is that the non-arp packet -- in this case the icmp packet --
is being 'exceptioned' to the SimpleForwarding code path because the node has not yet been programmed
with a flow that would cause it to forward the packet to its destination w/out involving the controller.

The race in this case is caused by Simpleforwarding handling the packet before HostTracker is fully aware
of the destination host. In such case, the forwarding fails to determine where to send the packet and drops it.

The proposed change in this commit takes a stab at handling the race by keeping the packet until either
1) the destination is known by HostTracker or 2) a max time expires. In order to accomplish that, the change
includes the creation of a thread that will periodically age out any packet that have been pending for too
long. The change also adds a concurrent map for efficient lookup among the pending packets. There is a
limitation in this implementation: it will keep at most 1 packet pending per destination ip address. This is
believed not to be a problem, because of the short amount of time it takes for hostTracker to learn about the
destination after the packet is put int the pending map.

Change-Id: I7ec1de69f7841eb7ca5603715b54685be9781401
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
10 years agoBUG-509 transaction future result listening 43/6743/1
Michal Rehak [Tue, 6 May 2014 13:09:27 +0000 (15:09 +0200)]
BUG-509 transaction future result listening

- replaced transactionResult.get() with future listener

Change-Id: I6f047a3c65fbb2cf669cb8912920aacc0c2848d3
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMerge "Bug: 627 Added RESTConf API Explorer that dynamically generates API documentat...
Tony Tkacik [Tue, 6 May 2014 06:52:40 +0000 (06:52 +0000)]
Merge "Bug: 627 Added RESTConf API Explorer that dynamically generates API documentation and serves it through swagger UI. Details are documented in this wiki: https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Restconf_API_Explorer"

10 years agoMerge changes I05e784af,Ie975a2ec
Tony Tkacik [Tue, 6 May 2014 06:49:43 +0000 (06:49 +0000)]
Merge changes I05e784af,Ie975a2ec

* changes:
  BUG-693 Config module for netconf client dispatcher.
  BUG-938 Fix negotiation error when using exi

10 years agoBreaking up 6360: dummy console 29/6729/5
Mathieu Lemay [Mon, 5 May 2014 23:20:56 +0000 (19:20 -0400)]
Breaking up 6360: dummy console

https://git.opendaylight.org/gerrit/#/c/6360/29

Change-Id: I7915821a74d582f9d41bc200c25e3d7b35cf140b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
10 years agoMerge "Breaking up 6360: Simple karaf distro"
Tony Tkacik [Mon, 5 May 2014 20:43:08 +0000 (20:43 +0000)]
Merge "Breaking up 6360: Simple karaf distro"

10 years agoMerge "Breaking up 6360: common pom file"
Tony Tkacik [Mon, 5 May 2014 20:35:20 +0000 (20:35 +0000)]
Merge "Breaking up 6360: common pom file"

10 years agoMerge "Bug 949: Fixed support for DataChangeListeners listening directly on Augmentation"
Ed Warnicke [Mon, 5 May 2014 19:53:40 +0000 (19:53 +0000)]
Merge "Bug 949: Fixed support for DataChangeListeners listening directly on Augmentation"

10 years agoBreaking up 6360: Simple karaf distro 28/6728/2
Ed Warnicke [Mon, 5 May 2014 18:57:41 +0000 (13:57 -0500)]
Breaking up 6360: Simple karaf distro

https://git.opendaylight.org/gerrit/#/c/6360/29

Change-Id: Ie2ab6f228146c5fe0db8c0caa0e99e9febe144ef
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoBreaking up 6360: common pom file 27/6727/2
Ed Warnicke [Mon, 5 May 2014 19:32:06 +0000 (14:32 -0500)]
Breaking up 6360: common pom file

https://git.opendaylight.org/gerrit/#/c/6360/29/opendaylight/commons/opendaylight/pom.xml
Just bringing in the common pom file changes.

Change-Id: Ie34e92325e55660dfdf009b1294c41217ec42534
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoBug 949: Fixed support for DataChangeListeners listening directly on Augmentation 26/6726/3
Tony Tkacik [Mon, 5 May 2014 18:19:55 +0000 (20:19 +0200)]
Bug 949: Fixed support for DataChangeListeners listening directly on Augmentation

Used InstanceIdentifier codec does not support AugmentIdentifier, since it is
designed for CompositeNode format (serialization as defined by YANG Spec).
Instance Identifier for NormalizedNode format allows to directly reference
augmentation, for which support was missing.

Added a special case handling of Instance Identifiers which targets augmentation
directly, since Binding-Aware API and NormalizedNode API allows it.

Change-Id: I6371a54dae0e32cac4e1c9b9ab309e91ec3192d9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agoRemove vip from the vips collections instead of members. 06/6606/2
Sivasamy Kaliappan [Tue, 29 Apr 2014 18:19:47 +0000 (23:49 +0530)]
Remove vip from the vips collections instead of members.

Change-Id: I82063e74526a770772fb1eb5d91ab68ea3aeb449
Signed-off-by: Sivasamy Kaliappan <sivasamyk@gmail.com>
10 years agoMerge "BUG-832 Add schemaContext to notification parsing process in sal-netcon-connector"
Ed Warnicke [Mon, 5 May 2014 12:43:36 +0000 (12:43 +0000)]
Merge "BUG-832 Add schemaContext to notification parsing process in sal-netcon-connector"

10 years agoMerge "BUG-832 Fix exception from sal-netconf-connector."
Ed Warnicke [Mon, 5 May 2014 12:42:39 +0000 (12:42 +0000)]
Merge "BUG-832 Fix exception from sal-netconf-connector."

10 years agoMerge "Skip from the surefire execution plugins that can step over guava feet"
Ed Warnicke [Mon, 5 May 2014 12:10:39 +0000 (12:10 +0000)]
Merge "Skip from the surefire execution plugins that can step over guava feet"

10 years agoBUG-693 Config module for netconf client dispatcher. 25/6025/7
Maros Marsalek [Wed, 23 Apr 2014 13:12:47 +0000 (15:12 +0200)]
BUG-693 Config module for netconf client dispatcher.

netconf/
NetconfClientDispatcher and NetconfSSHClientDispatcher merged into NetconfClientDispatcherImpl.
Introduced NetconfClientConfiguration to contain all configuration attributes for netconf clients.
Introduced interface for NetconfClientDispatchers.
Removed NetconfITSecureTest since it did not test secure connection.

config/
Added netconf-config-api maven module, which contains service definition of client-dispatcher.
Added netconf-config-dispatcher maven module, which contains config module for client-dispatcher.

md-sal/
Updated configuration for sal-netconf-connector with client dispatcher dependency (backwards compatibility preserved).

Change-Id: I05e784af6a9b8e11fad21d3bad0311c110754d31
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoBug 946: Fixed eclipse errors with nagasena projects 44/6744/2
tpantelis [Sat, 3 May 2014 07:30:58 +0000 (03:30 -0400)]
Bug 946: Fixed eclipse errors with nagasena projects

- Uploaded the nagasena OSGi bundle jars to nexus with group ID
org.openexi.
- Changed affected dependencies
- Removed thirdparty/org.openexi project

Change-Id: I280749e287a7b8e918095cff79729888b7caa4ec
Signed-off-by: tpantelis <tpanteli@brocade.com>
10 years agoBUG-938 Fix negotiation error when using exi 50/6650/2
Maros Marsalek [Fri, 2 May 2014 08:43:07 +0000 (10:43 +0200)]
BUG-938 Fix negotiation error when using exi

EXIConfirmation handler is now added to pipeline before start-exi is sent.

Add test with secure netconf server + exi

Change-Id: Ie975a2ecf31cfbb8c1fd4e25e8f41876e0552a00
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoBug 946: Fixed eclipse errors in sal-binding-dom-it 62/6662/2
tpantelis [Fri, 2 May 2014 03:26:54 +0000 (23:26 -0400)]
Bug 946: Fixed eclipse errors in sal-binding-dom-it

Enabled the yang-maven-plugin to run by defult in eclipse

Change-Id: I3137cbe790891333b7526c832c9a173f6e591d0c
Signed-off-by: tpantelis <tpanteli@brocade.com>
10 years agoMerge "BUG-633: allow overriding of channelFactory"
Ed Warnicke [Thu, 1 May 2014 16:36:16 +0000 (16:36 +0000)]
Merge "BUG-633: allow overriding of channelFactory"

10 years agoBUG-633: allow overriding of channelFactory 37/6637/1
Robert Varga [Thu, 1 May 2014 15:55:00 +0000 (17:55 +0200)]
BUG-633: allow overriding of channelFactory

It turns out netty does not let us override an already-set
channelFactory. Reorder customization to detect when such an override is
necessary.

Change-Id: I99de69b98e4034d4701313942d9ed2a09923375d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "BUG-634: introduce netty ChannelFactory wrapper"
Ed Warnicke [Thu, 1 May 2014 15:18:12 +0000 (15:18 +0000)]
Merge "BUG-634: introduce netty ChannelFactory wrapper"

10 years agoMerge "BUG 274 REST response instead of NumberFormatException"
Ed Warnicke [Thu, 1 May 2014 15:17:55 +0000 (15:17 +0000)]
Merge "BUG 274 REST response instead of NumberFormatException"

10 years agoMerge "Modify config code generator to write JmxAttribute as static fields."
Ed Warnicke [Thu, 1 May 2014 14:55:29 +0000 (14:55 +0000)]
Merge "Modify config code generator to write JmxAttribute as static fields."