controller.git
7 years agomoved maven property nexusproxy 12/2112/2
Michal Rehak [Wed, 23 Oct 2013 16:08:14 +0000 (18:08 +0200)]
moved maven property nexusproxy

now nexusproxy resides in pom where it is used
in commons.parent it was renamed to nexusdeploy to avoid misusage

Change-Id: I4485820797a0be6e91bae30b517950dc5bcef46b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agoAdded method for getting non-cached flow statistics 20/2120/1
Asad Ahmed [Wed, 23 Oct 2013 23:57:41 +0000 (16:57 -0700)]
Added method for getting non-cached flow statistics

Change-Id: I55f5846e35caca50dd638113fe77882b7213d221
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
7 years agoAdded per node flow query 19/2119/1
Asad Ahmed [Wed, 23 Oct 2013 20:59:54 +0000 (13:59 -0700)]
Added per node flow query

Change-Id: Iab10ad1a38b69786ff2f3b36b070bcca40cc8ee5
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
7 years agoAdding resources for a testing 00/2100/2
msunal [Wed, 23 Oct 2013 11:26:40 +0000 (13:26 +0200)]
Adding resources for a testing

- added xml, yang, json resources for a testing
- created JsonMapper class - there will be conversion to json based on yang schema

Change-Id: I71b13018f9e9e1ed20279f79a0a6e07a0ecef89a
Signed-off-by: Martin Sunal <msunal@cisco.com>
7 years agoImplement consistency barrier in yang-store-impl. 13/2113/1
Tomas Olvecky [Wed, 23 Oct 2013 16:27:26 +0000 (18:27 +0200)]
Implement consistency barrier in yang-store-impl.

Fix possible exceptions occurring on startup that are caused by OSGi container
notifying about added bundles in wrong order.

Change-Id: I3dae0447a775b6fd03c9d02ac0471bad82e0f2fb
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoAdd change notification functionality to yang-store. 79/2079/3
Tomas Olvecky [Tue, 22 Oct 2013 12:11:09 +0000 (14:11 +0200)]
Add change notification functionality to yang-store.

Add ability to listen for change notifications to yang-store. Listeners get notified when
new yang files are found in bundles and also when bundle with yang files is stopped.

Change-Id: I7c665a57ba7face18bf128d6a7db17c1a23526ce
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoFix for $[netconf.version} issues. 90/2090/1
Ed Warnicke [Wed, 23 Oct 2013 03:03:55 +0000 (22:03 -0500)]
Fix for $[netconf.version} issues.

Change-Id: I39bc581dbb09f5f145fd5d9b08c6872b58f29184
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoFixed bug when SAL Proxy service was not returned to the consumer 80/2080/3
Tony Tkacik [Tue, 22 Oct 2013 15:53:14 +0000 (17:53 +0200)]
Fixed bug when SAL Proxy service was not returned to the consumer

Change-Id: I5ba2e330c86925e8e893734a7f5b64ca1eb4c1e4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFixed two minor issues : 89/2089/2
Anil Vishnoi [Tue, 22 Oct 2013 21:56:43 +0000 (03:26 +0530)]
Fixed two minor issues :
    1) Throw error is VIP is not attached to any pool
    2) If source and destination machines are connected to same switch node, routing service returns null as a path between same node. Fixed this scenario by adding a check.

Change-Id: I8399bf40af2e1c90501240249802f8d89cc480e7
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
7 years agoAdded model-flow-management to distribution. 82/2082/2
Ed Warnicke [Tue, 22 Oct 2013 16:32:59 +0000 (11:32 -0500)]
Added model-flow-management to distribution.

Change-Id: I58ae5581ae2db62638057d1a045fcf6f3725c034
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMake the sanity test countup limit a constant and set it to 120 19/2019/3
Ed Warnicke [Sat, 19 Oct 2013 19:04:50 +0000 (14:04 -0500)]
Make the sanity test countup limit a constant and set it to 120

Also add some additional output indicating how long we've been
tryign to start.

Change-Id: I02778bdbee6b9778249cae318debff360ca89a7a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoAdded sonar converage for mdsal. 76/2076/2
Ed Warnicke [Tue, 22 Oct 2013 14:31:32 +0000 (09:31 -0500)]
Added sonar converage for mdsal.

Change-Id: Iebf580b59a5a03ff104adcc88cf6b9c162acb854
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBump version of netconf-subsystem to 0.2.2-SNAPSHOT. 83/2083/1
Tomas Olvecky [Tue, 22 Oct 2013 18:13:10 +0000 (20:13 +0200)]
Bump version of netconf-subsystem to 0.2.2-SNAPSHOT.

Also clean up poms in netconf subsystem.

Change-Id: I419700edbdf4051ea4fed6cbffc1a558635a5548
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoUpgrade netty version to 4.0.10. This release solves a resource leak bug 37/2037/2
Alissa Bonas [Mon, 21 Oct 2013 08:26:46 +0000 (11:26 +0300)]
Upgrade netty version to 4.0.10. This release solves a resource leak bug
in HashedWheelTimer.

Change-Id: Ic8ecbaf1753e4eaad926b083c22e779f252af315
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoSAL binding it test comments. 64/2064/2
Jozef Gloncak [Tue, 22 Oct 2013 06:21:40 +0000 (08:21 +0200)]
SAL binding it test comments.

Change-Id: Ibaec95527eeb29369a60c585e5b7eaeeacec4fb2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoProper unregistration of provider's session 68/2068/2
msunal [Tue, 22 Oct 2013 07:43:28 +0000 (09:43 +0200)]
Proper unregistration of provider's session
- if provider's session is closed, all RPCs from broker are removed

Change-Id: Ie59c19868b340588c2b7114830493986d1be3b6b
Signed-off-by: Martin Sunal <msunal@cisco.com>
7 years agobump netty to version 4.0.10.Final 67/2067/2
Martin Bobak [Mon, 21 Oct 2013 14:18:41 +0000 (16:18 +0200)]
bump netty to version 4.0.10.Final

Change-Id: Ia3cd0b6a0443d252971cfd0beb59bd5ccc800116
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoRelax conflict check in FRM 77/1977/5
Alessandro Boch [Thu, 17 Oct 2013 23:25:20 +0000 (16:25 -0700)]
Relax conflict check in FRM

- FRM to allow redundant flow entry installation requests

Change-Id: Ibd58562141369aea2595b63510aed1236b05190f
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoDeclare commons-io version 47/2047/2
Alissa Bonas [Mon, 21 Oct 2013 12:47:36 +0000 (15:47 +0300)]
Declare commons-io version

Change-Id: I5493d8144199af7127b7fe5c8b94d2c4c59ef1ab
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoAdded cookie to data packet model 56/2056/2
Tony Tkacik [Mon, 21 Oct 2013 17:07:50 +0000 (19:07 +0200)]
Added cookie to data packet model

Change-Id: If4a160536a7e7058741efd7ba795f82f545fccbf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoAdded bin/ to the directories that checkstyle skips. 53/2053/2
Ed Warnicke [Mon, 21 Oct 2013 15:03:18 +0000 (10:03 -0500)]
Added bin/ to the directories that checkstyle skips.

Change-Id: I5d16f56791357c0ac85a589e5d6f183a63d6aa70
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoAdded back the config subsystem. 33/2033/2
Ed Warnicke [Mon, 21 Oct 2013 00:28:26 +0000 (19:28 -0500)]
Added back the config subsystem.

Also added a maven plugin to the list of plugins Eclipse
should ignore as it doesn't know how to deal with them.

Change-Id: I963ff4f1e627f8a774c24160623e866502c1eeed
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoRemove deprecated methods from config-api. 51/2051/2
Tomas Olvecky [Mon, 21 Oct 2013 14:43:59 +0000 (16:43 +0200)]
Remove deprecated methods from config-api.

Remove methods that were supporting users before code generation was in place.

Change-Id: I6bb2106c98d7f4a1c0bcaa23bb7c565e93243fe2
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoMove 2 jacoco/sonar settings to commons pom for reuse. 57/1957/3
Alissa Bonas [Thu, 17 Oct 2013 09:36:32 +0000 (12:36 +0300)]
Move 2 jacoco/sonar settings to commons pom for reuse.

Change-Id: Ib32169e0dd4a8100f7f0258292955534fcd58a56
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoAdded TestHelper with new PaxExam options, which could be reused by other ITs. 43/2043/1
Tony Tkacik [Mon, 21 Oct 2013 11:24:33 +0000 (13:24 +0200)]
Added TestHelper with new PaxExam options, which could be reused by other ITs.

Change-Id: I8ee9e5e9f56c77fe6fa177ecb2675752e437ef48
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoAdded container and flow name details as in AD-SAL 09/2009/2
Prasanna Huddar [Fri, 18 Oct 2013 11:25:36 +0000 (16:55 +0530)]
Added container and flow name details as in AD-SAL

Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com>
Change-Id: I0350a78b59ba8068c642483cab5217c79ec71a71

7 years agoReworked Netconf framing mechanism, added chunked framing mechanism. 97/1897/4
Milos Fabian [Tue, 15 Oct 2013 07:35:43 +0000 (09:35 +0200)]
Reworked Netconf framing mechanism, added chunked framing mechanism.

Chunked framing mechanism http://tools.ietf.org/html/rfc6242#section-4.2

Change-Id: I00c44560836a8df66c33f6c90fa460984c4581fa
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoMake netconf client throw checked Interrupted exception instead of unchecked 02/2002/2
Maros Marsalek [Fri, 18 Oct 2013 08:18:37 +0000 (10:18 +0200)]
Make netconf client throw checked Interrupted exception instead of unchecked

Change-Id: Id49cc22fc463c754aca98fb03e53afe38b6c9ac4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoRefactored implementation of Notification Invoker 29/2029/3
Tony Tkacik [Sun, 20 Oct 2013 16:57:33 +0000 (18:57 +0200)]
Refactored implementation of Notification Invoker

sal-binding-broker:
  Refactored implementation of listener invoker to be avoid reflection
  when invoking notification callbacks to avoid reflection.

sal-binding-it:
  Added integration test which tests basic notification scenarios
  such as publishing and receiving notifications using generated
  interfaces.

Change-Id: I7afcf25e6f29608d76143058f2eb6aec12a7ccd2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoDeclare netty.version and reuse it in commons pom. 26/2026/1
Alissa Bonas [Sun, 20 Oct 2013 11:45:49 +0000 (14:45 +0300)]
Declare netty.version and reuse it in commons pom.

Change-Id: Idf1dc5a7ac172583dd2171fa73c13367a0af5637
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoUpdated BindingAware Activators to prevent premature initialization 55/1955/3
Tony Tkacik [Thu, 17 Oct 2013 08:26:47 +0000 (10:26 +0200)]
Updated BindingAware Activators to prevent premature initialization

Fixes a bug when BindingAwareActivators loaded in wrong order and
tried to retrieve MD-SAL broker before broker bundle was started.

Change-Id: I87f807974b8581a14b387928a52c2ee2fd83208c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoIntegrating Jolokia REST Bridge for JMX 92/1992/4
Madhu Venugopal [Fri, 18 Oct 2013 07:01:07 +0000 (00:01 -0700)]
Integrating Jolokia REST Bridge for JMX

Jolokia provides remote JMX functionality with JSON messages over REST API.
This change just integrates the Jolokia Servlet with the controller's Web Container.

Change-Id: I5dd12513d29903dbe10aeec9fc34080e5d25730b
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
7 years agoSlight fix to actually handle exception in Sanitytest. 72/1972/2
Ed Warnicke [Thu, 17 Oct 2013 15:16:40 +0000 (10:16 -0500)]
Slight fix to actually handle exception in Sanitytest.

Actually handle Thread.sleep InteruptException

Change-Id: I43ed0d976da336cfd71071e1d4196a24b031e01b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoModified the setting of JAVA_HOME for linux to be more generic. 10/2010/2
Sam Hague [Fri, 18 Oct 2013 13:09:51 +0000 (09:09 -0400)]
Modified the setting of JAVA_HOME for linux to be more generic.

The new code sets the value with the assumption that the user has java
somewhere in their path and that it is set to the JAVA version they
want to use. JAVA_HOME is then set based on that location.

Change-Id: Ie77f0c34f1c1d342ed0a8d0660631db7e5623137
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoBasic Northbound APIs for User Management 48/1948/3
mrajvaid [Thu, 17 Oct 2013 00:37:32 +0000 (17:37 -0700)]
Basic Northbound APIs for User Management

Change-Id: Ie0d36b9faf92fd0663fe17179d66e5f471f79e38
Signed-off-by: mrajvaid <mrajvaid@cisco.com>
7 years agoFix for versions in odl-model-project archetype. 76/1976/1
Ed Warnicke [Thu, 17 Oct 2013 22:44:12 +0000 (17:44 -0500)]
Fix for versions in odl-model-project archetype.

Change-Id: I33479badd1191efb16540b5f5949dcac0daec3be
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoRemove the usages of @XmlSeeAlso annotation. 52/1952/3
Prasanth Pallamreddy [Wed, 16 Oct 2013 18:48:56 +0000 (11:48 -0700)]
Remove the usages of @XmlSeeAlso annotation.

- The @XmlSeeAlso annotations are unnecessary now that the bundle
  scanner can detect them automatically.
- minor fix to the bundle scanner to allow annotated classes to be
  loaded from a proper classloader

Change-Id: I4445ddbdb5b2f2f8edce34f0c056e3da61f916d5
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
7 years agoFix warnings in poms - duplicate and incorrect dependencies 32/1932/2
Alissa Bonas [Wed, 16 Oct 2013 14:12:51 +0000 (17:12 +0300)]
Fix warnings in poms - duplicate and incorrect dependencies

Change-Id: Ia8978555a51ae9be02782b8c70d8867fe2052c7a
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoUpdated implementation of internal RPC Router for Binding-Aware Broker and added... 33/1933/4
Tony Tkacik [Wed, 16 Oct 2013 15:01:47 +0000 (17:01 +0200)]
Updated implementation of internal RPC Router for Binding-Aware Broker and added IT to it

sal-binding-broker:
    Updated implementation of runtime code generator to adhere to RpcRouter contract,
    which is used by binding aware broker for introspection and configuration of runtime generated
    instances without need to use Reflection.

sal-binding-it:
    Added end-to-end integration test which tests following scenarios:
      - Registration of 2 Providers of Flow Service, 1 Consumer
        after registration 4 instances of Flow Service are existing:
         MD-SAL Northbound (runtime generated) - returned to the consumer.
         Optimized RpcRouter (runtime generated) - internal to MD-SAL
         2 implementations supplied by Provider.

      - Test verifies that implementations are not leaked to the Consumer

      - Routing of messages (calls):
         1. Provider 1. registers as provider for Node One, Consumer sends message to Node One, Provider 1. is invoked.
         2. Provider 2. registers as provider for Node Rwo, consumer sends message to Node Two, Provider 2. is invoked.
 3. Provider 1. unregisters as provider for Node One, Provider 2. registers as provider  for Node One,
            Consumer sends message to Node One, Provider 2. is invoked.

Change-Id: I101e26c190cd1770aaff1db974f9b0c341506482
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoAdd code for working sanity test in windows. 93/1893/6
Ryan Moats [Mon, 14 Oct 2013 23:40:37 +0000 (18:40 -0500)]
Add code for working sanity test in windows.

Refactor application windows batch file to avoid delayed
execution issues.  Add windows batch file to run sanity test.
Refactor sanity test class to call windows batch file properly.
Refactor activator class to close System.out stream before exiting
so that ProcessBuilder detects the exit.

Refactor to first check at 10 seconds and then recheck every second
if bundles are still in the STARTING state.

Refactor to inherit IO and add limit of 60 retries.

And fix style errors

Change-Id: Ifa4d78ebfcf0eeaaccf99e56e84a88d33377f0fa
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoMoving the connection manager NB-API from the network configuration APIs to connectio... 24/1924/3
Madhu Venugopal [Wed, 16 Oct 2013 10:08:48 +0000 (03:08 -0700)]
Moving the connection manager NB-API from the network configuration APIs to connectionmanager API.
Also cleaned up these APIs as per the NBAPI conventions.

Change-Id: Ie633374210ce594d0df0b7a86f4fdc553ef64ade
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
7 years agoProvide Container authorization roles to application running in container 40/1940/1
Alessandro Boch [Wed, 16 Oct 2013 18:47:27 +0000 (11:47 -0700)]
Provide Container authorization roles to application running in container

- An application that runs in a container needs to grant access to its
  resources to the container administrative roles

Change-Id: I439bbb9d5f8aa6dfb17fcaf518654ef3d42979f7
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix .gitignore to ignore xtend-gen directories 17/1917/2
Ed Warnicke [Tue, 15 Oct 2013 20:25:13 +0000 (15:25 -0500)]
Fix .gitignore to ignore xtend-gen directories

Change-Id: I6fd66bff7d6c2ff895c92672271d67306fa323b4
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoProvide edit functionality for Static Flows 16/1916/2
Sapan Shah [Tue, 15 Oct 2013 19:27:25 +0000 (12:27 -0700)]
Provide edit functionality for Static Flows

Change-Id: I345579c8b97addc4a335044a4f34d5fc694c63e5
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoMD-SAL RuntimeDataProvider for Forwarding Rules 82/1882/7
Tony Tkacik [Mon, 14 Oct 2013 16:56:43 +0000 (18:56 +0200)]
MD-SAL RuntimeDataProvider for Forwarding Rules

Change-Id: I0eac10ec50c9f4a4e95a0d9542842078ef8c7422
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoAdded topology support to SAL Compatibility 05/1905/2
Tony Tkacik [Tue, 15 Oct 2013 14:23:42 +0000 (16:23 +0200)]
Added topology support to SAL Compatibility

Change-Id: I6bdb967313a3a2a78f3734de18ce92da5b8bf9ea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoRemoved xTend from private packages. Added OSGI-fied XTend to distribution 01/1901/1
Tony Tkacik [Tue, 15 Oct 2013 10:41:21 +0000 (12:41 +0200)]
Removed xTend from private packages. Added OSGI-fied XTend to distribution

 - Removed XTend library from Private packages in XTend projects
 - In runtime (distribution) XTend packages are provided by
   OSGI-fied XTend bundle org.opendaylight.yangtools.thirdpary:xtend-lib-osgi:2.4.3

Change-Id: Ib79e678d740ffbcf4c4e5f6c370271af5ca76019
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoAdded composed Activator for MD-SAL to AD-SAL translation 76/1876/8
Tony Tkacik [Mon, 14 Oct 2013 12:48:59 +0000 (14:48 +0200)]
Added composed Activator for MD-SAL to AD-SAL translation

Activator implements both ComponentBase Activator from AD-SAL
and uses Felix DM to retrieve Binding-Aware Broker which
then treats Activator as BindingAwareConsumer.

Change-Id: I24b414d8b9d0846d12cff55d5a3b54fa6b697c05
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoExclude yang/md-sal related bundles when building the base distribution package 85/1885/3
Moiz Raja [Mon, 14 Oct 2013 19:38:27 +0000 (12:38 -0700)]
Exclude yang/md-sal related bundles when building the base distribution package

This is done only when the DOINGRELEASE flag is enabled. This is not intended to
be a standard build to be used by ODL but by a specific project outside ODL.
Fixing this for backward support only.

Change-Id: I535072731d4189271b97c90338c16da1a6591b61
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoCandidate fix for "NoSuchAlgorithm SunX509 KeyManager" error. 91/1891/2
Ed Warnicke [Mon, 14 Oct 2013 21:41:48 +0000 (16:41 -0500)]
Candidate fix for "NoSuchAlgorithm SunX509 KeyManager" error.

Used KeyManagerFactory.getDefaultAlgorithm() instead.

Change-Id: Ib1cff94c5f33cb82b004b995802878ed8a75e87c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoFix for breakage regarding DataStoreIdentifiers 81/1881/4
Tony Tkacik [Mon, 14 Oct 2013 16:54:03 +0000 (18:54 +0200)]
Fix for breakage regarding DataStoreIdentifiers

Change-Id: I74ec719f5e3be040e6f399a24d2859a0ef89665e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoTemporarily disabling config subsystem 83/1883/2
Ed Warnicke [Mon, 14 Oct 2013 18:18:21 +0000 (13:18 -0500)]
Temporarily disabling config subsystem

Change-Id: Ifebd287cd7b79a30123fd8d325c0d90a7bbb3dce
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoUpdated RESTCONF implementation 75/1875/4
Tony Tkacik [Mon, 14 Oct 2013 12:43:05 +0000 (14:43 +0200)]
Updated RESTCONF implementation

  - Restconf implementation now implements new SAL readign contracts
    in form of <String,CompositeNode> where String is Restconf version
    of instance identifier.

    Translation of Restconf InstanceIdentifier into Binding-Independent
    Restconf Instance-Identifier is done by ControllerContext class
    which implements stateful translation of identifier based on schema
    context.

    After translation of instence-identifier most of actions maps
    directly to Binding-Independent APIs.

Change-Id: I248470e282826a3f04f6e99f54aae8fd14ea2eb3
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoInitial code drop of netconf protocol implementation 76/1776/9
Maros Marsalek [Tue, 8 Oct 2013 16:26:35 +0000 (18:26 +0200)]
Initial code drop of netconf protocol implementation

This implementation is based on infrastructure provided by the framework artifact
and contains server as well as client side code.

Netconf subsystem structure:
Netconf-api:
Api definition for client and server.

Netconf-impl:
Netconf server implementation. Server handles basic communication
and delegates handling of rpcs to an implementation of netconf-mapping-api.

Netconf-mapping-api:
Api definition for pluggable rpcs handler. Implementations of this api
are plugged dynamically into netconf-impl using OSGi apis.

Config-netconf-connector:
Implementation of netconf-mapping-api that handles netconf rpcs and delegates
requests to configuration subsystem

Netconf-util:
Utility classes used by client and server code.

Netconf-client:
Netconf client implementation.

Netconf-it:
Integration tests for netconf. These tests verify correct cooperation of netconf server,
config-netconf-connector, config subsystem and netconf client.

Config-persister-api:
Api definition for config persister. Config persister is a component that is responsible
for storing configuration snapshots after every change to the configuration via netconf rpcs.
(Pushed to config-subsystem)

Config-persister-impl:
Implementation of config persister that receives notifications from netconf-impl about changes
to the configuration and uses pluggable adapters to store received snapshots.

Config-persister-file-adapter:
Implementation of config persister adapter that stores and restores config snapshots from a file.
(Pushed to config-subsystem)

In order to run netconf in OSGi, some configuration issues had to be resolved
in config-subsystem bundles.

Change-Id: I8e0421c924b0714a4d49962c4bb5ca01ef68ac78
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoFixed Sanity Test to only accept bundles being RESOLVED if they are fragments 64/1864/2
Ed Warnicke [Sun, 13 Oct 2013 22:34:54 +0000 (17:34 -0500)]
Fixed Sanity Test to only accept bundles being RESOLVED if they are fragments

Change-Id: Idfc804a81be493b56ef74fee5e335f656eeba344
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoAdded routing context information to models. 62/1862/2
Tony Tkacik [Sun, 13 Oct 2013 20:03:57 +0000 (22:03 +0200)]
Added routing context information to models.

Change-Id: I8ed3497bf6a1905333fd042f732814e2e815a2a2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoUpdated Flow Capable Models & AD SAL Compatibility mapping 53/1853/3
Tony Tkacik [Sun, 13 Oct 2013 17:20:39 +0000 (19:20 +0200)]
Updated Flow Capable Models & AD SAL Compatibility mapping

  - Updated Inventory notifications of Flow Capable Nodes
  - Updated SAL Compatibility to use XTend for easier readability
    of Model-to-Model Mapping (AD-SAL to MD-SAL)
  - Added Adapter for: AD-SAL Inventory, Read services

Change-Id: I564301cdea66a3b843eb469520ba4383b1e92e23
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoUpdated ext:context-reference to point to right identity. 40/1840/1
Martin Vitez [Fri, 11 Oct 2013 16:52:46 +0000 (18:52 +0200)]
Updated ext:context-reference to point to right identity.

Change-Id: I36d79271ff16e5cfcc3117c563b8ca3cb2237889
Signed-off-by: Martin Vitez <mvitez@cisco.com>
7 years agoUpdated integration test for broker 36/1836/1
Tony Tkacik [Fri, 11 Oct 2013 14:54:31 +0000 (16:54 +0200)]
Updated integration test for broker

Change-Id: Ibcf908c651599890e72b8d2e9c0f137e04d99b49
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoUpdated Flow Services Adapter,started inventory adapter. 13/1813/2
Tony Tkacik [Thu, 10 Oct 2013 18:37:03 +0000 (20:37 +0200)]
Updated Flow Services Adapter,started inventory adapter.

Change-Id: Ie369f20445df872fec16bd4b9cc6318460f21573
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoUpdated flow capable node models. 98/1798/2
Tony Tkacik [Thu, 10 Oct 2013 11:46:06 +0000 (13:46 +0200)]
Updated flow capable node models.

Change-Id: I8308148e5e081bed135917e4f57b1611906cca74
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoRevert "Temporarily exclude config from the build until yangtools related issue is... 05/1805/1
Ed Warnicke [Thu, 10 Oct 2013 17:13:23 +0000 (17:13 +0000)]
Revert "Temporarily exclude config from the build until yangtools related issue is resolved."

This reverts commit 42ae0cde14c4cb565d4073d1e8969e69a476ad43.

The yangtools issue is fixed

Change-Id: I9e9ae3bda44780ed6cdf905941e99a24039157f2
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoTemporarily exclude config from the build until yangtools related issue is resolved. 01/1801/2
Ed Warnicke [Thu, 10 Oct 2013 15:14:00 +0000 (10:14 -0500)]
Temporarily exclude config from the build until yangtools related issue is resolved.

Change-Id: I1c520e33c2a34d096206200c189b0b0963d69b42
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoAdd felix webconsole and link it off the admin web ui 89/1789/2
Prasanth Pallamreddy [Tue, 1 Oct 2013 23:27:52 +0000 (16:27 -0700)]
Add felix webconsole and link it off the admin web ui

Change-Id: I8b26d95d0f6928f166df01a0e4655b123dd339a9
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
7 years agoMake use of NetUtils.getBroadcastMacAddr() 82/1782/2
Alessandro Boch [Thu, 10 Oct 2013 16:00:49 +0000 (09:00 -0700)]
Make use of NetUtils.getBroadcastMacAddr()

    ISSUE: I suggested to make NetUtils.broadcastMacAddr public, but that was no
           a good idea as we already have the getter and because that is an arra
           therefore vulnerable to modifications.

Change-Id: I098ca828d79ffe1d478c761d8b749ee100dfba5b
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoReuse NetUtils.BroadcastMACAddr in ArpHandler 92/1792/2
Alissa Bonas [Thu, 10 Oct 2013 08:19:28 +0000 (11:19 +0300)]
Reuse NetUtils.BroadcastMACAddr in ArpHandler

Change-Id: Id3dde60da07cb37e40dba79ed3481af794b4356d
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoFixed the yangtools related errors from Eclipse on import 88/1788/2
Ed Warnicke [Thu, 10 Oct 2013 02:19:20 +0000 (21:19 -0500)]
Fixed the yangtools related errors from Eclipse on import

Change-Id: I4bdcdc141906839f42428fad16e36d11ca16fd74
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMistake in the run.sh using backticks instead of quotes when setting JAVA_HOME 84/1784/1
Moiz Raja [Wed, 9 Oct 2013 22:08:56 +0000 (15:08 -0700)]
Mistake in the run.sh using backticks instead of quotes when setting JAVA_HOME

Change-Id: Iabe6474c54b01e5b5eabfd2e8e815638ad8190e9
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoReduce the fragility of the Sanity Test by not trying to access anything outside... 83/1783/2
Moiz Raja [Wed, 9 Oct 2013 20:28:39 +0000 (13:28 -0700)]
Reduce the fragility of the Sanity Test by not trying to access anything outside the current project

Change-Id: I4f563ae82becde73ff412aeddc159cf7c7051433
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoSanity test to verify that the bundles that are included as plugins in the controller... 36/1736/6
Moiz Raja [Mon, 7 Oct 2013 23:22:34 +0000 (16:22 -0700)]
Sanity test to verify that the bundles that are included as plugins in the controller load properly

Change-Id: Id472ab9f17f7a604e473177096b8a5045af913d3
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoExtract ARP and Ethernet creation to method and reuse it to avoid code 94/1694/3
Alissa Bonas [Sun, 6 Oct 2013 15:55:28 +0000 (18:55 +0300)]
Extract ARP and Ethernet creation to method and reuse it to avoid code
duplication.

Change-Id: I7dca913a93ed948c71f54282d03d862471193fee
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoUpdate to MD-SAL models 79/1779/3
Tony Tkacik [Wed, 9 Oct 2013 16:56:26 +0000 (18:56 +0200)]
Update to MD-SAL models

Fixed bug in MD-SAL activation

Change-Id: I636d4d7c7b696c68572e94456a87edc358af4850
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFix for validity check of Action field in FlowConfig 57/1757/2
Pramila Singh [Tue, 8 Oct 2013 22:49:33 +0000 (15:49 -0700)]
Fix for validity check of Action field in FlowConfig

Change-Id: I9ec131df550a5242227c049ec813c022829d1b4d
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoUpdate to MD-SAL APIs 68/1768/3
Tony Tkacik [Wed, 9 Oct 2013 10:51:17 +0000 (12:51 +0200)]
Update to MD-SAL APIs

Introduced new Common APIs from which Binding-Aware and Binding-Independent
APIs are derived, this allows to maintain similar contract between
sal-binding-api and sal-dom-api which provides different access to MD SAL.

 - Fixed typos in YANG models
 - Bumped version of YANG Maven Plugin to 0.5.9-SNAPSHOT which now enforces
   valid YANG models
 - Removed OFPort.yang - Part of that model should be part of flow-node-inventory.yang
 - Removed spaces and tabs from various files
 - Updated implementations to adhere to new API definitions.

Change-Id: I5661a76398e8c8d82250de532aef6e5d268123e8
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoDeclare switchmanager in dependencyManagement in commons, declare its 92/1692/4
Alissa Bonas [Sun, 6 Oct 2013 13:36:36 +0000 (16:36 +0300)]
Declare switchmanager in dependencyManagement in commons, declare its
version once, so it's inherited by child poms.

Change-Id: I48208159bd2058cc27386a89350fe1bd4cbb67f3
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoMake BroadcastMacAddr public in NetUtils 67/1767/2
Alissa Bonas [Wed, 9 Oct 2013 10:43:39 +0000 (13:43 +0300)]
Make BroadcastMacAddr public in NetUtils

Change-Id: I701289b39e7dd05322f67276d198d95e992d8455
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoFix typo "swtch" to "switch" 02/1602/3
Alissa Bonas [Wed, 2 Oct 2013 13:40:18 +0000 (16:40 +0300)]
Fix typo "swtch" to "switch"

Change-Id: Ia3633309a861fb019225398aa4907cbf4b77936e
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoRemoving config subsystem as it does not load in the controller. 58/1758/2
Ed Warnicke [Wed, 9 Oct 2013 00:06:29 +0000 (19:06 -0500)]
Removing config subsystem as it does not load in the controller.

Some notes on this:
1)  Config appears to be missing some yangtools.binding-generator-*
    dependencies that are needed in
    opendaylight/distribution/opendaylight/pom.xml
2)  Attempts to add those dependency fail because they need to
    be higher versions ( 0.6.0-SNAPSHOT and 0.5.9-SNAPSHOT)
    than the current setting for
    <yangtools.version> for the controller.
3)  Attempts to move the controller to use those higher versions
    causes other failures on load.

Config subsystem will be restored to the distribution as soon as it
works with the yangtools version being used in the controller.

Change-Id: Ic5e5c074531bee84494a42517d9de83b93793711
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoFixed most comments from https://git.opendaylight.org/gerrit/#/c/1721/ 56/1756/2
Ed Warnicke [Tue, 8 Oct 2013 22:34:55 +0000 (17:34 -0500)]
Fixed most comments from https://git.opendaylight.org/gerrit/#/c/1721/

Change-Id: I174a3662b13a3a6f2f07954c2d0c742e98cc5ff2
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoReworked pom files 21/1721/10
Tony Tkacik [Mon, 7 Oct 2013 13:21:28 +0000 (15:21 +0200)]
Reworked pom files

Each pom (artifact) declares it's dependencies (internal and external)
No dependencies declared at parent POM level, only dependency Management.

Also moved the <modules> from distribution/opendaylight to the root pom.xml
distribution/opendaylight now builds entirely from dependencies

I have intentionally left some things in here I think are wrong,
because the goal of this commit is to reproduce the existing build
(which it does, I've checked).  Subsequent commits will clean up other things.

Change-Id: I358bdac1c0f6a59b37a418a811a30235967fdfdc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFix NPE in OF plugin Topology Service shim 30/1730/2
Yevgeny Khodorkovsky [Mon, 7 Oct 2013 17:25:56 +0000 (10:25 -0700)]
Fix NPE in OF plugin Topology Service shim

This fixes a NPE that occurs in cluster mode with multiple containers

Change-Id: Ic852cb41f6f65ef5812f9d3f1729434533ce0f5a
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
7 years agoRename constants, add new constants for better code reuse. 97/1697/2
Alissa Bonas [Sun, 6 Oct 2013 20:21:43 +0000 (23:21 +0300)]
Rename constants, add new constants for better code reuse.

Change-Id: Ia2ae82c1c52974490d68997890c165004fd6920b
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoAdd missing test methods to IRouterAware and clean up unused imports. 31/1731/1
Ryan Moats [Mon, 7 Oct 2013 18:20:06 +0000 (13:20 -0500)]
Add missing test methods to IRouterAware and clean up unused imports.

Realized that initial Neutron IRouterAware was missing test methods
for interface attach and detach operation.  In addition, removed
unused imports from other classes.

Change-Id: I8547ad7e7437d7215151f843744b56b2e0d93197
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoRevert "Integrate the Distribution Sanity Test with the build" 26/1726/2
Giovanni Meo [Mon, 7 Oct 2013 15:18:21 +0000 (15:18 +0000)]
Revert "Integrate the Distribution Sanity Test with the build"
It failed merge the patch is not behaving well.
This reverts commit d78e985bc4ed590407c8c7800ba796d5ea55aa6c.

Change-Id: Id2d3a6215f7373165217ad92dfda7a4e9b07d7d8
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoRemoved yangtools packages from bundles export, cleaned up import packages. 49/1649/3
Milos Fabian [Thu, 3 Oct 2013 15:41:02 +0000 (17:41 +0200)]
Removed yangtools packages from bundles export, cleaned up import packages.

Change-Id: I7587222aa1774064f9b002bef277cbad1f058608
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoInital code drop of logback-config. 79/1679/2
Tomas Olvecky [Fri, 4 Oct 2013 14:29:41 +0000 (16:29 +0200)]
Inital code drop of logback-config.

This module bridges logback configuration over config-subsystem, allowing to reconfigure logback via JMX.

Change-Id: I52644b628d384d8ca015885cc9f016f4429238d4
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoIntegrate the Distribution Sanity Test with the build 61/1661/5
Moiz Raja [Fri, 4 Oct 2013 02:24:14 +0000 (19:24 -0700)]
Integrate the Distribution Sanity Test with the build

Added the sanity test to the build. The sanity test plugin is built but not added to the distribution.
In the package phase the test is executed and if the test fails (that is finds modules that are not
active or resolved) then the build fails

Change-Id: Iac8831811e6bf004dc0219043d1b8e23ffbfd33e
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoUpdated bundle instructions. 18/1718/2
Tony Tkacik [Mon, 7 Oct 2013 12:19:58 +0000 (14:19 +0200)]
Updated bundle instructions.

Change-Id: Id33f04cbab2cad79710c617ad1c342dd6cc2daf9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoUpdate to the SAL Data APIs. Added Flow Configuration model 14/1714/2
Tony Tkacik [Mon, 7 Oct 2013 11:12:02 +0000 (13:12 +0200)]
Update to the SAL Data APIs. Added Flow Configuration model

Change-Id: I17a10b5651f63ab9bc1d2a2ed64bf6ca8493b418
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoAdded xtend as private package. 09/1709/2
Tony Tkacik [Mon, 7 Oct 2013 08:03:42 +0000 (10:03 +0200)]
Added xtend as private package.

Change-Id: Ida3cb56116e7a525d776d576eaea486de5dfb3b3
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoPer container save configuration is not synced in the cluster 87/1687/1
Alessandro Boch [Sun, 6 Oct 2013 05:12:04 +0000 (22:12 -0700)]
Per container save configuration is not synced in the cluster

ISSUE: When container administrator saves the configuration on GUI,
       the configurations for the containers on which he has write permission
       are onlyu saved on the local controller.
CHANGE: Have ContainerConfigurationService manage its own event sync cache
        for this specific case. ContainerConfigurationService.saveConfigurations()
        gets invoked only when container adminidtrator trigger the save.For the
        save config triggered by system or network administrator, things work as
        today, it is handled by ConfigurationService which syncs the config event
        to the other ConfigurationServices in the cluster.

Change-Id: I961558579292fd10b0d8ee601aa64f3a3843b0ed
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoAdd tooltips for nodes in topology in UI 22/1622/2
Alissa Bonas [Wed, 2 Oct 2013 13:12:02 +0000 (16:12 +0300)]
Add tooltips for nodes in topology in UI

Bug:97
Change-Id: I12ec43b79e2df5c305b6a63c9e5434998db646d1
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoFix save config for Container Administrator 84/1684/1
Alessandro Boch [Sat, 5 Oct 2013 03:35:53 +0000 (20:35 -0700)]
Fix save config for Container Administrator

- Needed code was missing

Change-Id: Ibe4cbf18db0db96cc7f5b0a717b92ece3066b9c4
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix incorrect trace log in FRM 42/1642/3
Alessandro Boch [Thu, 3 Oct 2013 12:17:13 +0000 (05:17 -0700)]
Fix incorrect trace log in FRM

ISSUE: Log reports failure on opposite action, makes it hard to debug
CHANGE: Also lowering severity from warn to trace for some flow programming logs

Change-Id: If8f59137ccd2539b7d46019d0095b2cb2336fb57
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoIncorrect heading of a table column in the TroubleShooting GUI 60/1660/2
Maurice Qureshi [Thu, 3 Oct 2013 21:54:05 +0000 (14:54 -0700)]
Incorrect heading of a table column in the TroubleShooting GUI
The TroubleShooting Page on ODL Controller has a table "Existing Nodes". This table
has three columns. The middle column has switches. Current heading of this column is
"Static Route", instead of "Node ID".

Change-Id: I0f90d1156255591b00856e027e50bf447aa21733
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
7 years agoAllow Topology DB to keep track of production switches 56/1656/4
Alessandro Boch [Thu, 3 Oct 2013 19:09:42 +0000 (12:09 -0700)]
Allow Topology DB to keep track of production switches

ISSUE: Discovery service is able to discover any non SDN enable
switch directly conencted to the controlled SDN switches which
advertise itself through LLDP. It is a nice feature to be able
to see on the topology to which non-SDN switches the controlled
network nodes are conencted to.
Change in https://git.opendaylight.org/gerrit/#/c/1450/ breaks this feature.

CHANGE: Limit the validation check introduced in the above commit
to the edge head end point only.

Change-Id: I081f4320a73eea9bf2a39ca80717771d9c7adfb3
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoAdd HTTP Client library and refactor Northbound IntegrationTest 08/1608/4
Ryan Moats [Wed, 2 Oct 2013 15:11:17 +0000 (10:11 -0500)]
Add HTTP Client library and refactor Northbound IntegrationTest

Create a new commons.httpclient library for bundles that need
to function as an HTTP client.  Refactor the existing NB
IntegrationTest code to use this new library.

Ammended - library is now a profile of apache httpclient classes
to ensure things like timeouts are set on default and resources
are correctly released when finished.

Change-Id: I76f513b77700213752f4183e917fe239a9c324ff
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoBundleScanner needs to be registered as a bundle listener to track bundles being... 52/1652/2
Prasanth Pallamreddy [Thu, 3 Oct 2013 16:49:49 +0000 (09:49 -0700)]
BundleScanner needs to be registered as a bundle listener to track bundles being added dynamically.

Change-Id: I40af7fb2da4aabe9ae2605d0187d97384be5a3f4
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
7 years agoAdding xtend-gen directories to .gitignore 19/1619/2
Colin Dixon [Wed, 2 Oct 2013 20:28:43 +0000 (15:28 -0500)]
Adding xtend-gen directories to .gitignore

New generated files are showing up in git. This fixes that.

Change-Id: I069c5fc4eb86d4c3eb34631002336dacbd49beef
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
7 years agoRemove commented out code to fix sonar warnings 71/1571/2
Alissa Bonas [Tue, 1 Oct 2013 10:57:18 +0000 (13:57 +0300)]
Remove commented out code to fix sonar warnings

Change-Id: I541069ede01e456824e8e10eb196a34e477bdbd8
Signed-off-by: Alissa Bonas <abonas@redhat.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.