controller.git
6 years agoMerge "Bug 509: Added support for merge operation to InMemoryData Store"
Ed Warnicke [Thu, 24 Apr 2014 11:56:27 +0000 (11:56 +0000)]
Merge "Bug 509: Added support for merge operation to InMemoryData Store"

6 years agoBug 509: Added support for merge operation to InMemoryData Store 38/6338/3
Tony Tkacik [Wed, 23 Apr 2014 14:17:31 +0000 (16:17 +0200)]
Bug 509: Added support for merge operation to InMemoryData Store

Merge operation support is critical for backwards compatibility
and for Binding-Aware mapping and Restconf, which are not aware
of Mixin nodes representing lists, leaflists and choices.

Semantics of merge operation are similar to subtree modified,
but when node is not existing it creates one based on
state provided by user of the Data Broker APIs.

Merge operation also fixes concurrent creations of mixin nodes
as demonstrated in ConcurrentImplicitCreateTest,
where two separate applications may indirectly create same
root node.

Change-Id: I9ab290b512601bd99750a68ee53564e67ef0c879
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 722 - nagasena version bumped to 0000.0002.0038 51/6351/3
Martin Bobak [Wed, 23 Apr 2014 12:43:32 +0000 (14:43 +0200)]
Bug 722 - nagasena version bumped to 0000.0002.0038

Change-Id: Ie755a9a613096aed6f134005d216716c59b90563
Signed-off-by: Martin Bobak <mbobak@cisco.com>
6 years agoMerge "Bug 781: Statistics manager is throwing IllegalStateException"
Ed Warnicke [Wed, 23 Apr 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Bug 781: Statistics manager is throwing IllegalStateException"

6 years agoMerge changes I67420353,I6851f9b9
Tony Tkacik [Wed, 23 Apr 2014 11:48:59 +0000 (11:48 +0000)]
Merge changes I67420353,I6851f9b9

* changes:
  Bug:701-Have Typed ErrorNotification for different node errors
  Bug:645 - MDSAL Notification pool threads not getting spawned besides the core threads

6 years agoBUG-732 Add rollback-on-error error-option to edit-config rpcs from netconf-connector 05/6205/3
Maros Marsalek [Tue, 15 Apr 2014 14:00:27 +0000 (16:00 +0200)]
BUG-732 Add rollback-on-error error-option to edit-config rpcs from netconf-connector

Just in case rollback-on-error capability is supported

+ Add error response warning to netconf-connector

Change-Id: I16251a12b270bd0ed89b39bfccc5251b4b3fe934
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "BUG-732 Fix netconf client deadlock when downloading yang schemas from remote...
Tony Tkacik [Wed, 23 Apr 2014 08:14:48 +0000 (08:14 +0000)]
Merge "BUG-732 Fix netconf client deadlock when downloading yang schemas from remote device"

6 years agoMerge "BUG-758 Eliminate xtend from sal-netconf-connector"
Tony Tkacik [Wed, 23 Apr 2014 08:14:25 +0000 (08:14 +0000)]
Merge "BUG-758 Eliminate xtend from sal-netconf-connector"

6 years agoMerge "fix for BUG-709 - mixed up flow cookie and connection cookie"
Tony Tkacik [Wed, 23 Apr 2014 08:11:13 +0000 (08:11 +0000)]
Merge "fix for BUG-709 - mixed up flow cookie and connection cookie"

6 years agoBug 781: Statistics manager is throwing IllegalStateException 98/6298/3
Anil Vishnoi [Mon, 21 Apr 2014 23:05:57 +0000 (04:35 +0530)]
Bug 781: Statistics manager is throwing IllegalStateException

Change-Id: I418bd4b86bbe9802be3ec7ed904a14ce537f085e
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
6 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Tue, 22 Apr 2014 18:32:03 +0000 (18:32 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

6 years agoBug-590: Packet loss on first time ping test 16/6316/3
Flavio Fernandes [Tue, 22 Apr 2014 15:39:36 +0000 (11:39 -0400)]
Bug-590: Packet loss on first time ping test

In this commit, we are addressing 2 issues that could cause the exception (ie first ip packet) to
be lost. What is observed with this bug is that the non-arp packet -- in this case the icmp packet --
is being 'exceptioned' to the SimpleForwarding code path because the node has not yet been programmed
with flows that would allow it to forward the packet to its destination w/out involving the controller.

Change #1: In cases when the src and dst ip are of hosts in the same node, the getRoute() call is going
to return 'null'. That is because the IRouting lookup will not find a path when src and dst nodes are
the same.

Change #2: When looking up the rulesDB, the key used was using the destHost and the node of the incoming
connector. It should be the destHost and the node of the destHost. Kudos go 100% to Giovanni on this.

Change-Id: I4861acd6ab6d7efe14b50d7537e4b920bffc8a75
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
6 years agoBUG-509, BUG-808: Added datastore support for lists without keys. 11/6311/1
Robert Varga [Tue, 22 Apr 2014 12:54:04 +0000 (14:54 +0200)]
BUG-509, BUG-808: Added datastore support for lists without keys.

The datastore needs to support users who do not specify a list key, but
how expect the item ordering to be retained.

Added test which test all three possible behaviours of list
statement: ordered map, unordered map and list without keys.

Change-Id: I9e136267f57a88e4d2a6a4476025c33497373518
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-732 Fix netconf client deadlock when downloading yang schemas from remote device 53/6253/2
Maros Marsalek [Thu, 17 Apr 2014 10:12:25 +0000 (12:12 +0200)]
BUG-732 Fix netconf client deadlock when downloading yang schemas from remote device

Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Change-Id: Ic70085655e38ebc1e159fd4ba4b93172e468f4ad

6 years agoBUG-758 Eliminate xtend from sal-netconf-connector 52/6252/2
Maros Marsalek [Wed, 16 Apr 2014 09:29:09 +0000 (11:29 +0200)]
BUG-758 Eliminate xtend from sal-netconf-connector

Change-Id: I6add3e5ef2790aab5f0cda886f40bc400ff81f8d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "BUG-732 Fix netconf-connector unable to detect monitoring capability"
Ed Warnicke [Tue, 22 Apr 2014 12:26:11 +0000 (12:26 +0000)]
Merge "BUG-732 Fix netconf-connector unable to detect monitoring capability"

6 years agoMerge "Update to new version of the artifacts proposed by jenkins-controller-version...
Giovanni Meo [Tue, 22 Apr 2014 08:19:07 +0000 (08:19 +0000)]
Merge "Update to new version of the artifacts proposed by jenkins-controller-version-changes-30"

6 years agoMerge "Bug-780: potential lock release being missed if error code path happens in...
Giovanni Meo [Tue, 22 Apr 2014 08:17:51 +0000 (08:17 +0000)]
Merge "Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java"

6 years agoMerge "tomcat Session manager to support clustering using infinispan"
Giovanni Meo [Tue, 22 Apr 2014 08:15:50 +0000 (08:15 +0000)]
Merge "tomcat Session manager to support clustering using infinispan"

6 years agoBug-780: potential lock release being missed if error code path happens in SimpleBroa... 97/6297/1
Flavio Fernandes [Mon, 21 Apr 2014 22:52:56 +0000 (18:52 -0400)]
Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java

Change-Id: Ie8749e5dfcb04042922293ed45e8f06d42de90ab
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
6 years agoMerge "Bug 509: Improve logging in InMemoryDataStore."
Ed Warnicke [Mon, 21 Apr 2014 21:35:07 +0000 (21:35 +0000)]
Merge "Bug 509: Improve logging in InMemoryDataStore."

6 years agotomcat Session manager to support clustering using infinispan 66/6266/3
Harman Singh [Thu, 17 Apr 2014 23:43:22 +0000 (16:43 -0700)]
tomcat Session manager to support clustering using infinispan

Change-Id: I65faff3a62f5c2cf3098e87b52649bf58a6e873a
Signed-off-by: Harman Singh <harmasin@cisco.com>
6 years agoUpdate to new version of the artifacts proposed by jenkins-controller-version-changes-30 93/6293/1
jenkins-controller [Sun, 20 Apr 2014 00:58:14 +0000 (00:58 +0000)]
Update to new version of the artifacts proposed by jenkins-controller-version-changes-30

Change-Id: I78f3db52695a984cfde7aee159f4bf2c40582b9d
Signed-off-by: jenkins-controller <jenkins-controller@opendaylight.org>
6 years agoRemove last instance of controller.version 85/6285/2
Giovanni Meo [Fri, 18 Apr 2014 15:48:21 +0000 (17:48 +0200)]
Remove last instance of controller.version

controller.version was still used in the config.ini so made sure to
fix it

Change-Id: I7739df2c16dae6ce0e2f26aa991ff0984963cc63
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoRemoved duplication of the yang-jmx-generator-plugin 84/6284/2
Giovanni Meo [Fri, 18 Apr 2014 15:25:11 +0000 (17:25 +0200)]
Removed duplication of the yang-jmx-generator-plugin

- Removed unnecessary duplications or a dependency of
yang-maven-plugin which would cause issues in the release process

Change-Id: I858d96d298d2ce6a3a6be87a0261a7f23c2d70e8
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoRemove unnecessary variable in netconf-it 83/6283/2
Giovanni Meo [Fri, 18 Apr 2014 14:09:09 +0000 (16:09 +0200)]
Remove unnecessary variable in netconf-it

- Another roadblock to release of artifact mdsal.version is used as
variable in netconf-it, remove it

Change-Id: I955b7796c46a0852fd74d2ce2d77a033669f5922
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoRemove dependencyManagement from MDSAL 82/6282/3
Giovanni Meo [Fri, 18 Apr 2014 13:56:31 +0000 (15:56 +0200)]
Remove dependencyManagement from MDSAL

- MDSAL dependencyManagement has been removed in favor of commons.opendaylight

Change-Id: Ia744c3a24cebb5bc218991037359e69071575fdc
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "sal-dom-binding-it is not a bundle but is marked so"
Alessandro Boch [Sat, 19 Apr 2014 19:50:05 +0000 (19:50 +0000)]
Merge "sal-dom-binding-it is not a bundle but is marked so"

6 years agosal-dom-binding-it is not a bundle but is marked so 86/6286/2
Giovanni Meo [Fri, 18 Apr 2014 16:05:40 +0000 (18:05 +0200)]
sal-dom-binding-it is not a bundle but is marked so

- The wrong type of bundle causes the bundle to fail to compile

Change-Id: I41571c45d25262bc5af0b65f1cab9fa6587ce290
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim"
Alessandro Boch [Sat, 19 Apr 2014 19:08:22 +0000 (19:08 +0000)]
Merge "bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim"

6 years agoMerge "Remove hardcode yang.jmx.plugin"
Alessandro Boch [Sat, 19 Apr 2014 18:33:10 +0000 (18:33 +0000)]
Merge "Remove hardcode yang.jmx.plugin"

6 years agoMerge " Remove version mismatch in config.version"
Alessandro Boch [Fri, 18 Apr 2014 23:07:49 +0000 (23:07 +0000)]
Merge " Remove version mismatch in config.version"

6 years agoMerge "Ignore some auto-generated files"
Alessandro Boch [Fri, 18 Apr 2014 23:07:20 +0000 (23:07 +0000)]
Merge "Ignore some auto-generated files"

6 years agoMerge " Removed controller.version variable"
Madhu Venugopal [Fri, 18 Apr 2014 19:04:20 +0000 (19:04 +0000)]
Merge " Removed controller.version variable"

6 years agoMerge "Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statis...
Giovanni Meo [Fri, 18 Apr 2014 17:42:05 +0000 (17:42 +0000)]
Merge "Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics"

6 years agoRemove hardcode yang.jmx.plugin 81/6281/1
Giovanni Meo [Fri, 18 Apr 2014 13:40:51 +0000 (15:40 +0200)]
Remove hardcode yang.jmx.plugin

- Remove stale hardcode dependency

Change-Id: Ide87fd574cf6987a5d89bf31f9b078cad2033473
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years ago Remove version mismatch in config.version 80/6280/1
Giovanni Meo [Fri, 18 Apr 2014 13:32:50 +0000 (15:32 +0200)]
 Remove version mismatch in config.version

 - End goal was to remove several config.version present in the pom, in
 the making i cleaned some of the repetition in config parent pom and
 aligned with the commons.opendaylight
- Removed some more warning on the pom files

Change-Id: I6717ceb915fe90fa7313472eb03884de9d09235d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoIgnore some auto-generated files 79/6279/1
Giovanni Meo [Fri, 18 Apr 2014 08:55:10 +0000 (10:55 +0200)]
Ignore some auto-generated files

- Some files under yang-test are autogenerated, ignore them

Change-Id: If8eebca103fffef50d11c2871e68530713e43d81
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years ago Removed controller.version variable 78/6278/1
Giovanni Meo [Fri, 18 Apr 2014 11:13:23 +0000 (13:13 +0200)]
 Removed controller.version variable

- controller.version doesn't make much sense given the BOM is composed
of different modules and the version of the pom.xml at root decide the
version of the whole while each component keeps his versioning.

Change-Id: I9cf6a0e8334cf2725f8e487148fe29cacdbec512
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "Bug 773: SimpleForwardingImpl hits NPE when .frm member is null and new host...
Giovanni Meo [Fri, 18 Apr 2014 07:59:05 +0000 (07:59 +0000)]
Merge "Bug 773:  SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered"

6 years agoMerge "BUG-472: fix integration test breakage"
Giovanni Meo [Fri, 18 Apr 2014 07:58:31 +0000 (07:58 +0000)]
Merge "BUG-472: fix integration test breakage"

6 years agoIncorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics 68/6268/1
Pramila Singh [Fri, 18 Apr 2014 03:24:12 +0000 (20:24 -0700)]
Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics

Change-Id: I6d146d946e721540f70065de4ca8d1b8be73d838
Signed-off-by: Pramila Singh <pramisin@cisco.com>
6 years agoBug 773: SimpleForwardingImpl hits NPE when .frm member is null and new host is... 67/6267/1
Flavio Fernandes [Fri, 18 Apr 2014 02:26:03 +0000 (22:26 -0400)]
Bug 773:  SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered

Change-Id: Iba0986cec7f8cc999b2d9852b2bf21b2c5ba3c6f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
6 years agoMerge "BUG-509: use dedicated executor for notifications"
Tony Tkacik [Thu, 17 Apr 2014 17:16:19 +0000 (17:16 +0000)]
Merge "BUG-509: use dedicated executor for notifications"

6 years agoBUG-509: use dedicated executor for notifications 62/6262/2
Robert Varga [Thu, 17 Apr 2014 16:48:22 +0000 (18:48 +0200)]
BUG-509: use dedicated executor for notifications

This dedicates a thread to datastore notifications, such that they are
delivered outside of the invoking threads. Also adds proper headers.

Change-Id: I44aeb9c4fefb8784d22ded9ae591d38993905ffa
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Enhance the LLDPTLV.java to handle the LLDP port ID subtypes 3 (MAC) in additi...
Jason Ye [Thu, 17 Apr 2014 16:21:34 +0000 (16:21 +0000)]
Merge "Enhance the LLDPTLV.java to handle the LLDP port ID subtypes 3 (MAC) in addition to 7 (Local). Many Ethernet switches take MAC addresses as the port IDs."

6 years agofix for BUG-709 - mixed up flow cookie and connection cookie 59/6259/4
Michal Rehak [Thu, 17 Apr 2014 15:08:42 +0000 (17:08 +0200)]
fix for BUG-709 - mixed up flow cookie and connection cookie

- flow cookie [64b] is present at receivedPacket (to distinguish responsible flow)
- connection cookie [32b] is present at receivedPacket and is expected
  to be copied into corresponding transmitPacketInput (to distinguish auxiliary connection)
- fixed sal-compatibility, l2switch/implementation, sal-binding-it

Change-Id: I331aa3a0f582219a1c604e21466c7a893ee4ed67
Signed-off-by: Michal Rehak <mirehak@cisco.com>
6 years agoAdding auto-sorting plugin to all Controller via parent/pom.xml 47/6247/2
jameshall03885 [Wed, 16 Apr 2014 18:18:57 +0000 (14:18 -0400)]
Adding auto-sorting plugin to all Controller via parent/pom.xml

leveraging google's sortpom plugin, all controller poms are sorted
at build time as per the opendaylight/commons/parent/pom.xml configuration.

Sorted lists of properties, dependencies, and plugins will increase pom readability
and help prevent duplicate entry errors.

This first submission is huge as I changed one pom.xml and all are then sorted.
Only if the sortpom plugin is reconfigured will all pom's again be changed.

Note that if any pom.xml is pushed without having been through a build ... folks are
going to see pom.xml files showup as modified unintentionally.

Change-Id: I8553f38b9f0e5f6d27177ad6b9b9c35a4b43d55a
Signed-off-by: jameshall03885 <ghall@brocade.com>
6 years agoBUG-472: fix integration test breakage 56/6256/1
Robert Varga [Thu, 17 Apr 2014 14:27:56 +0000 (16:27 +0200)]
BUG-472: fix integration test breakage

This makes sure IT using TestHelper do not break due to openexi not
being pulled in.

Change-Id: Iccf465f017d8a651e703d516d8142ef3dba4a24d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUnify jacoco versions to 0.6.2.201302030002 24/5824/3
Maros Marsalek [Mon, 31 Mar 2014 16:30:55 +0000 (18:30 +0200)]
Unify jacoco versions to 0.6.2.201302030002

This cleans up previously unused pluginManagement sections and bumps
jacoco version 0.6.2.201302030002 (previously used by config subsys).

Change-Id: I027b219e7fd0225fe2ef12cbdcc1f7d47509e993
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoEnhance the LLDPTLV.java to handle the LLDP port ID 12/3812/2
Paiwei Wang [Wed, 18 Dec 2013 11:00:55 +0000 (03:00 -0800)]
Enhance the LLDPTLV.java to handle the LLDP port ID
subtypes 3 (MAC) in addition to 7 (Local).
Many Ethernet switches take MAC addresses as the
port IDs.

Change-Id: I8a0d0e5cf0e914a9fe77acd3d0d4787a2ac98760
Signed-off-by: Paiwei Wang <pwwang@itri.org.tw>
6 years agoBUG-732 Fix netconf-connector unable to detect monitoring capability 34/6234/2
Maros Marsalek [Wed, 16 Apr 2014 12:36:20 +0000 (14:36 +0200)]
BUG-732 Fix netconf-connector unable to detect monitoring capability

Change-Id: I6d84db9994a85116d6159d960908c0816f31461b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBug:701-Have Typed ErrorNotification for different node errors 49/6249/1
Kamal Rameshan [Thu, 17 Apr 2014 02:59:54 +0000 (19:59 -0700)]
Bug:701-Have Typed ErrorNotification for different node errors

Change-Id: I674203531d0205dd13b47b64616624b5193bcb4d
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
6 years agoBug:645 - MDSAL Notification pool threads not getting spawned besides the core threads 57/5857/3
Kamal Rameshan [Wed, 2 Apr 2014 00:20:22 +0000 (17:20 -0700)]
Bug:645 - MDSAL Notification pool threads not getting spawned besides the core threads

Change-Id: I6851f9b90b500b2b10a135bcda784a11c8f44786
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
6 years agoAllow abilitiy to boot controller with non-default admin credentials 48/6248/2
Prasanth Pallamreddy [Wed, 16 Apr 2014 18:48:08 +0000 (11:48 -0700)]
Allow abilitiy to boot controller with non-default admin credentials

  - Default admin password can be overridden using the reset
    mechanism. NETWORK_ADMIN_PASSWORD_RECOVERY can optionally
    contain the password to be reset to.
  - Provide optional configuration to disallow factory default
    password. (-Dusermanager.disable-default-admin-password=true)
  - Convert ATN & ATZ security sensitive messages to 'trace' level
    instead of 'info' level

Change-Id: I7dcaf15e8d562f61a3a4636a8abc244b0d6365ae
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
6 years agoMerge "BUG-731: remove unneeded null check"
Tony Tkacik [Wed, 16 Apr 2014 17:07:44 +0000 (17:07 +0000)]
Merge "BUG-731: remove unneeded null check"

6 years agoMerge "BUG-731: do not do String.toString()"
Tony Tkacik [Wed, 16 Apr 2014 17:07:18 +0000 (17:07 +0000)]
Merge "BUG-731: do not do String.toString()"

6 years agoMerge "BUG-731: do not catch Throwable"
Tony Tkacik [Wed, 16 Apr 2014 17:07:00 +0000 (17:07 +0000)]
Merge "BUG-731: do not catch Throwable"

6 years agoMerge "Bug 615: Removed xtend from Topology Manager"
Ed Warnicke [Wed, 16 Apr 2014 16:55:24 +0000 (16:55 +0000)]
Merge "Bug 615: Removed xtend from Topology Manager"

6 years agoMerge "Bug 509: Fixed incorrect merging of Data Store Writes / Events"
Ed Warnicke [Wed, 16 Apr 2014 16:44:35 +0000 (16:44 +0000)]
Merge "Bug 509: Fixed incorrect merging of Data Store Writes / Events"

6 years agoChange OpenEXI version to -SNAPSHOT 37/6237/4
Robert Varga [Wed, 16 Apr 2014 15:15:53 +0000 (17:15 +0200)]
Change OpenEXI version to -SNAPSHOT

This fixes the merge job failing because it cannot publish a released
artifact.

Change-Id: I6e2eeb5ef8e9e521df40a77c12ff8ae94436d16d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-472 Initial EXI encoder/decoder implementation in Netconf 78/5678/15
Maros Marsalek [Wed, 19 Mar 2014 14:58:03 +0000 (15:58 +0100)]
BUG-472 Initial EXI encoder/decoder implementation in Netconf

according to http://tools.ietf.org/html/draft-varga-netconf-exi-capability-02

Change-Id: I861c126a8df1b26f477aa354ed1f8dba59d651cd
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBUG-472: Add EXI codecs without wiring them 94/5494/6
Robert Varga [Sat, 8 Feb 2014 03:06:48 +0000 (04:06 +0100)]
BUG-472: Add EXI codecs without wiring them

This patch implements the EXI codecs to be used in the NETCONF pipeline.
No wiring into the protocol stack is done in this patch.

Change-Id: Ic708ef26d92e138f8269a49a2759f01d88085bf1
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-472: Import OpenEXI nagasena-0000.0002.0035.0 93/5493/4
Robert Varga [Sat, 1 Feb 2014 08:26:54 +0000 (09:26 +0100)]
BUG-472: Import OpenEXI nagasena-0000.0002.0035.0

This imports the OpenEXI nagasena library, on top of which the
implementation will be built.

Change-Id: I4ec0fc637f390fe14451c439870ec1846934ebbb
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: remove unneeded null check 29/6229/1
Robert Varga [Wed, 16 Apr 2014 09:20:38 +0000 (11:20 +0200)]
BUG-731: remove unneeded null check

Fixes a sonar warning:
https://sonar.opendaylight.org/issue/show/0b9faac8-cbfc-4aed-8749-80fdd53410d5

Change-Id: Ib44157dde70d9c654f6dcb242e1d44619a685ea6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: do not do String.toString() 28/6228/1
Robert Varga [Wed, 16 Apr 2014 09:17:18 +0000 (11:17 +0200)]
BUG-731: do not do String.toString()

Fixes a sonar warning. Also adds missing copyright headers.

Change-Id: If16eebc39e7f0d7e9787529995b666f04d239cdf
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: do not catch Throwable 27/6227/1
Robert Varga [Wed, 16 Apr 2014 09:07:46 +0000 (11:07 +0200)]
BUG-731: do not catch Throwable

This fixes the bad practice of catching Throwable, and uses logger
instead of e.printStackTrace().

Change-Id: I44541f7c71dda0bcf633d22d9a46b3959ed3001f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Resolve Bug:745 - remove windows line endings from config and netconf."
Tony Tkacik [Wed, 16 Apr 2014 08:28:40 +0000 (08:28 +0000)]
Merge "Resolve Bug:745 - remove windows line endings from config and netconf."

6 years agoBug 509: Improve logging in InMemoryDataStore. 24/6224/1
Tony Tkacik [Wed, 16 Apr 2014 07:14:34 +0000 (09:14 +0200)]
Bug 509: Improve logging in InMemoryDataStore.

Change-Id: Ia83fd9f68fde9cf082f5571f42b265a323638fb2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 509: Fixed incorrect merging of Data Store Writes / Events 17/6217/2
Tony Tkacik [Tue, 15 Apr 2014 15:48:56 +0000 (17:48 +0200)]
Bug 509: Fixed incorrect merging of Data Store Writes / Events

ForwardedBackwardsCompatibleDataBroker:

In old Data API only way to replace element was to use
remove/put combination, which changed with new Async DOM Broker
APIs where put is actually add/replace so previous delete is not
neccessary.

BackwardsCompatibleTransaction keeps track of such remove/put
operations and propagates put-only to new Async Data Transaction.

DOMImmutableDataChangeEvent:

Builder for DOMImmutableDataChange event used ImmutableMap builder
which throws IllegalArgumentException when same key/value combo
is overriden, which made impossible to merge some events. Switched
Builder implementation to use combination of HashMap and
ImmutableMap.copyOf() in order to prevent this
IllegalArgumentException to fail commit process.

Change-Id: I935bd4f5499c26190c52adcaee1df6335640bfaf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "BUG-509: add missing copyright headers"
Ed Warnicke [Tue, 15 Apr 2014 16:19:23 +0000 (16:19 +0000)]
Merge "BUG-509: add missing copyright headers"

6 years agoMerge "Bug 509: Fixed small discrepancies in Binding Data Change Events."
Ed Warnicke [Tue, 15 Apr 2014 16:15:53 +0000 (16:15 +0000)]
Merge "Bug 509: Fixed small discrepancies in Binding Data Change Events."

6 years agoMerge "Bug 509: Added In-memory datastore support for wildcarded change listeners"
Ed Warnicke [Tue, 15 Apr 2014 16:13:12 +0000 (16:13 +0000)]
Merge "Bug 509: Added In-memory datastore support for wildcarded change listeners"

6 years agoBUG-509: add missing copyright headers 96/6196/3
Robert Varga [Tue, 15 Apr 2014 09:13:52 +0000 (11:13 +0200)]
BUG-509: add missing copyright headers

Change-Id: Idb205cb5e14364661de24b0c9a8008a5995ba08b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 509: Fixed small discrepancies in Binding Data Change Events. 60/6160/6
Robert Varga [Mon, 14 Apr 2014 15:46:07 +0000 (17:46 +0200)]
Bug 509: Fixed small discrepancies in Binding Data Change Events.

DataNormalizer which was responsible to render representation
of Instance Identifier in original format was introducing
additional node, when translation happened from normalized
to legacy, which is only triggered by Data Change Events.

Implementation of responsible algorithm was changed to
use schema in order to derive legacy InstanceIdentifier.

Data Change Events

 - Translated Data Change events were deserialized from
   DOM format on each access to fields, which may introduced
   CPU time overhead.

   Immutability of backing Data Change Events allows to
   add lazy caching of translated TOs, since event and data
   contained in Event Object are immutable.

 - getUpdated*Data in original Binding APIs returned
   both created and modified, so backwards-compatible fix
   was introduced.

Change-Id: Idab3dffb8651d50cca79a22ddcd43af29561b80e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agobug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim 02/6202/1
Giovanni Meo [Tue, 15 Apr 2014 12:45:18 +0000 (14:45 +0200)]
bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim

- Cleanup of threads on bundle stop as well adjust of the logging
level during InterruptException

Change-Id: I3ae7aa5f50f76fae72c3119d00459f11ffa5a4ee
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoBug 491 - Use XmlUnit for xml comparing in junit tests. 56/6156/3
Milos Fabian [Mon, 14 Apr 2014 09:22:59 +0000 (11:22 +0200)]
Bug 491 - Use XmlUnit for xml comparing in junit tests.

-comparing XMLs as DOM Documents with XmlUnit
-added XmlUnit util class - contains common assertion tests

Change-Id: I505c7896e7243873b45c93ea3bf59c941a68924e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoResolve Bug:745 - remove windows line endings from config and netconf. 00/6200/1
Tomas Olvecky [Tue, 15 Apr 2014 11:26:05 +0000 (13:26 +0200)]
Resolve Bug:745 - remove windows line endings from config and netconf.

Change-Id: Id60c44a5f3fd4979f4e13cb00e6537998718e94f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Resolve Bug:717 - Remove fragment version requirement from config-persister-*"
Tony Tkacik [Tue, 15 Apr 2014 10:43:10 +0000 (10:43 +0000)]
Merge "Resolve Bug:717 - Remove fragment version requirement from config-persister-*"

6 years agoMerge "Bug 714 - Fixed creating DOM Document's element with namespace"
Tony Tkacik [Tue, 15 Apr 2014 10:40:30 +0000 (10:40 +0000)]
Merge "Bug 714 - Fixed creating DOM Document's element with namespace"

6 years agoMerge "Resolve Bug:445 Remove freemarker from config code generator."
Tony Tkacik [Tue, 15 Apr 2014 10:26:02 +0000 (10:26 +0000)]
Merge "Resolve Bug:445 Remove freemarker from config code generator."

6 years agoMerge "BUG 718: changed codec for URI parsing"
Tony Tkacik [Tue, 15 Apr 2014 10:25:03 +0000 (10:25 +0000)]
Merge "BUG 718: changed codec for URI parsing"

6 years agoMerge "Resolve Bug:713 - Open snapshot only once per session."
Tony Tkacik [Tue, 15 Apr 2014 10:09:26 +0000 (10:09 +0000)]
Merge "Resolve Bug:713 - Open snapshot only once per session."

6 years agoMerge "Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX...
Tony Tkacik [Tue, 15 Apr 2014 08:49:27 +0000 (08:49 +0000)]
Merge "Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean."

6 years agoResolve Bug:713 - Open snapshot only once per session. 57/6157/2
Tomas Olvecky [Mon, 14 Apr 2014 08:22:26 +0000 (10:22 +0200)]
Resolve Bug:713 - Open snapshot only once per session.

Rework NetconfOperationServiceSnapshot lifecycle: Open it when
session negotiator is requested, thus at entry point where both
hello message and session listener is created. Close the snapshot
when NetconfSessionListener receives down/terminated event.

Change-Id: Id491110524ab635e552a49f48e4938dd7113d8bf
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoResolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean. 26/6026/2
Tomas Olvecky [Thu, 10 Apr 2014 12:13:14 +0000 (14:13 +0200)]
Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean.

Fixes race condition that was observed in ITs, where config pusher started pushing
empty configuration and immediately registered itself as notification listener of
a JMX bean that was not yet present. Fix waits both for netconf-impl and
config-netconf-connector services so that both dependencies are activated before
pushing of configuration can occur.

Change-Id: Id328dc3bd7e41bad59bb84b03461d89f5faeeea4
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBug 591: Minimize the use of Xtend in sal-binding-broker-impl 84/5984/5
Raghurama Bhat [Tue, 8 Apr 2014 20:48:25 +0000 (13:48 -0700)]
Bug 591: Minimize the use of Xtend in sal-binding-broker-impl

Change-Id: I3b21ccdf42685c7b10bf66fadf99ae82692149cf
Signed-off-by: Raghurama Bhat <ragbhat@cisco.com>
6 years agoMerge "Cleanup utility classes"
Tony Tkacik [Tue, 15 Apr 2014 07:46:03 +0000 (07:46 +0000)]
Merge "Cleanup utility classes"

6 years agoMerge "BUG-459 Remove deprecated NetconfClient class."
Tony Tkacik [Tue, 15 Apr 2014 07:45:31 +0000 (07:45 +0000)]
Merge "BUG-459 Remove deprecated NetconfClient class."

6 years agoMerge "BUG-372: Rework sal-netconf-connector"
Tony Tkacik [Tue, 15 Apr 2014 07:45:11 +0000 (07:45 +0000)]
Merge "BUG-372: Rework sal-netconf-connector"

6 years agoMerge "Change RpcImplementation contract to asynchronous"
Tony Tkacik [Tue, 15 Apr 2014 07:43:39 +0000 (07:43 +0000)]
Merge "Change RpcImplementation contract to asynchronous"

6 years agoMerge "BUG702: RPC Router fails to acquire IP address of the host"
Tony Tkacik [Tue, 15 Apr 2014 07:28:02 +0000 (07:28 +0000)]
Merge "BUG702: RPC Router fails to acquire IP address of the host"

6 years agoBug 509: Added In-memory datastore support for wildcarded change listeners 43/6143/6
Tony Tkacik [Thu, 10 Apr 2014 13:39:31 +0000 (15:39 +0200)]
Bug 509: Added In-memory datastore support for wildcarded change listeners

Added support for wildcarded data change listeners,
which may register to updates of list entries (and their
subentries) without specifying key for list items.

Support for Wildcarded Data Change Listneners is done by
refactoring DataChangeEventResolver into Map/Reduce processing.

Map phase:
When visiting each modified node (with key) we also
looks for listener listening on same level without key.
This actually may trigger creation (mapping) of multiple events
for same listeners (eg. two flows we're added at the same time).

Reduce phase:
We walked thru all listeners to be notified and if they have
multiple events assigned, we merge them into one even to be
delivered.

Change-Id: Ic05ddae10bd0b316009cc5bafdeca76350f00390
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBUG-509: improve normalization error reporting 66/6166/3
Robert Varga [Mon, 14 Apr 2014 16:13:00 +0000 (18:13 +0200)]
BUG-509: improve normalization error reporting

This patch introduces an explicit checked exception for reporting
normalization errors, declares it at strategic places and makes use of
it for generating better error reports than:

Caused by: java.lang.IllegalArgumentException: Supplied QName (urn:opendaylight:params:xml:ns:yang:pcep:crabbe:initiated:00?revision=2014-01-13)initiation is not valid according to schema container stateful

Change-Id: I2020c9e6ef85035259558a32f141a132b6321e0e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: Fail forwarning write if read fails. 65/6165/2
Robert Varga [Mon, 14 Apr 2014 13:12:45 +0000 (15:12 +0200)]
BUG-509: Fail forwarning write if read fails.

This primarily gets rid of e.printStackTrace(), but as part of that it
defines an important thing: if a read fails while we're building up the
path, we should not try to continue with the operation.

Change-Id: I48cb6cd304a98684a6984d26b6fc8dd5d14963c5
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-459 Remove deprecated NetconfClient class. 14/5514/8
Maros Marsalek [Mon, 3 Mar 2014 12:35:48 +0000 (13:35 +0100)]
BUG-459 Remove deprecated NetconfClient class.

NetconfClient moved to test sources, now will be used only by tests.

Change-Id: Ia98abe3f6fa4f05566b71d57c519c2149726bcb6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBug 651 - Added back IDE profile and changed target for yang sources 14/5914/5
jameshall03885 [Wed, 9 Apr 2014 14:30:03 +0000 (10:30 -0400)]
Bug 651 - Added back IDE profile and changed target for yang sources

- The IDE maven profile was added back based on feedback from Giovanni Meo

- To avoid devs from having to run the IDE profile so eclipse can see the yang
generated source files, the yang source files are now generated under src/main/yang-gen-sals
or src/main/yang-gen-config instead of target/target-ide.

- The maven-clean-plugin was moved to the commons base pom and removed from
all child poms where it was specified. Thus, it will be automatically run for all
projects. The plugin's execution will clean all xtend and yang generated source dirs.

- The build-helper-maven-plugin was also moved to the commons base pom and removed from
all child poms. It will automatically run for all projects and no longer needs to be
specified in child poms. The plugin's execution will created eclipse source folders
for all xtend and yang generated source.

Tom P and Devin A really did all this work, Greg just gets credit unfairly.

Conflicts:
        opendaylight/config/config-module-archetype/src/main/resources/archetype-resources/pom.xml

Change-Id: I8d9e403629cab2e48d03d5c7a417a02f1d878ca7
Signed-off-by: tpantelis <tpanteli@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
Signed-off-by: dbavery <devin.avery@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
6 years agoBug 714 - Fixed creating DOM Document's element with namespace 55/6155/2
Milos Fabian [Mon, 14 Apr 2014 08:05:15 +0000 (10:05 +0200)]
Bug 714 - Fixed creating DOM Document's element with namespace

Change-Id: Ic7449e11a9b2057d350dc889fcb81872d9ce24f8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoCleanup utility classes 89/5489/7
Robert Varga [Thu, 27 Feb 2014 16:26:21 +0000 (17:26 +0100)]
Cleanup utility classes

Do not allow them to be instantiated, add a few comments and eliminate
e.printStackTrace();

Change-Id: I2e84bd81f2b91431791305fb61ca597337e98ae8
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-372: Rework sal-netconf-connector 58/5258/16
Robert Varga [Tue, 11 Feb 2014 07:44:46 +0000 (08:44 +0100)]
BUG-372: Rework sal-netconf-connector

This makes the connector truly asynchronous and able to work with
backing datastore going away. It will retry connecting infintely to the
backed device, too.

Change-Id: I843620bf63eeade231698c22592aaec0521a09ad
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.