controller.git
5 years agoMerge "Add sal-akka-raft test-jar dependency to sal-distributed-store pom"
Moiz Raja [Thu, 12 Mar 2015 01:33:51 +0000 (01:33 +0000)]
Merge "Add sal-akka-raft test-jar dependency to sal-distributed-store pom"

5 years agoAdd sal-akka-raft test-jar dependency to sal-distributed-store pom 55/16355/1
Tom Pantelis [Wed, 11 Mar 2015 21:11:22 +0000 (17:11 -0400)]
Add sal-akka-raft test-jar dependency to sal-distributed-store pom

So we can use the test utilities in sal-akka-raft.

Change-Id: Ibb28522ed49c61c53d3b3296b38c898c7ea5129b
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoMerge "Fixed testool performance bottleneck due to testtool using NetconfMonitoring...
Tony Tkacik [Wed, 11 Mar 2015 19:28:01 +0000 (19:28 +0000)]
Merge "Fixed testool performance bottleneck due to testtool using NetconfMonitoring from ODL. Added a dummy NetconfMonitoring implementation for testtool."

5 years agoMerge "Changed NetconfDeviceDatastoreAdapter and NetconfDeviceTopologyAdapter to...
Tony Tkacik [Wed, 11 Mar 2015 19:27:46 +0000 (19:27 +0000)]
Merge "Changed NetconfDeviceDatastoreAdapter and NetconfDeviceTopologyAdapter to use TransactionChains instead of Transactions to prevent race condition between init and update when a device is created."

5 years agoMerge "Remove duplicate dependency declarations"
Tony Tkacik [Wed, 11 Mar 2015 19:27:13 +0000 (19:27 +0000)]
Merge "Remove duplicate dependency declarations"

5 years agoMerge "Fixed failing tests due to different attribute handling in mdsal netconf north...
Tony Tkacik [Wed, 11 Mar 2015 19:27:07 +0000 (19:27 +0000)]
Merge "Fixed failing tests due to different attribute handling in mdsal netconf northbound."

5 years agoMerge "Make logger final"
Tony Tkacik [Wed, 11 Mar 2015 19:25:45 +0000 (19:25 +0000)]
Merge "Make logger final"

5 years agoMerge changes Ic1abe2f7,I9b4bc3ad,If347c979
Tony Tkacik [Wed, 11 Mar 2015 19:25:10 +0000 (19:25 +0000)]
Merge changes Ic1abe2f7,I9b4bc3ad,If347c979

* changes:
  Remove empty javadocs and make strings constant
  Remove unused logger
  Use an ImmutableMap

5 years agoMake logger final 15/16315/2
Robert Varga [Wed, 11 Mar 2015 10:18:33 +0000 (11:18 +0100)]
Make logger final

The logger should be marked as final and also be called LOG, not
_logger.

Change-Id: I75f675eec1ee54d659d93aef3e39204a1f7cc920
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRemove empty javadocs and make strings constant 14/16314/2
Robert Varga [Wed, 11 Mar 2015 10:17:50 +0000 (11:17 +0100)]
Remove empty javadocs and make strings constant

Cleans up malformed an empty javadocs and also make string constants
really constant.

Change-Id: Ic1abe2f7c2cb6e6327fde7095742fc0a96ca2e02
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRemove unused logger 13/16313/2
Robert Varga [Wed, 11 Mar 2015 10:16:47 +0000 (11:16 +0100)]
Remove unused logger

Removes the logger, which is not used anyway. Fixes an eclipse warning.

Change-Id: I9b4bc3ad88107b2b2ba0cd999b89e3105b2b3b65
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoUse an ImmutableMap 12/16312/2
Robert Varga [Wed, 11 Mar 2015 10:10:03 +0000 (11:10 +0100)]
Use an ImmutableMap

ImmutableMap has better lookup characteristics, so use that instead of
wrapping a regular hashmap.

Change-Id: If347c9790640f9802f438d5fa225978a56186805
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRemove duplicate dependency 16/16316/2
Robert Varga [Wed, 11 Mar 2015 11:00:30 +0000 (12:00 +0100)]
Remove duplicate dependency

Fixes a maven warning about duplicate artifacts.

Change-Id: Iccd64ce946ddfbff5b158780d9b29fca7c142521
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Migrate to using odlparent:features-test"
Tony Tkacik [Wed, 11 Mar 2015 16:18:35 +0000 (16:18 +0000)]
Merge "Migrate to using odlparent:features-test"

5 years agoDisable unstable netconf-notifications tests 27/16327/1
Maros Marsalek [Wed, 11 Mar 2015 14:30:58 +0000 (15:30 +0100)]
Disable unstable netconf-notifications tests

Comment out unreliable lassertions for XML payload comparison.
Proper fix needs to be provided.

Change-Id: I6e32eefb0ccf95e616dd9c236338593f49ff0af3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Use default SchemaCtx for base netconf ops(if not available)"
Tony Tkacik [Wed, 11 Mar 2015 12:28:39 +0000 (12:28 +0000)]
Merge "Use default SchemaCtx for base netconf ops(if not available)"

5 years agoUse default SchemaCtx for base netconf ops(if not available) 10/16310/1
Maros Marsalek [Wed, 11 Mar 2015 10:34:27 +0000 (11:34 +0100)]
Use default SchemaCtx for base netconf ops(if not available)

If remote device does not expose yang model for base netconf operations, use a
default, pre built schema context for these operations e.g. Lock, unlock

Change-Id: I33e89adaa9a151cc236586e75264a907bf45a5df
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-1513: migrate users to ChoiceSchemaNode 08/16308/1
Robert Varga [Wed, 11 Mar 2015 09:59:11 +0000 (10:59 +0100)]
BUG-1513: migrate users to ChoiceSchemaNode

This migrates all users to the new interface name, cleaning them up as
the data.api and model.api name clash is resolved.

Change-Id: Ibdc317d5ff86c6a895cccdacf6dfea1fb005d9b6
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRemove duplicate dependency declarations 43/16243/2
Robert Varga [Tue, 10 Mar 2015 08:52:48 +0000 (09:52 +0100)]
Remove duplicate dependency declarations

These are declared twice, producing a maven warning. Remove duplicities.

Change-Id: Ica73b9220c5815e45591cd1d4a7600b432adee5d
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMigrate to using odlparent:features-test 29/16229/2
Robert Varga [Tue, 10 Mar 2015 07:47:40 +0000 (08:47 +0100)]
Migrate to using odlparent:features-test

yangtools features-test is going away, migrate away from it.

Change-Id: Idcf27275fd57868ee1e56656854365ac2dcab907
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Bug 2412: Expose Mountpoints on proper path"
Tony Tkacik [Wed, 11 Mar 2015 06:13:38 +0000 (06:13 +0000)]
Merge "Bug 2412: Expose Mountpoints on proper path"

5 years agoMerge "BUG 2805 - Fixed Restconf RPC calls and POST to create data"
Tony Tkacik [Wed, 11 Mar 2015 06:13:12 +0000 (06:13 +0000)]
Merge "BUG 2805 - Fixed Restconf RPC calls and POST to create data"

5 years agoMerge "Bug 2364: Migrated Binding MD-SAL to not use composites nodes"
Tony Tkacik [Wed, 11 Mar 2015 06:12:48 +0000 (06:12 +0000)]
Merge "Bug 2364: Migrated Binding MD-SAL to not use composites nodes"

5 years agoBug 2412: Expose Mountpoints on proper path 79/16279/2
Maros Marsalek [Tue, 10 Mar 2015 16:14:08 +0000 (17:14 +0100)]
Bug 2412: Expose Mountpoints on proper path

Lists such as topology, node were not doubled
in the YANG Instance Identifier used as a key for mountpoints,
which prevented Binding compontents from accessing
them.

This patch fixes also bug in restconf, which was
also producing incorrect instance identifiers.

Change-Id: I3122163d00d4c23fcccc4bbffdf3d0113744c98d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Add netconf-ssh as dependency to features-mdsal"
Ed Warnicke [Tue, 10 Mar 2015 21:40:34 +0000 (21:40 +0000)]
Merge "Add netconf-ssh as dependency to features-mdsal"

5 years agoBUG 2805 - Fixed Restconf RPC calls and POST to create data 36/16136/8
Maros Marsalek [Tue, 10 Mar 2015 10:19:33 +0000 (11:19 +0100)]
BUG 2805 - Fixed Restconf RPC calls and POST to create data

RPCs now works again with JSON and XML
POST works with data store.

AbstractIdentifierAwareJaxRsProvider and its derivates,
provides InstanceIdentifierContext as was parsed from
RESTCONF URI, along with parsed NormalizedNode.

If operation is create, then parsed NormalizedNode
is used along with InstanceIdentifier context to compute
full InstanceIdentifier for data to be created
and works with these data.

This actually simplified flow in codecs.

Change-Id: I5b12965f35d946087cc57f19a28425b27eb27755
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoModify ChainedTransactionProxy to override sending of FindPrimaryShard 59/16159/3
Tom Pantelis [Sun, 8 Mar 2015 02:16:37 +0000 (21:16 -0500)]
Modify ChainedTransactionProxy to override sending of FindPrimaryShard

Previously, ChainedTransactionProxy overrode the sendCreateTransaction
method from TransactionProxy to intercept the sending of the
CreateTransaction message in order to asynchronously wait for the
previous
transaction's ready Futures to complete before sending the message.

To facilitate write-only transaction optimizations which will not create
a separate transaction actor, we need to intercept the FindPrimaryShard
message instead. Thus a new overridden method,
sendFindPrimaryShardAsync, was added the same as sendCreateTransaction
except it sends the FindPrimaryShard message..

Change-Id: I5d0a3de0b9530a538e2425147fad8ace823763f3
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoMerge "Refactor LegacyTransactionConntextImpl"
Moiz Raja [Tue, 10 Mar 2015 18:27:15 +0000 (18:27 +0000)]
Merge "Refactor LegacyTransactionConntextImpl"

5 years agoMerge "Handle FollowerInitialSyncStatus message in Shard/ShardManager"
Tom Pantelis [Tue, 10 Mar 2015 16:58:08 +0000 (16:58 +0000)]
Merge "Handle FollowerInitialSyncStatus message in Shard/ShardManager"

5 years agoBug 2364: Migrated Binding MD-SAL to not use composites nodes 61/16261/4
Tony Tkacik [Sun, 8 Mar 2015 15:30:27 +0000 (16:30 +0100)]
Bug 2364: Migrated Binding MD-SAL to not use composites nodes

Bidning MD-SAL is fully migrated to be adapter on top
of NormalizedNode MD-SAL. This migration once all legacy
classes are removed will provide easier-to-read more
maintanable code of Binding MD-SAL.

Change-Id: I1df6cda4bd6035ac5e01e1285f8aab4201dcc86d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoFixed failing tests due to different attribute handling in mdsal netconf northbound. 72/16272/1
Tomas Cere [Tue, 10 Mar 2015 14:49:38 +0000 (15:49 +0100)]
Fixed failing tests due to different attribute handling in mdsal netconf northbound.

Change-Id: I4f3723b9094f953307982ee25019e3736c9d24de
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoAdd netconf-ssh as dependency to features-mdsal 66/16266/1
Thanh Ha [Tue, 10 Mar 2015 14:49:54 +0000 (10:49 -0400)]
Add netconf-ssh as dependency to features-mdsal

This should fix our issue with autorelease-lithium build failing due to
missing netconf-ssh which happens occassionally.

Change-Id: I655290e1110203195934bfac1adf47d6d08f60db
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix netconf operation serialization in nc 57/16257/3
Maros Marsalek [Tue, 10 Mar 2015 12:29:27 +0000 (13:29 +0100)]
Fix netconf operation serialization in nc

For delete operation, the netconf operation attribute was not added to the
normalizedNode structure.

Change-Id: Idbe65ff3a6eee6fa24d96c68f8ce59da03f4c91d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoAdd SchemaContext to NormalizedNode parser in NETCONF 24/16024/9
Maros Marsalek [Wed, 4 Mar 2015 14:43:23 +0000 (15:43 +0100)]
Add SchemaContext to NormalizedNode parser in NETCONF

Change-Id: Id674dc60eba84cb5cb37b6f170654ae7333f91b6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMigrate users of AnyXml node to DOMSource 37/16137/9
Maros Marsalek [Fri, 6 Mar 2015 13:37:57 +0000 (14:37 +0100)]
Migrate users of AnyXml node to DOMSource

AnyXml node used to wrap Node<?> but now wraps a DOMSource

Change-Id: If4f5845e5a0611d5fe38951dd6afe73d0a6f95bc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoFixed testool performance bottleneck due to testtool using NetconfMonitoring from... 87/16187/4
Tomas Cere [Mon, 9 Mar 2015 09:23:56 +0000 (10:23 +0100)]
Fixed testool performance bottleneck due to testtool using NetconfMonitoring from ODL.
Added a dummy NetconfMonitoring implementation for testtool.

Change-Id: I4d2eaf955ccac78de135749bd8c2bda3e3d6f35b
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoMerge "Bug 2260: Reduce overhead of unused TransactionProxy instances"
Tom Pantelis [Mon, 9 Mar 2015 23:57:47 +0000 (23:57 +0000)]
Merge "Bug 2260: Reduce overhead of unused TransactionProxy instances"

5 years agoMerge "Performance optimizations for simple transactions"
Tom Pantelis [Mon, 9 Mar 2015 23:51:39 +0000 (23:51 +0000)]
Merge "Performance optimizations for simple transactions"

5 years agoBug 2260: Reduce overhead of unused TransactionProxy instances 59/15859/7
Tom Pantelis [Sun, 1 Mar 2015 02:21:10 +0000 (21:21 -0500)]
Bug 2260: Reduce overhead of unused TransactionProxy instances

Moved constructon of the operationLimiter and operationCompleter to the
throtteOperation method lazily. Added a volatile initialized boolean for
the lazy check and to "piggy-back" synchronize the updates to
operationLimiter and operationCompleter as well.

In TransactionProxy#ready, if no operations were performed then the
txFutureCallbackMap will be empty so returned a static
NoOpDOMStoreThreePhaseCommitCohort in that case.

The only remaining overhead in the constructor is the
TransactionIdentifier instance. The Builder seemed extraneous here so I
removed it to reduce the overhead from 2 object allocations to 1.

Change-Id: I083d4176c880055938bbf1f21c00da3859d66af6
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoHandle FollowerInitialSyncStatus message in Shard/ShardManager 95/15995/6
Moiz Raja [Tue, 3 Mar 2015 23:49:48 +0000 (15:49 -0800)]
Handle FollowerInitialSyncStatus message in Shard/ShardManager

Both Shard and ShardManager updated the status in their respective
MBeans so that the status can be queried from there

Change-Id: I9e9fd6c93ad6a1b4d260f6ecd9a7fd1d63f70a12
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 2412: Fixed reading of JSON using new codecs. 09/16209/2
Tony Tkacik [Mon, 9 Mar 2015 16:44:52 +0000 (17:44 +0100)]
Bug 2412: Fixed reading of JSON using new codecs.

Change-Id: I6676fc2f323d0d9152657dcc9b2cdb5f593110e5
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoPerformance optimizations for simple transactions 55/15955/3
Moiz Raja [Tue, 3 Mar 2015 00:32:31 +0000 (16:32 -0800)]
Performance optimizations for simple transactions

- Cache the ActorSelection for the primary shard in ActorContext
- Use isInstance to check for type of message instead of equals in ActorContext
  ShardManager and Shard
- Change the order in which we check for transaction type to create in Shard
- Create ShardTransactionIdentifier using the ShardTransactionIdentifier
  constructor instead of the Builder

These optimizations are aimed at making simple transactions faster in the dsBenchMark. This
set of optimizations reduced the amount of time that test takes from 20s to 18s on my Mac.

Change-Id: I1a4328d90839ef80041ae4f3bb7dccd45ac7fb97
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoChanged NetconfDeviceDatastoreAdapter and NetconfDeviceTopologyAdapter to use Transac... 88/16188/4
Tomas Cere [Mon, 9 Mar 2015 12:26:40 +0000 (13:26 +0100)]
Changed NetconfDeviceDatastoreAdapter and NetconfDeviceTopologyAdapter to use TransactionChains
instead of Transactions to prevent race condition between init and update when a device is created.

Change-Id: I8b7f507dd66d3bf95e15858c456f8905c9bbf4b9
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoQuickfix: Remove deprecated providers from Restconf Application 28/16028/9
Vaclav Demcak [Fri, 6 Mar 2015 13:36:50 +0000 (14:36 +0100)]
Quickfix: Remove deprecated providers from Restconf Application

Jersey 1.17 has problem with multiple Entity providers,
which consumes same content-type and produces different
Entity class. In wiring phase it does not report any problems,
but in runtime it may select incorrect one, which
will result in IllegalArgumentException, which is not
reported.

So in order to unblock most of functionality, legacy
providers are disabled.

This will fix data-store access, but without
subsequent patches RPCs are not usable.

Change-Id: I860e162232d887d13629504421076495a50a075b
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @POST invokeRpc for notification subscription 48/15948/13
Vaclav Demcak [Mon, 9 Mar 2015 13:32:32 +0000 (14:32 +0100)]
BUG 2412 - restconf @POST invokeRpc for notification subscription

* modified notification subscription to work on new api
* added conversion to normalized instance identifier in notification
subscription path
* removed mixin nodes from data change event path
* modified returned paths to skip augmentation identifiers in change
event path
* modified returned location header entry on get stream to use "ws"
protocol

Change-Id: If7f5e92eedbebe0daeb149a38d429a1dcb47c1c9
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @POST invokeRpc with nopayload method 23/15923/7
Vaclav Demcak [Mon, 2 Mar 2015 14:31:15 +0000 (15:31 +0100)]
BUG 2412 - restconf @POST invokeRpc with nopayload method

* migration to new faster Infrastructure API and Codecs for method
@POST invokeRpc(String,String,UriInfo) on @Path {/operations/identifier}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing rpc call method from RestconfService
to use NormalizedNodeContext

* add DOMRpcService -> DOMRpcRouter as rpcRoutingTable holder (it needs to change
in future commit, because we have SchemaContextListener in ControllerContext
and we can have own RpcRoutingTable management there

* fix tests (InvokeRpcMethodTest)
* ignore tests - which are not able to fix now
* remove old codecs from integration test suites to be sure of using corrct codecs

Change-Id: I44119bf0337a1f714991a0e003dabab2da482d23
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @POST invokeRpc with payload method 22/15922/6
Vaclav Demcak [Mon, 2 Mar 2015 14:30:33 +0000 (15:30 +0100)]
BUG 2412 - restconf @POST invokeRpc with payload method

* migration to new faster Infrastructure API and Codecs for method
@POST invokeRpc(String, NormalizedNodeContext,UriInfo)
on @Path {/operations/identifier}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing invokeRpc method from RestconfService
to use NormalizedNodeContext

* add DOMRpcService -> DOMRpcRouter as rpcRoutingTable holder (it
needs to change in future commit, because we have SchemaContextListener
in ControllerContext and we can have own RpcRoutingTable management there
Known issues:
We are ignoring Notification for invokeRpc method for yet.
It has to be fixed asap.

* fix tests (InvokeRpcMethodTest) - prepareDomPayload method create
serious rpc input obj.
* ignore tests - which are not able to fix now

Change-Id: I2e71f4d536a739a8e439ce6320b7e32569d1b0e0
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoMerge changes I4ec69712,I8348002a,I7e6abbf1,Idc2294da
Tony Tkacik [Sun, 8 Mar 2015 22:17:16 +0000 (22:17 +0000)]
Merge changes I4ec69712,I8348002a,I7e6abbf1,Idc2294da

* changes:
  BUG 2412 - restconf @POST createConfigurationData(payload) method migration
  BUG 2412 - restconf @POST createConfigurationData method migration
  BUG 1269 - fill HTTP POST response location attribute
  BUG 2412 - restconf @PUT updateConfigurationData method migration

5 years agoBUG-2314 Migrate netconf-connector to NormalizedNode 83/15783/9
Maros Marsalek [Tue, 24 Feb 2015 12:17:00 +0000 (13:17 +0100)]
BUG-2314 Migrate netconf-connector to NormalizedNode

CompositeNodes are wiped out from sal-netconf-connector.

The inital operations performed on a remote netconf device
(e.g. Schema download) is performed using a special schema
context that contains base netconf, netconf monitoring
and netconf notification schemas.

With this schema context, it is possible to also use
normalized nodes.

YangInstanceIdentifier -> NormalizedNode filter structure
is handled by a class named InstanceIdToFilter that was
extracted from deprecated DataNormalizer.

Change-Id: Ibcc399c3ef9413aa4f96dba5b4bb2611db7123a8
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2578 - Added Binding Adapters for new Notification Broker 17/15417/13
Jan Hajnar [Tue, 17 Feb 2015 15:47:54 +0000 (16:47 +0100)]
Bug 2578 - Added Binding Adapters for new Notification Broker

Implement and integrate Binding to DOM Notification adapters

* implemented forwarded notification broker
* added simple test for forwarded notification broker
* added configuration of new modules and services to md-sal config

Change-Id: I259c971f0dc61bc1b00cbaad2956c3d8b37ff780
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBUG 2412 - restconf @POST createConfigurationData(payload) method migration 55/15355/12
Vaclav Demcak [Mon, 16 Feb 2015 01:08:09 +0000 (02:08 +0100)]
BUG 2412 - restconf @POST createConfigurationData(payload) method migration

* migration to new faster Infrastructure API and Codecs for method
@POST createConfigurationData(NormalizedNodeContext) on @Path {/config}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing createConfigurationData(NormalizedNodeContext) from
RestconfService to use NormalizedNodeContext.

* add fix or comment tests - problem with RestconfDocumentedExceptionMapper
- it has to be fixed in future commit in this chain

Change-Id: I4ec69712535c322ba8bb8ba8be7943589c10d69b
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @POST createConfigurationData method migration 54/15354/13
Vaclav Demcak [Mon, 2 Mar 2015 14:18:03 +0000 (15:18 +0100)]
BUG 2412 - restconf @POST createConfigurationData method migration

* migration to new faster Infrastructure API and Codecs for method
@POST createConfigurationData(String,NormalizedNodeContext,UriInfo)
on @Path {/config/identifier}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing createConfigurationData method from RestconfService
to use NormalizedNodeContext.

* add additional functionality to find a correct child DataSchemaNode
for @POST input payload in XmlNormalizedNodeBodyReader

* add fix or comment tests - problem with RestconfDocumentedExceptionMapper
      - it has to be fixed in future commit in this chain

Change-Id: I8348002aaa817bc4816a0d132f5811fa84eda389
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 1269 - fill HTTP POST response location attribute 74/11274/16
Vaclav Demcak [Mon, 2 Mar 2015 14:16:10 +0000 (15:16 +0100)]
BUG 1269 - fill HTTP POST response location attribute

HTTP POST response atribute LOCATION is now filled with URI to top level
data which were inserted via POST HTTP operation.

!!!!!
RestCodec call was added. Not all codecs have String as output of serialize method
(InstanceIdentifier, Identityref). Currently serialize output is
transformed to string via toString method.
!!!!!

Change-Id: I7e6abbf100b2458907a1afd3b0dd96a6c54d5652
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @PUT updateConfigurationData method migration 53/15353/12
Vaclav Demcak [Wed, 11 Feb 2015 14:41:59 +0000 (15:41 +0100)]
BUG 2412 - restconf @PUT updateConfigurationData method migration

* migration to new faster Infrastructure API and Codecs for method
@PUT updateConfigurationData(String, NormalizedNodeContext)
on @Path {/config/identifier}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing updateConfigurationData method from RestconfService
to use NormalizedNodeContext.

* add fix or comment tests - problem with RestconfDocumentedExceptionMapper
  - it has to be fixed in future commit in this chain

Change-Id: Idc2294daed170c9e7dd5a5a0464a961759b34992
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoMerge "Remove Neutron dependencies"
Tony Tkacik [Sun, 8 Mar 2015 15:37:14 +0000 (15:37 +0000)]
Merge "Remove Neutron dependencies"

5 years agoMerge "BUG 2412 - restconf RestconfDocumentedExceptionMapper class migration"
Tony Tkacik [Sun, 8 Mar 2015 15:14:37 +0000 (15:14 +0000)]
Merge "BUG 2412 - restconf RestconfDocumentedExceptionMapper class migration"

5 years agoMerge changes If17aefba,I36d0f5ec
Tony Tkacik [Sun, 8 Mar 2015 15:13:27 +0000 (15:13 +0000)]
Merge changes If17aefba,I36d0f5ec

* changes:
  BUG 2412 - restconf getOperations method migration
  BUG 2412 - restconf mountpoint getOperations method migration

5 years agoMerge topic 'cleanup/composite-node'
Tony Tkacik [Sun, 8 Mar 2015 15:12:48 +0000 (15:12 +0000)]
Merge topic 'cleanup/composite-node'

* changes:
  BUG 2412 - restconf @GET getAvailableStreams(uri) method migration
  Add SchemaContext to NormalizedNode parser in RESTCONF

5 years agoBUG 2412 - restconf getOperations method migration 19/15819/6
Vaclav Demcak [Wed, 25 Feb 2015 00:47:50 +0000 (01:47 +0100)]
BUG 2412 - restconf getOperations method migration

* migration to new faster Infrastructure API and Codecs for method
@GET getOperations(UriInfo) on @Path {/operations}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing first method getModule(URI) from RestconfService
to use NormalizedNodeContext.
BUT we are not able follow specification for migration in this case
because, we have to change restconf-netconf yang schema before.

Change-Id: If17aefbaa139ee7f1064b25a8592da76d71c4bc4
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoMerge "Fixed build-failure because of undeclared transtive dependency."
Tony Tkacik [Sun, 8 Mar 2015 14:15:02 +0000 (14:15 +0000)]
Merge "Fixed build-failure because of undeclared transtive dependency."

5 years agoBUG 2412 - restconf @GET getAvailableStreams(uri) method migration 74/14974/12
Vaclav Demcak [Wed, 11 Feb 2015 12:04:49 +0000 (13:04 +0100)]
BUG 2412 - restconf @GET getAvailableStreams(uri) method migration

* migration to new faster Infrastructure API and Codecs for method
@GET getAvailableStreams(UriInfo) on @Path {/streams}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing getAvaliableStreams(UriInfo) method from RestconfService
to use NormalizedNodeContext.

* fix test suiteRestGetOperationTest

Change-Id: Ibe07c2afa72177a259ed7bb23a47e95369d0c145
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf mountpoint getOperations method migration 18/15818/5
Vaclav Demcak [Wed, 25 Feb 2015 00:27:20 +0000 (01:27 +0100)]
BUG 2412 - restconf mountpoint getOperations method migration

* migration to new faster Infrastructure API and Codecs for method
@GET getOperations(String,UriInfo) on @Path {/operations/identifier}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing first method getModule(URI) from RestconfService
to use NormalizedNodeContext.
BUT we are not able follow specification for migration in this case
because, we have to change restconf-netconf yang schema before.

Change-Id: I36d0f5ec88af7c4a9d8b7a2d7ed84ccdbabd9c13
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoAdd SchemaContext to NormalizedNode parser in RESTCONF 25/16025/5
Vaclav Demcak [Fri, 6 Mar 2015 13:35:45 +0000 (14:35 +0100)]
Add SchemaContext to NormalizedNode parser in RESTCONF

Correct parsing of identities, instance-identifiers
and others, requires access to full SchemaContext,
not only subset of it.

Migrated to parser factory, which provides that
access in order to correctly deserialize
context-sensitive types.

Change-Id: Ic92b9ce745080076a10d654acaba39e5c59f2b42
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoFixed build-failure because of undeclared transtive dependency. 70/16170/1
Tony Tkacik [Sun, 8 Mar 2015 13:26:20 +0000 (14:26 +0100)]
Fixed build-failure because of undeclared transtive dependency.

Change-Id: I1b11a861180437a2f317ee81d8699deaf3a741ba
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoRefactor LegacyTransactionConntextImpl 32/16032/4
Tom Pantelis [Wed, 4 Mar 2015 07:53:09 +0000 (02:53 -0500)]
Refactor LegacyTransactionConntextImpl

We have a compat package so the LegacyTransactionConntextImpl really
belongs there to keep it separate from the current classes. Also Legacy
really isn't a good name as it's too generic. The
LegacyTransactionConntextImpl is really specific to  pre-Lithium
compatibility so I renamed it to PreLithiumTransactionContextImpl to
make it clear.

I also refactored the helium compatibility tests in TransactionProxyTest
into a new PreLithiumTransactionProxyTest class to keep them separate.
This will make it easier to remove PreLithiumTransactionContextImpl and
its test code when it's no longer needed. Since it needs the same setup
as TransactionProxyTest and some of the utility methods, I moved all the
setup and utility methods to an AbstractTransactionProxyTest to avoid
duplication. This also makes TransactionProxyTest smaller as it now only
contains the test methods.

Change-Id: I9a81c7a1a07fac9098d497ff301c5d1909094c1b
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBUG 2584 : Block Datastore creation till Shards are ready 71/14171/4
Moiz Raja [Thu, 15 Jan 2015 15:27:09 +0000 (07:27 -0800)]
BUG 2584 : Block Datastore creation till Shards are ready

Change-Id: I4bef70ea9e6b0dd2cdb82344749abc5028cf3184
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Unit Test for md-sal netconf northbound mapping. Tests mapping of netconf...
Tony Tkacik [Thu, 5 Mar 2015 10:16:40 +0000 (10:16 +0000)]
Merge "Unit Test for md-sal netconf northbound mapping. Tests mapping of netconf operations and write/read into datastore."

5 years agoMerge "Fixed discard-changes for mdsal netconf, mapping code cleanup."
Tony Tkacik [Thu, 5 Mar 2015 09:15:26 +0000 (09:15 +0000)]
Merge "Fixed discard-changes for mdsal netconf, mapping code cleanup."

5 years agoExpose proper revision of yang-types model in testtool 33/15733/4
Maros Marsalek [Wed, 25 Feb 2015 16:13:00 +0000 (17:13 +0100)]
Expose proper revision of yang-types model in testtool

Also provide the yang model based capabilities in hello message

Change-Id: I56e2dfb48c5e1714bb829f39c1b020159aba95de
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Fix to karaf-parent to copy in dependencies."
Moiz Raja [Wed, 4 Mar 2015 22:11:49 +0000 (22:11 +0000)]
Merge "Fix to karaf-parent to copy in dependencies."

5 years agoMerge "Dynamically update DatastoreContext properties"
Moiz Raja [Wed, 4 Mar 2015 18:47:25 +0000 (18:47 +0000)]
Merge "Dynamically update DatastoreContext properties"

5 years agoFix to karaf-parent to copy in dependencies. 35/16035/1
Ed Warnicke [Wed, 4 Mar 2015 18:34:28 +0000 (10:34 -0800)]
Fix to karaf-parent to copy in dependencies.

Change-Id: I43602045be0f88d7f825f95d9e986adba136563f
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMerge changes Ida315250,I90171a8b
Tony Tkacik [Wed, 4 Mar 2015 09:17:20 +0000 (09:17 +0000)]
Merge changes Ida315250,I90171a8b

* changes:
  BUG-2637: migration final - cleanup
  BUG-2637: migration consequence - fix unit test

5 years agoBUG 2768 : Make election timeout factor 20 by default 13/15813/2
Moiz Raja [Fri, 27 Feb 2015 03:26:20 +0000 (19:26 -0800)]
BUG 2768 : Make election timeout factor 20 by default

We may need a follow up patch to make shards in a single node cluster
Leader by default.

For now this fix will delay Shard startup by 10 seconds in a single node cluster.

Change-Id: I5524c622f6eaeba2739d4cfe574f4ead759b8e10
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Introduce a mechanism for a Follower to signal it's sync up status"
Tom Pantelis [Wed, 4 Mar 2015 01:22:39 +0000 (01:22 +0000)]
Merge "Introduce a mechanism for a Follower to signal it's sync up status"

5 years agoIntroduce a mechanism for a Follower to signal it's sync up status 54/15954/2
Moiz Raja [Tue, 3 Mar 2015 03:49:41 +0000 (19:49 -0800)]
Introduce a mechanism for a Follower to signal it's sync up status

This patch introduces a new message FollowerInitialSyncUpStatus. The
purpose of the message is to inform the RaftActor or a sub-class thereof
whether the Follower's commitIndex is now atleast at the same level
as the Leader was when it first sent a heartbeat to the Follower.

This will hopefully be useful in a rolling upgrade scenario where
we may have just brought up a new node and need to wait for it to be
synced with the current leader before we bring down and upgrade another
node in the cluster.

Change-Id: If19e4d98c2be708fc6a35823ca92cfac7ca87394
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Switch opendaylight-karaf-empty to using karaf-parent"
Moiz Raja [Tue, 3 Mar 2015 22:04:08 +0000 (22:04 +0000)]
Merge "Switch opendaylight-karaf-empty to using karaf-parent"

5 years agoBUG-2637: migration final - cleanup 69/15969/4
Michal Rehak [Fri, 23 Jan 2015 21:12:26 +0000 (22:12 +0100)]
BUG-2637: migration final - cleanup

 - remove migrated features (feature-flow, odl-adsal-compatibility)
 - remove migrated apps (model-flow*, sal-compatibility, sm, im, tp, frm)
 - remove temporary fix in toaster-it

Change-Id: Ida315250f0035e09aa2e2afd0f8df076d9770861
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoBUG-2637: migration consequence - fix unit test 68/15968/3
Michal Rehak [Tue, 3 Mar 2015 13:08:01 +0000 (14:08 +0100)]
BUG-2637: migration consequence - fix unit test

 - fixed unit test in sal-binding-broker
 - temporary fix of toaster-it

Change-Id: I90171a8b1d15cde70946a95c8246f34f0e255f35
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoMerge "Exception when creating new DOMNotificationRouter"
Tony Tkacik [Tue, 3 Mar 2015 09:16:38 +0000 (09:16 +0000)]
Merge "Exception when creating new DOMNotificationRouter"

5 years agoFix Bug #2777 : Unable to deploy controller to a cluster - Adding missing config... 51/15951/1
Vamsi Devaki [Tue, 3 Mar 2015 00:09:09 +0000 (16:09 -0800)]
Fix Bug #2777 : Unable to deploy controller to a cluster - Adding missing config file to features

Change-Id: I400824a4618d00a97e7008f2ff349aa1d57c3a29
Signed-off-by: Vamsi Devaki <vamsi.devaki@hp.com>
5 years agoMerge "Bug 2769: Fix issues with ApplyLogEntries"
Moiz Raja [Mon, 2 Mar 2015 22:16:17 +0000 (22:16 +0000)]
Merge "Bug 2769: Fix issues with ApplyLogEntries"

5 years agoRemove Neutron dependencies 49/15749/4
Lorand Jakab [Wed, 25 Feb 2015 19:27:26 +0000 (21:27 +0200)]
Remove Neutron dependencies

Since Neutron source was removed and it's an independent feature now,
remove Neutron dependencies.

Change-Id: I443347a60f8418b1373ad7cb81f10d2ee063b6b0
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoSwitch opendaylight-karaf-empty to using karaf-parent 33/15933/1
Ed Warnicke [Mon, 2 Mar 2015 18:05:49 +0000 (10:05 -0800)]
Switch opendaylight-karaf-empty to using karaf-parent

This is important to make sure the correct piece are in place to
use opendaylight-karaf-empty as a basis for karaf integration tests.

Change-Id: I404b78bb9a46162b0393d495bc5d46977e2140a9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoUnit Test for md-sal netconf northbound mapping. 90/15890/2
Tomas Cere [Thu, 12 Feb 2015 15:59:49 +0000 (16:59 +0100)]
Unit Test for md-sal netconf northbound mapping.
Tests mapping of netconf operations and write/read into datastore.

Change-Id: I08aa59d8dfddb94eeddf8e37c8c86290f4a44ef1
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoFixed discard-changes for mdsal netconf, mapping code cleanup. 74/15774/3
Tomas Cere [Thu, 26 Feb 2015 12:51:42 +0000 (13:51 +0100)]
Fixed discard-changes for mdsal netconf, mapping code cleanup.

Change-Id: I44a872d8c03b49ed3b6082a97c78c6e94fd77257
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoBug 2763: Fixed JSON serialization of root of mount point 20/15720/3
Tony Tkacik [Wed, 25 Feb 2015 13:13:20 +0000 (14:13 +0100)]
Bug 2763: Fixed JSON serialization of root of mount point

Upgrade of yang-data-codec-gson library to use GSON
for streaming and serialization of JSON broke
one special-case which was reading of mount point
root.

This patch migrates NormalizedNodeJsonCodec to
use proper APIs, which allows more explicit control
of how stream is processed.

Change-Id: I0f57e8ef99114a08b1bceb51c47efbcb0546af73
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBug 2769: Fix issues with ApplyLogEntries 01/15901/4
Tom Pantelis [Sun, 1 Mar 2015 13:16:28 +0000 (08:16 -0500)]
Bug 2769: Fix issues with ApplyLogEntries

ApplyLogEntries defines toIndex as an int which is inconsistent with
everything else that stores journal indexes as long. In addition this
would cause an insiduous bug if an index was greater than max-int.

To maintain backwards compatibility, we can't change the type in
ApplyLogEntries so I created a new class, ApplyJournalEntries, that
defines toIndex as a long and deprecated ApplyLogEntries.

Also, the serialVersionUID for ApplyLogEntries was previously added in
Lithium however this would cause de-serialization failures when
recovering a pre-Lithium journal from persistence. So I removed the
serialVersionUID.

Change-Id: I7c5fe3a2ef8de292224a1a278abe53fc774a79d8
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBUG 2412 - restconf RestconfDocumentedExceptionMapper class migration 16/15816/1
Vaclav Demcak [Fri, 27 Feb 2015 09:31:52 +0000 (10:31 +0100)]
BUG 2412 - restconf RestconfDocumentedExceptionMapper class migration

* RestconfDocumentedException represents all describled error responses
  for Restconf reports. So we have to migrate the ExceptionMapper @Provider
  to new faster Infrastructure API which works with NormozilzedNodeContext.

* ignore "error-info" test + FIXME for 2 ignore test for RPC when expect
  APPLICATION

Change-Id: Ia08772bd68bb406d31034376ecefa09ab291d615
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoException when creating new DOMNotificationRouter 77/15777/2
Jan Hajnar [Thu, 26 Feb 2015 13:49:41 +0000 (14:49 +0100)]
Exception when creating new DOMNotificationRouter

* method after(eventHandler) was called on EventHandler that was not started.
* added missing disruptor.handleEventsWith() call before handler chaining
setup

documentation for 'after()' method:
https://lmax-exchange.github.io/disruptor/docs/index.html
class Disruptor, method after()

Change-Id: Icb5390114000d3f1bf1ea4096263ded633d9f123
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBUG-2739 Fixed leftover data when removing NETCONF device from topology 68/15768/2
Tomas Cere [Thu, 26 Feb 2015 09:07:10 +0000 (10:07 +0100)]
BUG-2739 Fixed leftover data when removing NETCONF device from topology

Change-Id: I73c8a5e27b8bf72f2aecf29699ce54ed872ad348
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoBUG 2762 : Fix issues found in previous patch 12/15812/1
Moiz Raja [Fri, 27 Feb 2015 02:51:00 +0000 (18:51 -0800)]
BUG 2762 : Fix issues found in previous patch

Comments from https://git.opendaylight.org/gerrit/#/c/15798

Change-Id: Iba4ec3950dd1726827d4a69bd4d75469d805898d
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2762 : Compute rate limit based on a more lenient algorithm 98/15798/3
Moiz Raja [Thu, 26 Feb 2015 20:50:02 +0000 (12:50 -0800)]
BUG 2762 : Compute rate limit based on a more lenient algorithm

Calculate the rate limit by looking at each percentile tenth instead of
a single value. This provides a more accurate limit.

Change-Id: Ic71476613ab966c716c203768f3ff395cb251ed0
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoFixed compilation breakage in Netconf CLI 86/15786/1
Tony Tkacik [Thu, 26 Feb 2015 16:44:15 +0000 (17:44 +0100)]
Fixed compilation breakage in Netconf CLI

Change-Id: I59380b25f50304c18e724ca435a290cba1ddc3c0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoMerge "Remove neutron post project split"
Tony Tkacik [Wed, 25 Feb 2015 15:25:44 +0000 (15:25 +0000)]
Merge "Remove neutron post project split"

5 years agoMerge "Startup arch - add odlparent to root pom."
Tony Tkacik [Wed, 25 Feb 2015 09:56:13 +0000 (09:56 +0000)]
Merge "Startup arch - add odlparent to root pom."

5 years agoRemove neutron post project split 64/15264/5
Ryan Moats [Fri, 13 Feb 2015 16:19:49 +0000 (10:19 -0600)]
Remove neutron post project split

Now that neutron code has been split into own repo, clean up here

Change-Id: I6529bedf160c1e1d0ba2c35a37a9b01284fe03a3
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
5 years agoMerge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"
Tony Tkacik [Wed, 25 Feb 2015 09:29:54 +0000 (09:29 +0000)]
Merge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"

5 years agoMerge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"
Tony Tkacik [Wed, 25 Feb 2015 09:29:26 +0000 (09:29 +0000)]
Merge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"

5 years agoMerge "BUG 2412 - restconf @GET getModule(uri) method migration"
Tony Tkacik [Wed, 25 Feb 2015 09:28:42 +0000 (09:28 +0000)]
Merge "BUG 2412 - restconf @GET getModule(uri) method migration"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.