controller.git
6 years agoMerge "Add a container for pass-through netconf access"
Tony Tkacik [Wed, 12 Mar 2014 10:14:45 +0000 (10:14 +0000)]
Merge "Add a container for pass-through netconf access"

6 years agoMerge "Fix clustering versions"
Tony Tkacik [Wed, 12 Mar 2014 10:13:30 +0000 (10:13 +0000)]
Merge "Fix clustering versions"

6 years agoMerge "Fixed whitespace dependent tests in config-persister-directory-adapter"
Tony Tkacik [Wed, 12 Mar 2014 10:11:54 +0000 (10:11 +0000)]
Merge "Fixed whitespace dependent tests in config-persister-directory-adapter"

6 years agoMerge "Use ObjectRegistration instead of Registration"
Tony Tkacik [Wed, 12 Mar 2014 10:01:04 +0000 (10:01 +0000)]
Merge "Use ObjectRegistration instead of Registration"

6 years agoMerge "added generated files to .gitignore"
Tony Tkacik [Wed, 12 Mar 2014 09:56:59 +0000 (09:56 +0000)]
Merge "added generated files to .gitignore"

6 years agoMerge "Fix typos in documentation"
Tony Tkacik [Wed, 12 Mar 2014 09:53:20 +0000 (09:53 +0000)]
Merge "Fix typos in documentation"

6 years agoMerge "Resolve Bug:419. Bump logging bridge reference to 0.4.2-SNAPSHOT."
Tony Tkacik [Wed, 12 Mar 2014 09:51:58 +0000 (09:51 +0000)]
Merge "Resolve Bug:419. Bump logging bridge reference to 0.4.2-SNAPSHOT."

6 years agoFix typos in documentation 07/5607/1
Moiz Raja [Wed, 12 Mar 2014 08:13:38 +0000 (09:13 +0100)]
Fix typos in documentation

Change-Id: I0023e7256f02170c04cc00579ee791f5a3578b1d
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Adding some more traces for better debuggability"
Alessandro Boch [Tue, 11 Mar 2014 22:39:44 +0000 (22:39 +0000)]
Merge "Adding some more traces for better debuggability"

6 years agoAdding some more traces for better debuggability 05/5605/2
Asad Ahmed [Tue, 11 Mar 2014 18:03:15 +0000 (11:03 -0700)]
Adding some more traces for better debuggability

Change-Id: I2d342497a9ac52cd7487363411a0ce191581f2a3
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoMerge "Fixed bug in NetUtils.isMulticastMACAddr() caused by sign extension."
Alessandro Boch [Tue, 11 Mar 2014 19:51:33 +0000 (19:51 +0000)]
Merge "Fixed bug in NetUtils.isMulticastMACAddr() caused by sign extension."

6 years agoFixed bug in NetUtils.isMulticastMACAddr() caused by sign extension. 03/5603/2
Shigeru Yasuda [Tue, 11 Mar 2014 16:41:55 +0000 (01:41 +0900)]
Fixed bug in NetUtils.isMulticastMACAddr() caused by sign extension.

This patch fixes a bug that returned false incorrectly when the MSB was set
in the MAC address.

Change-Id: I8d04534962b0a1a585cf0217969a6415f360140b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
6 years agoMerge "When node disconnects from master controller, no node takes over"
Alessandro Boch [Tue, 11 Mar 2014 19:05:30 +0000 (19:05 +0000)]
Merge "When node disconnects from master controller, no node takes over"

6 years agoMerge "Topology Manager to avoid redundant edge updates"
Alessandro Boch [Tue, 11 Mar 2014 15:47:57 +0000 (15:47 +0000)]
Merge "Topology Manager to avoid redundant edge updates"

6 years agoAdd a container for pass-through netconf access 29/5529/3
Robert Varga [Tue, 4 Mar 2014 22:50:23 +0000 (23:50 +0100)]
Add a container for pass-through netconf access

Change-Id: I4eeba4266250df9a27412db52b0a6f9ab2d5b42d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Cleanup warnings in restconf-broker NotificationService"
Tony Tkacik [Tue, 11 Mar 2014 11:21:44 +0000 (11:21 +0000)]
Merge "Cleanup warnings in restconf-broker NotificationService"

6 years agoMerge "Prune long-deprecated APIs"
Tony Tkacik [Tue, 11 Mar 2014 11:17:54 +0000 (11:17 +0000)]
Merge "Prune long-deprecated APIs"

6 years agoFixed whitespace dependent tests in config-persister-directory-adapter 63/5563/3
Michal Polkorab [Fri, 7 Mar 2014 10:13:00 +0000 (11:13 +0100)]
Fixed whitespace dependent tests in config-persister-directory-adapter

Change-Id: I487011b2628d1b229d72fce19a37425c6a109a64
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
6 years agoWhen node disconnects from master controller, no node takes over 88/5588/2
Yevgeny Khodorkovsky [Tue, 11 Mar 2014 02:15:42 +0000 (19:15 -0700)]
When node disconnects from master controller, no node takes over

- Node connections caches in connection manager were allocated after
  configureInstance call, thus failing CacheUpdateAware registration.

- Fix couple of NPEs in devices.web

Change-Id: I51975a4a984606ecfad8db0941315164eedc83cb
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoTopology Manager to avoid redundant edge updates 75/5575/3
Yevgeny Khodorkovsky [Mon, 10 Mar 2014 06:07:35 +0000 (23:07 -0700)]
Topology Manager to avoid redundant edge updates

- Redundant edge updates (such as in the case of
  cluster switchover) should not be notified to apps/listeners, to avoid
  expensive tasks

Change-Id: I44845d99085771e1dfebd63d12685fd2c2d8260c
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoAdd northbound archetype 85/5585/3
Andrew Kim [Mon, 10 Mar 2014 19:26:52 +0000 (14:26 -0500)]
Add northbound archetype

Change-Id: If7b42ddc1e6053450f8a7b17f3944c7ff026c5c4
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoFix clustering versions 84/5584/1
Robert Varga [Mon, 10 Mar 2014 19:18:45 +0000 (20:18 +0100)]
Fix clustering versions

This fixes the versions referenced in clustered-data-store and warnings
for overridden versions in sal-remoterpc-connector.

Change-Id: I5c955041e89e1c73986dca3fc541f85ccc6befae
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUse ObjectRegistration instead of Registration 74/5574/2
Robert Varga [Sun, 9 Mar 2014 18:48:01 +0000 (19:48 +0100)]
Use ObjectRegistration instead of Registration

Registration is becoming a generic concept, not tied to a particular
object. ObjectRegistration succeeds it for uses where you need to a
getInstance() object to get the associated object back. Migrate to using
that to get rid of deprecation warnings.

Drive-by:
- fix raw type use of ServiceRegistration

Change-Id: Ieaf77ab25e5b284a39fa9a6da7b3b101eb3b9e46
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCleanup warnings in restconf-broker NotificationService 02/5502/4
Robert Varga [Fri, 28 Feb 2014 13:27:51 +0000 (14:27 +0100)]
Cleanup warnings in restconf-broker NotificationService

The registration map is not needed and the executor is not used, so
remove them. Also reuse AbstractListenerRegistration in place of a
custom-coded class.

Change-Id: Ia4060370faa03fb85d9a90471938501a583072d3
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoPrune long-deprecated APIs 01/5501/4
Robert Varga [Fri, 28 Feb 2014 12:42:05 +0000 (13:42 +0100)]
Prune long-deprecated APIs

Prune APIs which have been deprecated well before the Hydrogen release.
No outside users should be relying on them at this point.

Change-Id: I5b966c98733912ece175ce8fa5a4a821c3b2c6d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove unused import and raw type references 71/5571/2
Robert Varga [Sun, 9 Mar 2014 13:44:46 +0000 (14:44 +0100)]
Remove unused import and raw type references

Fixes a couple of warnings just by removing imports and adding <?> to
Iterator.

Change-Id: I71f9a1e0176a1a72fb402e972b1e39ac6c1bba0f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCleanup AbstractDataTransaction state changes 70/5570/1
Robert Varga [Sun, 9 Mar 2014 10:40:11 +0000 (11:40 +0100)]
Cleanup AbstractDataTransaction state changes

Centralize state to be internal and add time tracking, such that it can
be used in logs and statistics.

Change-Id: Ie4197cd2a10bb6b89931f5ecd9b3cc6dcfbe3011
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove SupressWarnings("all") 69/5569/1
Robert Varga [Sun, 9 Mar 2014 10:15:37 +0000 (11:15 +0100)]
Remove SupressWarnings("all")

It turns out to be unnecessary except for a raw type usage -- which is
fixed.

Change-Id: Icdbfbb9b23a4446caeff4cf73a423874b05e0361
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd interface documentation 68/5568/1
Robert Varga [Fri, 28 Feb 2014 12:41:49 +0000 (13:41 +0100)]
Add interface documentation

Change-Id: I3573d1153a62bfe36a01504198a3d1182d1013c1
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoadded generated files to .gitignore 55/5555/1
Michal Rehak [Thu, 6 Mar 2014 15:00:32 +0000 (16:00 +0100)]
added generated files to .gitignore

- files and directories generated by maven-eclipse-plugin

Change-Id: I119b2a98f52f55c28f8b94f2852ab79b318f27b6
Signed-off-by: Michal Rehak <mirehak@cisco.com>
6 years agoResolve Bug:419. Bump logging bridge reference to 0.4.2-SNAPSHOT. 49/5549/1
Tomas Olvecky [Wed, 5 Mar 2014 12:34:52 +0000 (13:34 +0100)]
Resolve Bug:419. Bump logging bridge reference to 0.4.2-SNAPSHOT.

Change-Id: I7c2d14311099c592407412a4473f325b82408bba
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Remove duplicate netconf namespace constant"
Tony Tkacik [Wed, 5 Mar 2014 09:25:41 +0000 (09:25 +0000)]
Merge "Remove duplicate netconf namespace constant"

6 years agoMerge "Get rid of netconf operation filters"
Tony Tkacik [Wed, 5 Mar 2014 09:25:17 +0000 (09:25 +0000)]
Merge "Get rid of netconf operation filters"

6 years agoMerge "Enhanced message handling"
Tony Tkacik [Wed, 5 Mar 2014 09:18:28 +0000 (09:18 +0000)]
Merge "Enhanced message handling"

6 years agoMerge "Overrode equals and hashcode in RouteIdentifierImpl Updated pom to reflect...
Tony Tkacik [Wed, 5 Mar 2014 09:17:30 +0000 (09:17 +0000)]
Merge "Overrode equals and hashcode in RouteIdentifierImpl Updated pom to reflect correct dependency version"

6 years agoMerge "Adding import for google.common.collect in pom"
Tony Tkacik [Wed, 5 Mar 2014 09:16:56 +0000 (09:16 +0000)]
Merge "Adding import for google.common.collect in pom"

6 years agoMerge "Enabling Remote RPC Router module in ODL distribution."
Tony Tkacik [Wed, 5 Mar 2014 09:16:37 +0000 (09:16 +0000)]
Merge "Enabling Remote RPC Router module in ODL distribution."

6 years agonull check for the node connector in the container's edgePropsMap 28/5528/1
Asad Ahmed [Tue, 4 Mar 2014 19:39:13 +0000 (11:39 -0800)]
null check for the node connector in the container's edgePropsMap

Change-Id: I448803eb09a39d8d9ddb598231bad016eaaa1590
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoRemove duplicate netconf namespace constant 23/5523/1
Maros Marsalek [Tue, 4 Mar 2014 14:30:10 +0000 (15:30 +0100)]
Remove duplicate netconf namespace constant

Change-Id: I7af2cb2631136fb4ae947f7150ad2e5d8f2df567
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoGet rid of netconf operation filters 22/5522/1
Maros Marsalek [Tue, 4 Mar 2014 10:20:26 +0000 (11:20 +0100)]
Get rid of netconf operation filters

Merge NetconfOperationFilter interface into NetconfOperation
Execute all operations that can handle a certain request in chained execution (ordered by priority)
Reimplement all current filters as chained operations
Remove NetconfOperationRouter parameter from NetconfOperation
NetconfOperations handling the same request must have different priorities

Change-Id: Iab9c680e6eceab4059feb77616a9d006fb613711
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoEnhanced message handling 38/5338/9
Abhishek Kumar [Fri, 14 Feb 2014 22:39:35 +0000 (14:39 -0800)]
Enhanced message handling

-Added support for ping/pong messages
-Improved logging
-Refactored code, added MessageHandler for better handling of message
-Updated dependency version in pom

Change-Id: I04ff607c287afbe8a2ea156a0f8cd9029c1504ab
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoOverrode equals and hashcode in RouteIdentifierImpl 16/5316/10
Abhishek Kumar [Fri, 14 Feb 2014 00:25:41 +0000 (16:25 -0800)]
Overrode equals and hashcode in RouteIdentifierImpl
Updated pom to reflect correct dependency version

Change-Id: Ie88cecec686a5c542f8d3edcc99e895ecbf39c3b
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoAdding import for google.common.collect in pom 14/5314/5
Abhishek Kumar [Fri, 14 Feb 2014 00:15:50 +0000 (16:15 -0800)]
Adding import for google.common.collect in pom

Change-Id: Iabddd5cb310a6bf0ff40b38c4decc1a5ae915ffb
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoEnabling Remote RPC Router module in ODL distribution. 13/5313/6
Abhishek Kumar [Thu, 13 Feb 2014 23:26:44 +0000 (15:26 -0800)]
Enabling Remote RPC Router module in ODL distribution.

- Added initial Route Change event
- Updated pom
- Fix rebase conflicts
- Added 02-clustering to initial configuration

Change-Id: I64dc6550171755af52a403f576c086ef2257b4a2
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoMerge "The code through out hosttracker assumes the switch manager service reference...
Alessandro Boch [Mon, 3 Mar 2014 22:33:59 +0000 (22:33 +0000)]
Merge "The code through out hosttracker assumes the switch manager service reference is not null. Hence making switch manager as a required dependency to satisfy the above assumption."

6 years agoMerge "Remove static state and default beans from RuntimeMappingModuleFactory,SchemaS...
Tony Tkacik [Mon, 3 Mar 2014 13:06:34 +0000 (13:06 +0000)]
Merge "Remove static state and default beans from RuntimeMappingModuleFactory,SchemaServiceImplSingletonModuleFactory."

6 years agoMerge "Bug 383 - exception raised if key part of URI is incorrect"
Tony Tkacik [Mon, 3 Mar 2014 10:41:25 +0000 (10:41 +0000)]
Merge "Bug 383 - exception raised if key part of URI is incorrect"

6 years agoMerge "Eradicate exificient from the repository"
Tony Tkacik [Mon, 3 Mar 2014 09:39:47 +0000 (09:39 +0000)]
Merge "Eradicate exificient from the repository"

6 years agoMerge "Do not use currently-deprecated APIs"
Tony Tkacik [Mon, 3 Mar 2014 09:30:03 +0000 (09:30 +0000)]
Merge "Do not use currently-deprecated APIs"

6 years agoMerge "Deprecate NetconfMessageHeader test class"
Tony Tkacik [Mon, 3 Mar 2014 09:29:24 +0000 (09:29 +0000)]
Merge "Deprecate NetconfMessageHeader test class"

6 years agoThe code through out hosttracker assumes the switch manager service reference is... 06/5506/1
Asad Ahmed [Sat, 1 Mar 2014 00:34:38 +0000 (16:34 -0800)]
The code through out hosttracker assumes the switch manager service reference is not null.
Hence making switch manager as a required dependency to satisfy the above assumption.

Change-Id: I067e35de9910a6d5ba057f94ec161468d6b37ad9
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoMerge "included the nodetype in the congruence check. also handled the condition...
Alessandro Boch [Fri, 28 Feb 2014 23:11:04 +0000 (23:11 +0000)]
Merge "included the nodetype in the congruence check. also handled the condition where the node id is null."

6 years agoincluded the nodetype in the congruence check. 05/5505/1
Asad Ahmed [Fri, 28 Feb 2014 21:06:25 +0000 (13:06 -0800)]
included the nodetype in the congruence check.
also handled the condition where the node id is null.

Change-Id: I536312801719f7596381db3294c091560d3b5e49
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoMerge "Eliminate superfluous pluginManagement section"
Tony Tkacik [Fri, 28 Feb 2014 14:04:05 +0000 (14:04 +0000)]
Merge "Eliminate superfluous pluginManagement section"

6 years agoMerge "Cleanup dependencyManagement overrides"
Tony Tkacik [Fri, 28 Feb 2014 14:03:52 +0000 (14:03 +0000)]
Merge "Cleanup dependencyManagement overrides"

6 years agoDo not use currently-deprecated APIs 00/5500/1
Robert Varga [Fri, 28 Feb 2014 12:56:28 +0000 (13:56 +0100)]
Do not use currently-deprecated APIs

SchemaServiceListener has been renamed to SchemaContextListener
upstream, with the usual migration strategy. Let's use the latter where
possible.

Change-Id: Ic24596a424322d3bfbc0bca27a94cf281cde85e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDeprecate NetconfMessageHeader test class 99/5499/1
Robert Varga [Fri, 28 Feb 2014 12:45:26 +0000 (13:45 +0100)]
Deprecate NetconfMessageHeader test class

This gets rid of the deprecation warnings, as the entire test will go
when NetconfMessageHeader goes.

Change-Id: Icfc90299d2a9227125671ed1ce0ef56632572f4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove static state and default beans from RuntimeMappingModuleFactory,SchemaServiceI... 96/5496/1
Tomas Olvecky [Fri, 28 Feb 2014 10:27:13 +0000 (11:27 +0100)]
Remove static state and default beans from RuntimeMappingModuleFactory,SchemaServiceImplSingletonModuleFactory.

Remove static reference from factories as this breaks tests: it is useful to tear down config subsystem
between tests, but there is no way to clean up static fields.
Since default beans are discouraged, rework those factories to enforce instance naming so that only a single
instance can be created.
01-md-sal.xml already creates both modules.

Change-Id: I5efbe12b349ae82bfff12ae9a767505a66df2f90
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Add toaster sample consumer/provider modules to initial configuration."
Tony Tkacik [Fri, 28 Feb 2014 09:38:15 +0000 (09:38 +0000)]
Merge "Add toaster sample consumer/provider modules to initial configuration."

6 years agoEradicate exificient from the repository 92/5492/1
Robert Varga [Sat, 1 Feb 2014 08:01:20 +0000 (09:01 +0100)]
Eradicate exificient from the repository

Change-Id: I08e05f72818c22b6a46aee02a00c539006006905
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoPath class exposes internal field 64/5464/4
Alessandro Boch [Thu, 27 Feb 2014 23:55:35 +0000 (15:55 -0800)]
Path class exposes internal field

- Currently a caller of Path.getEdges() can mutate the Path object's edge list

Change-Id: I35659f73b88e1426df05ea3ac4157f9ef56f7f77
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoMerge "method unsetFlowProgrammerNotifier was mis-spelled in activator causing the...
Alessandro Boch [Thu, 27 Feb 2014 23:04:38 +0000 (23:04 +0000)]
Merge "method unsetFlowProgrammerNotifier was mis-spelled in activator causing the corresponding unset method in flow programmer service never to get called"

6 years agoMerge "Use same memory settings for surefire and failsafe plugins"
Alessandro Boch [Thu, 27 Feb 2014 23:01:42 +0000 (23:01 +0000)]
Merge "Use same memory settings for surefire and failsafe plugins"

6 years agomethod unsetFlowProgrammerNotifier was mis-spelled in activator 91/5491/1
Asad Ahmed [Thu, 27 Feb 2014 22:39:57 +0000 (14:39 -0800)]
method unsetFlowProgrammerNotifier was mis-spelled in activator
causing the corresponding unset method in flow programmer service
never to get called

Change-Id: I33ee35b3b75d7c389189cc1609e1991bc80223c0
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoMerge "FlowConfig to only run syntactic validation"
Jason Ye [Thu, 27 Feb 2014 20:25:04 +0000 (20:25 +0000)]
Merge "FlowConfig to only run syntactic validation"

6 years agoMerge "Exception for URI /restconf/operations/module_name:rpc ended with slash"
Tony Tkacik [Thu, 27 Feb 2014 16:06:03 +0000 (16:06 +0000)]
Merge "Exception for URI /restconf/operations/module_name:rpc ended with slash"

6 years agoMerge "We already have a merged and validated flow entry. There is no need for extrac...
Alessandro Boch [Thu, 27 Feb 2014 15:33:01 +0000 (15:33 +0000)]
Merge "We already have a merged and validated flow entry. There is no need for extracting the original flow entry and then validating and merging it again with the containerflow."

6 years agoMerge "Centralize yang-maven-plugin version"
Tony Tkacik [Thu, 27 Feb 2014 14:59:24 +0000 (14:59 +0000)]
Merge "Centralize yang-maven-plugin version"

6 years agoMerge "Deprecate org.opendaylight.controller.sal.common.util.Futures"
Tony Tkacik [Thu, 27 Feb 2014 14:57:41 +0000 (14:57 +0000)]
Merge "Deprecate org.opendaylight.controller.sal.common.util.Futures"

6 years agoUse same memory settings for surefire and failsafe plugins 34/5234/2
Prasanth Pallamreddy [Mon, 10 Feb 2014 19:33:42 +0000 (11:33 -0800)]
Use same memory settings for surefire and failsafe plugins

  - This addresses the OOME issue seen during the tail end
    of the build when running unit tests.

Change-Id: I054e1dfa502bca19a62521a3b714f1a072b59ded
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
6 years agoFixed order of applying changes when forwarding transactions 84/5484/1
Robert Varga [Thu, 27 Feb 2014 11:44:18 +0000 (12:44 +0100)]
Fixed order of applying changes when forwarding transactions

Commit 5659f588f80522a5be5c80d0e5ff34068b5f4786 changed the semantics of
remove/update operations such that the order of application became
significant: remove, then put.

Unfortunately we failed to notice that there are two places which apply
the operations in wrong order, thus breaking clients who perform a
remove/put in a single transaction -- e.g. replacing data without
merging it.

Fix DataStore and Binding->DOM connector.

Change-Id: I4fb12730e8256d3614846adb1fa5a1096284e0eb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoEliminate superfluous pluginManagement section 83/5483/1
Robert Varga [Thu, 27 Feb 2014 12:24:26 +0000 (13:24 +0100)]
Eliminate superfluous pluginManagement section

This structure is a recipe for a warning: jacoco.version is specified in
a parent pom, so there is no use specifying it in the pluginManagement
section here. Rather move it to the parent -- where it belongs.

Change-Id: Iadc84620ad69cccd681b9898ab87459520daafd5
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCleanup dependencyManagement overrides 82/5482/1
Robert Varga [Thu, 27 Feb 2014 12:19:48 +0000 (13:19 +0100)]
Cleanup dependencyManagement overrides

This patch gets rid of a few warnings coming from overriding version
specified in parent dependencyManagement section.

Change-Id: Ida9662498bd152cc91954dc1843045c0553164ba
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCentralize yang-maven-plugin version 81/5481/1
Robert Varga [Thu, 27 Feb 2014 12:05:29 +0000 (13:05 +0100)]
Centralize yang-maven-plugin version

There is no reason for individual projects to define the version over
and over again -- let's keep it in one place.

Change-Id: I4ea6ccbc51e31cf3cef3b7c1304ea7dcc02667f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDeprecate org.opendaylight.controller.sal.common.util.Futures 80/5480/1
Robert Varga [Thu, 27 Feb 2014 11:11:34 +0000 (12:11 +0100)]
Deprecate org.opendaylight.controller.sal.common.util.Futures

We use guava throughout -- and those are better.

Change-Id: I0013f8fc0c10742791159abdf151662eaae5629f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd toaster sample consumer/provider modules to initial configuration. 77/5477/2
Maros Marsalek [Thu, 27 Feb 2014 08:05:16 +0000 (09:05 +0100)]
Add toaster sample consumer/provider modules to initial configuration.

Toaster modules are now part of configuration subsystem, but were not started by default so far.
Toaster consumer/provider are now started by default and behave just like before.

In addition, now you can access toaster modules via netconf endpoint started by the controller (port 8383).
Toasts-made count for toaster-consumer is now reported as operational data and can be accessed using get rpc.

Change-Id: Ia649ed4f0255de22aae35d4362e51ba1bc53936e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoWe already have a merged and validated flow entry. There is no need 76/5476/1
Asad Ahmed [Thu, 27 Feb 2014 00:45:15 +0000 (16:45 -0800)]
We already have a merged and validated flow entry. There is no need
for extracting the original flow entry and then validating and merging it again
with the containerflow.

Change-Id: I131abdefc3bde14b148af0264cd220ea0c61c528
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoAdding routed RPC support in Remote RPC Router 83/4683/8
Abhishek Kumar [Fri, 24 Jan 2014 08:31:49 +0000 (00:31 -0800)]
Adding routed RPC support in Remote RPC Router

 - Updated RoutingTable to add a new routed RPC cache
 - Updated sal-core-api to add Remote RPC Router as default delegate in SchemaAwareRpcBroker
 - Refactored RemoteRpcProvider code.
 - Added unit tests for routing table
 - Removed RouteIdentifier <-> JSON conversion. Its not used anymore
 - Rebased with master

Change-Id: Id13a0a6a9ae6ded7ea9068b7a613a9e196c89a7b
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoBug 383 - exception raised if key part of URI is incorrect 26/5326/3
Jozef Gloncak [Fri, 14 Feb 2014 10:14:12 +0000 (11:14 +0100)]
Bug 383 - exception raised if key part of URI is incorrect

Null pointer exception was caused for case when it wasn't possible to
decode key part of URI (null value was returned)

For case when key leaf type was identityref and wasn't specified as
module_name:identity_name NullPointerException was raised.

Change-Id: I6343d98e6549c02906628c78f61f97c18b244fe4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoMerge "Migrate toaster samples to config-subsystem"
Tony Tkacik [Wed, 26 Feb 2014 13:41:31 +0000 (13:41 +0000)]
Merge "Migrate toaster samples to config-subsystem"

6 years agoMerge "Add reverse() method in Edge and Path classes"
Alessandro Boch [Tue, 25 Feb 2014 23:51:11 +0000 (23:51 +0000)]
Merge "Add reverse() method in Edge and Path classes"

6 years agoFlowConfig to only run syntactic validation 63/5463/1
Alessandro Boch [Tue, 25 Feb 2014 02:03:34 +0000 (18:03 -0800)]
FlowConfig to only run syntactic validation

- The validate function of FlowConfig class should only run syntactic validation
  The opearational validation like input/output/enqueue port presence, flood
  action on non default container check, etc. should be run only at installation
  time. Also this validation should be run for all the flow installation requests
  either they come from static flow config or from Flow Entry install/modify
  request coming from other bundles.
- With the above change at controller restart, static flow configurations which
  were valid at controller stop but no longer after reboot (for ex. switch sdn
  enabled ports have changed) will still show on the Flow GUI as non installed,
  and their toggling with fail with proper message.

Change-Id: I49d97af49d58102e51a3c8c12db915b60bcb6f4b
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoMerge "Refactor configuration for ConfigPersister."
Tony Tkacik [Tue, 25 Feb 2014 18:40:06 +0000 (18:40 +0000)]
Merge "Refactor configuration for ConfigPersister."

6 years agoMerge "Fix for bugs 446 and 456"
Tony Tkacik [Tue, 25 Feb 2014 18:39:17 +0000 (18:39 +0000)]
Merge "Fix for bugs 446 and 456"

6 years agoMigrate toaster samples to config-subsystem 33/5133/8
Maros Marsalek [Wed, 5 Feb 2014 15:18:08 +0000 (16:18 +0100)]
Migrate toaster samples to config-subsystem

 - Fix integration test for toaster samples.
 - The toaster is now disabled by default in distribution
   in order to enable it, you must change configure toaster module
   as in opendaylight/md-sal/samples/toaster-it/src/test/resources/controller.xml

Change-Id: I7c70704c2faea8d39b0f9ad32394e78bca6c80dc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Suppress unchecked cast warnings"
Tony Tkacik [Tue, 25 Feb 2014 18:15:54 +0000 (18:15 +0000)]
Merge "Suppress unchecked cast warnings"

6 years agoMerge "Prune long-deprecated APIs"
Tony Tkacik [Tue, 25 Feb 2014 18:13:31 +0000 (18:13 +0000)]
Merge "Prune long-deprecated APIs"

6 years agoSuppress unchecked cast warnings 34/5434/3
Robert Varga [Tue, 18 Feb 2014 10:45:26 +0000 (11:45 +0100)]
Suppress unchecked cast warnings

These casts are either safe, or we need to throw an exception --
ClassCast is as good an exception as any.

Change-Id: I74026fee5004984bfc18d990a3b6fee68a1fb479
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoPrune long-deprecated APIs 33/5433/4
Robert Varga [Wed, 19 Feb 2014 10:44:06 +0000 (11:44 +0100)]
Prune long-deprecated APIs

These APIs are from prototype days and have never properly worked. Prune
them to reduce the baggage we carry around.

Change-Id: I9ac89552edf76f0740c660c100ec0426627b413a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix logging arguments in two-phase commit 57/5457/2
Robert Varga [Tue, 25 Feb 2014 13:35:32 +0000 (14:35 +0100)]
Fix logging arguments in two-phase commit

Change-Id: I0be572998f4ce5d30dca5178f946fab15ed925ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix comments and remove use of deprecated class 06/5406/3
Robert Varga [Wed, 19 Feb 2014 02:55:48 +0000 (03:55 +0100)]
Fix comments and remove use of deprecated class

This primarily removes SchemaServiceListener, as that is deprecated and
implied by SchemaContextListener, which is replacing it.

Change-Id: I977e818ff466ab27f6cd213d1e0e255e2f1b59a4
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd reverse() method in Edge and Path classes 53/5453/2
Chi-Vien Ly [Mon, 24 Feb 2014 20:23:31 +0000 (12:23 -0800)]
Add reverse() method in Edge and Path classes

Change-Id: I27ada22079999facf6e9f00e05b60aa480e4f2b9
Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
6 years agoMerge "Close Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem."
Tony Tkacik [Tue, 25 Feb 2014 15:38:06 +0000 (15:38 +0000)]
Merge "Close Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem."

6 years agoMerge "Add watchdog thread to detect illegal blocking calls during second phase commit."
Tony Tkacik [Tue, 25 Feb 2014 14:59:52 +0000 (14:59 +0000)]
Merge "Add watchdog thread to detect illegal blocking calls during second phase commit."

6 years agoMerge "Better exception handling when instantiating YangModelBindingProvider, fix...
Tony Tkacik [Tue, 25 Feb 2014 14:58:10 +0000 (14:58 +0000)]
Merge "Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator."

6 years agoClose Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem. 36/5436/4
Tomas Olvecky [Fri, 21 Feb 2014 10:46:42 +0000 (11:46 +0100)]
Close Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem.

Change-Id: I7b633407ce186507379c0008408deae3775fd0df
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoAdd watchdog thread to detect illegal blocking calls during second phase commit. 70/4870/5
Tomas Olvecky [Fri, 14 Feb 2014 15:22:10 +0000 (16:22 +0100)]
Add watchdog thread to detect illegal blocking calls during second phase commit.

Add a thread that starts when second phase commit starts, that will monitor if
a module instance occupies the commit thread for more than 5 seconds. If so, log
a warning every second informing about possible misuse of config subsystem to
block on external resources.
Added a proxy module that caches Module#getInstance() call as this method is
idempotent.

Change-Id: Ia1e56386bdd8c6b7a6dc625cfc69253b927c92a9
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBetter exception handling when instantiating YangModelBindingProvider, fix confignetc... 58/5458/1
Tomas Olvecky [Tue, 25 Feb 2014 13:44:26 +0000 (14:44 +0100)]
Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator.

Do not just log exception if it occurs while calling getModuleInfo, but add it as nested exception.
Fix confignetconfconnector activator: if activator fails to find ConfigRegistry, stop method should interrupt searching for it.

Change-Id: I0b97e5a044be0fd2304b35d34f46a1c540aac248
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "fix bug 431"
Tony Tkacik [Tue, 25 Feb 2014 12:02:03 +0000 (12:02 +0000)]
Merge "fix bug 431"

6 years agoMerge "Integration test added to netconf-it to test identity (de)serialization."
Tony Tkacik [Tue, 25 Feb 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Integration test added to netconf-it to test identity (de)serialization."

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.