Robert Varga [Mon, 9 Jun 2014 15:46:24 +0000 (17:46 +0200)]
Inventory manager: get rid of synchronized blocks
This patch reworks the inventory manager to operate on batches, such
that it does not block notification threads and lowers the pressure on
the datastore.
Change-Id: I1953ce22446853b99a201381ff4d7b64a3cfcee7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jozef Gloncak [Mon, 23 Jun 2014 08:18:59 +0000 (10:18 +0200)]
Bug 1231 - fix of broken tests in sal-rest-connector
Dummy values were added to places where null values as SchemaPath were
presented.
Change-Id: I1a7d109ec4b9dfa24ef77adfc7aa9ccff74482c1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Maros Marsalek [Fri, 20 Jun 2014 11:06:50 +0000 (13:06 +0200)]
BUG-944 Fix nested union types in config subsystem module attributes
Before this patch only unions of non-union types are supported.
Change-Id: If4aa0980246763b211a1c3fca0168ee84a1e75f9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Fri, 20 Jun 2014 12:55:23 +0000 (12:55 +0000)]
Merge "Fix checkstyle errors in sal-compatibility"
Ed Warnicke [Fri, 20 Jun 2014 12:48:14 +0000 (12:48 +0000)]
Merge "Bug 629: Make BindingDataBroker to be visible."
Ed Warnicke [Fri, 20 Jun 2014 12:48:01 +0000 (12:48 +0000)]
Merge "Bug 629: Make SchemaService required for Data Brokers"
Maros Marsalek [Fri, 20 Jun 2014 12:29:26 +0000 (14:29 +0200)]
Fix checkstyle errors in sal-compatibility
Change-Id: I696d3ade9b3b9d5705efa03f2a27dd914ae295ef
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Fri, 20 Jun 2014 12:14:32 +0000 (12:14 +0000)]
Merge "Add copyright messages for java files"
Tony Tkacik [Fri, 20 Jun 2014 12:13:07 +0000 (12:13 +0000)]
Merge "Introducing ShardManager"
Alessandro Boch [Thu, 19 Jun 2014 19:57:10 +0000 (19:57 +0000)]
Merge "Swagger UI for AD-SAL"
Tony Tkacik [Thu, 19 Jun 2014 14:38:21 +0000 (16:38 +0200)]
Bug 629: Make BindingDataBroker to be visible.
Inroduced support for injecting and retrieving
new BindingDataBroker via config-subsystem,
OSGI.
Note: This patch does not provide access to
BindingDataBroker is still not available via
Consumer/Provider context.
Change-Id: Iaa7e65aeeb873c38fded2fecb45e2f0dca1e7714
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Thu, 19 Jun 2014 14:35:47 +0000 (16:35 +0200)]
Bug 629: Make SchemaService required for Data Brokers
Binding Aware versions of Data Brokers did not
required SchemaService when constructed.
Refactored their constructor to make it
obvious that Schema Service is required.
Change-Id: I6c7c69df15aa0130a92015b2c52ba1a9e4cab7b1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Ed Warnicke [Thu, 19 Jun 2014 14:06:25 +0000 (14:06 +0000)]
Merge "BUG-1167: missing Notification of FLOW_REMOVED"
tpantelis [Thu, 29 May 2014 01:36:13 +0000 (21:36 -0400)]
Bug 977: Return RpcError result on neconf failure
NetconfDocumentedException:
- Added methods to convert to and from XML.
NetconfMessageTransformUtil:
- Added code to convert a NetconfDocumentedException to an RpcError.
- Modified checkSuccessReply and checkValidReply to throw
NetconfDocumentedException instead of IllegalStateException.
NetconfDeviceCommunicator:
- Modified processMessage to return an RpcError result for invalid
message and netconf error reply.
- Modified other places that previously returned an exception in the
Future to intsead return an RpcError result.
- Improved synchronization by removing synchronized from method sigs
and locking only the code that needs it.
SendErrorExceptionUtil:
- Modified createDocument to call
NetconfDocumentedException.toXMLDocument
XmlNetconfConstants:
- Moved to netconf-api so NetconfDocumentedException could access it.
The rest of the changed files were to change the import for
XmlNetconfConstants.
Change-Id: Id0ef3ac91bbcb85c9a7a198ceac272fb07f4b9f9
Signed-off-by: tpantelis <tpanteli@brocade.com>
Ed Warnicke [Wed, 18 Jun 2014 20:58:39 +0000 (20:58 +0000)]
Merge "Prepare for security-related catalina/tomcat version updates"
Ryan Moats [Wed, 18 Jun 2014 20:24:39 +0000 (15:24 -0500)]
Prepare for security-related catalina/tomcat version updates
In preparation for updating tomcat/catalina versions to address
security issues, move catalina/tomcat version numbers to
properties in pom.xml
Change-Id: I619cd7b0cc01dd2437d3d0ff1286e14137dbb3ec
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Tony Tkacik [Wed, 18 Jun 2014 16:56:03 +0000 (16:56 +0000)]
Merge "Bug 931, Bug 910 - Enhance Restconf Swagger Documentation"
Ed Warnicke [Wed, 18 Jun 2014 12:59:05 +0000 (12:59 +0000)]
Merge "BUG-1140: inPort disappeared from match"
Tony Tkacik [Wed, 18 Jun 2014 12:34:14 +0000 (12:34 +0000)]
Merge "Bug 225 - added support for depth RESTCONF parameter in URI"
Tony Tkacik [Wed, 18 Jun 2014 12:11:59 +0000 (12:11 +0000)]
Merge "BUG-1105: Implement subtree filtering in netconf"
Pramila Singh [Tue, 17 Jun 2014 04:43:44 +0000 (21:43 -0700)]
Incorrect connect API is called in ConnectionMgr when NodeType is provided
Change-Id: I73d7539cfbd97cfd2f3da570c8e29ff0787d8f18
Signed-off-by: Pramila Singh <pramisin@cisco.com>
mrajvaid [Mon, 16 Jun 2014 19:59:21 +0000 (12:59 -0700)]
Swagger UI for AD-SAL
-Use 'mvn clean install -P docs' to build swagger ui bundle
-UI can be accessed at http://<controller-ip:contoller-web-port>/swagger
Change-Id: I466518f78e23d31c15515f3dcd1f3e46af802f2d
Signed-off-by: mrajvaid <mrajvaid@cisco.com>
Moiz Raja [Mon, 16 Jun 2014 20:14:58 +0000 (13:14 -0700)]
Add copyright messages for java files
Change-Id: I8ac584f45481d9453480d8ccc5316a0f0baca199
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Fri, 13 Jun 2014 23:11:18 +0000 (16:11 -0700)]
Introducing ShardManager
Change-Id: I6bf6955ece55d1a1bdcc150a3fec77f8aff22d6e
Signed-off-by: Moiz Raja <moraja@cisco.com>
Michal Rehak [Tue, 17 Jun 2014 15:45:29 +0000 (17:45 +0200)]
BUG-1140: inPort disappeared from match
- added inPort into ToSalConversionsUtils.toMatch
- added utility method for creating NodeId out of NodeConnectorId and unit test
Change-Id: Ibbfe697aaf756f44553bbbbb9dfd6c9c9660f8b6
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Devin Avery [Mon, 16 Jun 2014 13:38:18 +0000 (09:38 -0400)]
Bug 931, Bug 910 - Enhance Restconf Swagger Documentation
1) We now generate different data models for config and operation data stores
2) We no longer generate URLs for leaf nodes since RESTConf doesn't support those
3) We now expose our mount points in our system in a list, which a user can select and view the list of mounted resources
4) Cleaned up non-ODL branding, adding in ODL branding.
To test
A) Add a device which has mounts in your system (consider ping 2.0 https://wiki.opendaylight.org/view/Ping_2.0_-_Discover_and_Model_Plugin or a netconf device)
B) Navigate to http://localhost:8080/apidoc/explorer)
Patch Set 2: Original Change
Patch Set 3: Rebased, remformmated existing code which used 2 spaces instead of 4
Patch Set 4: Kicking off a second build, since I got mixed build messages.
Change-Id: Ic1f7ad60c6ccd1079d35e66c0dbc4d1a760dd0ec
Signed-off-by: Devin Avery <devin.avery@brocade.com>
Ed Warnicke [Tue, 17 Jun 2014 11:49:19 +0000 (11:49 +0000)]
Merge "Bug 629: Introduction of Configuration Commit Handler"
Ed Warnicke [Tue, 17 Jun 2014 11:22:17 +0000 (11:22 +0000)]
Merge "Added container wrapper against action to support augmentation"
Robert Varga [Tue, 10 Jun 2014 08:53:49 +0000 (10:53 +0200)]
BUG-272: Fixed last checkstyle offenders & activate checkstyle enforcement
This patch adds xtend-gen to excluded directories and finally removes
the enforcer plugin override -- thus making md-sal components subject to
controller-wide checkstyle rules.
Change-Id: I3ccad778f90e450843122bc904a30a0cd4ca79f3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Ed Warnicke [Tue, 17 Jun 2014 01:28:12 +0000 (01:28 +0000)]
Merge "added containermanager shell feature"
Ed Warnicke [Mon, 16 Jun 2014 23:38:39 +0000 (23:38 +0000)]
Merge "Add some unimplemented proxy classes related to DOMStore"
Ed Warnicke [Mon, 16 Jun 2014 23:37:45 +0000 (23:37 +0000)]
Merge "Add more yang/sal dependencies"
Ed Warnicke [Mon, 16 Jun 2014 23:37:08 +0000 (23:37 +0000)]
Merge "Hook the Distributed Data store into the config sub-system"
Ed Warnicke [Mon, 16 Jun 2014 23:36:06 +0000 (23:36 +0000)]
Merge "Add akka dependencies"
Moiz Raja [Fri, 13 Jun 2014 00:51:11 +0000 (17:51 -0700)]
Add some unimplemented proxy classes related to DOMStore
Added basic implementation of DistributedDataStore which does not do much more than fill
in the interface and put tests in place.
All the Proxy classes are still unimplemented.
Change-Id: I9506a05858404a9140f0faf436bd6fb128289693
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Thu, 12 Jun 2014 23:01:56 +0000 (16:01 -0700)]
Add more yang/sal dependencies
Change-Id: I6a5d7087233bfc1c88a4f113cc6d3a476055a60c
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Thu, 12 Jun 2014 22:32:09 +0000 (15:32 -0700)]
Hook the Distributed Data store into the config sub-system
Change-Id: Iceb93fb524a4d036466dd2d5ffa5a740e24bd435
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Thu, 12 Jun 2014 20:07:59 +0000 (13:07 -0700)]
Add akka dependencies
Just add the maven dependencies
Change-Id: I530c6b6fdf9a9832030cfda0f3d0b954eea464a2
Signed-off-by: Moiz Raja <moraja@cisco.com>
Ed Warnicke [Mon, 16 Jun 2014 20:20:29 +0000 (20:20 +0000)]
Merge "Initial commit of the akka based distributed-datastore"
jfokkan [Thu, 8 May 2014 15:32:42 +0000 (11:32 -0400)]
added containermanager shell feature
PatchSet5: Worked containermanager.shell into distro
and pom files so that it both builds and
is pulled into the old distribution/opendaylight.
Also checked to make sure that it worked there.
PatchSet6: Fixed adding of new shell bundle to old
distro
Change-Id: I7f4d86c9902a7f4a8f6bd4bae74ebe4a9634e3bc
Signed-off-by: Jonathan Fok kan <jfokkan@inocybe.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tony Tkacik [Mon, 16 Jun 2014 16:33:40 +0000 (18:33 +0200)]
Bug 629: Introduction of Configuration Commit Handler
One piece of functionality which was not-well defined
in original APIs and was missing in new APIs is
user-submitted commit handlers.
Contract of Commit Handlers was updated to reflect
more existing concept of three-phase commit and
to allow commit handlers only for configuration
subtree.
Access to proposed data is done via read-only
transaction instead of data change event,
since commit handlers may want to cross-reference
data with other and we need to capture this reads
as preconditions for later commit phases.
Change-Id: Id2049c05384dd74792f3cfbbb9f77bf684223be2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
tpantelis [Wed, 4 Jun 2014 22:53:36 +0000 (18:53 -0400)]
Bug 225 - added support for depth RESTCONF parameter in URI
Modified RestconfImpl to prune the resulting ComositeNode tree
based on the depth parameter, if specified.
A depth of 1 retrieves just the target resource and no children. This is
a way to determine if the resource exists. A depth of 2 retrieves the
target resource and just its direct children - any child container would
be empty.
Change-Id: I44d99f9886e3837a1bb13eda84aec3c4cc6b21ae
Signed-off-by: tpantelis <tpanteli@brocade.com>
Ed Warnicke [Fri, 13 Jun 2014 12:20:54 +0000 (12:20 +0000)]
Merge changes Ia119c9ae,Ic2290d7f
* changes:
Bug 1106: Introduced OptimisticLockFailedException
Bug 1073: Added support to DOMBrokerImpl for Transaction Chaining
Prasanna Huddar [Fri, 13 Jun 2014 06:51:20 +0000 (12:21 +0530)]
Added container wrapper against action to support augmentation
Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com>
Change-Id: Icbc27971807343b4b8335867d76e111c142667b1
Robert Varga [Sun, 8 Jun 2014 18:38:17 +0000 (20:38 +0200)]
BUG-272: Fix module whitespace
This patch fixes yang module whitespace to make the structure clear.
Change-Id: I05442cff873b31a2e68f010c630a4b3da2f5c0c3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Moiz Raja [Thu, 12 Jun 2014 18:57:19 +0000 (11:57 -0700)]
Initial commit of the akka based distributed-datastore
Change-Id: Id497e1e2eb94c1c4a4f274eb7eadfe2448ea029d
Signed-off-by: Moiz Raja <moraja@cisco.com>
Michal Rehak [Thu, 12 Jun 2014 15:02:39 +0000 (17:02 +0200)]
BUG-1167: missing Notification of FLOW_REMOVED
- added propagation of switchFlowRemoved notification
Change-Id: I9edf2ebe52fc919c0e986cbe4f58e80a352eda8b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Tony Tkacik [Thu, 5 Jun 2014 17:07:31 +0000 (19:07 +0200)]
Bug 1106: Introduced OptimisticLockFailedException
Introduced two new Exceptions to InMemoryDOMDataStore:
- IncorrectDataStructureException
- ConflictingModificationAppliedException.
Introduced OptimisticLockFailedException to DataBroker
API which is thrown when transaction fails because
of ConflictingModificationAppliedException,
which is raised when other modification already
applied to data tree prevents commit on submitted
modification.
OptimisticLockFailedException is propagated to
the clients also via returned Future and may be
present as causeof ExecutionException when
get() is invoked on Future.
Change-Id: Ia119c9ae4c4ffa9774b45b1d6d54cade7a5b8c32
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 26 May 2014 10:04:45 +0000 (12:04 +0200)]
Bug 1073: Added support to DOMBrokerImpl for Transaction Chaining
Splitted functionality of DOMBrokerImpl to separate classes
which allows easier code reuse with transaction chaining:
New internal APIs:
DOMDataCommitExecutor - Commit executor which invokes
three-phase commit coordination
DOMDataCommitErrorListener - Error listener for commit executor
and one execution
AbstractDOMForwardedTransactionFactory - Factory which creates
composite transactions on top of DOMStore transactions
DOMDataCommitCoordinatorImpl - Commit Executor implementation
DOMBrokerTransactionChainImpl - Implementation of DOMTransactionChain.
Added 2 JUnit tests for Transaction Chains:
- Test positive scenario (chain of write, read, delete transactions)
- Test IllegalStateException when previous transaction
was not commited.
Change-Id: Ic2290d7fb3d4ea52a44bea02b493c1e537e929a6
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Ed Warnicke [Wed, 11 Jun 2014 23:21:51 +0000 (23:21 +0000)]
Merge "Bug-1152:Wrapping PopVlanAction within PopVlanActionCase"
Ed Warnicke [Wed, 11 Jun 2014 19:38:36 +0000 (19:38 +0000)]
Merge "Added move of branding jar to assembly"
Ed Warnicke [Wed, 11 Jun 2014 19:38:21 +0000 (19:38 +0000)]
Merge "Added karaf branding."
Ed Warnicke [Wed, 11 Jun 2014 17:09:28 +0000 (17:09 +0000)]
Merge "Renamed MD-SAL all feature to follow proper odl prefix"
Tomas Olvecky [Wed, 7 May 2014 12:23:08 +0000 (14:23 +0200)]
Bug 951 - Externalize cors definition of restconf
Create new project called filter-valve that allows defining filters
outside of web.xml. An xml file is added to configuration folder
of distribution.
The valve allows any kind of filters to be applied around each
request, mapping contexts and path pattern same way as servlet
specification does. The xml file allows defining filter templates,
each context (WAB) can reuse and modify the common configuration.
Currently only restconf has externalized cors filter definition.
Change-Id: Ia8b6053efdff2b3c1150eec95e63b460d84c457e
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Kamal Rameshan [Wed, 11 Jun 2014 02:05:41 +0000 (19:05 -0700)]
Bug-1152:Wrapping PopVlanAction within PopVlanActionCase
Change-Id: Ibafe249a6fc86c914efb188b7af63d635b971b38
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Mathieu Lemay [Tue, 10 Jun 2014 20:09:43 +0000 (16:09 -0400)]
Renamed MD-SAL all feature to follow proper odl prefix
Change-Id: I727869714d42f9711000c9660cdb3ee2c468b3f0
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
Tony Tkacik [Tue, 10 Jun 2014 19:33:30 +0000 (19:33 +0000)]
Merge changes I52e0dd0d,I6dbf3316,Iafae27bc,Ibbb1250b,Icdb56d14,I7ede1482,Ib335fd1d,I6ce09820,I621fa3a4
* changes:
BUG-272: fix issues in sal-rest-docgen
BUG-272: fix sal-binding-api
BUG-272: fix sal-compatibility
BUG-272: fix sal-dom-spi
BUG-272: fix sal-dom-broker
BUG-272: fix sal-remoterpc-connector
BUG-272: fix remoterpc-routingtable
BUG-272: fix sal-dom-api
BUG-272: fix sal-binding-broker
Tony Tkacik [Tue, 10 Jun 2014 17:32:19 +0000 (17:32 +0000)]
Merge changes I63383291,I1c9f10e9,I9cac529f,I269d373b,I7ede3ba5,I4afc1e15
* changes:
BUG-272: fix sal-common-api
BUG-272: fix sal-netconf-connector
BUG-272: fix toaster-consumer
BUG-272: cleanup sal-rest-connector
BUG-272: use L for long suffix
BUG-272: remove empty statements
Ed Warnicke [Tue, 10 Jun 2014 14:06:58 +0000 (14:06 +0000)]
Merge "Bug 1106: Introduced TransactionCommitFailedException."
Ed Warnicke [Tue, 10 Jun 2014 13:46:52 +0000 (13:46 +0000)]
Merge "Removed `which` dependency, now using proper shell builtin."
Robert Varga [Tue, 10 Jun 2014 12:51:08 +0000 (14:51 +0200)]
BUG-272: fix issues in sal-rest-docgen
This fixes some small issues in sal-rest-docgen.
Change-Id: I52e0dd0d4aaed1363f203e81acf3922b4dd285b5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 12:34:16 +0000 (14:34 +0200)]
BUG-272: fix sal-binding-api
Fixes various small issues in sal-binding-api
Change-Id: I6dbf33169e693cb8f449c42062dfedbf6a3e105e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 12:37:02 +0000 (14:37 +0200)]
BUG-272: fix sal-compatibility
FIxes a single issue in sal-compatibility
Change-Id: Iafae27bca3d1266b0b4f4492b152cd73d0314641
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 12:32:31 +0000 (14:32 +0200)]
BUG-272: fix sal-dom-spi
Fixes minor offences in sal-dop-spi
Change-Id: Ibbb1250bc930c2b5b74b919a184d413279a51f74
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 12:32:02 +0000 (14:32 +0200)]
BUG-272: fix sal-dom-broker
Fixes minor offences in sal-dom-broker
Change-Id: Icdb56d14f57626e59b39296af9e9e8946e8fb4b6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 12:06:08 +0000 (14:06 +0200)]
BUG-272: fix sal-remoterpc-connector
Fixes various offences in sal-remoterpc-connector
Change-Id: I7ede148251ba0e4a84d2bdcaf213c27218d7804b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 11:56:19 +0000 (13:56 +0200)]
BUG-272: fix remoterpc-routingtable
Organizes imports to fix issues reported.
Change-Id: Ib335fd1d3e199f332437423017deaf25acfd81e8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 11:55:28 +0000 (13:55 +0200)]
BUG-272: fix sal-dom-api
Removes imports used only by documentation.
Change-Id: I6ce098201e1a80244c650931192d746eec1cb848
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 11:35:46 +0000 (13:35 +0200)]
BUG-272: fix sal-binding-broker
Fixes various small offenses in sal-binding-broker
Change-Id: I621fa3a430e869ecaade06fb2bf189d692d90e85
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 09:32:23 +0000 (11:32 +0200)]
BUG-272: fix sal-common-api
Removes a single unused import.
Change-Id: I633832911c6a0459c4b4428cd17cca63c8287e56
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 09:29:25 +0000 (11:29 +0200)]
BUG-272: fix sal-netconf-connector
Removes unused imports
Change-Id: I1c9f10e91147e942581f12248c9b9539a15d9253
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 09:26:17 +0000 (11:26 +0200)]
BUG-272: fix toaster-consumer
Removes superfluous imports from the same package.
Change-Id: I9cac529f12587660161b219376d0340ddecd8c88
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 09:15:04 +0000 (11:15 +0200)]
BUG-272: cleanup sal-rest-connector
Preparatory patch, expand wildcard imports to get rid of checkstyle
failures. Save action added final keywords where appropriate.
Change-Id: I269d373bed9fd83d3837f9ed4d3ff7fc105d7305
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 09:10:08 +0000 (11:10 +0200)]
BUG-272: use L for long suffix
This is 'L' is less ambiguous visually than 'l'.
Change-Id: I7ede3ba56e3622cbbc9d513c0a3d7fd07ff1121c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 09:05:54 +0000 (11:05 +0200)]
BUG-272: remove empty statements
Preparatory patch: removes reported empty statements.
Change-Id: I4afc1e15efe6edd5d48ea8f40e189ee1e1774d4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 10 Jun 2014 11:32:21 +0000 (11:32 +0000)]
Merge "BUG-868: do not instantiate SchemaPath directly"
Tony Tkacik [Tue, 10 Jun 2014 11:30:42 +0000 (11:30 +0000)]
Merge "BUG-614: Remove YangtoolsMappingHelper in favor of BindingReflections"
Tony Tkacik [Tue, 10 Jun 2014 11:30:21 +0000 (11:30 +0000)]
Merge "BUG-614: introduce AbstractRuntimeCodeGenerator"
Tony Tkacik [Tue, 10 Jun 2014 11:30:06 +0000 (11:30 +0000)]
Merge "BUG-614: migrate RuntimeGeneratedInvoker"
Tony Tkacik [Tue, 10 Jun 2014 11:29:34 +0000 (11:29 +0000)]
Merge "BUG-614: migrate RpcMetadata"
Tony Tkacik [Tue, 10 Jun 2014 11:29:16 +0000 (11:29 +0000)]
Merge "BUG-868: use a single version of ClassLoaderUtils"
Tony Tkacik [Tue, 10 Jun 2014 11:02:28 +0000 (11:02 +0000)]
Merge "BUG-272: remove tabs from Java files"
Tony Tkacik [Tue, 10 Jun 2014 10:47:22 +0000 (10:47 +0000)]
Merge "BUG-272: remove trailing whitespace from Java files"
Tony Tkacik [Tue, 10 Jun 2014 10:46:50 +0000 (10:46 +0000)]
Merge "BUG-272: remove trailing whitespace from XML files"
Tony Tkacik [Tue, 10 Jun 2014 10:46:37 +0000 (10:46 +0000)]
Merge "BUG-272: remove tabs from XML files"
Robert Varga [Tue, 10 Jun 2014 09:02:29 +0000 (11:02 +0200)]
BUG-272: remove tabs from Java files
Preparatory patch: bulk-convert tabs to 4 spaces.
Change-Id: I4c24c763faf41cb4fcfd0277f8b3c7511269e9b7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 08:58:26 +0000 (10:58 +0200)]
BUG-272: remove trailing whitespace from Java files
Preparatory patch, bulk-removes all trailing whitespace from Java files.
Change-Id: I1fbef5746df7277b3865429d4faa82fc8ba8cbb5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 08:56:20 +0000 (10:56 +0200)]
BUG-272: remove trailing whitespace from XML files
Preparatory patch, bulk-removes trailing whitespace.
Change-Id: I32287893c6ed3079aa7926567f8d0705f8607564
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jun 2014 08:54:33 +0000 (10:54 +0200)]
BUG-272: remove tabs from XML files
Preparatory patch, replaces tabs with 4 spaces.
Change-Id: I84bff9c83d19b9252cf277f23d2931e2ba8dd6de
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 5 Jun 2014 15:15:11 +0000 (17:15 +0200)]
BUG-614: Remove YangtoolsMappingHelper in favor of BindingReflections
As it turns out YangtoolsMappingHelper is an old duplicate of
BindingReflections, with a single isNotification() method. That method
is buggy, as it does not perform all the checks required. Remove it and
use the unified method exposed from BindingReflections.
Change-Id: Ifc2ef9746c2556feac05466439ed910208289413
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 5 Jun 2014 12:15:44 +0000 (14:15 +0200)]
BUG-614: introduce AbstractRuntimeCodeGenerator
Introduce AbstractRuntimeCodeGenerator, which is the base service class
for interactions with the rest of the world. It implements the public
contracts and as much of the logic as possible in pure Java and defines
a clear interface subclasses need to provide. RuntimeCodeGenerator.xtend
then adds an implementation of it.
Change-Id: Ic04f3e840825ae1f59583c0a9a2f6fbfc7bb66f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 5 Jun 2014 11:54:08 +0000 (13:54 +0200)]
BUG-614: migrate RuntimeGeneratedInvoker
RuntimeGeneratedInvoker is another DTO, so let's migrate it to
java-land.
Change-Id: If8e654c38de1be5f8e263f81eb7550d745913906
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 5 Jun 2014 11:27:09 +0000 (13:27 +0200)]
BUG-614: migrate RpcMetadata
RpcMetadata is just another DTO. Just migrate it to Java.
Change-Id: I9bff2616a1cd14fc7a5d73f7be2607d46b67b23e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 5 Jun 2014 11:24:31 +0000 (13:24 +0200)]
BUG-868: use a single version of ClassLoaderUtils
This removes the static import, which hid the fact we are using two
different ClassLoaderUtils (both deprecated).
Change-Id: If37786d591a4c9975d2d10539c70f888dd7d6c5c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 7 Jun 2014 10:31:55 +0000 (12:31 +0200)]
Topology manager: get rid of sychronized sections
Instead of executing changes one by one, we aggregate them such that
ordering is preserved and we have one outstanding transaction at any
given moment. This is done by placing a queue between the notification
and data store, dispatched by a background thread. This should improve
scalability by reducing number of transactions and improving
notification thread concurrency.
Change-Id: Ica70971e4540a060491ac4c0b89a134984947fca
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 5 Jun 2014 15:43:36 +0000 (17:43 +0200)]
Bug 1106: Introduced TransactionCommitFailedException.
Change-Id: Icc4392a74aee24e3d2ae69387caa76bbeccb15ca
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tomas Olvecky [Thu, 5 Jun 2014 15:43:20 +0000 (17:43 +0200)]
BUG-1105: Implement subtree filtering in netconf
Implement subtree filtering according to RFC 6241 section 6.
Current implementation first gathers response XML, then
applies filtering. Since netconf server is pluggable,
modules that might consume significant amount of time
to build their response can read the filter and optimize
their result. Even if modules do not support filtering,
their result is filtered by SubtreeFilter right before
sending out the aggregated response.
Change-Id: Ica04f8f3adfe06599e54a577fceca0508554d667
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Robert Varga [Sat, 7 Jun 2014 07:51:50 +0000 (09:51 +0200)]
Topology manager: Pre-construct identifiers
Another obvious optimization: we pre-construct identifiers for later
use, so we do not end up performing "expensive" operations.
Change-Id: I2f611dca6fb37363799dfbffc72588391008c041
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 6 Jun 2014 17:20:03 +0000 (19:20 +0200)]
Minimize synchronized blocks
This is a simple, obviously-correct improvement of scalability: we
reduce the sice of the synchronized sections such that they only cover
the datastore interaction.
Change-Id: I1c78804e6aed22aac73f67e9c5de43ff465c7836
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 9 Jun 2014 09:43:21 +0000 (09:43 +0000)]
Merge changes I057476f2,I5b8602e7
* changes:
BUG-832 Fix rpcResult to xml translation to use schema for get/get-config.
BUG-1041 Make rpc-request -> xml translation use schema context
Code Review / controller.git / log