controller.git
11 months agoRelease Fluorine release/fluorine-sr2
jenkins-releng [Mon, 4 Feb 2019 02:41:20 +0000 (02:41 +0000)]
Release Fluorine

12 months agoBump to yangtools-2.0.16 31/79731/1
Robert Varga [Sat, 19 Jan 2019 11:44:05 +0000 (12:44 +0100)]
Bump to yangtools-2.0.16

This aligns with odlparent-3.1.6.

Change-Id: Ib0f12e5c795b09f0813c6bbe5961c8fef055489d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
12 months agoBump to odlparent 3.1.6 36/79636/1
Stephen Kitt [Fri, 18 Jan 2019 09:19:20 +0000 (10:19 +0100)]
Bump to odlparent 3.1.6

Change-Id: I7cc4d721a9105cc49f9ab364f0247b07e44f62de
Signed-off-by: Stephen Kitt <skitt@redhat.com>
12 months agoOutput last log term on recovery complete 79/79379/1
Tom Pantelis [Wed, 9 Jan 2019 16:18:37 +0000 (11:18 -0500)]
Output last log term on recovery complete

Change-Id: Idea699d1620cf0f3d1f8173c3b08954d4d41a8d4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
12 months agoImprove follower term conflict resolution 51/79351/1
Robert Varga [Tue, 23 Jan 2018 16:08:03 +0000 (17:08 +0100)]
Improve follower term conflict resolution

Rather than performing a linear search downwards for a matching
log entry, take into account follower's last log index. This
eliminates the need for a lot of round-trips if the follower is
far behind the leader, but does not have a complete common ancestry.

Change-Id: I63c815f108d322de5d438a6eda43aaa7982d820a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2659ea7bb9f51d216c2736a58ad86591380a9527)

12 months agoinfo should be debug in CommitTransactionPayload 86/79286/1
Tom Pantelis [Mon, 7 Jan 2019 17:53:48 +0000 (12:53 -0500)]
info should be debug in CommitTransactionPayload

The log statement was recently added but should be debug.

Change-Id: I04fe1e22f9ca47826a634d9ea8748f271ac57353
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 7da4ebe44e626f23a453cd427b243d6cefaa9011)

12 months agoSend leader's full address via AppendEntries 82/79282/1
Tom Pantelis [Thu, 6 Dec 2018 16:43:26 +0000 (11:43 -0500)]
Send leader's full address via AppendEntries

Added the leader's full actor address to AppendEntries. The
address can be rather long and we don't need to normally send
it so it's an Optional. The follower indicates via AppendEntriesReply
whether it needs the leader to send its address (new
needsLeaderAddress field). On receipt of the leader's address,
the follower sets it in its local RaftActorContext and notifies
the PeerAddressResolver. The ShardPeerAddressResolver impl
updates its local cache thus enabling transactions to resolve
the remote leader actor.

Since we're changing the serialized footprint of AppendEntries
and AppendEntriesReply, I preserved backwards compatibility by
versioning a new externalizable Proxy for each.

JIRA: CONTROLLER-1861
Change-Id: I1c0870a596b1782015eb973153b74dfcd48694e7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
12 months agoSpecify initial serialization buffer capacity for Payloads 45/79145/2
Tom Pantelis [Tue, 4 Dec 2018 18:02:38 +0000 (13:02 -0500)]
Specify initial serialization buffer capacity for Payloads

JFR shows a lot of re-allocations of the backing byte [] when
serializing CommitTransactionPayload. Specify a reasonable
initial buffer capacity (the default in ByteArrayOutputStream
is 32) to reduce re-allocations. This is also configurable via
the cfg file (default is 512).

Also did the same for the other smaller Payload classes like
PurgeTransactionPayload.

JIRA: CONTROLLER-1870
Change-Id: I7ebced56812bfc102409b5b2a8b7f4b1b54359fc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
13 months agoBump yangtools to 2.0.15 47/78647/2
Robert Varga [Tue, 11 Dec 2018 13:37:23 +0000 (14:37 +0100)]
Bump yangtools to 2.0.15

This brings in latest fixes.

Change-Id: Ia901451f2fc7f821b7b491e240b4260fd3005a0d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
13 months agoBump to odlparent 3.1.5 34/78934/2
Stephen Kitt [Fri, 21 Dec 2018 10:47:22 +0000 (11:47 +0100)]
Bump to odlparent 3.1.5

Change-Id: I8d480291ee1131245ddf9a04e32f91914a5f2ae7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
13 months agoAvoid unnecessary unsuccessful AppendEntriesReply 29/78929/2
Tom Pantelis [Fri, 14 Dec 2018 17:36:16 +0000 (12:36 -0500)]
Avoid unnecessary unsuccessful AppendEntriesReply

In some CSIT runs I see messages such as "The prevLogIndex 10 was
found in the log but the term -1 is not equal to the append entries
prevLogTerm 2" which results in the Follower sending an unsuccessful
reply indicating it's out-of-sync. This causes the Leader to try to
catch it up.

However in the test cases, the Follower isn't actually
out-of-sync but rather it gets behind enough (the test issues 1000
txns per second per node) such that the leader re-sends AppendEntries
with log entries it already sent. When the Follower eventually receives
the first AppendEntries, it appends the entries and may do a "fake"
snapshot, ie trim the in-memory journal list and advance the snapshot
index. If so, when the duplicate AppendEntries is received, the leader's
previous log index is no longer in the Follower's journal log.
In Follower.isOutOfSync, isLogEntryPresent returns true b/c the leader's
previous index is included in the last snapshot even though it was trimmed
from the journal log. However, getLogEntryTerm returns -1 b/c it
checks if the index is in the journal log or equal to the snapshot
index, ie it doesn't take into account that the index may be in the
last snapshot. This is inconsistent with the first check and results in
the Follower reporting that it's out-of-sync when it really isnt.

I've also seen a negative result of this on the Leader side when a Follower
reports it's out-of-sync - the Follower's last log index is in the snapshot
but getLogEntryTerm returns -1 causing the Leader to take the last resort,
inefficient path of decrementing the Follower's next index in order to
catch it up.

Therefore I changed these 2 cases to also check if the index is in the snapshot
and, if so, use the snapshot term.

Change-Id: I4331d8fee85789a7004a692abb1b9c629eecd570
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c77c163d54872612b47f0f2550931fa408ed596b)

13 months agoadd real "end-to-end" coverage in TracingBrokerTest 58/78858/2
Michael Vorburger [Fri, 14 Dec 2018 15:22:49 +0000 (16:22 +0100)]
add real "end-to-end" coverage in TracingBrokerTest

This reproduces the NPE from CONTROLLER-1877,
and fails without the fix from the previous commit.

JIRA: CONTROLLER-1877
Change-Id: Ia2fa6093f8a02c37e1ff04250dcd17ab069c1bd5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 26a9c9959de71fc874f84ed9bf5b314ba125657c)

13 months agofix NPE in odl-mdsal-trace 56/78856/1
Michael Vorburger [Fri, 14 Dec 2018 15:37:16 +0000 (16:37 +0100)]
fix NPE in odl-mdsal-trace

It (probably) broke back in
Commit a6286576cf76bce93009c58b88ba1e949ef717af
Change-Id: Id82a79e8e430665f6fb5433ed7bab858044eacbe.

This NPE only occurs if mdsaltrace has non-empty write-watches
(as it does in the initial default mdsaltrace_config.xml).

The following commit adds a non-regression test for this.

Caused by: java.lang.NullPointerException
  at org.opendaylight.mdsal.binding.dom.codec.impl.BindingCodecContext.getCodecContextNode(BindingCodecContext.java:152)
  at org.opendaylight.mdsal.binding.dom.codec.impl.InstanceIdentifierCodec.deserialize(InstanceIdentifierCodec.java:36)
  at org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry.fromYangInstanceIdentifier(BindingNormalizedNodeCodecRegistry.java:101)
  at org.opendaylight.mdsal.binding.dom.adapter.BindingToNormalizedNodeCodec.fromYangInstanceIdentifier(BindingToNormalizedNodeCodec.java:215)
  at Proxyabf4ea17_f2e5_4773_bd89_e4f8393036df.fromYangInstanceIdentifier(Unknown Source)
  at Proxy1038cd39_b88e_4023_8cb1_af39f6d6feb2.fromYangInstanceIdentifier(Unknown Source)
  at org.opendaylight.controller.md.sal.trace.dom.impl.TracingBroker.toPathString(TracingBroker.java:270)
  at org.opendaylight.controller.md.sal.trace.dom.impl.TracingBroker.toPathString(TracingBroker.java:264)
  at org.opendaylight.controller.md.sal.trace.dom.impl.TracingBroker$Watch.eventIsOfInterest(TracingBroker.java:167)
  at org.opendaylight.controller.md.sal.trace.dom.impl.TracingBroker.isWriteWatched(TracingBroker.java:248)
  at org.opendaylight.controller.md.sal.trace.dom.impl.AbstractTracingWriteTransaction.recordOp(AbstractTracingWriteTransaction.java:37)
  at org.opendaylight.controller.md.sal.trace.dom.impl.AbstractTracingWriteTransaction.<init>(AbstractTracingWriteTransaction.java:32)
  at org.opendaylight.controller.md.sal.trace.dom.impl.TracingWriteTransaction.<init>(TracingWriteTransaction.java:24)

JIRA: CONTROLLER-1877
Change-Id: Ia9fbf69bc1c3553e929a045146a3610bce72cd96
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit ce85ee4b6d9334bd0b67b0bac1d0cc3565e4ea10)

13 months agoAlways save to local copy in IdIntsListener 04/78504/1
Tom Pantelis [Sun, 2 Dec 2018 20:49:16 +0000 (15:49 -0500)]
Always save to local copy in IdIntsListener

The Listener Stability CSIT fails intermittently due to the
IdIntsListener reporting that its local view of the data
tree as captured from DTCNs does not match the final read
of the data after the writes are done and the leader change
is complete. On DTCN, the IdIntsListener only stores the new
data if the data before in the DTCN matches its stored copy of
the data from the previous DTCN. When the test fails, this
check fails early on and after that it will never match. A
prior patch added a diff of the data nodes that failed the check
which shows that the id-int entry for "prefix-1" was missing
in the stored copy. This is added at the start of the test
(each node adds its own entry). It's unclear to me if it's
actually valid to ensure that the stored copy matches the
current DTCN's data before so I removed the check - let's see
if there's any further tests failures.

Change-Id: I7b861fc85b42586832072fdc19de103733e4fbf5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 78de7c0dbbb387a46c12f3e28efa15030efa6e62)

13 months agoImprove failure reporting in IdIntsListener 64/78464/1
Tom Pantelis [Fri, 30 Nov 2018 16:43:18 +0000 (11:43 -0500)]
Improve failure reporting in IdIntsListener

The Listener Stability CSIT fails intermittently where the
IdIntsListener reports that the final read of the data doesn't
match it's local copy obtained from DTCN's. It would be helpful
to output the difference.

When the test fails, there are a lot of "Ignoring notification"
warnings from IdIntsListener so output the diff the first time
that occurs.

Change-Id: I49e9cd0414a904a61778a8c028ead7dc2b8fd593
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 95788d18b61dd21bdd8406a9c725ad76b3044535)

13 months agoImprove error reporting in WriteTransactionsHandler 60/78460/1
Tom Pantelis [Fri, 30 Nov 2018 03:32:48 +0000 (22:32 -0500)]
Improve error reporting in WriteTransactionsHandler

The Leader Isolation CSIT is failing intermittently with a failed
tx and it would help to log the exception trace as restconf no longer
reports it. Also modified some fields to be thread-safe as they are
accessed by multiple threads although not concurrently/

Change-Id: Ifce3cd177e5e0cc7c7020866000cb915b9f9c4bf
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 26aee5f28675801253a1244d0c0ad74a7e51b3e4)

13 months agoAdd specific serializer for SimpleReplicatedLogEntry 26/78426/1
Tom Pantelis [Mon, 3 Dec 2018 17:59:43 +0000 (12:59 -0500)]
Add specific serializer for SimpleReplicatedLogEntry

JFR shows a lot of re-allocations of the backing byte [] when
serializing SimpleReplicatedLogEntry. We can pretty closely
estimate the total serialized size with some reasonable padding
since the Payload is already serialized. Introduce a
specific akka serializer for this.

Jira: CONTROLLER-1872
Change-Id: I94ac9528657119b5bab60dc2f37eef98f18ca1b0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 4ecb8ecaf04594b3312a44d801423f515ea445b3)

13 months agoUpdate procedure to restart controller on quarantined condition. 83/77283/3
Ajay Lele [Mon, 15 Oct 2018 18:23:37 +0000 (11:23 -0700)]
Update procedure to restart controller on quarantined condition.

There was a behavior change in Karaf [0] because of which restarting
the container now requires the system property karaf.restart to be
set to true in addition to karaf.restart.jvm property. Update
controller restart logic on quarantined condition for the same.

[0] https://issues.apache.org/jira/browse/KARAF-5179

Change-Id: I7b93eb87f53870efea70f2c9a9b82eeca783aa0b
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
(cherry picked from commit 8db9c583f92f65d03d7688d5b65cecf7a906d918)

13 months agotell-based - reconnect on leader change 11/78211/2
Tom Pantelis [Wed, 21 Nov 2018 20:38:05 +0000 (15:38 -0500)]
tell-based - reconnect on leader change

The ShardManager is the aggregation point for shards so we need
to propagate shard leader change events etc to the ClientActorBehavior
to initiate a refresh of the backend info. The ModuleShardBackendResolver
sends a new message, RegisterForShardAvailabilityChanges, to the
ShardManager actor with a Consumer callback that is notified by the
ShardManager when events affecting shard leader availability occur.
The ModuleShardBackendResolver then propagates the event notification
to callbacks registered via a new notifyWhenBackendInfoIsStale method
exposed via the BackendInfoResolver interface, which the
ClientActorBehavior calls.

JIRA: CONTROLLER-1873
Change-Id: I9dbcabf5a75b195c811a22dd522115d329e5dc4b
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit 1819f12a7e562482d9328a8e4c4aeffd2b1a2c01)

13 months agoUse explicit classes for Listener forwarding 09/78209/2
Robert Varga [Tue, 27 Nov 2018 12:09:30 +0000 (13:09 +0100)]
Use explicit classes for Listener forwarding

This allows us to use ForwardingObject, which will forward
toString() invocations intact, properly identifying registered
listeners.

Change-Id: I486352d41047b20cb5b2735cff911d7d49aaf963
JIRA: CONTROLLER-1874
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
13 months agoUse SharedSingletonMapTemplate 77/78177/2
Robert Varga [Sun, 25 Nov 2018 17:21:00 +0000 (18:21 +0100)]
Use SharedSingletonMapTemplate

We know the key statically, hence we can use more efficient maps
to hold our NodeIdentifierWithPredicates. This saves some CPU cycles
as well as produces less garbage.

JIRA: MDSAL-917
Change-Id: I55b89498ab725f8aba85f8e7f1c8bb16f0fe6565
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
14 months agoImprove NormalizedNodeInputStreamReader 76/78176/2
Robert Varga [Sun, 25 Nov 2018 17:29:17 +0000 (18:29 +0100)]
Improve NormalizedNodeInputStreamReader

We really want to retain source iteration order of predicates
being streamed into the system, as they usually match the order
locally.

Refactor NormalizedNodeInputStreamReader to read complete
NodeIdentifierWithPredicate objects, thus allowing us to use
ImmutableOffsetMapTemplate to skip some data checks and copying
around.

MDSAL: YANGTOOLS-917
Change-Id: I162919c7e56109fc98933a4eeae8669b030dc992
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
14 months agoBump yangtools to 2.0.13 34/78134/2
Robert Varga [Mon, 26 Nov 2018 08:51:46 +0000 (09:51 +0100)]
Bump yangtools to 2.0.13

This bumps yantools to latest 2.0.x release.

Change-Id: If73b8eb99219e3beb6624f22fa1528cf282c6b51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
14 months agoUse pre-sized ImmutableLists for yang-data-api 55/78155/1
Robert Varga [Sun, 25 Nov 2018 17:23:50 +0000 (18:23 +0100)]
Use pre-sized ImmutableLists for yang-data-api

ImmutableList.builder() did not pre-size its arrays correctly,
leading to poor performance. That is no longer the case and we can
correctly pre-allocate it -- giving us the ArrayList equivalent in
immutable form, hence skipping copying in
{SchemaPath,YangInstanceIdentifier}.create()

Change-Id: I4a070dca26138f28de69e4a0e1f9b0298ee2312b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit da9ee8c80328bd6e21064e44f95f29ffc1e99d41)

14 months agoProxy MD-SAL interfaces in DOMMountPointServiceImpl 18/78018/5
Robert Varga [Wed, 7 Nov 2018 12:49:48 +0000 (13:49 +0100)]
Proxy MD-SAL interfaces in DOMMountPointServiceImpl

This patch deals with the case where a mount point is registered
via Controller interfaces and then accessed via MD-SAL interfaces
by providing any missing MD-SAL services via proxies built on top
of their Controller counterparts.

This also adds utility convertors to DOM{DataTree,Rpc}Identifier,
so they are readily available.

JIRA: CONTROLLER-1869
Change-Id: Iece3f1d2a2bba58669114f6f8b8abf89fd188690
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e1ede0942d3bff1f1b150816e6bfa96ed9366c20)

14 months agoProxy controller services in DOMMountPointServiceImpl 17/78017/6
Jakub Morvay [Tue, 6 Nov 2018 18:17:44 +0000 (19:17 +0100)]
Proxy controller services in DOMMountPointServiceImpl

When we are proxying a DOMMountPoint, we also need to take care
of bridging legacy interfaces on top of MD-SAL interfaces.

This patch refactors DOM{Notification,Rpc}Router to factor out
DOM{Notification,Rpc}Service adapters and creates DOMActionService
adapter. These are then used in DOMMountPointAdapter, which in
turn is used by DOMMountPointServiceImpl.

This deals with the case when an MD-SAL-registered mount point
is accessed via Controller APIs.

JIRA: CONTROLLER-1869
Change-Id: Ide4c636afdbd13e233880ab616aec52e46ea115f
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ddbc3eb6ae763f10d466bfdd1c33f0cb30665bc0)

14 months agoHide DOMMountPointServiceImpl.registerMountPoint implementation 79/77579/3
Robert Varga [Wed, 7 Nov 2018 11:39:29 +0000 (12:39 +0100)]
Hide DOMMountPointServiceImpl.registerMountPoint implementation

This adds a trivial package-protected method which holds the
implementation, allowing us to short-circuit some casts.

Change-Id: I41d792c50d87638fc6ba51433cd26bf68980fca2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e5bd339c5b81732da4496010b03533ec247455fa)

14 months agoUse Method.getParameterCount() 78/77878/3
Robert Varga [Fri, 16 Nov 2018 07:33:57 +0000 (08:33 +0100)]
Use Method.getParameterCount()

Java 8 introduced this method, which bypasses array cloning done
by getParameterTypes(), making it more efficient. Take advantage
of it.

Change-Id: I130a58c8ca667e57ae29c99abdd8066d8ca7dbd7
JIRA: MDSAL-398
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
14 months agoFix DOMDataReadTransaction javadoc 71/77771/2
Robert Varga [Wed, 14 Nov 2018 09:12:30 +0000 (10:12 +0100)]
Fix DOMDataReadTransaction javadoc

Remove double start of the javadoc.

Change-Id: I6524d117e3eecaeda77c0e7b40a50053dc944b96
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 21869c9921ae9bc4f32cc1314a105a6f528ec691)

14 months agoIntroduce ReadTransaction.exists() 22/77822/2
Robert Varga [Wed, 14 Nov 2018 09:11:44 +0000 (10:11 +0100)]
Introduce ReadTransaction.exists()

This method exists in the DOM API, but for some reason it was left
out if the Binding API. Introduce it as default methods riding on
the read() method and override them in all known implementations,
so the request is efficiently routed.

JIRA: MDSAL-389
Change-Id: Id56332d6f720396305ac68e40554e62fd17c34fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a6bdbfafe60b9aeac056187f27229e476fbf88bf)

14 months agoBump operation timeout to 500ms 07/77607/2
Robert Varga [Thu, 8 Nov 2018 01:42:03 +0000 (02:42 +0100)]
Bump operation timeout to 500ms

It seems we cannot meet our own deadlines in our unit tests, let's
bump them to 500ms instead of 100ms.

Change-Id: Ic0f9f09da3108e150bd3ec2b465d66bb3aa80485
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1b51c280231f3829f445491c857c1a1648f917ce)

14 months agoBump versions by x.y.(z+1) 96/77996/1
jenkins-releng [Tue, 20 Nov 2018 23:48:13 +0000 (23:48 +0000)]
Bump versions by x.y.(z+1)

Change-Id: Ie56b4681b9f699d71bd1dba3500e749b2428928c
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
15 months agoForce UntrustedXML to be initialized from activator 66/77266/2
Robert Varga [Wed, 24 Oct 2018 21:01:25 +0000 (23:01 +0200)]
Force UntrustedXML to be initialized from activator

Touching UntrustedXML during bundle activator should cause it to
bind to the JRE XML provider rather than discovering other members
via a TCCL.

Change-Id: I9c6625be7873ed96d5e292a3165e7f319ac68b56
JIRA: CONTROLLER-1867
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
15 months agoBump to odlparent 3.1.4 and yangtools 2.0.12 51/76851/3
Stephen Kitt [Thu, 11 Oct 2018 09:47:25 +0000 (11:47 +0200)]
Bump to odlparent 3.1.4 and yangtools 2.0.12

Change-Id: I1e74db121d23c07fefb8ddfb940f78d790709397
Signed-off-by: Stephen Kitt <skitt@redhat.com>
15 months agoMove commit payload propagation 70/76570/1
Robert Varga [Tue, 2 Oct 2018 15:20:16 +0000 (17:20 +0200)]
Move commit payload propagation

Since Shard.persistPayload() will shortcut when we do not have
a followers or persistence, we must update metadata before we
notify the cohort of the success, as for commit-immediate
transactions that will result in a purge payload being persisted.
That payload will shortcut, too, and execute on stack, hence
metadata will see purge before commit -- leaving it in inconsistent
leaky state.

Move allMetadataCommittedTransaction() calls from
applyReplicatedPayload() down to just after we modify the data
tree and before we invoke listeners.

Change-Id: I1ed2f62756367982cfff08302c79f1c63a871df2
JIRA: CONTROLLER-1746
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 4a97740e7fe14f99dc6f6f2b07e44f4123103ce0)

15 months agoCorrect exception handling in LegacyDOMDataBrokerAdapter 58/76558/1
Robert Varga [Mon, 1 Oct 2018 09:50:13 +0000 (11:50 +0200)]
Correct exception handling in LegacyDOMDataBrokerAdapter

When a TransactionChain is closed, we need to make sure we throw
the correct (controller) exception instead of re-wrapping the mdsal
one.

Change-Id: I74434115fe14a18ba520fc789fa8a21d932a4a15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
15 months agoUse LogicalDatastoreType.toMdsal() 18/76518/1
Robert Varga [Mon, 1 Oct 2018 08:39:27 +0000 (10:39 +0200)]
Use LogicalDatastoreType.toMdsal()

Use direct converter method rather than matching through name, which
results in faster mapping.

Change-Id: Ic247ebc5c5704d3eb1953eea4d7f36b1d3d49cb8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
16 months agoConstruct IMDS delegate with proper type 03/76203/4
Robert Varga [Tue, 18 Sep 2018 08:35:47 +0000 (10:35 +0200)]
Construct IMDS delegate with proper type

This patch makes sure we do not ignore the datastore type, but
pass it down to MD-SAL's IMDS.

Since we are converting from controller to mdsal LogicalDatastoreType
in multiple places, centralize this via LogicalDatastoreType.toMdsal().

JIRA: MDSAL-370
Change-Id: I5e027fd439e325ff91344de98511e503fc801992
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
16 months agoBump yangtools-2.0.11 37/76137/2
Robert Varga [Mon, 17 Sep 2018 08:59:18 +0000 (10:59 +0200)]
Bump yangtools-2.0.11

This brinsg in the latest fixes.

Change-Id: Ie576ffdd40afccd6a22170525027b9ef8c9a94d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
16 months agoMigrate controller docs to the controller project 73/75873/1
Thanh Ha [Sun, 9 Sep 2018 00:48:24 +0000 (20:48 -0400)]
Migrate controller docs to the controller project

Change-Id: Ic6ad9bade1240b08cc112f275ea2d1b4516d5446
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
16 months agoBootstrap Controller documentation 72/75872/1
Thanh Ha [Sun, 9 Sep 2018 00:44:58 +0000 (20:44 -0400)]
Bootstrap Controller documentation

Issue: DOCS-69
Change-Id: Iaf57d73e8d720b910c66cae41a75f10ceefba80f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
16 months agoDisable artery max frame size settingd 94/75394/2
Tom Pantelis [Wed, 22 Aug 2018 22:55:12 +0000 (18:55 -0400)]
Disable artery max frame size settingd

These were accidently set really large when we were first
looking at artery a while ago but they blow up with
java.lang.OutOfMemoryError: Direct buffer memory. So
set them to the defaults and comment them out.

Change-Id: I92dc150808601271f879bc3917a036b76af8d914
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
(cherry picked from commit f605b10df459b9c9df3c697c610f5e6a71b96a0d)

16 months agoFix illegal check in CreateTransactionReply 39/75439/2
Robert Varga [Thu, 23 Aug 2018 14:02:40 +0000 (16:02 +0200)]
Fix illegal check in CreateTransactionReply

The null check is wrong here, as instanceof will evaluate to a boolean,
which will always result in a non-null reference. Fix this by using
checkArgument().

Change-Id: I9c5c1795227cafafc4393ea86aa464287cd96df2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0fdb21f91e0e61e8ee911beb4cda9053537a0ccd)

16 months agoFix prefix shard configuration update handling 10/75410/2
Robert Varga [Wed, 22 Aug 2018 16:48:30 +0000 (18:48 +0200)]
Fix prefix shard configuration update handling

If the list of shards is completely deleted, we end up jumping
into an empty method -- obviously missing updates. This codepath
is really shared, as DataTreeCandidateNode resolves recursively,
creating apropriate delta for children.

Change-Id: I6a70421a5ca405830a1012798f302b390b7aa2f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3dc48592696e6a4535c0e125c1e23dbc62bc9091)

16 months agoBump versions by x.y.(z+1) 77/75577/1
jenkins-releng [Thu, 30 Aug 2018 16:51:19 +0000 (16:51 +0000)]
Bump versions by x.y.(z+1)

Change-Id: I510f3d88b49a2d101d31fe350fa01a2fea08dcc5
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
17 months agoUpdate .gitreview to stable/fluorine 70/74970/1
Anil Belur [Thu, 9 Aug 2018 12:12:24 +0000 (17:42 +0530)]
Update .gitreview to stable/fluorine

Change-Id: Iefe161b49fa8f420ffa714a91b568fdb84ef33ad
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
17 months agoBump yangtools to 2.0.10 80/74880/2
Robert Varga [Mon, 6 Aug 2018 15:44:25 +0000 (17:44 +0200)]
Bump yangtools to 2.0.10

This fixes an issue with actions, hence we need it in Fluorine.

Change-Id: I4b312e3e8ca2eafdd8a63781e78c0c019f4f7a4a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoRemove RoutingLogic interface 53/74853/1
Tom Pantelis [Mon, 6 Aug 2018 12:56:43 +0000 (08:56 -0400)]
Remove RoutingLogic interface

This is no longer used...

Change-Id: I167eed99d7e457a7d6b1d53f39c07a1dfc6c5bf3
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
17 months agoSimplify ListenableFuture translation 27/74827/4
Robert Varga [Sat, 4 Aug 2018 01:09:51 +0000 (03:09 +0200)]
Simplify ListenableFuture translation

We can forgo instantiation of immediate futures by using a simple
.transform(Optional::fromJavaUtil).

Change-Id: If33247bc473852d739f593bb7e752323b3ac6583
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoFix deprecation warnings and checkstyle in benchmarks 14/71214/13
Robert Varga [Mon, 23 Apr 2018 13:49:28 +0000 (15:49 +0200)]
Fix deprecation warnings and checkstyle in benchmarks

This fixes up warnings/checkstyle and flips the enforcement switch.

Change-Id: I22754c767ef643d703286a30252cf57006062ade
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoAdd MappingCheckedFuture 26/74826/3
Robert Varga [Sat, 4 Aug 2018 01:02:41 +0000 (03:02 +0200)]
Add MappingCheckedFuture

This class is moved here from MD-SAL, as CheckedFutures are not
used there anymore.

Change-Id: I84cda1d543a5bebdb17249943ee26ca8fe3f97bf
JIRA: MDSAL-229
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoConvert dsbenchmark to mdsal APIs 04/74804/3
Robert Varga [Fri, 3 Aug 2018 15:31:22 +0000 (17:31 +0200)]
Convert dsbenchmark to mdsal APIs

With controller interfaces deprecated, move benchmark to use MD-SAL
interfaces instead.

Change-Id: I79f52260171e3f4f770511f389bbc773e86e6939
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoReduce use of deprecated methods 03/74803/2
Robert Varga [Fri, 3 Aug 2018 15:12:49 +0000 (17:12 +0200)]
Reduce use of deprecated methods

We do not really need the old semantics in a lot of sites, so
migrate them over to replacement methods.

Change-Id: Ib60e395dd9da82934d1591555c9ad46c05dac0e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoAllow DataObjectModification to address grouping nodes 06/74606/4
Robert Varga [Sat, 28 Jul 2018 08:50:19 +0000 (10:50 +0200)]
Allow DataObjectModification to address grouping nodes

This adds the API and implementation required to address child
nodes introduced in cases by the use of a grouping.

JIRA: MDSAL-342
Change-Id: I70871dcaa3441fbef81dfb15bfd965d133aa0894
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoChange log to warn in LocalThreePhaseCommitCohort 01/74701/1
Tom Pantelis [Tue, 31 Jul 2018 18:22:14 +0000 (14:22 -0400)]
Change log to warn in LocalThreePhaseCommitCohort

Change-Id: Ieeb60989eb3665cad9cc4dc4d25c7ab7e0983437
JIRA:CONTROLLER-1855
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
17 months agoAllow filtering transaction traces with a minimum 52/74652/3
Michael Vorburger [Mon, 30 Jul 2018 13:25:05 +0000 (15:25 +0200)]
Allow filtering transaction traces with a minimum

This adds a "minimum open number of transactions" option to
trace:transactions and print out a clear final message indicating
whether any leaks were found or not.

JIRA: CONTROLLER-1765
Change-Id: Ie9f4ee263ed7defcb84c8b82dc8ec6f1f81ba07d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
17 months agosimplify a statement in NormalizedNodeInputStreamReader 76/74476/2
Michael Vorburger [Wed, 25 Jul 2018 21:47:46 +0000 (23:47 +0200)]
simplify a statement in NormalizedNodeInputStreamReader

and fix a JavaDoc warning in NormalizedNodeOutputStreamWriter

Change-Id: I471dc3d4c8d1327fa8adaca89b8ca1d46036929d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
17 months agoAdd Action(Provider)Adapters 10/74610/2
Robert Varga [Sat, 28 Jul 2018 11:13:52 +0000 (13:13 +0200)]
Add Action(Provider)Adapters

This adds adapters based on MD-SAL to sal-binding-broker, allowing
actions to be invoked.

Change-Id: I7efa0ef81c239d12e7d61097daa6a36391e7b89b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
17 months agoAdd (DOM)Action(Provider) bridges 09/74609/3
Robert Varga [Sat, 28 Jul 2018 10:56:34 +0000 (12:56 +0200)]
Add (DOM)Action(Provider) bridges

We need to add bridge interfaces which allow NETCONF to expose
DOMActionService through Controller's mountpoints. Also add binding
equivalents, so users of Controller Binding have access to them.

JIRA: MDSAL-283
Change-Id: Ie6b0819345928637df29c5a15bf1634f8932de19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoImprove ProgressTracker class javadoc 80/74580/3
Vratko Polak [Mon, 26 Jun 2017 16:58:07 +0000 (18:58 +0200)]
Improve ProgressTracker class javadoc

Previously it was mentioning only "frontend" and "backend".
Now it also mentions "users", to distinguish opening and closing tasks
(which happens on user-frontend boundary) from reconnect scenarios
(which happen on frontend-backend boundary).

Change-Id: I2e1739ac40d9e1b0661d9de42099fd97e816585c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
18 months agoConvert sal-remoterpc to mdsal APIs 97/74597/1
Tom Pantelis [Fri, 27 Jul 2018 21:12:04 +0000 (17:12 -0400)]
Convert sal-remoterpc to mdsal APIs

Change-Id: I161be27bce6f5f453e7324a737c4057493d80fa2
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoBump yangtools to 2.0.9 73/74573/2
Robert Varga [Fri, 27 Jul 2018 12:09:03 +0000 (14:09 +0200)]
Bump yangtools to 2.0.9

This patch bumps yangtools to latest release.

Change-Id: If5342423112cd39f82232bf2379002e8cc08daed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoDeprecate controller APIs 82/74582/2
Tom Pantelis [Fri, 27 Jul 2018 14:23:15 +0000 (10:23 -0400)]
Deprecate controller APIs

Deprecated the high-level interfaces, eg DataBroker.

Change-Id: I754e3a5059c05d70616f3bd4ff3a00a05115fead
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoAdjust to mdsal CursorAware API changes 79/74479/3
Tom Pantelis [Wed, 25 Jul 2018 22:26:30 +0000 (18:26 -0400)]
Adjust to mdsal CursorAware API changes

Corresponding mdsal patch: https://git.opendaylight.org/gerrit/#/c/74478/

Change-Id: I82041945b1f15c492f77d65c065068a6fab3878a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoBump to odlparent 3.1.3 93/74193/5
Stephen Kitt [Wed, 18 Jul 2018 16:06:37 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3

Change-Id: I61d53cb19006ea11fd3917e6e395ce0870b7367e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
18 months agoAdjust to DOMDataTreeCommitCohort API change 71/74471/1
Tom Pantelis [Wed, 25 Jul 2018 17:17:54 +0000 (13:17 -0400)]
Adjust to DOMDataTreeCommitCohort API change

Use the new canCommit method that returns FluentFuture
instead of the deprecated CheckedFuture.

Change-Id: I110722a96c4933d32d8ff4b3237a90feddf21747
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoSimplify code using Java 8 features 44/74344/4
Stephen Kitt [Mon, 23 Jul 2018 15:31:33 +0000 (17:31 +0200)]
Simplify code using Java 8 features

* List::sort
* lambda expressions
* Comparator::comparing...
* Collection::removeIf
* method references
* Map::computeIfAbsent
* Map::merge

Change-Id: I1793591c071c7ce5465939afe8b4846b769b5953
Signed-off-by: Stephen Kitt <skitt@redhat.com>
18 months agoRemove unused exceptions 39/74339/5
Stephen Kitt [Mon, 23 Jul 2018 14:45:38 +0000 (16:45 +0200)]
Remove unused exceptions

This drops exception declarations which are never used.

Change-Id: Icc8938b9c3b437a0d5961ec1b481fd06c52d47f2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
18 months agoAdjust to mdsal invokeRpc API change 66/74366/5
Tom Pantelis [Tue, 24 Jul 2018 00:07:26 +0000 (20:07 -0400)]
Adjust to mdsal invokeRpc API change

mdsal patch: https://git.opendaylight.org/gerrit/#/c/74365/

Change-Id: Ie14d9d582f5e6f141b852248f2b7cc8dca1b97b3
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoDrop unnecessary property reference 07/74407/3
Stephen Kitt [Tue, 24 Jul 2018 15:32:40 +0000 (17:32 +0200)]
Drop unnecessary property reference

maven-surefire-plugin is specified by odlparent, we don’t need to
re-specify the version here.

Change-Id: I94550466303a5839b68cd6422d742383e29d3b64
Signed-off-by: Stephen Kitt <skitt@redhat.com>
18 months agoUse moved BindingReflections 89/74389/1
Robert Varga [Tue, 24 Jul 2018 11:18:17 +0000 (13:18 +0200)]
Use moved BindingReflections

BindingReflections are being evacuated from yang-binding, use them
from their new location.

Change-Id: Ib14971102980688227f1f761c17a22362d4e7e3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoSwitch to binding-dom-adapter's NotificationListenerInvoker 33/74333/2
Robert Varga [Mon, 23 Jul 2018 12:18:33 +0000 (14:18 +0200)]
Switch to binding-dom-adapter's NotificationListenerInvoker

NotificationListenerInvoker should not be in yang-binding, consume it
from the adapter instead.

Change-Id: I30f533342e7e27a26af583a15d4baec73580f2ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoSwitch to binding-dom-adapter's RpcServiceInvoker 30/74330/2
Robert Varga [Mon, 23 Jul 2018 10:38:28 +0000 (12:38 +0200)]
Switch to binding-dom-adapter's RpcServiceInvoker

RpcServiceInvoker should not be in yang-binding, consume it from
the adapter instead.

Change-Id: I79b3d282b3c86ef3e49645c8782bef3fa29f9722
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoFix DOMRpcRouter breakage 12/74312/1
Tom Pantelis [Sun, 22 Jul 2018 15:18:26 +0000 (11:18 -0400)]
Fix DOMRpcRouter breakage

https://git.opendaylight.org/gerrit/#/c/74209/ broke the DOMRpcRouter
for UTs that use the empty constructor. The mdsal DOMRpcRouter no longer
implements DOMRpcProviderService directly so the SchemaContext was not
getting set via onGlobalContextUpdated.

Change-Id: Ic9381742f43b05264724eb80eef41201a1285c2a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoFix intermittent testFlipMemberVotingStates failure 99/74299/1
Tom Pantelis [Sat, 21 Jul 2018 03:26:47 +0000 (23:26 -0400)]
Fix intermittent testFlipMemberVotingStates failure

Failure was see in auto-release:

ClusterAdminRpcServiceTest.testFlipMemberVotingStates:976->lambda$testFlipMemberVotingStates$8:978 Expected leader member-1. Actual: member-1-shard-cars-oper_testFlipMemberVotingStates

The test output showed it timed out trying to transfer leadership to member-3. The
timeout deadline is the election timeout interval which is the
heartbeatInterval * election-timeout-factor which were set to 300 and 1.
It seems 300ms is a bit too low for comfort so I changed it to 1000ms (100 * 10);

Change-Id: I1e3c79de960dcced8af71fecdf1ab8bdba433448
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoFix DOMRpcRouter breakage from mdsal 69/74269/2
Robert Varga [Fri, 20 Jul 2018 08:15:00 +0000 (10:15 +0200)]
Fix DOMRpcRouter breakage from mdsal

MD-SAL's DOMRpcRouter no longer directly implements services,
acquire them from the accessor methods.

Change-Id: Icf337e8b8183726c87bf38d3252dccb0b911ba17
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoConvert toaster to mdsal APIs 57/74257/2
Tom Pantelis [Thu, 19 Jul 2018 20:44:30 +0000 (16:44 -0400)]
Convert toaster to mdsal APIs

Change-Id: I5cbbd42bd3435686346a7945881dd0d31f13a796
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoModels should depend on odl-mdsal-binding-base 31/74231/1
Robert Varga [Thu, 19 Jul 2018 12:36:33 +0000 (14:36 +0200)]
Models should depend on odl-mdsal-binding-base

Models do not need runtime services, hence depend on base only,
which is already being pulled in by odl-mdsal-model-rfc6991.

Change-Id: I1e2a7421008bfc6ec70d45459c5486c6f2815e10
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoDo not pull in models into odl-mdsal-broker-local 81/74081/4
Robert Varga [Mon, 16 Jul 2018 18:28:05 +0000 (20:28 +0200)]
Do not pull in models into odl-mdsal-broker-local

Broker should be able to function without additional models as it
has no specific dependencies. Remove dependency on odl-mdsal-models
to allow it to load without as few models as possible.

JIRA: MDSAL-363
Change-Id: Ib230c87cbd832e16380be3b989185ac87336f30b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoAdjust to mdsal DOM read/exists FluentFuture change 28/74128/8
Tom Pantelis [Tue, 17 Jul 2018 15:05:41 +0000 (11:05 -0400)]
Adjust to mdsal DOM read/exists FluentFuture change

This patch needs to be coordinated with
https://git.opendaylight.org/gerrit/#/c/74127/.

Change-Id: Iceeff9f9f75ca40ebc31bd839b5e6a5c8639aa4c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoUpdate odl-message-bus-collector dependencies 80/74080/2
Robert Varga [Mon, 16 Jul 2018 18:26:35 +0000 (20:26 +0200)]
Update odl-message-bus-collector dependencies

odl-message-bus-collector requires draft-clemm ietf-topology, which
it is currently pulling odl-mdsal-broker-local transitively.

Explicitly depend on the model, so odl-mdsal-broker-local can load
without additional models.

Change-Id: Ib0eb898fe3d801a937d389886ff924a0895b48c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoLower odl-clustering-test-app 79/74079/2
Robert Varga [Mon, 16 Jul 2018 18:19:09 +0000 (20:19 +0200)]
Lower odl-clustering-test-app

This feature requires only RFC6991 ietf-{inet,yang}-types, lower
its dependencies accordingly.

Change-Id: Ic11fe663ca33297b652d160fcb8635b473c0b591
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoLower odl-controller-model-topology dependencies 78/74078/2
Robert Varga [Mon, 16 Jul 2018 18:13:52 +0000 (20:13 +0200)]
Lower odl-controller-model-topology dependencies

This feature requires only draft-clemm topology model and
odl-mdsal-model-inventory, lower feature dependencies accordingly.

Change-Id: I66c32cac8f8dbc27c59ddf91c75d807242d49fe9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoLower odl-mdsal-model-inventory dependencies 77/74077/2
Robert Varga [Mon, 16 Jul 2018 18:09:06 +0000 (20:09 +0200)]
Lower odl-mdsal-model-inventory dependencies

This model requires only RFC6991 ietf-inet-types, depend on the correct
modular mdsal feature.

Change-Id: I466a47c46c770ee7283ad720ae5b68e0852024f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoLower odl-benchmark-api dependencies 76/74076/2
Robert Varga [Mon, 16 Jul 2018 18:04:23 +0000 (20:04 +0200)]
Lower odl-benchmark-api dependencies

We really do not need all the models, only yang-ext, hence pull
only odl-mdsal-binding-base.

Change-Id: Id2429038fbe5cdf2e3c82270e4d66211f72d0409
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoRestore binding RPC shortcut 35/74035/5
Tom Pantelis [Sat, 14 Jul 2018 01:42:46 +0000 (21:42 -0400)]
Restore binding RPC shortcut

The binding -> binding RPC serialization shortcut was broken by
recent changes so restore it. The LazyDOMRpcResultFuture from
the binding adapter is preserved by DOMRpcRouter via intermediate
DOMRpcResult adapters.

Change-Id: I98942471f4e8430d0043f5c09cb8a38ce2a5d7b9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoRemove sal.core.api.mount.MountProvisionListener 94/73894/6
Robert Varga [Tue, 10 Jul 2018 19:04:45 +0000 (21:04 +0200)]
Remove sal.core.api.mount.MountProvisionListener

There are no in-tree users, remove this interface.

Change-Id: I88c1b370db95db1e21bcd14bc21dbadd1f782852
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoUse Binding{Data,RpcFuture}Aware 25/73825/6
Robert Varga [Mon, 9 Jul 2018 02:33:16 +0000 (04:33 +0200)]
Use Binding{Data,RpcFuture}Aware

In order to bridge mdsal and controller binding interfaces, we need
to have a common way of accessing the binding future. Companion MDSAL
patch added Binding{Data,RpcFuture}Aware interfaces, which exposes
just that, and his patch makes use of it in the controller.

JIRA: SFC-222
Change-Id: If2407f4950de1b34e809b275cc2afc4cfefc8a10
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoEliminate getSupportedExtensions() 69/73969/3
Robert Varga [Thu, 12 Jul 2018 08:13:58 +0000 (10:13 +0200)]
Eliminate getSupportedExtensions()

blueprint does not like the default method, run a straight-up
removal.

Change-Id: I2bfbc5eb2587d6cd790cc8153c357f9251ac2485
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoMove LegacyDOMDataBrokerAdapter to sal-core-compat 62/73962/2
Tom Pantelis [Thu, 12 Jul 2018 01:43:34 +0000 (21:43 -0400)]
Move LegacyDOMDataBrokerAdapter to sal-core-compat

Change-Id: I4e75bb4eda3418651d33c3d8a3852715dceeeee6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoAdd DOMExtensibleService.getExtensions() implementations 37/73937/1
Robert Varga [Wed, 11 Jul 2018 13:22:08 +0000 (15:22 +0200)]
Add DOMExtensibleService.getExtensions() implementations

This adds implementations so we can switchover the base interface
and require getExtensions() to be implemented. Also take advantage
of the improvement introduced in getExtensions() return type.

Change-Id: I67f05782d311b895088e248119e77832a8892724
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoUse ClassToInstanceMap for extensions 35/73935/1
Robert Varga [Wed, 11 Jul 2018 13:01:25 +0000 (15:01 +0200)]
Use ClassToInstanceMap for extensions

Using a plain map was an API design mistake, make sure implementations
are serving a ClassToInstanceMap before embarking on migration.

Change-Id: I2609d08d9df9f0da8d4f23fdeb5007979db80d72
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoDeprecate sal.core.api.mount.MountProvisionListener 91/73891/4
Robert Varga [Tue, 10 Jul 2018 17:59:03 +0000 (19:59 +0200)]
Deprecate sal.core.api.mount.MountProvisionListener

This interface has an exact copy in DOMMountPointListener, deprecate
it and adjust implementations to not require it.

Change-Id: If19a3a34094a9dbbc25665967074a32e562a7dca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoProxy DOMMountPointServiceImpl to MD-SAL API 58/73858/3
Tom Pantelis [Mon, 9 Jul 2018 17:07:56 +0000 (13:07 -0400)]
Proxy DOMMountPointServiceImpl to MD-SAL API

Change-Id: Ic16ce1a850340482688c492045101af45ca7e521
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 months agoRemove sal.core.api.BrokerService 90/73890/1
Robert Varga [Tue, 10 Jul 2018 17:41:28 +0000 (19:41 +0200)]
Remove sal.core.api.BrokerService

This interface has been long deprecated and it is not really used
anywhere. Remove it.

Change-Id: I8dcee98f19d80df4532891f73776dc4c268ef025
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoRemove sal.core.api.RpcRoutingContext 89/73889/1
Robert Varga [Tue, 10 Jul 2018 17:39:35 +0000 (19:39 +0200)]
Remove sal.core.api.RpcRoutingContext

This class is not used anywhere, remove it.

Change-Id: Ibaad5ad39fe1726016c87b4d1c01660b1f301613
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoProxy over MDSAL-provided IMDS 39/71439/5
Robert Varga [Thu, 26 Apr 2018 16:56:57 +0000 (18:56 +0200)]
Proxy over MDSAL-provided IMDS

This patch migrates Controller IMDS to be just a proxy over the
MDSAL's IMDS implementation.

Change-Id: I8e54ec344d010a91e06ef2f1fb63586de3b26949
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoRemove sal.core.api.model 69/73869/5
Robert Varga [Tue, 10 Jul 2018 07:48:19 +0000 (09:48 +0200)]
Remove sal.core.api.model

This removes deprecated and unused sal.core.api.model package
along with its only implementation, migrating final stragglers
to DOMSchemaService.

Change-Id: Id355ffd96a5aaa0ffa48e018bfadea596ec58ac8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoRemove deprecated controller.sal.core.api interfaces 67/73867/4
Robert Varga [Tue, 10 Jul 2018 07:36:14 +0000 (09:36 +0200)]
Remove deprecated controller.sal.core.api interfaces

Broker, Consumer, Provider and related classes have been deprecated
for a long time and no longer have any in-tree users. Remove them.

Change-Id: I82aab628b7612e636d2c18427e5e71f93c11083f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
18 months agoRemove use of CheckedFuture in clustering-it-provider 71/73871/2
Robert Varga [Tue, 10 Jul 2018 08:13:00 +0000 (10:13 +0200)]
Remove use of CheckedFuture in clustering-it-provider

We do not need checkedGet(), hence we can get by with a
ListenableFuture only.

Change-Id: Ie8cab5293a13041a90d275c2b67a90d06beaccad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.